mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-10-25 05:45:42 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix deadlock when using putmultifilejob with rate limits enabled

Browse source 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
This commit is contained in:
Claudio Cambra 2023-05-15 19:30:27 +08:00
parent f28a1a368e
commit a547f55f2f
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/libsync/putmultifilejob.cpp
View file

@ -44,6 +44,13 @@ void PutMultiFileJob::start()
QNetworkRequest req;
for(const auto &oneDevice : _devices) {
// Our rate limits in UploadDevice::readData will cause an application freeze if used here.
// QHttpMultiPart's internal QHttpMultiPartIODevice::readData will loop over and over trying
// to read data from our UploadDevice while there is data left to be read; this will cause
// a deadlock as we will never have a chance to progress the data read
oneDevice._device->setChoked(false);
oneDevice._device->setBandwidthLimited(false);
auto onePart = QHttpPart{};
onePart.setBodyDevice(oneDevice._device.get());