GUI: run clang-tidy modernize-use-override

src/gui/clientproxy.h

@@ -53,7 +53,7 @@ class SystemProxyRunnable : public QObject, public QRunnable
     Q_OBJECT
 public:
     SystemProxyRunnable(const QUrl &url);
-    void run();
+    void run() override;
 signals:
     void systemProxyLookedUp(const QNetworkProxy &url);
 

src/gui/creds/shibboleth/shibbolethwebview.cpp

@@ -47,7 +47,7 @@ public:
             settings()->setAttribute(QWebSettings::DeveloperExtrasEnabled, true);
         }
     }
-    QString userAgentForUrl(const QUrl &url) const
+    QString userAgentForUrl(const QUrl &url) const override
     {
         return QWebPage::userAgentForUrl(url) + " " + Utility::userAgentString();
     }

src/gui/folderwizard.h

@@ -53,7 +53,7 @@ public:
     explicit FolderWizardLocalPath(const AccountPtr &account);
     ~FolderWizardLocalPath();
 
-    virtual bool isComplete() const Q_DECL_OVERRIDE;
+    bool isComplete() const Q_DECL_OVERRIDE;
     void initializePage() Q_DECL_OVERRIDE;
     void cleanupPage() Q_DECL_OVERRIDE;
 
@@ -80,10 +80,10 @@ public:
     explicit FolderWizardRemotePath(const AccountPtr &account);
     ~FolderWizardRemotePath();
 
-    virtual bool isComplete() const Q_DECL_OVERRIDE;
+    bool isComplete() const Q_DECL_OVERRIDE;
 
-    virtual void initializePage() Q_DECL_OVERRIDE;
-    virtual void cleanupPage() Q_DECL_OVERRIDE;
+    void initializePage() Q_DECL_OVERRIDE;
+    void cleanupPage() Q_DECL_OVERRIDE;
 
 protected slots:
 
@@ -123,10 +123,10 @@ public:
     explicit FolderWizardSelectiveSync(const AccountPtr &account);
     ~FolderWizardSelectiveSync();
 
-    virtual bool validatePage() Q_DECL_OVERRIDE;
+    bool validatePage() Q_DECL_OVERRIDE;
 
-    virtual void initializePage() Q_DECL_OVERRIDE;
-    virtual void cleanupPage() Q_DECL_OVERRIDE;
+    void initializePage() Q_DECL_OVERRIDE;
+    void cleanupPage() Q_DECL_OVERRIDE;
 
 private:
     SelectiveSyncWidget *_selectiveSync;

src/gui/generalsettings.h

@@ -37,7 +37,7 @@ class GeneralSettings : public QWidget
 public:
     explicit GeneralSettings(QWidget *parent = nullptr);
     ~GeneralSettings();
-    QSize sizeHint() const;
+    QSize sizeHint() const override;
 
 private slots:
     void saveMiscSettings();

src/gui/notificationconfirmjob.h

@@ -62,7 +62,7 @@ signals:
     void jobFinished(QString reply, int replyCode);
 
 private slots:
-    virtual bool finished() Q_DECL_OVERRIDE;
+    bool finished() Q_DECL_OVERRIDE;
 
 private:
     QByteArray _verb;

src/gui/ocsjob.h

@@ -143,7 +143,7 @@ signals:
     void etagResponseHeaderReceived(const QByteArray &value, int statusCode);
 
 private slots:
-    virtual bool finished() Q_DECL_OVERRIDE;
+    bool finished() Q_DECL_OVERRIDE;
 
 private:
     QByteArray _verb;

src/gui/selectivesyncdialog.cpp

@@ -54,7 +54,7 @@ public:
     }
 
 private:
-    bool operator<(const QTreeWidgetItem &other) const
+    bool operator<(const QTreeWidgetItem &other) const override
     {
         int column = treeWidget()->sortColumn();
         if (column == 1) {

src/gui/selectivesyncdialog.h

@@ -94,7 +94,7 @@ public:
     // Dialog for the whole account (Used from the wizard)
     explicit SelectiveSyncDialog(AccountPtr account, const QString &folder, const QStringList &blacklist, QWidget *parent = nullptr, Qt::WindowFlags f = nullptr);
 
-    virtual void accept() Q_DECL_OVERRIDE;
+    void accept() Q_DECL_OVERRIDE;
 
     QStringList createBlackList() const;
     QStringList oldBlackList() const;

src/gui/sharedialog.h

@@ -50,7 +50,7 @@ public:
     ~ShareDialog();
 
 private slots:
-    void done(int r);
+    void done(int r) override;
     void slotPropfindReceived(const QVariantMap &result);
     void slotPropfindError();
     void slotThumbnailFetched(const int &statusCode, const QByteArray &reply);

src/gui/sharee.h

@@ -67,8 +67,8 @@ public:
 
     typedef QVector<QSharedPointer<Sharee>> ShareeSet; // FIXME: make it a QSet<Sharee> when Sharee can be compared
     void fetch(const QString &search, const ShareeSet &blacklist);
-    int rowCount(const QModelIndex &parent = QModelIndex()) const;
-    QVariant data(const QModelIndex &index, int role) const;
+    int rowCount(const QModelIndex &parent = QModelIndex()) const override;
+    QVariant data(const QModelIndex &index, int role) const override;
 
     QSharedPointer<Sharee> getSharee(int at);
 

src/gui/thumbnailjob.h

@@ -45,7 +45,7 @@ signals:
      */
     void jobFinished(int statusCode, QByteArray reply);
 private slots:
-    virtual bool finished() Q_DECL_OVERRIDE;
+    bool finished() Q_DECL_OVERRIDE;
 };
 }
 

src/gui/wizard/owncloudadvancedsetuppage.h

@@ -35,9 +35,9 @@ class OwncloudAdvancedSetupPage : public QWizardPage
 public:
     OwncloudAdvancedSetupPage();
 
-    virtual bool isComplete() const Q_DECL_OVERRIDE;
-    virtual void initializePage() Q_DECL_OVERRIDE;
-    virtual int nextId() const Q_DECL_OVERRIDE;
+    bool isComplete() const Q_DECL_OVERRIDE;
+    void initializePage() Q_DECL_OVERRIDE;
+    int nextId() const Q_DECL_OVERRIDE;
     bool validatePage() Q_DECL_OVERRIDE;
     QString localFolder() const;
     QStringList selectiveSyncBlacklist() const;

src/gui/wizard/owncloudsetuppage.h

@@ -45,9 +45,9 @@ public:
     OwncloudSetupPage(QWidget *parent = nullptr);
     ~OwncloudSetupPage();
 
-    virtual bool isComplete() const Q_DECL_OVERRIDE;
-    virtual void initializePage() Q_DECL_OVERRIDE;
-    virtual int nextId() const Q_DECL_OVERRIDE;
+    bool isComplete() const Q_DECL_OVERRIDE;
+    void initializePage() Q_DECL_OVERRIDE;
+    int nextId() const Q_DECL_OVERRIDE;
     void setServerUrl(const QString &);
     void setAllowPasswordStorage(bool);
     bool validatePage() Q_DECL_OVERRIDE;

src/gui/wizard/postfixlineedit.h

@@ -44,7 +44,7 @@ public:
     void setFullText(const QString &text);
 
 protected:
-    void paintEvent(QPaintEvent *pe);
+    void paintEvent(QPaintEvent *pe) override;
 
 private:
     QString _postfix;

src/gui/wizard/slideshow.h

@@ -59,10 +59,10 @@ signals:
     void currentSlideChanged(int index);
 
 protected:
-    void mousePressEvent(QMouseEvent *event);
-    void mouseReleaseEvent(QMouseEvent *event);
-    void paintEvent(QPaintEvent *event);
-    void timerEvent(QTimerEvent *event);
+    void mousePressEvent(QMouseEvent *event) override;
+    void mouseReleaseEvent(QMouseEvent *event) override;
+    void paintEvent(QPaintEvent *event) override;
+    void timerEvent(QTimerEvent *event) override;
 
 private:
     void maybeRestartTimer();

src/gui/wizard/webview.cpp

@@ -23,7 +23,7 @@ class WebViewPageUrlRequestInterceptor : public QWebEngineUrlRequestInterceptor
     Q_OBJECT
 public:
     WebViewPageUrlRequestInterceptor(QObject *parent = nullptr);
-    void interceptRequest(QWebEngineUrlRequestInfo &info);
+    void interceptRequest(QWebEngineUrlRequestInfo &info) override;
 };
 
 class WebViewPageUrlSchemeHandler : public QWebEngineUrlSchemeHandler
@@ -31,7 +31,7 @@ class WebViewPageUrlSchemeHandler : public QWebEngineUrlSchemeHandler
     Q_OBJECT
 public:
     WebViewPageUrlSchemeHandler(QObject *parent = nullptr);
-    void requestStarted(QWebEngineUrlRequestJob *request);
+    void requestStarted(QWebEngineUrlRequestJob *request) override;
 
 Q_SIGNALS:
     void urlCatched(QString user, QString pass, QString host);

src/gui/wizard/webviewpage.h

@@ -17,9 +17,9 @@ public:
 
     void initializePage() Q_DECL_OVERRIDE;
     int nextId() const Q_DECL_OVERRIDE;
-    bool isComplete() const;
+    bool isComplete() const override;
 
-    AbstractCredentials* getCredentials() const;
+    AbstractCredentials* getCredentials() const override;
     void setConnected();
 
 signals: