mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-10-25 13:55:47 +03:00
Code Issues Projects Releases Packages Wiki Activity

Sql: db close() failing isn't fatal

Browse source 
The assert was made fatal when looking at asserts for #5429 #5518
without having a particular problem in mind. Recent reports weakly
suggest that this might lead to occasional crashes for users when
sqlite_close fails in ways that look ignorable.
This commit is contained in:
Christian Kamm 2017-11-14 10:35:06 +01:00 committed by ckamm
parent 161f6baba6
commit 820ebf4b6e
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/common/ownsql.cpp
View file

@ -184,8 +184,8 @@ void SqlDatabase::close()
{ {
if (_db) { if (_db) {
SQLITE_DO(sqlite3_close(_db)); SQLITE_DO(sqlite3_close(_db));
// Fatal because reopening an unclosed db might be problematic. if (_errId != SQLITE_OK)
ENFORCE(_errId == SQLITE_OK, "Error when closing DB"); qCWarning(lcSql) << "Closing database failed" << _error;
_db = 0; _db = 0;
} }
} }