Merge pull request #2919 from nextcloud/validate_ssl_providers_certificate

Validate the providers ssl certificate
This commit is contained in:
Kevin Ottens 2021-02-12 10:50:41 +01:00 committed by GitHub
commit 81831fd69a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -52,9 +52,6 @@ public:
protected: protected:
bool certificateError(const QWebEngineCertificateError &certificateError) override; bool certificateError(const QWebEngineCertificateError &certificateError) override;
private:
QUrl _rootUrl;
}; };
// We need a separate class here, since we cannot simply return the same WebEnginePage object // We need a separate class here, since we cannot simply return the same WebEnginePage object
@ -191,15 +188,10 @@ QWebEnginePage * WebEnginePage::createWindow(QWebEnginePage::WebWindowType type)
void WebEnginePage::setUrl(const QUrl &url) { void WebEnginePage::setUrl(const QUrl &url) {
QWebEnginePage::setUrl(url); QWebEnginePage::setUrl(url);
_rootUrl = url;
} }
bool WebEnginePage::certificateError(const QWebEngineCertificateError &certificateError) { bool WebEnginePage::certificateError(const QWebEngineCertificateError &certificateError)
if (certificateError.error() == QWebEngineCertificateError::CertificateAuthorityInvalid && {
certificateError.url().host() == _rootUrl.host()) {
return true;
}
/** /**
* TODO properly improve this. * TODO properly improve this.
* The certificate should be displayed. * The certificate should be displayed.