From 00d8343e764c717dea02242f208b2e66c131c203 Mon Sep 17 00:00:00 2001 From: Markus Goetz Date: Wed, 7 Feb 2018 17:08:22 +0100 Subject: [PATCH 1/2] SettingsDialogMac: Also start timer for notifications --- src/gui/settingsdialogmac.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gui/settingsdialogmac.cpp b/src/gui/settingsdialogmac.cpp index 0e117779b..be385eda3 100644 --- a/src/gui/settingsdialogmac.cpp +++ b/src/gui/settingsdialogmac.cpp @@ -121,6 +121,7 @@ SettingsDialogMac::SettingsDialogMac(ownCloudGui *gui, QWidget *parent) ConfigFile cfg; cfg.restoreGeometry(this); + _activitySettings->setNotificationRefreshInterval(cfg.notificationRefreshInterval()); } void SettingsDialogMac::closeEvent(QCloseEvent *event) From 13b2e51dfe8c662f5805c4730b99cb2a35500ac0 Mon Sep 17 00:00:00 2001 From: Markus Goetz Date: Thu, 8 Feb 2018 17:20:50 +0100 Subject: [PATCH 2/2] Notifications: Immediately request when getting account online --- src/gui/settingsdialog.cpp | 8 ++++++++ src/gui/settingsdialog.h | 1 + src/gui/settingsdialogmac.cpp | 9 +++++++++ src/gui/settingsdialogmac.h | 1 + 4 files changed, 19 insertions(+) diff --git a/src/gui/settingsdialog.cpp b/src/gui/settingsdialog.cpp index 1eaf38fd2..d1f7c767a 100644 --- a/src/gui/settingsdialog.cpp +++ b/src/gui/settingsdialog.cpp @@ -237,6 +237,9 @@ void SettingsDialog::accountAdded(AccountState *s) connect(s->account().data(), &Account::accountChangedAvatar, this, &SettingsDialog::slotAccountAvatarChanged); connect(s->account().data(), &Account::accountChangedDisplayName, this, &SettingsDialog::slotAccountDisplayNameChanged); + // Refresh immediatly when getting online + connect(s, &AccountState::isConnectedChanged, this, &SettingsDialog::slotRefreshActivityAccountStateSender); + slotRefreshActivity(s); } @@ -379,6 +382,11 @@ QAction *SettingsDialog::createColorAwareAction(const QString &iconPath, const Q return createActionWithIcon(coloredIcon, text, iconPath); } +void SettingsDialog::slotRefreshActivityAccountStateSender() +{ + slotRefreshActivity(qobject_cast(sender())); +} + void SettingsDialog::slotRefreshActivity(AccountState *accountState) { if (accountState) { diff --git a/src/gui/settingsdialog.h b/src/gui/settingsdialog.h index 60c72dec7..37ff29da8 100644 --- a/src/gui/settingsdialog.h +++ b/src/gui/settingsdialog.h @@ -59,6 +59,7 @@ public slots: void showIssuesList(const QString &folderAlias); void slotSwitchPage(QAction *action); void slotRefreshActivity(AccountState *accountState); + void slotRefreshActivityAccountStateSender(); void slotAccountAvatarChanged(); void slotAccountDisplayNameChanged(); diff --git a/src/gui/settingsdialogmac.cpp b/src/gui/settingsdialogmac.cpp index be385eda3..7d033b59a 100644 --- a/src/gui/settingsdialogmac.cpp +++ b/src/gui/settingsdialogmac.cpp @@ -21,6 +21,7 @@ #include "generalsettings.h" #include "networksettings.h" #include "accountsettings.h" +#include "accountstate.h" #include "creds/abstractcredentials.h" #include "configfile.h" #include "progressdispatcher.h" @@ -161,6 +162,9 @@ void SettingsDialogMac::accountAdded(AccountState *s) connect(s->account().data(), &Account::accountChangedAvatar, this, &SettingsDialogMac::slotAccountAvatarChanged); connect(s->account().data(), &Account::accountChangedDisplayName, this, &SettingsDialogMac::slotAccountDisplayNameChanged); + // Refresh immediatly when getting online + connect(s, &AccountState::isConnectedChanged, this, &SettingsDialogMac::slotRefreshActivityAccountStateSender); + slotRefreshActivity(s); } @@ -176,6 +180,11 @@ void SettingsDialogMac::accountRemoved(AccountState *s) _activitySettings->slotRemoveAccount(s); } +void SettingsDialogMac::slotRefreshActivityAccountStateSender() +{ + slotRefreshActivity(qobject_cast(sender())); +} + void SettingsDialogMac::slotRefreshActivity(AccountState *accountState) { if (accountState) { diff --git a/src/gui/settingsdialogmac.h b/src/gui/settingsdialogmac.h index 5b4f412b8..f3f82cd35 100644 --- a/src/gui/settingsdialogmac.h +++ b/src/gui/settingsdialogmac.h @@ -49,6 +49,7 @@ public slots: void showActivityPage(); void showIssuesList(const QString &folderAlias); void slotRefreshActivity(AccountState *accountState); + void slotRefreshActivityAccountStateSender(); private slots: void accountAdded(AccountState *);