Disable http2 support for now

Issue: #7610
This commit is contained in:
Hannah von Reth 2019-12-02 15:30:47 +01:00 committed by Kevin Ottens
parent 0e7c56e81c
commit 6c19b02888
No known key found for this signature in database
GPG key ID: 074BBBCB8DECC9E2

View file

@ -98,12 +98,8 @@ QNetworkReply *AccessManager::createRequest(QNetworkAccessManager::Operation op,
#if QT_VERSION >= QT_VERSION_CHECK(5, 9, 4)
// only enable HTTP2 with Qt 5.9.4 because old Qt have too many bugs (e.g. QTBUG-64359 is fixed in >= Qt 5.9.4)
/* Disable http2 for now due to Qt bug but allow enabling it via env var, see: https://github.com/owncloud/client/pull/7620
* and: https://github.com/nextcloud/desktop/pull/1806
* Issue: https://github.com/nextcloud/desktop/issues/1503
*/
if (newRequest.url().scheme() == "https") { // Not for "http": QTBUG-61397
// http2 seems to cause issues, as with our recommended server setup we don't support http2, disable it by default for now
static const bool http2EnabledEnv = qEnvironmentVariableIntValue("OWNCLOUD_HTTP2_ENABLED") == 1;
newRequest.setAttribute(QNetworkRequest::HTTP2AllowedAttribute, http2EnabledEnv);