From 5761f4cd8aeb31c2b58e1e00d6ff72caa56dd8c7 Mon Sep 17 00:00:00 2001 From: Christian Kamm Date: Tue, 30 Jul 2019 13:40:52 +0200 Subject: [PATCH] SyncEngine: Don't duplicate fatal errors Previously fatal error texts were duplicated: Once they entered the SyncResult via the SyncFileItem and once via syncError(). syncError is intended for folder-wide sync issues that are not pinned to particular files. Thus that duplicated path is removed. For #5088 --- src/libsync/syncengine.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/libsync/syncengine.cpp b/src/libsync/syncengine.cpp index b5eef406f..4e75da8e0 100644 --- a/src/libsync/syncengine.cpp +++ b/src/libsync/syncengine.cpp @@ -827,10 +827,6 @@ void SyncEngine::slotItemCompleted(const SyncFileItemPtr &item) { _progressInfo->setProgressComplete(*item); - if (item->_status == SyncFileItem::FatalError) { - syncError(item->_errorString); - } - emit transmissionProgress(*_progressInfo); emit itemCompleted(item); }