mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-11-28 03:49:20 +03:00
Code Issues Projects Releases Packages Wiki Activity

Check for file equalness after having created a conflict file.

Browse source 
If the files are equal and the conflict was created because the
timestamps were screwed the conflict is removed again. This only
works on the local repository so far.

Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
This commit is contained in:
Klaas Freitag 2013-03-22 21:04:09 +01:00 committed by Andreas Schneider
parent 9f7de96a73
commit 4e6d54194f
1 changed files with 32 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
src/csync_propagate.c
View file

@ -32,6 +32,8 @@
#include "csync_private.h" #include "csync_private.h"
#include "csync_misc.h" #include "csync_misc.h"
#include "csync_propagate.h" #include "csync_propagate.h"
#include "csync_statedb.h"
#include "vio/csync_vio_local.h"
#include "vio/csync_vio.h" #include "vio/csync_vio.h"
#define CSYNC_LOG_CATEGORY_NAME "csync.propagator" #define CSYNC_LOG_CATEGORY_NAME "csync.propagator"
@ -454,12 +456,11 @@ static int _backup_path(char** duri, const char* uri, const char* path)
} }
static int _csync_backup_file(CSYNC *ctx, csync_file_stat_t *st) { static int _csync_backup_file(CSYNC *ctx, csync_file_stat_t *st, char **duri) {
enum csync_replica_e drep = -1; enum csync_replica_e drep = -1;
enum csync_replica_e rep_bak = -1; enum csync_replica_e rep_bak = -1;
char *suri = NULL; char *suri = NULL;
char *duri = NULL;
char errbuf[256] = {0}; char errbuf[256] = {0};
@ -479,7 +480,7 @@ static int _csync_backup_file(CSYNC *ctx, csync_file_stat_t *st) {
goto out; goto out;
} }
if (_backup_path(&duri, ctx->remote.uri,st->path) < 0) { if (_backup_path(duri, ctx->remote.uri,st->path) < 0) {
ctx->status_code = CSYNC_STATUS_MEMORY_ERROR; ctx->status_code = CSYNC_STATUS_MEMORY_ERROR;
rc = -1; rc = -1;
goto out; goto out;
@ -493,7 +494,7 @@ static int _csync_backup_file(CSYNC *ctx, csync_file_stat_t *st) {
goto out; goto out;
} }
if ( _backup_path(&duri, ctx->local.uri, st->path) < 0) { if ( _backup_path(duri, ctx->local.uri, st->path) < 0) {
ctx->status_code = CSYNC_STATUS_MEMORY_ERROR; ctx->status_code = CSYNC_STATUS_MEMORY_ERROR;
rc = -1; rc = -1;
goto out; goto out;
@ -514,12 +515,12 @@ static int _csync_backup_file(CSYNC *ctx, csync_file_stat_t *st) {
} }
CSYNC_LOG(CSYNC_LOG_PRIORITY_TRACE,"suri: %s",suri); CSYNC_LOG(CSYNC_LOG_PRIORITY_TRACE,"suri: %s",suri);
CSYNC_LOG(CSYNC_LOG_PRIORITY_TRACE,"duri: %s",duri); CSYNC_LOG(CSYNC_LOG_PRIORITY_TRACE,"duri: %s",*duri);
/* rename the older file to conflict */ /* rename the older file to conflict */
ctx->replica = drep; ctx->replica = drep;
if (csync_vio_rename(ctx, suri, duri) < 0) { if (csync_vio_rename(ctx, suri, *duri) < 0) {
ctx->status_code = csync_errno_to_csync_status(CSYNC_STATUS_PROPAGATE_ERROR); ctx->status_code = csync_errno_to_csync_status(CSYNC_STATUS_PROPAGATE_ERROR);
switch (errno) { switch (errno) {
case ENOMEM: case ENOMEM:
@ -532,7 +533,7 @@ static int _csync_backup_file(CSYNC *ctx, csync_file_stat_t *st) {
strerror_r(errno, errbuf, sizeof(errbuf)); strerror_r(errno, errbuf, sizeof(errbuf));
CSYNC_LOG(CSYNC_LOG_PRIORITY_ERROR, CSYNC_LOG(CSYNC_LOG_PRIORITY_ERROR,
"file: %s, command: rename, error: %s", "file: %s, command: rename, error: %s",
duri, *duri,
errbuf); errbuf);
goto out; goto out;
} }
@ -541,7 +542,7 @@ static int _csync_backup_file(CSYNC *ctx, csync_file_stat_t *st) {
/* set instruction for the statedb merger */ /* set instruction for the statedb merger */
st->instruction = CSYNC_INSTRUCTION_NONE; st->instruction = CSYNC_INSTRUCTION_NONE;
CSYNC_LOG(CSYNC_LOG_PRIORITY_DEBUG, "BACKUP file: %s", duri); CSYNC_LOG(CSYNC_LOG_PRIORITY_DEBUG, "BACKUP file: %s", *duri);
rc = 0; rc = 0;
@ -552,7 +553,6 @@ out:
} }
SAFE_FREE(suri); SAFE_FREE(suri);
SAFE_FREE(duri);
ctx->replica = rep_bak; ctx->replica = rep_bak;
@ -577,14 +577,35 @@ static int _csync_sync_file(CSYNC *ctx, csync_file_stat_t *st) {
static int _csync_conflict_file(CSYNC *ctx, csync_file_stat_t *st) { static int _csync_conflict_file(CSYNC *ctx, csync_file_stat_t *st) {
int rc = -1; int rc = -1;
char *conflict_file_name;
rc = _csync_backup_file(ctx, st); char *uri = NULL;
rc = _csync_backup_file(ctx, st, &conflict_file_name);
if(rc>=0) if(rc>=0)
{ {
rc = _csync_push_file(ctx, st); rc = _csync_push_file(ctx, st);
} }
if( rc >= 0 ) {
/* if its the local repository, check if both files are equal. */
if( ctx->current == REMOTE_REPLICA ) {
if (asprintf(&uri, "%s/%s", ctx->local.uri, st->path) < 0) {
return -1;
}
if( c_compare_file(uri, conflict_file_name) == 1 ) {
/* the files are byte wise equal. The conflict can be erased. */
if (csync_vio_local_unlink(conflict_file_name) < 0) {
CSYNC_LOG(CSYNC_LOG_PRIORITY_DEBUG, "REMOVE of csync conflict file %s failed.", conflict_file_name );
} else {
CSYNC_LOG(CSYNC_LOG_PRIORITY_DEBUG, "REMOVED csync conflict file %s as files are equal.",
conflict_file_name );
}
}
}
}
return rc; return rc;
} }