The configuration directory is a static attribute in mirallconfigfile class

This commit is contained in:
Sebastian Meßmer 2013-01-14 00:48:26 +01:00
parent e0645b4b63
commit 4caca2ce1a
5 changed files with 14 additions and 21 deletions

View file

@ -63,10 +63,6 @@ void mirallLogCatcher(QtMsgType type, const char *msg)
// ---------------------------------------------------------------------------------- // ----------------------------------------------------------------------------------
Application *Application::getInstance() {
return dynamic_cast<Application*>(qApp);
}
Application::Application(int &argc, char **argv) : Application::Application(int &argc, char **argv) :
SharedTools::QtSingleApplication(argc, argv), SharedTools::QtSingleApplication(argc, argv),
_tray(0), _tray(0),
@ -78,7 +74,6 @@ Application::Application(int &argc, char **argv) :
_theme(Theme::instance()), _theme(Theme::instance()),
_updateDetector(0), _updateDetector(0),
_logBrowser(0), _logBrowser(0),
_dataLocation(QDesktopServices::storageLocation(QDesktopServices::DataLocation)),
_showLogWindow(false), _showLogWindow(false),
_logFlush(false), _logFlush(false),
_helpOnly(false) _helpOnly(false)
@ -186,11 +181,6 @@ Application::~Application()
qDebug() << "* Mirall shutdown"; qDebug() << "* Mirall shutdown";
} }
const QString &Application::getDataLocation() const
{
return _dataLocation;
}
void Application::slotStartUpdateDetector() void Application::slotStartUpdateDetector()
{ {
_updateDetector = new UpdateDetector(this); _updateDetector = new UpdateDetector(this);
@ -960,7 +950,7 @@ void Application::parseOptions(const QStringList &options)
_theme->setSystrayUseMonoIcons(true); _theme->setSystrayUseMonoIcons(true);
} else if (option == QLatin1String("--confdir")) { } else if (option == QLatin1String("--confdir")) {
if (it.hasNext() && !it.peekNext().startsWith(QLatin1String("--"))) { if (it.hasNext() && !it.peekNext().startsWith(QLatin1String("--"))) {
_dataLocation=it.next(); MirallConfigFile::setConfDir(it.next());
} else { } else {
showHelp(); showHelp();
} }

View file

@ -53,10 +53,6 @@ public:
bool giveHelp(); bool giveHelp();
static Application *getInstance();
const QString &getDataLocation() const;
signals: signals:
protected slots: protected slots:
@ -132,7 +128,6 @@ private:
QMap<QString, QString> _overallStatusStrings; QMap<QString, QString> _overallStatusStrings;
LogBrowser *_logBrowser; LogBrowser *_logBrowser;
QString _logFile; QString _logFile;
QString _dataLocation;
bool _showLogWindow; bool _showLogWindow;
bool _logFlush; bool _logFlush;
bool _helpOnly; bool _helpOnly;

View file

@ -29,7 +29,6 @@
#endif #endif
#include <QtCore> #include <QtCore>
#include "application.h"
namespace Mirall { namespace Mirall {
@ -38,9 +37,10 @@ FolderMan::FolderMan(QObject *parent) :
{ {
// if QDir::mkpath would not be so stupid, I would not need to have this // if QDir::mkpath would not be so stupid, I would not need to have this
// duplication of folderConfigPath() here // duplication of folderConfigPath() here
QDir storageDir(Application::getInstance()->getDataLocation()); MirallConfigFile cfg;
QDir storageDir(cfg.configPath());
storageDir.mkpath(QLatin1String("folders")); storageDir.mkpath(QLatin1String("folders"));
_folderConfigPath = Application::getInstance()->getDataLocation() + QLatin1String("/folders"); _folderConfigPath = cfg.configPath() + QLatin1String("folders");
_folderChangeSignalMapper = new QSignalMapper(this); _folderChangeSignalMapper = new QSignalMapper(this);
connect(_folderChangeSignalMapper, SIGNAL(mapped(const QString &)), connect(_folderChangeSignalMapper, SIGNAL(mapped(const QString &)),

View file

@ -18,7 +18,6 @@
#include "mirall/owncloudtheme.h" #include "mirall/owncloudtheme.h"
#include "mirall/miralltheme.h" #include "mirall/miralltheme.h"
#include "mirall/credentialstore.h" #include "mirall/credentialstore.h"
#include "mirall/application.h"
#include <QtCore> #include <QtCore>
#include <QtGui> #include <QtGui>
@ -32,6 +31,7 @@
namespace Mirall { namespace Mirall {
QString MirallConfigFile::_oCVersion; QString MirallConfigFile::_oCVersion;
QString MirallConfigFile::_confDir = QDesktopServices::storageLocation(QDesktopServices::DataLocation);
bool MirallConfigFile::_askedUser = false; bool MirallConfigFile::_askedUser = false;
MirallConfigFile::MirallConfigFile( const QString& appendix ) MirallConfigFile::MirallConfigFile( const QString& appendix )
@ -39,9 +39,14 @@ MirallConfigFile::MirallConfigFile( const QString& appendix )
{ {
} }
void MirallConfigFile::setConfDir(const QString &value)
{
_confDir=value;
}
QString MirallConfigFile::configPath() const QString MirallConfigFile::configPath() const
{ {
QString dir = Application::getInstance()->getDataLocation(); QString dir = _confDir;
if( !dir.endsWith(QLatin1Char('/')) ) dir.append(QLatin1Char('/')); if( !dir.endsWith(QLatin1Char('/')) ) dir.append(QLatin1Char('/'));
return dir; return dir;
} }

View file

@ -97,6 +97,8 @@ public:
int proxyPort() const; int proxyPort() const;
QString proxyUser() const; QString proxyUser() const;
QString proxyPassword() const; QString proxyPassword() const;
static void setConfDir(const QString &value);
protected: protected:
// these classes can only be access from CredentialStore as a friend class. // these classes can only be access from CredentialStore as a friend class.
@ -112,6 +114,7 @@ private:
private: private:
static bool _askedUser; static bool _askedUser;
static QString _oCVersion; static QString _oCVersion;
static QString _confDir;
QString _customHandle; QString _customHandle;
}; };