From 133a8ec22503df9d4407c72e6c585f8068eacb87 Mon Sep 17 00:00:00 2001 From: Klaas Freitag Date: Fri, 21 Nov 2014 08:13:20 +0100 Subject: [PATCH] Added a fixme for an edge case detected by QuickCheck. --- csync/src/csync_reconcile.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/csync/src/csync_reconcile.c b/csync/src/csync_reconcile.c index c68adc32d..53bd347ee 100644 --- a/csync/src/csync_reconcile.c +++ b/csync/src/csync_reconcile.c @@ -254,6 +254,10 @@ static int _csync_merge_algorithm_visitor(void *obj, void *data) { is_equal_files = (other->modtime == cur->modtime); } else { is_equal_files = ((other->size == cur->size) && (other->modtime == cur->modtime)); + // FIXME: do a binary comparision of the file here because of the following + // edge case: + // The files could still have different content, even though the mtime + // and size are the same. } if (is_equal_files) { /* The files are considered equal. */