mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-10-23 04:45:43 +03:00
Code Issues Projects Releases Packages Wiki Activity

Add early return checks for setter methods

Browse source 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
This commit is contained in:
Claudio Cambra 2022-10-01 10:37:02 +02:00
parent 685a0362fc
commit 0ca927843f
No known key found for this signature in database
GPG key ID: C839200C384636B0
4 changed files with 30 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/gui/fileactivitylistmodel.cpp
View file

@ -34,6 +34,10 @@ QString FileActivityListModel::localPath() const
void FileActivityListModel::setLocalPath(const QString &localPath)
{
if(localPath == _localPath) {
return;
}
_localPath = localPath;
Q_EMIT localPathChanged();

18
src/gui/filedetails/shareemodel.cpp
View file

@ -82,11 +82,15 @@ QVariant ShareeModel::data(const QModelIndex &index, const int role) const
AccountState *ShareeModel::accountState() const
{
return _accountState.data();
return _accountState;
}
void ShareeModel::setAccountState(AccountState *accountState)
{
if (accountState == _accountState) {
return;
}
_accountState = accountState;
Q_EMIT accountStateChanged();
}
@ -98,6 +102,10 @@ bool ShareeModel::shareItemIsFolder() const
void ShareeModel::setShareItemIsFolder(const bool shareItemIsFolder)
{
if (shareItemIsFolder == _shareItemIsFolder) {
return;
}
_shareItemIsFolder = shareItemIsFolder;
Q_EMIT shareItemIsFolderChanged();
}
@ -109,6 +117,10 @@ QString ShareeModel::searchString() const
void ShareeModel::setSearchString(const QString &searchString)
{
if (searchString == _searchString) {
return;
}
_searchString = searchString;
Q_EMIT searchStringChanged();
@ -127,6 +139,10 @@ ShareeModel::LookupMode ShareeModel::lookupMode() const
void ShareeModel::setLookupMode(const ShareeModel::LookupMode lookupMode)
{
if (lookupMode == _lookupMode) {
return;
}
_lookupMode = lookupMode;
Q_EMIT lookupModeChanged();
}

2
src/gui/filedetails/shareemodel.h
View file

@ -87,7 +87,7 @@ private:
QTimer _userStoppedTypingTimer;
AccountStatePtr _accountState;
AccountState *_accountState;
QString _searchString;
bool _shareItemIsFolder = false;
bool _fetchOngoing = false;

8
src/gui/filedetails/sharemodel.cpp
View file

@ -899,6 +899,10 @@ QString ShareModel::localPath() const
void ShareModel::setLocalPath(const QString &localPath)
{
if (localPath == _localPath) {
return;
}
_localPath = localPath;
Q_EMIT localPathChanged();
updateData();
@ -911,6 +915,10 @@ AccountState *ShareModel::accountState() const
void ShareModel::setAccountState(AccountState *accountState)
{
if (accountState == _accountState) {
return;
}
_accountState = accountState;
// Change the server and account-related properties