nextcloud-desktop/.clang-tidy

Checks: '-*,
    bugprone-argument-comment,
    bugprone-branch-clone,
    cppcoreguidelines-init-variables,
    misc-*,
    -misc-non-private-member-variables-in-classes,
    modernize-avoid-bind,
    modernize-concat-nested-namespaces,
    modernize-deprecated-headers,
    modernize-deprecated-ios-base-aliases,
    modernize-loop-convert,
    modernize-make-*,
    modernize-raw-string-literal,
    modernize-redundant-void-arg,
    modernize-replace-*,
    modernize-return-braced-init-list,
    modernize-shrink-to-fit,
    modernize-unary-static-assert,
    modernize-use-auto,
    modernize-use-bool-literals,
    modernize-use-default-member-init,
    modernize-use-emplace,
    modernize-use-equals-delete,
    modernize-use-nodiscard,
    modernize-use-equals-default,
    modernize-use-noexcept,
    modernize-user-override,
    modernize-use-nullptr,
    modernize-use-transparent-functors,
    modernize-use-uncaught-exceptions,
    modernize-use-using,
'
WarningsAsErrors: '*'
HeaderFilterRegex: '.*'
AnalyzeTemporaryDtors: false
FormatStyle:     none
CheckOptions:
  - key: modernize-use-default-member-init.UseAssignment
    value: 1
Run clang-tidy from the 5.12-clang pipeline This should pass, with the minimal .clang-tidy which was provided. Other PRs should be done to enable further checks. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-27 19:44:25 +03:00			`Checks: '-*,`
Enable the bugprone-argument-comment clang-tidy check Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-08-18 17:51:16 +03:00			`bugprone-argument-comment,`
Enable the bugprone-branch-clone clang-tidy check Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-08-18 18:41:02 +03:00			`bugprone-branch-clone,`
Do not declare local variables without an initial value. Signed-off-by: Camila San <hello@camila.codes> 2020-05-29 16:07:05 +03:00			`cppcoreguidelines-init-variables,`
Enable all the misc clang-tidy check except one This flagged mostly unused parameters. Didn't enable the misc-non-private-member-variables-in-classes check as we got a lot of those. Hopefully we'll get to fix them at some point but that feels too early and too much work for now. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-08-19 17:32:57 +03:00			`misc-*,`
			`-misc-non-private-member-variables-in-classes,`
Enable "trivial" modernize clang-tidy checks This is a bunch of modernize checks which we don't hit at all. This is an easy win and also make sure those old constructs won't creep up behind our back. Note that some of them won't trigger until we bump our C++ baseline standard to C++17. But I'd say that's OK, that'll force our hand to do those C++17 related cleanups when the time comes. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-08-12 12:22:16 +03:00			`modernize-avoid-bind,`
			`modernize-concat-nested-namespaces,`
Enable the modernize-deprecated-headers check on clang-tidy Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-08-13 14:00:56 +03:00			`modernize-deprecated-headers,`
Enable "trivial" modernize clang-tidy checks This is a bunch of modernize checks which we don't hit at all. This is an easy win and also make sure those old constructs won't creep up behind our back. Note that some of them won't trigger until we bump our C++ baseline standard to C++17. But I'd say that's OK, that'll force our hand to do those C++17 related cleanups when the time comes. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-08-12 12:22:16 +03:00			`modernize-deprecated-ios-base-aliases,`
Enable the modernize-loop-convert check on clang-tidy Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-08-13 13:23:02 +03:00			`modernize-loop-convert,`
Add some more make_unique calls Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-27 21:00:11 +03:00			`modernize-make-*,`
Add more raw string literals missed previously Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-06-04 15:09:06 +03:00			`modernize-raw-string-literal,`
Remove the last redundant void arg I left behind Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-27 21:14:41 +03:00			`modernize-redundant-void-arg,`
Run clang-tidy from the 5.12-clang pipeline This should pass, with the minimal .clang-tidy which was provided. Other PRs should be done to enable further checks. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-27 19:44:25 +03:00			`modernize-replace-*,`
Cleanup the missing braced init list returns Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-27 21:19:15 +03:00			`modernize-return-braced-init-list,`
Run clang-tidy from the 5.12-clang pipeline This should pass, with the minimal .clang-tidy which was provided. Other PRs should be done to enable further checks. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-27 19:44:25 +03:00			`modernize-shrink-to-fit,`
Enable "trivial" modernize clang-tidy checks This is a bunch of modernize checks which we don't hit at all. This is an easy win and also make sure those old constructs won't creep up behind our back. Note that some of them won't trigger until we bump our C++ baseline standard to C++17. But I'd say that's OK, that'll force our hand to do those C++17 related cleanups when the time comes. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-08-12 12:22:16 +03:00			`modernize-unary-static-assert,`
Add missing auto opportunities Somehow forgot to run it on the updater code Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-27 21:23:36 +03:00			`modernize-use-auto,`
Run clang-tidy from the 5.12-clang pipeline This should pass, with the minimal .clang-tidy which was provided. Other PRs should be done to enable further checks. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-27 19:44:25 +03:00			`modernize-use-bool-literals,`
Use default member init when applicable This also fixes a couple of warnings at places (out of order init for instance) and a potential bug in the webflow credentials / qtkeychain integration. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-28 17:59:24 +03:00			`modernize-use-default-member-init,`
Run clang-tidy from the 5.12-clang pipeline This should pass, with the minimal .clang-tidy which was provided. Other PRs should be done to enable further checks. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-27 19:44:25 +03:00			`modernize-use-emplace,`
Enable "trivial" modernize clang-tidy checks This is a bunch of modernize checks which we don't hit at all. This is an easy win and also make sure those old constructs won't creep up behind our back. Note that some of them won't trigger until we bump our C++ baseline standard to C++17. But I'd say that's OK, that'll force our hand to do those C++17 related cleanups when the time comes. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-08-12 12:22:16 +03:00			`modernize-use-equals-delete,`
			`modernize-use-nodiscard,`
Enable the modernize-use-equals-default check on clang-tidy Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-08-12 18:19:49 +03:00			`modernize-use-equals-default,`
Run clang-tidy from the 5.12-clang pipeline This should pass, with the minimal .clang-tidy which was provided. Other PRs should be done to enable further checks. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-27 19:44:25 +03:00			`modernize-use-noexcept,`
Enable "trivial" modernize clang-tidy checks This is a bunch of modernize checks which we don't hit at all. This is an easy win and also make sure those old constructs won't creep up behind our back. Note that some of them won't trigger until we bump our C++ baseline standard to C++17. But I'd say that's OK, that'll force our hand to do those C++17 related cleanups when the time comes. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-08-12 12:22:16 +03:00			`modernize-user-override,`
Enable the modernize-user-nullptr check on clang-tidy Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-08-12 17:14:48 +03:00			`modernize-use-nullptr,`
Run clang-tidy from the 5.12-clang pipeline This should pass, with the minimal .clang-tidy which was provided. Other PRs should be done to enable further checks. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-27 19:44:25 +03:00			`modernize-use-transparent-functors,`
			`modernize-use-uncaught-exceptions,`
Enable the modernize-use-using check on clang-tidy Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-08-12 16:23:11 +03:00			`modernize-use-using,`
Run clang-tidy from the 5.12-clang pipeline This should pass, with the minimal .clang-tidy which was provided. Other PRs should be done to enable further checks. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-27 19:44:25 +03:00			`'`
			`WarningsAsErrors: '*'`
			`HeaderFilterRegex: '.*'`
			`AnalyzeTemporaryDtors: false`
			`FormatStyle: none`
Use default member init when applicable This also fixes a couple of warnings at places (out of order init for instance) and a potential bug in the webflow credentials / qtkeychain integration. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com> 2020-05-28 17:59:24 +03:00			`CheckOptions:`
			`- key: modernize-use-default-member-init.UseAssignment`
			`value: 1`