mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-11-27 09:30:13 +03:00
Code Issues Projects Releases Packages Wiki Activity
nextcloud-desktop/test/testutility.cpp

224 lines
8.4 KiB
C++
Raw Normal View History

Add tests for Utility namespace
2013-08-09 14:56:43 +04:00
/*
This software is in the public domain, furnished "as is", without technical
support, and with no warranty, express or implied, as to its usefulness for
any purpose.
*/
#include <QtTest>
Utility: Add a function to check if two filenames are equal plus test. It calls canonical path always and works with the correct case preserving depending on the platform.
2016-10-12 15:48:00 +03:00
#include <QTemporaryDir>
Add tests for Utility namespace
2013-08-09 14:56:43 +04:00
Move Utility to a new common static library Now that csync builds as C++, this will avoid having to implement functionalities needed by csync mandatorily in csync itself. This library is built as part of libocsync and symbols exported through it. This requires a relicense of Utility as LGPL. All classes moved into this library from src/libsync will need to be relicensed as well.
2017-08-16 09:36:52 +03:00
#include "common/utility.h"
Add tests for Utility namespace
2013-08-09 14:56:43 +04:00
Fix tests
2014-11-10 00:36:49 +03:00
using namespace OCC::Utility;
Add tests for Utility namespace
2013-08-09 14:56:43 +04:00
Utility::fsCasePreserving: remove UNIT_TESTING ifdef Since the release package will be build with unit test, we don't want to query the env variable at every call to fsCasePreserving. So only test the env variable at startup. And the testutility can still change the value. (The env variable is still used from t8.pl and maybe smashbox) Issue #6318
2018-02-20 16:29:45 +03:00
namespace OCC {
OCSYNC_EXPORT extern bool fsCasePreserving_override;
}
Add tests for Utility namespace
2013-08-09 14:56:43 +04:00
class TestUtility : public QObject
{
Q_OBJECT
private slots:
testLaunchOnStartup shouldn't fail on dev setup This test was failing locally for me. Indeed, through QStandardPaths it was finding the user settings of my production client and not having the initial state it expected. Using QStandardPaths test mode then it starts from a clean slate every time. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-05-27 16:11:25 +03:00
void initTestCase()
{
QStandardPaths::setTestModeEnabled(true);
}
Add tests for Utility namespace
2013-08-09 14:56:43 +04:00
void testFormatFingerprint()
{
QVERIFY2(formatFingerprint("68ac906495480a3404beee4874ed853a037a7a8f")
Revert "fix test" This reverts commit f35e2efd4efea9b5a17f8e3a30ee2665b497b911.
2014-01-22 02:49:16 +04:00
== "68:ac:90:64:95:48:0a:34:04:be:ee:48:74:ed:85:3a:03:7a:7a:8f",
Add tests for Utility namespace
2013-08-09 14:56:43 +04:00
"Utility::formatFingerprint() is broken");
}
void testOctetsToString()
{
Revert "Utility: Use SI units" This reverts commit 7445fa7ef77ccefbd9eb1153cec9523ca62bd4fe. and commit f654c53c35f41e40973c827606c061524cc1b2eb. The server still use wrong powers, so we still need to use the same
2015-01-15 15:54:39 +03:00
QLocale::setDefault(QLocale("en"));
Use the same convention as on the server to format strings * use power of 10 SI units * use "B" instead of "bytes" * use at least 2 significant digit, but no more than one digit after the period
2013-08-29 14:06:41 +04:00
QCOMPARE(octetsToString(999) , QString("999 B"));
Utility: Fix the size display back to JEDEC standard. Also updated the test.
2015-09-10 18:31:44 +03:00
QCOMPARE(octetsToString(1024) , QString("1 KB"));
Adjust size description strings #3403 @jancorchardt suggested to not have decimal places on file sizes, except for GB.
2016-01-21 11:50:32 +03:00
QCOMPARE(octetsToString(1364) , QString("1 KB"));
Use the same convention as on the server to format strings * use power of 10 SI units * use "B" instead of "bytes" * use at least 2 significant digit, but no more than one digit after the period
2013-08-29 14:06:41 +04:00
Adjust size description strings #3403 @jancorchardt suggested to not have decimal places on file sizes, except for GB.
2016-01-21 11:50:32 +03:00
QCOMPARE(octetsToString(9110) , QString("9 KB"));
QCOMPARE(octetsToString(9910) , QString("10 KB"));
Utility: Fix the size display back to JEDEC standard. Also updated the test.
2015-09-10 18:31:44 +03:00
QCOMPARE(octetsToString(10240) , QString("10 KB"));
Use the same convention as on the server to format strings * use power of 10 SI units * use "B" instead of "bytes" * use at least 2 significant digit, but no more than one digit after the period
2013-08-29 14:06:41 +04:00
Utility: Fix the size display back to JEDEC standard. Also updated the test.
2015-09-10 18:31:44 +03:00
QCOMPARE(octetsToString(123456) , QString("121 KB"));
Transfers: Show a decimal for single digit MB rates #4428
2017-04-04 10:54:06 +03:00
QCOMPARE(octetsToString(1234567) , QString("1.2 MB"));
Utility: use SI units for the sizes in bytes
2015-08-05 17:22:09 +03:00
QCOMPARE(octetsToString(12345678) , QString("12 MB"));
Utility: Fix the size display back to JEDEC standard. Also updated the test.
2015-09-10 18:31:44 +03:00
QCOMPARE(octetsToString(123456789) , QString("118 MB"));
QCOMPARE(octetsToString(1000LL*1000*1000 * 5) , QString("4.7 GB"));
Use the same convention as on the server to format strings * use power of 10 SI units * use "B" instead of "bytes" * use at least 2 significant digit, but no more than one digit after the period
2013-08-29 14:06:41 +04:00
Tests: Move all comparisons from QVERIFY to QCOMPARE
2013-08-29 16:48:40 +04:00
QCOMPARE(octetsToString(1), QString("1 B"));
QCOMPARE(octetsToString(2), QString("2 B"));
Utility: Fix the size display back to JEDEC standard. Also updated the test.
2015-09-10 18:31:44 +03:00
QCOMPARE(octetsToString(1024), QString("1 KB"));
QCOMPARE(octetsToString(1024*1024), QString("1 MB"));
QCOMPARE(octetsToString(1024LL*1024*1024), QString("1 GB"));
Add tests for Utility namespace
2013-08-09 14:56:43 +04:00
}
void testLaunchOnStartup()
{
Tests: make tests run in parallel
2013-08-29 16:50:45 +04:00
qsrand(QDateTime::currentDateTime().toTime_t());
QString postfix = QString::number(qrand());
Add tests for Utility namespace
2013-08-09 14:56:43 +04:00
Tests: make tests run in parallel
2013-08-29 16:50:45 +04:00
const QString appName = QString::fromLatin1("testLaunchOnStartup.%1").arg(postfix);
Tests: Fix indentation
2013-08-29 16:50:18 +04:00
const QString guiName = "LaunchOnStartup GUI Name";
QVERIFY(hasLaunchOnStartup(appName) == false);
setLaunchOnStartup(appName, guiName, true);
QVERIFY(hasLaunchOnStartup(appName) == true);
setLaunchOnStartup(appName, guiName, false);
QVERIFY(hasLaunchOnStartup(appName) == false);
Add tests for Utility namespace
2013-08-09 14:56:43 +04:00
}
Utility: improve the function to conver a duration to string - Make it translatable - Make use of the %n so that it supports plurals (but this will only take effect if we have an english translation) - Only put two units. eg: "5 years 7 months" instead of "5 years 7 months 12 days 34 minutes 23 seconds" Even when it is "2 hours 23 minutes" the amount of second does not matter, especially since the estimation is likely to be boggus anyway Issues #2672 and #3097
2015-06-29 15:53:37 +03:00
void testDurationToDescriptiveString()
{
QLocale::setDefault(QLocale("C"));
//NOTE: in order for the plural to work we would need to load the english translation
quint64 sec = 1000;
quint64 hour = 3600 * sec;
Test: Don't fail when DST change is near #5284
2016-11-08 13:13:19 +03:00
QDateTime current = QDateTime::currentDateTimeUtc();
Utility: improve the function to conver a duration to string - Make it translatable - Make use of the %n so that it supports plurals (but this will only take effect if we have an english translation) - Only put two units. eg: "5 years 7 months" instead of "5 years 7 months 12 days 34 minutes 23 seconds" Even when it is "2 hours 23 minutes" the amount of second does not matter, especially since the estimation is likely to be boggus anyway Issues #2672 and #3097
2015-06-29 15:53:37 +03:00
Add utility function for shorter time duration strings #3403
2016-01-21 11:53:58 +03:00
QCOMPARE(durationToDescriptiveString2(0), QString("0 second(s)") );
QCOMPARE(durationToDescriptiveString2(5), QString("0 second(s)") );
QCOMPARE(durationToDescriptiveString2(1000), QString("1 second(s)") );
QCOMPARE(durationToDescriptiveString2(1005), QString("1 second(s)") );
QCOMPARE(durationToDescriptiveString2(56123), QString("56 second(s)") );
QCOMPARE(durationToDescriptiveString2(90*sec), QString("1 minute(s) 30 second(s)") );
QCOMPARE(durationToDescriptiveString2(3*hour), QString("3 hour(s)") );
QCOMPARE(durationToDescriptiveString2(3*hour + 20*sec), QString("3 hour(s)") );
QCOMPARE(durationToDescriptiveString2(3*hour + 70*sec), QString("3 hour(s) 1 minute(s)") );
QCOMPARE(durationToDescriptiveString2(3*hour + 100*sec), QString("3 hour(s) 2 minute(s)") );
QCOMPARE(durationToDescriptiveString2(current.msecsTo(current.addYears(4).addMonths(5).addDays(2).addSecs(23*60*60))),
Utility: improve the function to conver a duration to string - Make it translatable - Make use of the %n so that it supports plurals (but this will only take effect if we have an english translation) - Only put two units. eg: "5 years 7 months" instead of "5 years 7 months 12 days 34 minutes 23 seconds" Even when it is "2 hours 23 minutes" the amount of second does not matter, especially since the estimation is likely to be boggus anyway Issues #2672 and #3097
2015-06-29 15:53:37 +03:00
QString("4 year(s) 5 month(s)") );
Add utility function for shorter time duration strings #3403
2016-01-21 11:53:58 +03:00
QCOMPARE(durationToDescriptiveString2(current.msecsTo(current.addDays(2).addSecs(23*60*60))),
Utility: improve the function to conver a duration to string - Make it translatable - Make use of the %n so that it supports plurals (but this will only take effect if we have an english translation) - Only put two units. eg: "5 years 7 months" instead of "5 years 7 months 12 days 34 minutes 23 seconds" Even when it is "2 hours 23 minutes" the amount of second does not matter, especially since the estimation is likely to be boggus anyway Issues #2672 and #3097
2015-06-29 15:53:37 +03:00
QString("2 day(s) 23 hour(s)") );
Add utility function for shorter time duration strings #3403
2016-01-21 11:53:58 +03:00
QCOMPARE(durationToDescriptiveString1(0), QString("0 second(s)") );
QCOMPARE(durationToDescriptiveString1(5), QString("0 second(s)") );
QCOMPARE(durationToDescriptiveString1(1000), QString("1 second(s)") );
QCOMPARE(durationToDescriptiveString1(1005), QString("1 second(s)") );
QCOMPARE(durationToDescriptiveString1(56123), QString("56 second(s)") );
QCOMPARE(durationToDescriptiveString1(90*sec), QString("2 minute(s)") );
QCOMPARE(durationToDescriptiveString1(3*hour), QString("3 hour(s)") );
QCOMPARE(durationToDescriptiveString1(3*hour + 20*sec), QString("3 hour(s)") );
QCOMPARE(durationToDescriptiveString1(3*hour + 70*sec), QString("3 hour(s)") );
QCOMPARE(durationToDescriptiveString1(3*hour + 100*sec), QString("3 hour(s)") );
QCOMPARE(durationToDescriptiveString1(current.msecsTo(current.addYears(4).addMonths(5).addDays(2).addSecs(23*60*60))),
QString("4 year(s)") );
QCOMPARE(durationToDescriptiveString1(current.msecsTo(current.addDays(2).addSecs(23*60*60))),
QString("3 day(s)") );
Utility: improve the function to conver a duration to string - Make it translatable - Make use of the %n so that it supports plurals (but this will only take effect if we have an english translation) - Only put two units. eg: "5 years 7 months" instead of "5 years 7 months 12 days 34 minutes 23 seconds" Even when it is "2 hours 23 minutes" the amount of second does not matter, especially since the estimation is likely to be boggus anyway Issues #2672 and #3097
2015-06-29 15:53:37 +03:00
}
Utility: Added function versionOfInstalledBinary() It calls the binary with param --version and returns the first line of the output. For owncloud, that is the version string.
2015-07-16 19:16:16 +03:00
void testVersionOfInstalledBinary()
{
if( isLinux() ) {
Make version check test conditional for now
2015-08-07 13:42:18 +03:00
if ( qgetenv("DISPLAY").isEmpty() ) {
// Current requires an X-Server
return;
}
Fix utility test: Pass a command name to do the version check.
2016-05-10 17:26:42 +03:00
// pass the binary name owncloud to the next call. This brakes branding,
// but branding is not supposed to work with this.
Update testutility Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-22 16:03:12 +03:00
QString ver = versionOfInstalledBinary(OWNCLOUD_BIN_PATH+QLatin1String("/nextcloud"));
qDebug() << "Version of installed Nextcloud: " << ver;
test Utility: really check for a version string.
2015-07-31 16:38:01 +03:00
QVERIFY( !ver.isEmpty());
Use raw string literals when appropriate This is especially nice for Windows paths. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-05-26 21:13:51 +03:00
QRegExp rx( R"(Nextcloud version \d+\.\d+\.\d+.*)" );
test Utility: really check for a version string.
2015-07-31 16:38:01 +03:00
QVERIFY( rx.exactMatch(ver));
Utility: Added function versionOfInstalledBinary() It calls the binary with param --version and returns the first line of the output. For owncloud, that is the version string.
2015-07-16 19:16:16 +03:00
} else {
test Utility: really check for a version string.
2015-07-31 16:38:01 +03:00
QVERIFY( versionOfInstalledBinary().isEmpty());
Utility: Added function versionOfInstalledBinary() It calls the binary with param --version and returns the first line of the output. For owncloud, that is the version string.
2015-07-16 19:16:16 +03:00
}
}
Tests: Add a test for the timeAgoInWords function
2016-02-15 19:59:01 +03:00
void testTimeAgo()
{
timeAgo test: Fix for qt4, clean up
2016-05-12 10:25:15 +03:00
// Both times in same timezone
Tests: Add a test for the timeAgoInWords function
2016-02-15 19:59:01 +03:00
QDateTime d1 = QDateTime::fromString("2015-01-24T09:20:30+01:00", Qt::ISODate);
QDateTime d2 = QDateTime::fromString("2015-01-23T09:20:30+01:00", Qt::ISODate);
QString s = timeAgoInWords(d2, d1);
Update testutility Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-22 16:03:12 +03:00
QCOMPARE(s, QLatin1String("1 day ago"));
Tests: Add a test for the timeAgoInWords function
2016-02-15 19:59:01 +03:00
timeAgo test: Fix for qt4, clean up
2016-05-12 10:25:15 +03:00
// Different timezones
Tests: Add a test for the timeAgoInWords function
2016-02-15 19:59:01 +03:00
QDateTime earlyTS = QDateTime::fromString("2015-01-24T09:20:30+01:00", Qt::ISODate);
timeAgo test: Fix for qt4, clean up
2016-05-12 10:25:15 +03:00
QDateTime laterTS = QDateTime::fromString("2015-01-24T09:20:30-01:00", Qt::ISODate);
Tests: Add a test for the timeAgoInWords function
2016-02-15 19:59:01 +03:00
s = timeAgoInWords(earlyTS, laterTS);
Update testutility Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-22 16:03:12 +03:00
QCOMPARE(s, QLatin1String("2 hours ago"));
Tests: Add a test for the timeAgoInWords function
2016-02-15 19:59:01 +03:00
timeAgo test: Fix for qt4, clean up
2016-05-12 10:25:15 +03:00
// 'Now' in whatever timezone
Tests: Add a test for the timeAgoInWords function
2016-02-15 19:59:01 +03:00
earlyTS = QDateTime::currentDateTime();
laterTS = earlyTS;
s = timeAgoInWords(earlyTS, laterTS );
QCOMPARE(s, QLatin1String("now"));
earlyTS = earlyTS.addSecs(-6);
s = timeAgoInWords(earlyTS, laterTS );
QCOMPARE(s, QLatin1String("Less than a minute ago"));
}
Utility: Add a function to check if two filenames are equal plus test. It calls canonical path always and works with the correct case preserving depending on the platform.
2016-10-12 15:48:00 +03:00
void testFsCasePreserving()
{
Utility::fsCasePreserving: remove UNIT_TESTING ifdef Since the release package will be build with unit test, we don't want to query the env variable at every call to fsCasePreserving. So only test the env variable at startup. And the testutility can still change the value. (The env variable is still used from t8.pl and maybe smashbox) Issue #6318
2018-02-20 16:29:45 +03:00
QVERIFY(isMac() || isWindows() ? fsCasePreserving() : ! fsCasePreserving());
QScopedValueRollback<bool> scope(OCC::fsCasePreserving_override);
Don't use int literals for bools Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-05-20 09:52:26 +03:00
OCC::fsCasePreserving_override = true;
Utility: Add a function to check if two filenames are equal plus test. It calls canonical path always and works with the correct case preserving depending on the platform.
2016-10-12 15:48:00 +03:00
QVERIFY(fsCasePreserving());
Don't use int literals for bools Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-05-20 09:52:26 +03:00
OCC::fsCasePreserving_override = false;
Utility: Add a function to check if two filenames are equal plus test. It calls canonical path always and works with the correct case preserving depending on the platform.
2016-10-12 15:48:00 +03:00
QVERIFY(! fsCasePreserving());
}
void testFileNamesEqual()
{
QTemporaryDir dir;
QVERIFY(dir.isValid());
QDir dir2(dir.path());
QVERIFY(dir2.mkpath("test"));
if( !fsCasePreserving() ) {
QVERIFY(dir2.mkpath("TEST"));
}
QVERIFY(dir2.mkpath("test/TESTI"));
QVERIFY(dir2.mkpath("TESTI"));
QString a = dir.path();
QString b = dir.path();
QVERIFY(fileNamesEqual(a, b));
QVERIFY(fileNamesEqual(a+"/test", b+"/test")); // both exist
QVERIFY(fileNamesEqual(a+"/test/TESTI", b+"/test/../test/TESTI")); // both exist
Utility::fsCasePreserving: remove UNIT_TESTING ifdef Since the release package will be build with unit test, we don't want to query the env variable at every call to fsCasePreserving. So only test the env variable at startup. And the testutility can still change the value. (The env variable is still used from t8.pl and maybe smashbox) Issue #6318
2018-02-20 16:29:45 +03:00
QScopedValueRollback<bool> scope(OCC::fsCasePreserving_override, true);
Utility: Add a function to check if two filenames are equal plus test. It calls canonical path always and works with the correct case preserving depending on the platform.
2016-10-12 15:48:00 +03:00
QVERIFY(fileNamesEqual(a+"/test", b+"/TEST")); // both exist
QVERIFY(!fileNamesEqual(a+"/test", b+"/test/TESTI")); // both are different
dir.remove();
}
Conflicts: Add user name to conflict file name #6325 For the case of uploading conflict files only.
2018-01-23 13:12:45 +03:00
void testSanitizeForFileName_data()
{
QTest::addColumn<QString>("input");
QTest::addColumn<QString>("output");
QTest::newRow("")
<< "foobar"
<< "foobar";
QTest::newRow("")
<< "a/b?c<d>e\\f:g*h|i\"j"
<< "abcdefghij";
QTest::newRow("")
<< QString::fromLatin1("a\x01 b\x1f c\x80 d\x9f")
<< "a b c d";
}
Utility: Add a function to check if two filenames are equal plus test. It calls canonical path always and works with the correct case preserving depending on the platform.
2016-10-12 15:48:00 +03:00
Conflicts: Add user name to conflict file name #6325 For the case of uploading conflict files only.
2018-01-23 13:12:45 +03:00
void testSanitizeForFileName()
{
QFETCH(QString, input);
QFETCH(QString, output);
QCOMPARE(sanitizeForFileName(input), output);
}
Add tests for Utility namespace
2013-08-09 14:56:43 +04:00
};
Fix UtilityTest on macOS
2017-01-27 20:12:18 +03:00
QTEST_GUILESS_MAIN(TestUtility)
Simplify the build of auto tests Remove all configure_files: - Move all tests to cpp files - Use the QTEST_MAIN macro instead of a generated main.cpp - Include test*.moc in the cpp to let CMAKE_AUTOMOC call moc - Pass info through add_definitions instead of generating oc_bin.h with them This makes sure that build errors points to the original test source file instead of the generated one in the build directory to be able to jump and fix errors directly from the IDE's error pane.
2016-03-30 18:58:15 +03:00
#include "testutility.moc"
Reference in a new issue Copy permalink