mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-11-25 06:25:56 +03:00
Code Issues Projects Releases Packages Wiki Activity
nextcloud-desktop/test/testfolderman.cpp

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

198 lines
8.2 KiB
C++
Raw Normal View History

FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
/*
* This software is in the public domain, furnished "as is", without technical
* support, and with no warranty, express or implied, as to its usefulness for
* any purpose.
*
*/
Fix test build... again. The issue was unrelated to moc! We just need to make sure QT_VERSION etc. are actually defined when we use them for a test!
2015-07-15 10:47:42 +03:00
#include <qglobal.h>
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
#include <QTemporaryDir>
#include <QtTest>
Move Utility to a new common static library Now that csync builds as C++, this will avoid having to implement functionalities needed by csync mandatorily in csync itself. This library is built as part of libocsync and symbols exported through it. This requires a relicense of Utility as LGPL. All classes moved into this library from src/libsync will need to be relicensed as well.
2017-08-16 09:36:52 +03:00
#include "common/utility.h"
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
#include "folderman.h"
Make the AccountState a construction argument of the Folder This will help moving the SyncEngine construction in the constructor and allow moving functionalities from Folder to SyncEngine or its delegated objects.
2016-03-16 21:07:40 +03:00
#include "account.h"
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
#include "accountstate.h"
TestFolderMan: don't pollute user's settings
2016-10-11 12:55:20 +03:00
#include "configfile.h"
Fix the folderman test, adopting the checkPathValidity method tests.
2016-10-07 17:24:09 +03:00
#include "creds/httpcredentials.h"
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
using namespace OCC;
Fix the folderman test, adopting the checkPathValidity method tests.
2016-10-07 17:24:09 +03:00
class HttpCredentialsTest : public HttpCredentials {
public:
HttpCredentialsTest(const QString& user, const QString& password)
Fix compile of tests
2017-01-03 12:52:39 +03:00
: HttpCredentials(user, password)
Fix the folderman test, adopting the checkPathValidity method tests.
2016-10-07 17:24:09 +03:00
{}
void askFromUser() Q_DECL_OVERRIDE {
}
};
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
static FolderDefinition folderDefinition(const QString &path) {
FolderDefinition d;
d.localPath = path;
d.targetPath = path;
d.alias = path;
return d;
}
class TestFolderMan: public QObject
{
Q_OBJECT
FolderMan _fm;
private slots:
void testCheckPathValidityForNewFolder()
{
QTemporaryDir dir;
TestFolderMan: don't pollute user's settings
2016-10-11 12:55:20 +03:00
ConfigFile::setConfDir(dir.path()); // we don't want to pollute the user's config file
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
QVERIFY(dir.isValid());
QDir dir2(dir.path());
QVERIFY(dir2.mkpath("sub/ownCloud1/folder/f"));
QVERIFY(dir2.mkpath("ownCloud2"));
QVERIFY(dir2.mkpath("sub/free"));
QVERIFY(dir2.mkpath("free2/sub"));
Wizards: allow adding a folder in a non-existing directory and create that folder The owncloud wizard already created the directory, but the recent addition of FolderMan::checkPathValidityForNewFolder stopped allowing unexisting directories. So change FolderMan::checkPathValidityForNewFolder to allow non existing directory and whange the FolderWizard to create the directory if it does not exist. Issue #3492
2015-07-28 13:14:52 +03:00
{
QFile f(dir.path() + "/sub/file.txt");
f.open(QFile::WriteOnly);
f.write("hello");
}
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QString dirPath = dir2.canonicalPath();
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
Fix the folderman test, adopting the checkPathValidity method tests.
2016-10-07 17:24:09 +03:00
AccountPtr account = Account::create();
QUrl url("http://example.de");
HttpCredentialsTest *cred = new HttpCredentialsTest("testuser", "secret");
account->setCredentials(cred);
account->setUrl( url );
AccountStatePtr newAccountState(new AccountState(account));
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
FolderMan *folderman = FolderMan::instance();
QCOMPARE(folderman, &_fm);
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QVERIFY(folderman->addFolder(newAccountState.data(), folderDefinition(dirPath + "/sub/ownCloud1")));
QVERIFY(folderman->addFolder(newAccountState.data(), folderDefinition(dirPath + "/ownCloud2")));
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
// those should be allowed
Fix the folderman test, adopting the checkPathValidity method tests.
2016-10-07 17:24:09 +03:00
// QString FolderMan::checkPathValidityForNewFolder(const QString& path, const QUrl &serverUrl, bool forNewDirectory)
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/sub/free"), QString());
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/free2/"), QString());
Wizards: allow adding a folder in a non-existing directory and create that folder The owncloud wizard already created the directory, but the recent addition of FolderMan::checkPathValidityForNewFolder stopped allowing unexisting directories. So change FolderMan::checkPathValidityForNewFolder to allow non existing directory and whange the FolderWizard to create the directory if it does not exist. Issue #3492
2015-07-28 13:14:52 +03:00
// Not an existing directory -> Ok
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/sub/bliblablu"), QString());
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/sub/free/bliblablu"), QString());
// QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/sub/bliblablu/some/more"), QString());
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
Wizards: allow adding a folder in a non-existing directory and create that folder The owncloud wizard already created the directory, but the recent addition of FolderMan::checkPathValidityForNewFolder stopped allowing unexisting directories. So change FolderMan::checkPathValidityForNewFolder to allow non existing directory and whange the FolderWizard to create the directory if it does not exist. Issue #3492
2015-07-28 13:14:52 +03:00
// A file -> Error
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/sub/file.txt").isNull());
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
Fix the folderman test, adopting the checkPathValidity method tests.
2016-10-07 17:24:09 +03:00
// There are folders configured in those folders, url needs to be taken into account: -> ERROR
QUrl url2(url);
const QString user = account->credentials()->user();
url2.setUserName(user);
// The following both fail because they refer to the same account (user and url)
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/sub/ownCloud1", url2).isNull());
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/ownCloud2/", url2).isNull());
Fix the folderman test, adopting the checkPathValidity method tests.
2016-10-07 17:24:09 +03:00
// Now it will work because the account is different
QUrl url3("http://anotherexample.org");
url3.setUserName("dummy");
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/sub/ownCloud1", url3), QString());
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/ownCloud2/", url3), QString());
Fix the folderman test, adopting the checkPathValidity method tests.
2016-10-07 17:24:09 +03:00
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath).isNull());
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/sub/ownCloud1/folder").isNull());
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/sub/ownCloud1/folder/f").isNull());
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
// make a bunch of links
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QVERIFY(QFile::link(dirPath + "/sub/free", dirPath + "/link1"));
QVERIFY(QFile::link(dirPath + "/sub", dirPath + "/link2"));
QVERIFY(QFile::link(dirPath + "/sub/ownCloud1", dirPath + "/link3"));
QVERIFY(QFile::link(dirPath + "/sub/ownCloud1/folder", dirPath + "/link4"));
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
// Ok
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QVERIFY(folderman->checkPathValidityForNewFolder(dirPath + "/link1").isNull());
QVERIFY(folderman->checkPathValidityForNewFolder(dirPath + "/link2/free").isNull());
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
// Not Ok
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/link2").isNull());
Fix the folderman test, adopting the checkPathValidity method tests.
2016-10-07 17:24:09 +03:00
// link 3 points to an existing sync folder. To make it fail, the account must be the same
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/link3", url2).isNull());
Fix the folderman test, adopting the checkPathValidity method tests.
2016-10-07 17:24:09 +03:00
// while with a different account, this is fine
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QCOMPARE(folderman->checkPathValidityForNewFolder(dirPath + "/link3", url3), QString());
Fix the folderman test, adopting the checkPathValidity method tests.
2016-10-07 17:24:09 +03:00
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/link4").isNull());
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/link3/folder").isNull());
Wizards: allow adding a folder in a non-existing directory and create that folder The owncloud wizard already created the directory, but the recent addition of FolderMan::checkPathValidityForNewFolder stopped allowing unexisting directories. So change FolderMan::checkPathValidityForNewFolder to allow non existing directory and whange the FolderWizard to create the directory if it does not exist. Issue #3492
2015-07-28 13:14:52 +03:00
// test some non existing sub path (error)
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/sub/ownCloud1/some/sub/path").isNull());
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/ownCloud2/blublu").isNull());
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/sub/ownCloud1/folder/g/h").isNull());
QVERIFY(!folderman->checkPathValidityForNewFolder(dirPath + "/link3/folder/neu_folder").isNull());
Wizards: allow adding a folder in a non-existing directory and create that folder The owncloud wizard already created the directory, but the recent addition of FolderMan::checkPathValidityForNewFolder stopped allowing unexisting directories. So change FolderMan::checkPathValidityForNewFolder to allow non existing directory and whange the FolderWizard to create the directory if it does not exist. Issue #3492
2015-07-28 13:14:52 +03:00
// Subfolder of links
Fix FolderManTest on macOS On macOS /var is a symlink to /private/var and we have to make sure that we use the canonical path before and after it enters the code to make sure we compare paths correctly.
2017-02-09 20:17:01 +03:00
QVERIFY(folderman->checkPathValidityForNewFolder(dirPath + "/link1/subfolder").isNull());
QVERIFY(folderman->checkPathValidityForNewFolder(dirPath + "/link2/free/subfolder").isNull());
Wizards: allow adding a folder in a non-existing directory and create that folder The owncloud wizard already created the directory, but the recent addition of FolderMan::checkPathValidityForNewFolder stopped allowing unexisting directories. So change FolderMan::checkPathValidityForNewFolder to allow non existing directory and whange the FolderWizard to create the directory if it does not exist. Issue #3492
2015-07-28 13:14:52 +03:00
// Invalid paths
QVERIFY(!folderman->checkPathValidityForNewFolder("").isNull());
// Should not have the rights
QVERIFY(!folderman->checkPathValidityForNewFolder("/").isNull());
QVERIFY(!folderman->checkPathValidityForNewFolder("/usr/bin/somefolder").isNull());
Wizards: Never propose an existing folder for syncing #5597
2017-03-20 16:28:32 +03:00
}
void testFindGoodPathForNewSyncFolder()
{
// SETUP
QTemporaryDir dir;
ConfigFile::setConfDir(dir.path()); // we don't want to pollute the user's config file
QVERIFY(dir.isValid());
QDir dir2(dir.path());
QVERIFY(dir2.mkpath("sub/ownCloud1/folder/f"));
QVERIFY(dir2.mkpath("ownCloud"));
QVERIFY(dir2.mkpath("ownCloud2"));
QVERIFY(dir2.mkpath("ownCloud2/foo"));
QVERIFY(dir2.mkpath("sub/free"));
QVERIFY(dir2.mkpath("free2/sub"));
QString dirPath = dir2.canonicalPath();
AccountPtr account = Account::create();
QUrl url("http://example.de");
HttpCredentialsTest *cred = new HttpCredentialsTest("testuser", "secret");
account->setCredentials(cred);
account->setUrl( url );
AccountStatePtr newAccountState(new AccountState(account));
FolderMan *folderman = FolderMan::instance();
QCOMPARE(folderman, &_fm);
QVERIFY(folderman->addFolder(newAccountState.data(), folderDefinition(dirPath + "/sub/ownCloud/")));
QVERIFY(folderman->addFolder(newAccountState.data(), folderDefinition(dirPath + "/ownCloud2/")));
// TEST
QCOMPARE(folderman->findGoodPathForNewSyncFolder(dirPath + "/oc", url),
QString(dirPath + "/oc"));
QCOMPARE(folderman->findGoodPathForNewSyncFolder(dirPath + "/ownCloud", url),
QString(dirPath + "/ownCloud3"));
QCOMPARE(folderman->findGoodPathForNewSyncFolder(dirPath + "/ownCloud2", url),
QString(dirPath + "/ownCloud22"));
QCOMPARE(folderman->findGoodPathForNewSyncFolder(dirPath + "/ownCloud2/foo", url),
QString(dirPath + "/ownCloud2/foo"));
QCOMPARE(folderman->findGoodPathForNewSyncFolder(dirPath + "/ownCloud2/bar", url),
QString(dirPath + "/ownCloud2/bar"));
QCOMPARE(folderman->findGoodPathForNewSyncFolder(dirPath + "/sub", url),
QString(dirPath + "/sub2"));
FolderMan::checkPathValidityForNewFolder factorize the function to check the validity of a new folder out of the folder wizard to the FolderMan. There is even a test for it now. That way we can also use it in the normal wizard
2015-07-13 15:35:19 +03:00
}
};
For tests we do not need a xserver running. Use for tests QTEST_GUILESS_MAIN and QTEST_APPLESS_MAIN.
2016-05-11 02:17:16 +03:00
QTEST_APPLESS_MAIN(TestFolderMan)
Simplify the build of auto tests Remove all configure_files: - Move all tests to cpp files - Use the QTEST_MAIN macro instead of a generated main.cpp - Include test*.moc in the cpp to let CMAKE_AUTOMOC call moc - Pass info through add_definitions instead of generating oc_bin.h with them This makes sure that build errors points to the original test source file instead of the generated one in the build directory to be able to jump and fix errors directly from the IDE's error pane.
2016-03-30 18:58:15 +03:00
#include "testfolderman.moc"
Reference in a new issue Copy permalink