Álvaro Brey
7bd0190c4b
Merge pull request #9225 from nextcloud/wording
...
rename "read only" -> "view only"
2021-11-09 08:30:19 +01:00
Álvaro Brey Vilas
7966fa7923
Re-try to get file management permission if user does not enable it, and show toast.
...
Does not allow any usage of the app if permission is not granted.
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 16:56:22 +01:00
Álvaro Brey Vilas
44968b20ad
PermissionUtil: fix version conditional
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 16:26:44 +01:00
Tobias Kaminsky
2e80f45191
Merge pull request #9188 from nextcloud/leakCanary
...
Use LeakCanary in debug mode
2021-11-08 15:14:41 +01:00
tobiasKaminsky
f4f0c22492
rename "read only" -> "view only"
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-08 14:05:45 +01:00
Álvaro Brey Vilas
be54fa0bce
Update spotbugs results
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:56:04 +01:00
Álvaro Brey Vilas
3c80a05354
Revert "Use internalTemporalPath instead of temporalPath"
...
This reverts commit 1811d040f7
2021-11-08 13:50:43 +01:00
Álvaro Brey Vilas
41dbdaf3ed
Revert "DownloadFileOperation: use moveFile instead of File.renameTo"
...
This reverts commit f18f72abcd
2021-11-08 13:50:26 +01:00
Álvaro Brey Vilas
5eeb8c0343
Remove What's New screens for scoped storage
...
Not needed if we get the manage permission
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:46:23 +01:00
Álvaro Brey Vilas
6a76372fde
GrantStoragePermissionRule: grant MANAGE_EXTERNAL_STORAGE on sdk >=30
...
Feels a bit hacky but it's the actual recommended way:
https://developer.android.com/training/data-storage/manage-all-files#enable-manage-external-storage-for-testing
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:40:17 +01:00
Álvaro Brey Vilas
a0b85cac71
Ditch scoped storage, try MANAGE_EXTERNAL_STORAGE
...
We _are_ a file-managing app, after all.
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:13:02 +01:00
Álvaro Brey
0f024b81e0
Merge pull request #9223 from nextcloud/Valdnet-patch-2
...
i18n: Minor changes to sentence
2021-11-08 11:52:37 +01:00
Álvaro Brey Vilas
9eb2fcc6c1
spotbugs: Show list of scanned files
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 10:37:42 +01:00
Valdnet
a638101359
i18n: Minor changes to sentence
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-11-08 09:02:27 +01:00
Nextcloud bot
dce7eb713a
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-08 06:34:35 +00:00
Tobias Kaminsky
7b80e23b8e
Merge pull request #9220 from nextcloud/fixTranslations
...
Translation files must be one line
2021-11-08 07:21:47 +01:00
tobiasKaminsky
915b764f36
Translation files must be one line
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-08 07:04:59 +01:00
Álvaro Brey
72198d4865
Merge pull request #9161 from nextcloud/dependabot/gradle/daggerVersion-2.40
...
Bump daggerVersion from 2.39.1 to 2.40
2021-11-05 16:16:18 +01:00
Álvaro Brey
c161b5235b
Merge pull request #9197 from nextcloud/dependabot/gradle/androidx.annotation-annotation-1.3.0
...
Bump annotation from 1.2.0 to 1.3.0
2021-11-05 16:14:20 +01:00
Álvaro Brey Vilas
14c1e8d718
build.gradle: Refactor spotbugs setup
...
- Don't duplicate tasks. Use the ones that spotbugs provides and link them to their sourcesets
- Add dependencies to compileSources to the spotbugs tasks
- Update spotbugs plugin
This results in a much higher amount of issues. They were probably not being properly scanned earlier.
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-05 16:12:05 +01:00
dependabot[bot]
17b602e263
Bump daggerVersion from 2.39.1 to 2.40
...
Bumps `daggerVersion` from 2.39.1 to 2.40.
Updates `dagger` from 2.39.1 to 2.40
- [Release notes](https://github.com/google/dagger/releases )
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md )
- [Commits](https://github.com/google/dagger/compare/dagger-2.39.1...dagger-2.40 )
Updates `dagger-android` from 2.39.1 to 2.40
- [Release notes](https://github.com/google/dagger/releases )
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md )
- [Commits](https://github.com/google/dagger/compare/dagger-2.39.1...dagger-2.40 )
Updates `dagger-android-support` from 2.39.1 to 2.40
- [Release notes](https://github.com/google/dagger/releases )
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md )
- [Commits](https://github.com/google/dagger/compare/dagger-2.39.1...dagger-2.40 )
Updates `dagger-compiler` from 2.39.1 to 2.40
- [Release notes](https://github.com/google/dagger/releases )
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md )
- [Commits](https://github.com/google/dagger/compare/dagger-2.39.1...dagger-2.40 )
Updates `dagger-android-processor` from 2.39.1 to 2.40
- [Release notes](https://github.com/google/dagger/releases )
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md )
- [Commits](https://github.com/google/dagger/compare/dagger-2.39.1...dagger-2.40 )
---
updated-dependencies:
- dependency-name: com.google.dagger:dagger
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.dagger:dagger-android
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.dagger:dagger-android-support
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.dagger:dagger-compiler
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.dagger:dagger-android-processor
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-11-05 11:51:28 +00:00
dependabot[bot]
0dc54823b9
Bump annotation from 1.2.0 to 1.3.0
...
Bumps annotation from 1.2.0 to 1.3.0.
---
updated-dependencies:
- dependency-name: androidx.annotation:annotation
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-11-05 11:50:31 +00:00
Álvaro Brey
78945f82d2
Merge pull request #9206 from nextcloud/dependabot/gradle/com.google.android.exoplayer-exoplayer-2.16.0
...
Bump exoplayer from 2.15.1 to 2.16.0
2021-11-05 12:49:06 +01:00
dependabot[bot]
3058ff7301
Bump exoplayer from 2.15.1 to 2.16.0
...
Bumps [exoplayer](https://github.com/google/ExoPlayer ) from 2.15.1 to 2.16.0.
- [Release notes](https://github.com/google/ExoPlayer/releases )
- [Changelog](https://github.com/google/ExoPlayer/blob/release-v2/RELEASENOTES.md )
- [Commits](https://github.com/google/ExoPlayer/compare/r2.15.1...r2.16.0 )
---
updated-dependencies:
- dependency-name: com.google.android.exoplayer:exoplayer
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-11-05 02:06:15 +00:00
Álvaro Brey
518343c4e4
Merge pull request #9195 from nextcloud/whats-new-sdk-30
...
Add What's New view to warn users of changes in storage after sdk 30
2021-11-04 14:35:29 +01:00
Álvaro Brey
35a2324482
Merge pull request #9175 from nextcloud/fix/url-parse-search-result
...
Unified search: skip local file check for non-file results
2021-11-04 14:27:25 +01:00
Álvaro Brey
a994ebc3f4
Merge pull request #9044 from nextcloud/target-sdk-30
...
Target SDK 30
2021-11-04 13:46:16 +01:00
Álvaro Brey
30be31f525
Merge pull request #9166 from nextcloud/namespacedAction
...
Use package specific action
2021-11-04 13:39:46 +01:00
Álvaro Brey Vilas
aa417537df
Disable leakCanary for CI builds
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-04 13:10:56 +01:00
Álvaro Brey Vilas
cb6d9a6c07
What's new: add second page of info for sdk30 storage update
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-04 13:03:14 +01:00
Álvaro Brey Vilas
40860d98be
AppInfo: add getVersionName, remove getFormattedVersionCode
...
Only used for WhatsNewActivity, and showing the human-readable string makes more sense.
Also convert the appinfo package to kotlin, since we're at it
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-04 12:44:28 +01:00
Tobias Kaminsky
5ac0b76bc1
Merge pull request #9190 from nextcloud/stale-bot-exempt-label
...
stale action: Add exempt label to mark issues that shouldn't be stale automatically
2021-11-04 11:52:08 +01:00
Tobias Kaminsky
d657b865f7
Merge pull request #9191 from nextcloud/docs/signoff-contributing
...
CONTRIBUTING: add indication that commits should be signed off.
2021-11-04 11:50:04 +01:00
tobiasKaminsky
c15f64308b
Use package specific action
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-04 08:21:12 +00:00
Álvaro Brey Vilas
be43a629fd
Add What's New view to warn users of changes in storage after sdk 30
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-03 16:49:20 +01:00
Álvaro Brey Vilas
6d4b3b8444
Fix ktlint
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-03 10:30:10 +01:00
Álvaro Brey Vilas
5e00733912
Add missing copyright header to PermissionUtil
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-03 09:16:22 +01:00
Nextcloud bot
6822cfda6a
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-03 03:50:54 +00:00
Álvaro Brey Vilas
f18f72abcd
DownloadFileOperation: use moveFile instead of File.renameTo
...
File.renameTo fails if both files aren't under the same mountpoint.
As the tmp file is in internal storage now, it has to be move differently if the target dir is in external storage.
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 16:31:46 +01:00
Álvaro Brey Vilas
1811d040f7
Use internalTemporalPath instead of temporalPath
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 12:59:06 +01:00
Álvaro Brey
578da09f05
Merge pull request #9179 from sryze/contact-settings-back-fix
...
Prevent duplicate Settings activity on back stack
2021-11-02 09:40:28 +01:00
tobiasKaminsky
4d99f62759
Use LeakCanary in debug mode
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-02 08:37:03 +00:00
Álvaro Brey
432f51b4ec
Merge pull request #9181 from nextcloud/dependabot/gradle/byteBuddyVersion-1.11.22
...
Bump byteBuddyVersion from 1.11.21 to 1.11.22
2021-11-02 09:23:06 +01:00
Álvaro Brey
07bc3f4f50
Merge pull request #9180 from nextcloud/dependabot/gradle/com.google.code.gson-gson-2.8.9
...
Bump gson from 2.8.8 to 2.8.9
2021-11-02 09:17:27 +01:00
Álvaro Brey Vilas
78aa89e1be
CONTRIBUTING: add indication that commits should be signed off.
...
Also add ToC entry for git hooks, which was missing
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 09:07:31 +01:00
Sergey Zolotarev
f08ad758cd
Prevent duplicate Settings activity on back stack
...
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
2021-11-02 14:05:59 +06:00
Álvaro Brey Vilas
f2c81a9715
stale action: Add exempt label to mark issues that shouldn't be stale automatically
...
We've got some issues that are open since a long time ago but aren't resolved, and there isn't some clear short term resolution to them.
As such these isues are kept open because they still affect users, but the users have to be "fighting" the stale bot, which
understandably generates confusion and frustration.
This PR adds a specific label we can add to those issues so that the stale action will ignore them.
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:36:05 +01:00
Álvaro Brey Vilas
063ef4f8df
Fix PermissionUtil after rebase
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:44 +01:00
Álvaro Brey Vilas
0ad8c4350d
Fix storage permissions in debug manifest too
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:43 +01:00
Álvaro Brey Vilas
886c2574fb
MediaProvider: remove useless parens
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:43 +01:00
