mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-11-28 18:28:59 +03:00
Code Issues Projects Releases Packages Wiki Activity
15764 commits 228 branches 1574 tags 622 MiB
Commit graph

15764 commits

This branch
This branch
All branches
Author SHA1 Message Date
tobiasKaminsky
86d1a2820f
fix spotbugs 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2020-09-02 09:31:32 +02:00
Tobias Kaminsky
75066c8673
Merge pull request #6798 from nextcloud/ezaquarii/fix-illegal-state-exception-when-stopping-audio-player 
Start audio player using foreground service API on Android 26+
 2020-09-02 09:04:28 +02:00
Nextcloud bot
0efd71d62c
[tx-robot] updated from transifex 2020-09-02 05:32:13 +00:00
Jens Mueller
031e506ec0 fix inplace scrollview in sharing fragment 
Signed-off-by: Jens Mueller <tschenser@gmx.de>
 2020-09-01 17:17:53 +02:00
dependabot-preview[bot]
4dcb298505
Merge pull request #6836 from nextcloud/dependabot/gradle/androidx.test.ext-junit-1.1.2 2020-09-01 11:55:20 +00:00
Tobias Kaminsky
7123359223
Merge pull request #6812 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.12.0 
Bump detekt-gradle-plugin from 1.11.2 to 1.12.0
 2020-09-01 13:13:46 +02:00
tobiasKaminsky
4e0c111395
removed unneeded layout 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2020-09-01 13:11:15 +02:00
dependabot-preview[bot]
1a5f0a8eaa
Bump junit from 1.1.1 to 1.1.2 
Bumps junit from 1.1.1 to 1.1.2.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-09-01 11:07:41 +00:00
Tobias Kaminsky
a8359787bf
Merge pull request #6838 from nextcloud/dependabot/gradle/androidx.test-runner-1.3.0 
Bump runner from 1.2.0 to 1.3.0
 2020-09-01 13:06:29 +02:00
tobiasKaminsky
e6a516f10a
Fix not waiting for non-metered wifi 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2020-09-01 12:35:20 +02:00
tobiasKaminsky
a3cb17a829
add TestActivity to launch fragments in it 
fix wrong class cast exception message

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2020-08-31 17:05:57 +02:00
Tobias Kaminsky
3f0e68fe30
Merge pull request #6859 from nextcloud/fixMaxScale 
Do not use scale larger than max scale
 2020-08-31 13:22:17 +02:00
tobiasKaminsky
fc2e84a5b0
do not use scale larger than max scale 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2020-08-31 11:07:11 +02:00
tobiasKaminsky
ebf7097042
Fix crashing app when adding same account for second time when using qrCode 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2020-08-31 10:52:33 +02:00
dependabot-preview[bot]
ca5ee406ec
Bump detekt-gradle-plugin from 1.11.2 to 1.12.0 
Bumps [detekt-gradle-plugin](https://github.com/detekt/detekt) from 1.11.2 to 1.12.0.
- [Release notes](https://github.com/detekt/detekt/releases)
- [Commits](https://github.com/detekt/detekt/compare/v1.11.2...v1.12.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-08-31 07:03:29 +00:00
dependabot-preview[bot]
228116484c
Merge pull request #6837 from nextcloud/dependabot/gradle/com.karumi-shot-4.4.0 2020-08-31 07:02:10 +00:00
Tobias Kaminsky
90a7e00c62
Merge pull request #6762 from nextcloud/enoughSpaceComputation 
compute space: take downloaded folder into account
 2020-08-31 08:25:44 +02:00
Tobias Kaminsky
96877679e5
Merge pull request #6810 from nextcloud/dependabot/gradle/androidx.constraintlayout-constraintlayout-2.0.1 
Bump constraintlayout from 2.0.0 to 2.0.1
 2020-08-31 08:23:50 +02:00
dependabot-preview[bot]
75dfa034fa
Bump shot from 4.3.0 to 4.4.0 
Bumps [shot](https://github.com/karumi/shot) from 4.3.0 to 4.4.0.
- [Release notes](https://github.com/karumi/shot/releases)
- [Changelog](https://github.com/Karumi/Shot/blob/master/release.gradle)
- [Commits](https://github.com/karumi/shot/compare/4.3.0...4.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-08-28 10:43:53 +00:00
tobiasKaminsky
15dcad229c
no sticky broadcast: 
- use local broadcast system instead
- no need to remove sticky broadcasts then

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2020-08-28 12:34:20 +02:00
Tobias Kaminsky
adff9511e9
Merge pull request #6819 from nextcloud/twoChars 
Use two chars for avatars
 2020-08-28 12:27:40 +02:00
dependabot-preview[bot]
0fe5faf68f
Bump runner from 1.2.0 to 1.3.0 
Bumps runner from 1.2.0 to 1.3.0.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-08-28 10:22:33 +00:00
Tobias Kaminsky
ba8bd8f705
Merge pull request #6842 from nextcloud/updateTrashbin 
update trashbin screenshot
 2020-08-28 12:19:01 +02:00
tobiasKaminsky
91721c6ae2
update trashbin screenshot 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2020-08-28 12:12:14 +02:00
nextcloud-android-bot
9583fc87ec Drone: update FindBugs results to reflect reduced error/warning count [skip ci] 
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
 2020-08-27 15:52:23 +00:00
Torsten Grote
27f48b331f
Instrumentation tests for DocumentsProvider 
Note there's still some FIXMEs in the tests that hint at bugs discovered
by the tests.

Also this is very incomplete, but a good beginning for further tests.

Signed-off-by: Torsten Grote <t@grobox.de>
 2020-08-27 11:18:14 -03:00
Torsten Grote
1fdea37c2b
Improve DocumentsProvider implementation 
The initial goal was to make all operations completely synchronous,
so failures can be detected by apps using our DocumentsProvider.

However, `#openDocument()` could not be made fully synchronous,
because we need to wait for the ParcelFileDescriptor we are returning to
close before we can upload a file.
Nextcloud works with locally cached files that only get synchronized to
remote storage.

Things I have tried:

* Use the Handler from the calling I/O Thread:
  not guaranteed to have a prepared Looper,
  so can't always create Handler on that Thread
* Extend ParcelFileDescriptor and override its close() methods:
  For some reason they don't get called when the stream gets closed
* notify the content URI when the upload is complete,
  so callers can wait for the notification:
  works, but is non-standard.
  Other DPs are not doing it,
  so it requires Nextcloud specific code on caller side
  and is still hacky:
  what happens if notification doesn't come? Timeout, but for how long?
* use other ways to get a ParcelFileDescriptor on the file:
  couldn't find anything that would interface with Nextcloud's
  current architecture

Signed-off-by: Torsten Grote <t@grobox.de>
 2020-08-27 11:18:13 -03:00
tobiasKaminsky
6fcc95d117
compute space: take downloaded folder into account 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2020-08-27 15:38:27 +02:00
Tobias Kaminsky
da2352974c
Merge pull request #6774 from nextcloud/noNullOnDataSet 
arbitrary data set: store "" instead of null
 2020-08-27 15:31:40 +02:00
Tobias Kaminsky
c149813e2b
Merge pull request #6805 from nextcloud/ezaquarii/fix-unresponsive-audio-player-controls-with-linear-layout 
Fix unresponsive preview player controls
 2020-08-27 15:31:12 +02:00
Tobias Kaminsky
8a5d58a64e
Merge pull request #6725 from grote/is-child-performance 
Improve performance of DocumentsProvider#isChildDocument()
 2020-08-27 15:29:15 +02:00
Tobias Kaminsky
d50d8a4577
Merge pull request #6816 from nextcloud/dependabot/gradle/androidx.test-core-1.3.0 
Bump core from 1.2.0 to 1.3.0
 2020-08-27 15:12:41 +02:00
Tobias Kaminsky
2a4d466627
Merge pull request #6811 from nextcloud/dependabot/gradle/androidx.test-orchestrator-1.3.0 
Bump orchestrator from 1.2.0 to 1.3.0
 2020-08-27 15:07:58 +02:00
Tobias Kaminsky
41fcb90bf2
Merge pull request #6735 from nextcloud/semver-vs-marketing 
Update CONTRIBUTING.md
 2020-08-27 13:42:00 +02:00
Nextcloud bot
9183e3c9d1
[tx-robot] updated from transifex 2020-08-27 03:31:06 +00:00
tobiasKaminsky
2a0f14231a
Reduce extend of FileActivity, use DrawerActivity instead 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2020-08-26 15:14:21 +02:00
tobiasKaminsky
12f827e063
Use two chars for avatars 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2020-08-26 10:41:27 +02:00
Tobias Kaminsky
8fc2bcdab0
Merge pull request #6807 from merttumer/master 
Fix insert image file picker only opens once
 2020-08-26 09:10:30 +02:00
Nextcloud bot
6b80669000
[tx-robot] updated from transifex 2020-08-26 03:31:16 +00:00
dependabot-preview[bot]
2b7031d198
Bump core from 1.2.0 to 1.3.0 
Bumps core from 1.2.0 to 1.3.0.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-08-26 01:15:52 +00:00
dependabot-preview[bot]
d1a9bb27c9
Bump orchestrator from 1.2.0 to 1.3.0 
Bumps orchestrator from 1.2.0 to 1.3.0.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-08-26 01:14:01 +00:00
dependabot-preview[bot]
2be2b9f393
Bump constraintlayout from 2.0.0 to 2.0.1 
Bumps constraintlayout from 2.0.0 to 2.0.1.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-08-26 01:13:18 +00:00
merttumer
e37635e602
Fix insert image file picker only opens once 
When no image is selected from the intent we should set onReceiveValue to null and uploadMessage to null otherwise it does not open after closing it without selecting an image.
 2020-08-25 22:51:12 +03:00
Chris Narkiewicz
6feedf881f
Start audio player using foreground service API on Android 26+ 
On API 26+ (Oreo, 8.0) running background services is restricted
by power saving mechanisms, causing occasional IllegalStateException
when service intent is rejected by the OS.

Migrate to startForegroundService API to mitigate this problem.
Audio player service is foreground by design.

Fixes #6665

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2020-08-25 18:55:13 +01:00
Chris Narkiewicz
6e6f8303a8
Fix unresponsive preview player controls 
Media controls view were covered by a ScrollView
stealing all touch events. By changing it to FrameLayout,
touch events can reach media controls.

Content embedded inside ScrollView should not
exceed screen boundaries. If so - content must
be changed.

This fixes immediate problem with unresponsive media controls
reported in #6796 and #6782.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2020-08-25 18:24:58 +01:00
Torsten Grote
e8870334d2
Improve performance of DocumentsProvider#isChildDocument() 
The old solution iterates through all parents of the child until it
finds the given parent or the storage root.
This has been show to be very expensive in empirical tests.

Therefore, this commit introduces a more efficient solution that simply
compares the file paths of child and given parent.
It also ensures that parent and child belong to the same account.

Reviewers need to take extra care that this change does not introduce
security issues by claiming a document is a child of a parent when it is
really not.

Signed-off-by: Torsten Grote <t@grobox.de>
 2020-08-25 09:32:48 -03:00
tobiasKaminsky
a79a780129
arbitrary data set: store "" instead of null 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2020-08-25 08:43:32 +02:00
dependabot-preview[bot]
1fec59e719
Merge pull request #6801 from nextcloud/dependabot/gradle/com.pinterest-ktlint-0.38.1 2020-08-25 05:47:40 +00:00
dependabot-preview[bot]
493f77f060
Bump ktlint from 0.38.0 to 0.38.1 
Bumps [ktlint](https://github.com/pinterest/ktlint) from 0.38.0 to 0.38.1.
- [Release notes](https://github.com/pinterest/ktlint/releases)
- [Changelog](https://github.com/pinterest/ktlint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pinterest/ktlint/compare/0.38.0...0.38.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-08-25 01:13:12 +00:00
Tobias Kaminsky
a90cf6a364
Merge pull request #6786 from nextcloud/dependabot/gradle/com.pinterest-ktlint-0.38.0 
Bump ktlint from 0.37.2 to 0.38.0
 2020-08-24 10:09:55 +02:00