10518 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
ardevd	8919321eea	authentication: Make the anonymous inner class a lambda. ... With Java 8, most uses of anonymous inner classes should be replaced by lambdas to highly increase the readability of the source code.	2018-05-15 09:03:38 +02:00
ardevd	e5a1de5e50	authentication: Use single quotes around single character "lastIndexOf" calls. ... An indexOf or lastIndexOf call with a single letter String can be made more performant by switching to a call with a char argument.	2018-05-15 09:02:55 +02:00
ardevd	75d10d6afb	authentication: Use equalsIgnoreCase() instead of convoluted toLowerCase() ... Using toLowerCase() or toUpperCase() to make case insensitive comparisons is inefficient because it requires the creation of temporary, intermediate String objects. In this case, it also made the fi statement complex and difficult to read.	2018-05-15 09:01:56 +02:00
ardevd	21a4d56a44	authentication: Use a string constant instead of duplicating "select_oc_account" three times. ... Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.	2018-05-15 08:58:39 +02:00
ardevd	27999b5b2c	authentication: Added empty private constructor to AccountUtils. ... The private constructor hides the implicit public one	2018-05-15 08:55:59 +02:00
ardevd	e2c0ccda6f	mainapp: Add @Override annotation to onCreate()	2018-05-15 08:50:15 +02:00
ardevd	13a6adfbc1	mainapp: Removed unused import.	2018-05-15 08:48:42 +02:00
ardevd	5ecbd68667	touchimageview: Variable declaration should be separate. ... Declaring multiple variable on one line is difficult to read.	2018-05-15 08:46:32 +02:00
ardevd	3485cbe3fb	touchimageview: Removed empty statement. ... ; has no meaning here.	2018-05-15 08:44:15 +02:00
ardevd	89f985fccb	touchimageview: Removed redundant static qualifier. ... Nested enum types are implicitly static	2018-05-15 08:43:45 +02:00
Nextcloud bot	3b93315193	[tx-robot] updated from transifex	2018-05-15 00:46:24 +00:00
eho	fcd900021f	util: Annotate getFileTypeIcon with Nullable. ... If context is null the drawable passed back will be null as well.	2018-05-14 21:50:48 +02:00
ardevd	00badca7b3	ui:activities Fixed license header formatting.	2018-05-14 15:58:20 +02:00
ardevd	d0a4374646	data:activities Declare context before initializing Account object so that we can re-use the context variable.	2018-05-14 15:57:05 +02:00
ardevd	dd16750742	data:activities: Removed hard coded error message for no results. ... Reference the file_list_empty_headline_server_search string resource instead using the context passed from MainApp.	2018-05-14 15:56:18 +02:00
ardevd	e80cef5be5	ui:activities ActivitiesPresenter formatting cleanup. ... - Fixed indentation and removed redundant newlines.	2018-05-14 15:52:19 +02:00
ardevd	00d94c022b	ui:activities Make ActivitiesPresenter package private.	2018-05-14 15:51:20 +02:00
Andy Scherzinger	4d2dc56e82	Merge pull request #2578 from nextcloud/nullContextAgain ... fix again a null context	2018-05-14 14:29:54 +02:00
tobiasKaminsky	b5bed7874e	fix again a null context ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2018-05-14 14:09:53 +02:00
Nextcloud bot	d094946b2d	[tx-robot] updated from transifex	2018-05-14 00:46:08 +00:00
Nextcloud bot	700d3bf7f3	[tx-robot] updated from transifex	2018-05-12 00:45:52 +00:00
ardevd	e705206ca6	utils: Replace deprecated getResources().getDrawable() with ContextCompat.getDrawable() ... Resources#getDrawable(int) method was deprecated in Marshmallow in favor of the new, Theme-aware replacement.	2018-05-11 12:06:22 +02:00
ardevd	9aa4c254ed	utils: Verify that context is not Null before calling context.getResources().	2018-05-11 12:03:36 +02:00
Nextcloud bot	0a122b26ad	[tx-robot] updated from transifex	2018-05-11 00:44:29 +00:00
Nextcloud bot	baaecbb2bc	[tx-robot] updated from transifex	2018-05-10 00:49:10 +00:00
Tobias Kaminsky	a2c0ae798a	Merge pull request #2549 from nextcloud/contextNull ... Context null -> npe	2018-05-09 16:23:23 +02:00
Andy Scherzinger	14c586df7d	Merge pull request #2566 from nextcloud/localSorting ... Fix local sorting	2018-05-09 16:16:41 +02:00
tobiasKaminsky	c362398591	fix local sorting ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2018-05-09 15:40:48 +02:00
Andy Scherzinger	c2ac4c4ddd	Merge pull request #2564 from nextcloud/bug-identical-sub-expression ... MainApp: Fixed auto upload state check.	2018-05-09 15:10:35 +02:00
ardevd	cf9925249b	MainApp: Fixed instant upload check. ... The if statement should check whether instant photo uploads or instant video uploads are enabled.	2018-05-09 14:34:43 +02:00
Andy Scherzinger	35b7412bcd	Merge pull request #2565 from nextcloud/bug-authentication-urlnormalization ... authentication: Fixed HTTPS prefixed URL normalization.	2018-05-09 14:28:12 +02:00
Tobias Kaminsky	e68b4d7c18	Merge pull request #2563 from nextcloud/extendingReviewerList ... Adding @ardevd to the list of reviewer	2018-05-09 14:18:59 +02:00
ardevd	3da9b5f12e	authentication: Fixed HTTPS prefixed URL normalization. ... I'm assuming here that the if statement is supposed to be checking whether the normalized URL starts with HTTP or HTTPS. The current version seemingly has a typo which this commit fixes.	2018-05-09 13:22:47 +02:00
ardevd	cd0268220e	MainApp: Removed identical sub-expression in if statement. ... This is almost certainly a mistake. Using the same value on either side of a binary operator makes no sense.	2018-05-09 13:12:22 +02:00
Andy Scherzinger	ad064fdc24	Merge pull request #2533 from nextcloud/fileDetail ... Iteration 1 for File detail & new sharing	2018-05-09 12:29:43 +02:00
Andy Scherzinger	705317bb88	Adding @ardevd to the reviewer list	2018-05-09 12:26:44 +02:00
AndyScherzinger	200e5aac07	center tabs	2018-05-09 11:34:04 +02:00
nextcloud-android-bot	1049a8a91b	Drone: update Lint results to reflect reduced error/warning count [skip ci]	2018-05-09 11:34:03 +02:00
AndyScherzinger	1349c2648c	fix lint issues	2018-05-09 11:34:02 +02:00
AndyScherzinger	e047df0f4a	fix theming/tinting for tab indicator	2018-05-09 11:34:02 +02:00
AndyScherzinger	70a9c9584d	add theming/tinting for sharing headers	2018-05-09 11:34:01 +02:00
AndyScherzinger	dc771a8d67	implemented pull-to-refresh for activities	2018-05-09 11:34:01 +02:00
AndyScherzinger	7c21f46b89	fix empty activities icon	2018-05-09 11:34:00 +02:00
AndyScherzinger	c7d8171be1	fix use of asyncDrawable	2018-05-09 11:33:59 +02:00
AndyScherzinger	27a2041db5	codacy cleanup + fixed javaDoc	2018-05-09 11:33:59 +02:00
AndyScherzinger	5934bbfe9a	also use standard character avatars for sharees instead of grey icons (just for iteration 1, soon tobe replaces by the new details&sharing implementation)	2018-05-09 11:33:58 +02:00
AndyScherzinger	adb9ab24ef	cleanup details fragment, use standard character avatars for sharees instead of grey icons (just for iteration 1)	2018-05-09 11:33:58 +02:00
AndyScherzinger	57e061ed8d	uncomment unused method/calls for use whenever we switch to glide	2018-05-09 11:33:57 +02:00
AndyScherzinger	941f621fcc	implement set available offline via menu	2018-05-09 11:33:57 +02:00
AndyScherzinger	60a497a9af	load center cropped preview image, hide type icon	2018-05-09 11:33:56 +02:00