Commit graph

736 commits

Author SHA1 Message Date
tobiasKaminsky
7da1156753 use androidX annotations
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2023-10-19 07:36:38 +02:00
Andy Scherzinger
502844dfc0
bump lint score to reflect master score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2023-08-17 12:17:37 +02:00
Andy Scherzinger
891818711e
bump score from master
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2023-07-28 16:58:14 +02:00
Andy Scherzinger
5a9c5629bf
Bump lint score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2023-07-10 21:40:48 +02:00
tobiasKaminsky
f2aff7a12c
Detect if beta is true
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2023-06-13 09:04:46 +02:00
Andy Scherzinger
ca6390bce2
bump lint score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2023-06-08 15:14:57 +02:00
tobiasKaminsky
2aecc3b92f
Fix screenshot test on jdk17
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2023-06-07 14:55:06 +02:00
github-actions
d5635f7f16 Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: github-actions <github-actions@github.com>
2023-05-14 21:52:02 +02:00
Álvaro Brey
539fe061f3
Update scripts/generate_metadata.py for new metadata location
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2023-02-06 13:03:32 +01:00
Álvaro Brey
38a9590bcc
Move per-flavor fastlane metadata to top-level src/ folder
This is what's currently supported by FDroid, see https://gitlab.com/fdroid/fdroidserver/-/issues/829

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2023-02-06 12:19:50 +01:00
Álvaro Brey
0cb1cb0258
Chore: copy wait_for_server from library
Get rid of duplicated countr

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2023-01-17 09:58:06 +01:00
github-actions
985283e18d Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: github-actions <github-actions@github.com>
2023-01-05 08:32:09 +00:00
Álvaro Brey
5428cf710b
analysis: Also publish summary to GITHUB_STEP_SUMMARY
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-21 12:34:03 +01:00
github-actions
07bc1e8fd0 Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: github-actions <github-actions@github.com>
2022-11-15 10:02:46 +00:00
github-actions
80f65865b1 Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: github-actions <github-actions@github.com>
2022-10-14 19:11:35 +00:00
Andy Scherzinger
a1fb1c08d5
correct lint score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-10-14 11:29:35 +02:00
github-actions
3da226c3e8
Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: github-actions <github-actions@github.com>
2022-10-14 11:29:33 +02:00
github-actions
4102d45a83
Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: github-actions <github-actions@github.com>
2022-10-14 11:28:45 +02:00
Álvaro Brey
b201b3a090
Update pre-commit hook to use spotless for kotlin
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-10-07 17:43:48 +02:00
Álvaro Brey
509236deaa
runCombinedTest: ensure entire logcat is recorded
Start streaming logcat before tests instead of dumping it after. This avoids buffer overflow.

Additionally use xz instead of gzip, for greater compression

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-07-18 12:01:40 +02:00
tobiasKaminsky
2c69d94162 fix uploadReport.sh
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-07-05 12:25:23 +00:00
Álvaro Brey
7fb3c6f2ed
Remove detectNewJavaFiles script
Now built into the workflow

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-06-30 09:44:36 +02:00
Tobias Kaminsky
d62e215cf9
Fix QA upload (#10447)
* secret is called GIT_TOKEN on GitHub

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

* Remove "sudo" from qa build to preserve env variables

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>

Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-06-28 07:43:32 +00:00
Tobias Kaminsky
e11ba7fd9e
Merge pull request #10358 from nextcloud/chore/logcat-for-failing-IT
Upload logcat on failing master-IT builds
2022-06-20 08:49:45 +02:00
tobiasKaminsky
60757a1853
Groupfolders cannot be encrypted
added test showing folder types

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-06-13 16:17:28 +02:00
Álvaro Brey
e9c30584a7
runCombinedTest: remove leftover debug flags
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-06-13 12:00:44 +02:00
Álvaro Brey
22deea9e4f
Upload logcat on failing master-IT builds
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-06-10 16:29:57 +02:00
github-actions
bf0a884e54 Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: github-actions <github-actions@github.com>
2022-06-08 15:35:45 +00:00
nextcloud-android-bot
89c712d39c Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-06-01 07:28:17 +00:00
Álvaro Brey
f54d234626
Merge pull request #10279 from nextcloud/chore/analysis-github-token
workflows/analysis: Use GITHUB_TOKEN instead of GIT_TOKEN, and some cleanup
2022-05-31 10:07:03 +02:00
Álvaro Brey
96ee2ee661
Fix spotbugs not failing builds when count increases
spotbugs-up now needs base branch, not target branch

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-06 09:32:15 +02:00
nextcloud-android-bot
1ea61c6fe6 Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-04-29 15:07:40 +00:00
nextcloud-android-bot
e2c3091fc0 Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey
c20c3e4066
Merge pull request #10014 from nextcloud/spotbugs-improvements
Spotbugs improvements
2022-04-27 11:34:35 +02:00
Álvaro Brey Vilas
7073746309
Use defusedxml for xml parsing instead of etree
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 11:03:59 +02:00
Álvaro Brey Vilas
6eff01d735
Fix some codacy warnings
- Quote some strings in analysis-wrapper
 - Cleanup unneeded checks in spotbugs-up

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 10:53:30 +02:00
Álvaro Brey Vilas
79fc8c61d9
codecov: add flag to integration test coverage so the UI is clearer
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 10:19:23 +02:00
Álvaro Brey Vilas
3879d90eec Ditch findbugs-results.txt: use the stable branch XML as single source of truth
Poor man's baseline

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 08:07:32 +00:00
Álvaro Brey Vilas
21a432dc9e Generate spotbugs summary from xml
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 08:07:32 +00:00
Álvaro Brey Vilas
323fdda409 Drone: optimize assemble while waiting for server/emulator
- Don't assemble Gplay separately from gplayDebug. We already have some GH actions to verify that all flavors assemble.
- Assemble the AndroidTest task, so that there's less work to do when installGplayDebug is called

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 06:13:49 +00:00
Álvaro Brey Vilas
f572176e4c Drone: don't run unit tests
Done in GH actions now

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 06:13:49 +00:00
nextcloud-android-bot
d1a3b415d8 Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-04-19 12:40:36 +00:00
nextcloud-android-bot
997e4c736c Analysis: update Spotbugs results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-04-18 17:22:02 +00:00
nextcloud-android-bot
eddbe5ef28 Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-04-18 17:20:49 +00:00
nextcloud-android-bot
e47f97b07e
Analysis: update Spotbugs results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-04-13 10:20:07 +02:00
tobiasKaminsky
a9473d6158
Fix drone check due to app subfolder
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-13 10:18:21 +02:00
Tobias Kaminsky
31dda2e0fb
Merge pull request #9985 from nextcloud/fastscrollWithLib
Fastscroll for all lists
2022-04-13 08:30:03 +02:00
nextcloud-android-bot
c8cf7bbfe7 Analysis: update Spotbugs results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-04-12 07:23:20 +00:00
tobiasKaminsky
7817a3b8d5
Let us no longer create java files
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-08 10:17:44 +02:00
tobiasKaminsky
c18bf9983e
correct location of different build.gradle files
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-22 07:58:39 +01:00
Álvaro Brey
138d3a03a9
Merge pull request #9972 from nextcloud/fix/search-loading
Fix search loading animation and display
2022-03-17 13:04:10 +01:00
Álvaro Brey
b70eeaae3a
Merge pull request #9977 from nextcloud/chore/ktlint-gradle
Use ktlint plugin instead of manual ktlint tasks
2022-03-16 13:05:23 +01:00
nextcloud-android-bot
a64986e2e3
Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-03-16 11:40:41 +01:00
Álvaro Brey Vilas
3597fb0a53
Use ktlint plugin instead of manual ktlint tasks
- Recommended by ktlint
 - Analyzes sources for all sourcesets without extra config
 - Less gradle code to maintain

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-16 11:30:39 +01:00
tobiasKaminsky
d9b8b3baf8
Add NDK to buildDev
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-16 07:56:39 +01:00
Álvaro Brey Vilas
91c46090e8
Increase findbugs-results.txt
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 14:09:57 +01:00
Álvaro Brey Vilas
a860761144
Increase lint and spotbugs
Lint is expected, spotbugs is false positive

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 13:22:52 +01:00
Álvaro Brey Vilas
d23d20f31b
Fix git hooks for new source location
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:42:11 +01:00
Álvaro Brey Vilas
797316b75a
Fix screenshot screens for new source location
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:38:56 +01:00
Álvaro Brey Vilas
b7c0e94b3d
Fix scripts/buildDev for new source location
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:30:59 +01:00
Álvaro Brey Vilas
4c28ac03ff
Fix scripts/androidScreenshotTest for new source location
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:28:21 +01:00
Álvaro Brey Vilas
0282a98528
Fix generate_metadata.py
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:16:42 +01:00
Álvaro Brey Vilas
b55c452f5f
Fix uploadReport.sh for new structure
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:15:06 +01:00
Álvaro Brey Vilas
516544115c
Fix screenshot tests after subproject change
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:14:46 +01:00
Álvaro Brey Vilas
dd4085cf96
Fix analysis script for new project structure
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:12:47 +01:00
tobiasKaminsky
e32de23933
fix qa
fix lint
fix uploadArtifact.sh

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-11 11:11:43 +01:00
Álvaro Brey Vilas
b4c241cef9
Update analysis.yml
Analysis: don't add "skip ci" to drone commit messages

Messes up Github Actions and doesn't work on Drone anyway

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

analysis: Fix commiter name and email

Not drone anymore

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-09 15:02:44 +01:00
nextcloud-android-bot
3f61f6767f Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-03-09 09:34:24 +00:00
Álvaro Brey
4a621176a4
Merge pull request #9922 from nextcloud/syncedfolders-async
SyncedFoldersActivity: asynchronous loading
2022-03-09 10:01:20 +01:00
Álvaro Brey Vilas
2a8123210a
Analysis scripts: fix push
I am TIRED of fighting with this scripts and Github actions

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-08 13:16:53 +01:00
nextcloud-android-bot
0a97b9b797
Drone: update FindBugs results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-03-04 17:50:11 +01:00
nextcloud-android-bot
0ad73f845d
Drone: update Lint results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-03-04 17:49:54 +01:00
Unpublished
3c002fa0c3
Allow EditorWebView accessing URLs with custom certificate
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>

Drone: update Lint results to reflect reduced error/warning count

Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>

Drone: update FindBugs results to reflect reduced error/warning count

Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-03-01 16:26:37 +01:00
nextcloud-android-bot
a990e6c2c8 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-02-25 13:54:05 +00:00
nextcloud-android-bot
99854accf6 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-02-25 12:49:47 +00:00
nextcloud-android-bot
2854b72f77 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-02-21 16:47:54 +00:00
nextcloud-android-bot
28e8c0d1ad Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-02-21 16:46:46 +00:00
Unpublished
2bd0bf0f14 Update findbugs-results.txt
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>
2022-02-20 13:22:48 +01:00
nextcloud-android-bot
905b21e04a
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
ebf59510fc remove gplay.gradle, use gplayImplementation instead
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-01-27 12:15:37 +00:00
Álvaro Brey Vilas
96c55a6d9f
FileSortOrder*: convert to Kotlin
Need more kotlin in the codebase and these were simple enough

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:49:07 +01:00
nextcloud-android-bot
d51268d7b8
Drone: update FindBugs results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-01-26 14:09:47 +01:00
nextcloud-android-bot
af2059660f Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-01-26 12:08:19 +00:00
Álvaro Brey Vilas
494cceab8e
Analysis: fix checkout and commit generation
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:54:24 +01:00
Álvaro Brey Vilas
5a65c65e76
uploadReport: update shot path
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-25 10:41:06 +01:00
Álvaro Brey Vilas
9fa63c7547
Run analysis workflow in github actions
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-13 09:29:43 +01:00
tobiasKaminsky
719551505e
Fix DialogFragmentIT test
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-01-10 10:12:44 +01:00
Álvaro Brey
9433e2968e Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Álvaro Brey <drone@nextcloud.com>
2021-12-22 08:51:21 +00:00
Álvaro Brey Vilas
3775e13b5c
Increase lint due to dependencies
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 18:50:46 +01:00
Álvaro Brey Vilas
f81779285e Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: Álvaro Brey Vilas <drone@nextcloud.com>
2021-12-10 13:05:22 +00:00
Álvaro Brey Vilas
3b023e9be5
Update analysis results
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-10 13:08:06 +01:00
Álvaro Brey Vilas
d84d82b176 Increase findbugs
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-01 10:47:22 +01:00
Álvaro Brey Vilas
8f6c7fe4d9
Increase findbugs result
Was missing in a previous PR

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-26 11:02:55 +01:00
Álvaro Brey Vilas
815e946adc
Increase spotbugs result due to new spotbugs version
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-25 09:19:13 +01:00
Álvaro Brey Vilas
be54fa0bce
Update spotbugs results
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:56:04 +01:00
Álvaro Brey Vilas
14c1e8d718
build.gradle: Refactor spotbugs setup
- Don't duplicate tasks. Use the ones that spotbugs provides and link them to their sourcesets
 - Add dependencies to compileSources to the spotbugs tasks
 - Update spotbugs plugin

This results in a much higher amount of issues. They were probably not being properly scanned earlier.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-05 16:12:05 +01:00
tobiasKaminsky
3823eccfe6
AccountManagerService needs to be exported
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-27 08:49:05 +02:00
drone
05d98ccc4b Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2021-10-26 06:02:19 +00:00
drone
16b37bcc05
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 16:06:17 +02:00
tobiasKaminsky
042c413569
Calendar backup/import
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 13:02:12 +02:00