mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-12-23 09:10:33 +03:00
Code Issues Projects Releases Packages Wiki Activity
20292 commits 221 branches 1589 tags 640 MiB
Commit graph

645 commits

Author SHA1 Message Date
Dariusz Olszewski
07f61fcfa2 Apply suggestion from code review - FileDataStorageManager 
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Dariusz Olszewski <8277636+starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
1a669e4eb6 Apply suggestions from code review 
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Dariusz Olszewski <8277636+starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
0fb3c92495 Fix compilation of tests (revert marking getFileByEncryptedRemotePath as @Nullable) 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
4df8946b5e spotlessKotlinCheck 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
9cbaa00724 SpotBugs 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
8ec6e3a0af Use Room/DAO for getFolderWithDescendants (used by moveLocalFile) and finally remove createFileInstance(cursor) - no longer needed 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
e76201d59f Use Room/DAO for getGalleryItems and getAllFiles 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
8272facf41 Use Room/DAO for other getFileByX and fileExists 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
5d8bb3e8f5 Simplify getFileById - as suggested in review comment 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Álvaro Brey
dd8a70262e FileEntity: fix parent and contentLength types 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
71180412f9 Use Room/DAO for getFileById 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
32a7120610 Old implementation of getFolderContent ordered results by file name 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
45b9006068 Convert NULL values for integer/long columns to 0 (SpotBugs) 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
1d44674d83 Seems that timestamps need Long rather than Int 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
092a3051df Missing newline (detekt) 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Dariusz Olszewski
cdeff1696b Use Room/DAO for getFolderContent 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-12-13 23:28:15 +01:00
Álvaro Brey
c0788b11b0
Merge pull request #11139 from nextcloud/doNotDeleteEncryptedFolder 
Encrypted folder cannot be deleted, must first unset encryption
 2022-12-13 16:57:42 +01:00
Álvaro Brey
66c617828a
Merge pull request #11124 from nextcloud/fix/upload-worker-infinite-loop 
Fix infinite loop in upload worker
 2022-12-12 13:14:20 +01:00
Álvaro Brey
396b920d4f
Merge pull request #11119 from nextcloud/fix/fullscreen-dialog-insets-android9 
PreviewVideoFullscreenDialog: fix immersive mode logic
 2022-12-12 12:46:27 +01:00
Tobias Kaminsky
b40f7f6e0b
Merge pull request #11122 from nextcloud/fixTemplateId 
Template id must be long, as it is fileID, which can be very big
 2022-12-06 08:15:19 +01:00
tobiasKaminsky
1d62ee7835
Encrypted folder cannot be deleted, must first unset encryption 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-12-05 09:43:40 +01:00
Álvaro Brey
f403b25599 SettingsActivity: Better error message when davdroid login fails 
Server URI is not the only problem that can happen here.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-12-02 12:36:14 +00:00
Álvaro Brey
aa938747ff
Merge pull request #11106 from nextcloud/throttleSetup 
show only one setup dialog, prevents strange situation on double tapping
 2022-12-02 11:31:56 +01:00
Álvaro Brey
84044905d1
UploadsStorageManager: remove in-memory limit for queries 
Only added for FilesUploadWorker workaround that is no longer used

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-12-01 17:00:02 +01:00
Álvaro Brey
f425045a31
FilesUploadWorker: fix infinite loop when uploads failed 
With the previous approach (uploadsStorageManager.gtCurrentAndPendingUploadsForAccount),
an upload that is, for example, waiting for wifi, would always be returned in the call,
thus the list would never be empty.

To avoid this but still process the uploads in pages to avoid OOM, we'll request them page-wise
from the StorageManager, with the pages ordered by ascending ID. This way we will only process each upload once,
but newly added uploads after we start will not be missed.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-12-01 16:52:43 +01:00
Álvaro Brey
a3e21d719b
UploadsStorageManager: extract getUploadsPage from getUploads 
First step for making it accessible from outside

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-12-01 16:17:22 +01:00
tobiasKaminsky
52497bb3e3
Template id must be long, as it is fileID, which can be very big 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-12-01 12:13:50 +01:00
Álvaro Brey
4a14602f0e
PreviewVideoFullscreenDialog: fix insets 
This was breaking the window in Android 9 when going back twice from a fullscreen video.

Testing steps:
1. Open a video
2. Go to fullscreen
3. Close fullscreen
4. Press Back

This caused a white screen in Android 9 before this PR

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-12-01 11:04:24 +01:00
Álvaro Brey
5d4b7a6d04
Merge pull request #11113 from nextcloud/fix-crash-when-disabling-airplane-mode 
Fix crash when disabling airplane mode
 2022-11-30 09:33:56 +01:00
Chris Narkiewicz
45567fb6d4
Fix crash when disabling airplane mode 
Fixes #11096

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2022-11-29 20:17:38 +00:00
Álvaro Brey
f74f59220c
Merge pull request #11089 from nextcloud/fix/video-fullscreen-buffer 
Video preview: use fullscreen dialog for video instead of new activity
 2022-11-29 13:33:10 +01:00
Álvaro Brey
3f990c3f21 PreviewVideoFullscreenDialog: workaround for rotated videos on sdk < 29 
See comments in added code for explanation

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-28 19:22:49 +00:00
Álvaro Brey
bdc0fc71e5 PreviewVideoFullscreenDialog: use listeners to control transfer, and pause the video while transfer is happening 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-28 19:22:49 +00:00
Álvaro Brey
b55d5768de Fix lint and spotbugs 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-28 19:22:49 +00:00
Álvaro Brey
bbb85513e1 Video preview: use fullscreen dialog for video instead of new activity 
This allows transfering the playback directly between Player views, thus avoiding creating
a new ExoPlayer, re-starting the stream, having to pass playing status/current position, etc.

Additionally:
- Always enable buffering animation so it's clear when a video is loading
- Add padding to fullscreen duration numbers so they don't get cut off on rounded screens

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-28 19:22:49 +00:00
Tobias Kaminsky
397ba74274 use getParentFragmentManager 
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
 2022-11-28 14:18:09 +00:00
tobiasKaminsky
831bffe571 show only one setup dialog, prevents strange situation on double tapping 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-11-28 14:18:09 +00:00
Álvaro Brey
e85737f41d Disable StrictMode by default 
StrictMode is not a good fit for the state of our app, since we are way too far from async operations or correct threading.
As a result, we find ourselves disabling the strict mode manually every time we actually want to work on something, as otherwise the
logspam drowns everything else.

With this PR I propose to disable StrictMode unless a prop is set in the Gradle build, which will also control LeakCanary.
Running `./gradlew installGplayDebug -P perfAnalysis` will install the app with both LeakCanary and StrictMode enabled.
This allows us to analyze performance problems on demand, without making our daily work harder.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-28 15:09:04 +01:00
tobiasKaminsky
393e34d28c
restart SettingsActivity after changing e2e settings 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-11-24 15:40:26 +01:00
tobiasKaminsky
3f82d37415
revert to master library 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-11-24 15:40:26 +01:00
tobiasKaminsky
f49252c87e
hide e2e options after removing local e2e setup 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-11-24 15:40:26 +01:00
Álvaro Brey
b110735dcc
NextcloudDatabase: enable automigration for new db version 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-24 15:40:26 +01:00
Álvaro Brey
0d098255d9
Pass through SetupEncryptionDF result to SettingsActivity 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-24 15:40:26 +01:00
Álvaro Brey
6b4d6a6dfd
SettingsActivity: fix conditional to show e2e encrypt option 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-24 15:40:26 +01:00
tobiasKaminsky
e3a7453846
properly handle stage 2: key exists, but e2e is not setup on this device 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-11-24 15:40:26 +01:00
Álvaro Brey
1b945b6131
SetupEncryptionDialogFragment: use builtin onCancel for setting cancel result 
This captures back button as well

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-24 15:40:26 +01:00
Álvaro Brey
09aac00330
SetupEncryptionActivity: finish activity when error happens 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-24 15:40:26 +01:00
Álvaro Brey
6568d1d272
Close SetupEncryptionActivity when dialog is dismissed 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-24 15:40:26 +01:00
tobiasKaminsky
5b4aba11f5
Better show different states of E2E 
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-11-24 15:40:24 +01:00
Álvaro Brey
1c4a1063f1
Merge pull request #10928 from nextcloud/test/calendar-skip-empty 
Fix issues with calendar exporting
 2022-11-23 22:11:31 +01:00
Álvaro Brey
c938a929c1
Merge pull request #11067 from nextcloud/fix/gallery-crash 
GalleryFragment: fix crash when scrolling slowly until the end of the list
 2022-11-23 22:10:20 +01:00
Álvaro Brey
f797260f76
Merge pull request #11068 from nextcloud/fix/favorites-back-navigation 
FileDisplayActivity: fix drawer menu item when browsing back from favorite folder
 2022-11-23 22:08:51 +01:00
Álvaro Brey
eaae4a0f9c
Merge pull request #11069 from nextcloud/fix/video-fullscreen-stuck 
Misc fixes for video player
 2022-11-23 22:07:43 +01:00
Álvaro Brey
09319ac7c3
Merge pull request #11074 from nextcloud/fix/calendar-backup-wrong-account 
CalendarBackupWork: upload to configured account, not current account
 2022-11-23 22:06:54 +01:00
Álvaro Brey
b0a3d6cc7e
Merge pull request #11059 from nextcloud/feature/3175/shortcuts_bottombar 
Allow Pin to Home with file actions bottom sheet
 2022-11-23 18:56:38 +01:00
Álvaro Brey
38e83cd03c Keep screen on while video is playing 
Fixes #9059

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-23 10:31:49 +00:00
Álvaro Brey
625ada4c17 Add default error and completion handler to Exoplayer in preview fragment/activity 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-23 10:31:49 +00:00
Álvaro Brey
250e8129dd
CalendarBackupWork: upload to configured account, not current account 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-23 11:13:03 +01:00
Álvaro Brey
7d8e37a8a0
FileDisplayActivity: also update sort group after browsing up 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-23 10:26:16 +01:00
Álvaro Brey
850e9e7ec3 CalendarBackupWork: log amount of calendars 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-23 08:12:10 +00:00
Álvaro Brey
b3eab117db calendar export: port some changes from upstream 
Ignore deleted events, and fix alarm triggers

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-23 08:12:10 +00:00
Álvaro Brey
008ee4e0cd SaveCalendar: don't try to export empty calendars 
Causes crashes

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-23 08:12:10 +00:00
Álvaro Brey
7bf90d364b
FileDisplayActivity: fix drawer menu item when browsing back from favorite folder 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-22 16:50:42 +01:00
Felix Nüsse
ea2a1a9163 extract string resource 
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
 2022-11-22 16:31:15 +01:00
Álvaro Brey
c1ce254692
GalleryFragment: fix crash when scrolling slowly until the end of the list 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-22 13:52:54 +01:00
Álvaro Brey
8f1369cba2
ShortcutUtil: use system utilities to get pixel size for dimens instead of manually calculating them 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-22 11:00:12 +01:00
Álvaro Brey
52e1e8cef5
ShortcutUtil: use ShortcutManagerCompat to avoid min SDK requirement 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-22 10:53:09 +01:00
Álvaro Brey
280a92be51
Fix style and static analysis issues 
- Rename ShortcutUtils.kt to ShortcutUtil.kt to match contained class
- Remove unused const
- Fix formatting with spotless

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-22 10:14:27 +01:00
Álvaro Brey
8a24ea03a0
Inject ShortcutUtil instead of manually creating it 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-22 10:11:02 +01:00
Felix Nüsse
d555847fea extract and explain constant integer values for icon size 
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
 2022-11-21 16:47:30 +01:00
Felix Nüsse
c19a256a97 Update shortcututils to use existing FolderIcon-function 
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
 2022-11-21 16:47:30 +01:00
Felix Nüsse
758bfe1e17 Implement errorchecking and remove deprecations as suggested by @AlvaroBrey 
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
 2022-11-21 16:47:30 +01:00
Felix Nüsse
f81340f63d Add check for version in FileMenuFilter and ActionChoosen() 
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
 2022-11-21 16:47:30 +01:00
Felix Nüsse
a25069eff3 Remove checks from shortcutUtils and move the same 
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
 2022-11-21 16:47:30 +01:00
Felix Nüsse
3e5ac3068c Update app/src/main/java/com/owncloud/android/files/FileMenuFilter.java 
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
 2022-11-21 16:47:30 +01:00
Felix Nüsse
e6c014d832 Update app/src/main/java/com/nextcloud/ui/fileactions/FileAction.kt 
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
 2022-11-21 16:47:30 +01:00
tobiasKaminsky
64ca4b1858 Check if e2e is available in DocumentsStorageProvider 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-11-21 11:20:38 +01:00
Felix Nüsse
5b2cc6f2c5 Allow Pin to Home with BottomBarDialog 
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
 2022-11-19 14:36:01 +01:00
Álvaro Brey
ec4067c199 ArbitraryDataProvider: distinguish between null value and nonexisting entities 
Not the same thing!

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-18 10:39:41 +01:00
Álvaro Brey
9c218ed18a Fix nullability of types for ArbitraryDataProvider interface 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-18 10:39:41 +01:00
Álvaro Brey
f490823e4e Extract interface from ArbitraryDataProvider for better decoupling and testing 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-18 10:39:41 +01:00
Álvaro Brey
5499441738 Use Room DAO for ArbitraryDataProvider instead of contentResolver 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-18 10:39:41 +01:00
Álvaro Brey
ab13b9873c
Merge pull request #11052 from nextcloud/doNotAllowSharedEncryptedFolder 
prohibit share of an encrypted folder
 2022-11-17 14:47:23 +01:00
Tobias Kaminsky
1b0a2cce72
also check for shared with me 
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
 2022-11-17 13:14:37 +01:00
tobiasKaminsky
66746a6b12
prohibit share of an encrypted folder 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-11-17 12:50:59 +01:00
Álvaro Brey
b78c236a59
chore: Remove unused legacy migration code 
This was leftover in the Room PR, where we removed support for DB version <24. As such, all the code supporting those older versions is unused now.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 10:24:47 +01:00
Álvaro Brey
f8f0d46633
Fix FileMenuFilterIT 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:59 +01:00
Álvaro Brey
7cb85ec6a1
FileActionsBottomSheet: color loading animation with primary color 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:59 +01:00
Álvaro Brey
4523537587
File actions bottom sheet: show file thumbnail 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:59 +01:00
Álvaro Brey
422c0a5011
Small spotbugs cleanup 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:58 +01:00
Álvaro Brey
a160ccd936
Clean up unused resources 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:58 +01:00
Álvaro Brey
b43df7c711
Minor cleanup 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:58 +01:00
Álvaro Brey
6d97bd5145
Remove obsolete TODOs 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:58 +01:00
Álvaro Brey
36f918da7e
Fix icon tinting for fake placeholder menu iteFix icon tinting for fake placeholder menu itemm 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:58 +01:00
Álvaro Brey
0cc2e6875d
FileActionsBottomSheet: parse arguments in ViewModel, handle errors 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:58 +01:00
Álvaro Brey
702a9cedf0
FileActionsBottomSheet: fix things that were parameters, but shouldn't 
- Result listener should be done through the fragmentResultListener API
- ComponentsGetter is attached on onAttach

This avoids crashes on config changes, etc

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:57 +01:00
Álvaro Brey
263d139fe2
FileMenuFilter: simplify and remove unneeded stuff for new approach 
We're always starting from the full list and removing stuff now, so toShow makes no sense

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:57 +01:00
Álvaro Brey
7c53e77e57
FileActionsBottomSheet: additional filtering in FileDetailFragment 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:57 +01:00
Álvaro Brey
dd94167733
FileActionsBottomSheet: show loading animation, load items in background 
Since we're going to load the files in background too, it's a good idea to start doing this already

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:57 +01:00
Álvaro Brey
0e0935bef6
FileActionsBottomSheet: add drag handle for accesibility 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:57 +01:00
Álvaro Brey
5ff16b9ba5
Show lock info in bottom sheet 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:57 +01:00
Álvaro Brey
1aa248d1bf
FileActionsBottomSheet: Display file name or file count as bottom sheet title 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:57 +01:00
Álvaro Brey
e7ff6df581
FileActionsBottomSheet: make scrollable in case full list doesn't fit in screen 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:57 +01:00
Álvaro Brey
a1265bdae7
FileActionsBottomSheet: handle additional filtering for preview fragments 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:57 +01:00
Álvaro Brey
689a4bda6a
Extract responsibilities from FileMenuFilter static methods to utility classes. 
God class count -= 1

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:56 +01:00
Álvaro Brey
e41d474e89
FileActionsBottomSheet: use ViewModel 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:46 +01:00
Álvaro Brey
5b628f520c
Set icons for file actions 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:09 +01:00
Álvaro Brey
f2d0acdba3
Use bottom sheet for file actions 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-17 09:13:02 +01:00
Álvaro Brey
2651dcee0a
Merge pull request #11041 from nextcloud/fix/storage-permission-loop 
Fix storage permission loop when permission denied, and remember permission asked
 2022-11-16 21:01:55 +01:00
Álvaro Brey
b32ea65774 WalledCheckCache: use current epoch instead of millis since boot to avoid problems on reboot 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-16 14:17:56 +01:00
Álvaro Brey
f3a810600d WalledCheckCache: rename field and parameter for clarity 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-16 14:17:56 +01:00
Álvaro Brey
4118cd69c1 Cache walled check for 10 minutes 
Tentative cache time, accepting other proposals. My rationale for 10 minutes was that 6 checks an hour seems like not too much,
while not locking the app for too long in case there's an error and the cache is not cleared on network change.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-16 14:17:56 +01:00
Álvaro Brey
2ad11ad7f5
Merge pull request #11040 from nextcloud/fix/home-icon 
Fix toolbar home icon being arrow in places where it should be hamburger menu
 2022-11-16 12:38:25 +01:00
Álvaro Brey
e0ef3bf0b5
Merge pull request #10953 from nextcloud/chore/bump-uploader 
FileUploader: bump down min sdk for upload worker for 3.23
 2022-11-16 12:37:45 +01:00
Álvaro Brey
9e1d3e0b08
Merge pull request #11039 from nextcloud/fix/newest-files-nav 
FileDisplayActivity: fix restoring selected menu item when resuming
 2022-11-16 12:36:45 +01:00
Álvaro Brey
d71773dbbb
Merge pull request #11046 from nextcloud/fix/remove-favorites-gone 
OCFileListFragment: also reset search type when resetting search event
 2022-11-16 12:35:01 +01:00
Álvaro Brey
2654e88a52
OCFileListFragment: also reset search type when resetting search event 
Fixes an issue where it was persisted after coming back from Favorites, and
the fragment was incorrectly deleting favorite files from the list when unfavoriting.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-16 10:49:16 +01:00
tobiasKaminsky
e7ce821465 Only show "set encrypted" if folder is empty and has no empty files/folder in it 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-11-16 09:34:04 +00:00
Álvaro Brey
38a5283f98 PermissionUtil: remember permission requested when requesting media storage permissions 
For devices under SDK 30, permission was asked on every startup, which is not desired, and is different from the
behaviour above SDK 30. This fixes that.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-16 07:54:36 +00:00
Álvaro Brey
fc5f0ff836 UploadFilesActivity: request permission on onStart instead of onResume 
onResume is always called after permission dialog is closed, so it causes a loop

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-16 07:54:36 +00:00
Álvaro Brey
ea4a8a35a7
Merge pull request #10977 from nextcloud/enter-the-room 
Setup Room database
 2022-11-15 16:24:23 +01:00
Álvaro Brey
2581764c3d
Fix toolbar back icon being arrow in places where it should be hamburger menu 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-15 15:59:27 +01:00
Álvaro Brey
18f4209971
FileDisplayActivity: fix restoring selected menu item when resuming 
Not needed as it will be correctly selected elsewhere, and was causing wrong caching

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-15 15:55:02 +01:00
Álvaro Brey
f049603f35 Delete database migration code under database v24 (app v2.0.0) 
Migration from such old app versions is broken anyway, not only in the database, but also in sharedprefs

Additionally, configure destructive migration for unsupported versions in Room

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-15 10:02:46 +00:00
Álvaro Brey
ec07d26334 Add migrations for capabilities and files tables as well 
They both have unused columns that were not removed in previous migrations, and this makes Room unhappy

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-15 10:02:46 +00:00
Álvaro Brey
cc9b38b972 Clean up creation, injection and migrations for room database 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-15 10:02:46 +00:00
Álvaro Brey
da60c7f6b2 FileContentProvider: secure projectionMap manually in the absence of projectionMap 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-15 10:02:46 +00:00
Álvaro Brey
73ba1e2421 Export Room schemas 
Needed to enable auto-upgrades later

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-15 10:02:46 +00:00
Álvaro Brey
fdab7afbfd Fix column types and implement migrations 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-15 10:02:46 +00:00
Álvaro Brey
d0ab9ff67b Setup base Room configuration 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-15 10:02:46 +00:00
Dariusz Olszewski
8faf600057 Proposed fix for "jumping" file list 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-11-15 09:16:16 +00:00
Álvaro Brey
fe3a6e6790
Give groupfolders priority when choosing icon for folder 
In the server UI, a groupfolder that also has a link shows as a groupfolder.
In the app, it shows as a link. This fixes that.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-08 10:59:31 +01:00
Andy Scherzinger
ae802cd27d
Merge pull request #11001 from nextcloud/fix/sso-dialog-theming 
Use material 3 style for SSO dialog
 2022-11-08 10:25:40 +01:00
Álvaro Brey
92b62ec782
SSO dialog: also color dialog background 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-08 09:15:54 +01:00
Álvaro Brey
6810540a29
Color SSO dialog buttons with primary color instead of default m3 violet color 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-07 15:34:06 +01:00
Álvaro Brey
d0ffbe2479
Use material 3 style for SSO dialog 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-11-07 13:03:31 +01:00
Abdusalam Yabrak
aa92109ab1 Fixed folder content visibility 
Signed-off-by: Abdusalam Yabrak <abdusalam.yabrak@axiell.com>
 2022-11-04 19:22:21 +01:00
Álvaro Brey
9569dcfd97
Merge pull request #10966 from nextcloud/cancelMnemonic 
Show cancel button when entering mnemonic
 2022-11-03 16:43:13 +01:00
Álvaro Brey
ea1c43bd44
Merge pull request #10961 from nextcloud/encryptNotOnMainThread 
use existing method via eventbus to encrypt folder
 2022-11-02 17:23:46 +01:00
tobiasKaminsky
1d6df6ad83 Show cancel button when entering mnemonic 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-11-02 17:03:40 +01:00
tobiasKaminsky
6f826bbd8d
Show warning when trying to access an encrypted folder, when not yet setup 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-11-01 10:41:08 +01:00
Álvaro Brey
96b12d6165
Fix keyboard opening on dialogs causing squished dialogs in Material3 
Use the proper InputMethodManager service to allow dialogs to correctly detect keyboard opening, and adjust margins properly

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-10-31 15:55:35 +01:00
tobiasKaminsky
32fab01c91
use existing method via eventbus to encrypt folder 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-10-31 15:22:50 +01:00
Álvaro Brey
26a43ed2ca
FileUploader: bump down min sdk for upload worker for 3.23 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-10-28 15:08:59 +02:00
Álvaro Brey
40f5f58b18 UploadListActivity: throttle list updates to 1 every second to avoid frying the database when files are being rapidly uploaded 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-10-28 10:37:42 +02:00
Álvaro Brey
ebeff0c496 UploadFileOperation: ensure channel is closed 
Triggers strict mode warnings

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-10-28 10:37:42 +02:00
Álvaro Brey
e4a922b913 FilesUploadWorker: process uploads in batches of 100 to prevent reading a large amount of rows in every loop 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-10-28 10:37:42 +02:00
Álvaro Brey
079eb6e5c1 FilesSyncWork: dont do a database call for every single upload 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-10-28 10:37:42 +02:00
Álvaro Brey
f83c3aebdc UploadFileOperation: don't read entire list of uploads every time we want to update the size of just one 
Wtf

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-10-28 10:37:42 +02:00
Álvaro Brey
044a321678 FilesUploadHelper: insert all uploads in single transaction to avoid too many listener calls 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-10-28 10:37:42 +02:00