Commit graph

19608 commits

Author SHA1 Message Date
Álvaro Brey
619563b34a
Merge pull request #11061 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.22.0
Bump detekt-gradle-plugin from 1.21.0 to 1.22.0
2022-11-21 17:26:27 +01:00
Álvaro Brey
5fe237033f
Merge pull request #10968 from nextcloud/e2eDocumentNotSetup
Check if e2e is available in DocumentsStorageProvider
2022-11-21 17:20:21 +01:00
Felix Nüsse
d555847fea extract and explain constant integer values for icon size
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
c19a256a97 Update shortcututils to use existing FolderIcon-function
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
758bfe1e17 Implement errorchecking and remove deprecations as suggested by @AlvaroBrey
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
f81340f63d Add check for version in FileMenuFilter and ActionChoosen()
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
a25069eff3 Remove checks from shortcutUtils and move the same
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
e4d51be54c Update app/src/main/res/values/strings.xml
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
3e5ac3068c Update app/src/main/java/com/owncloud/android/files/FileMenuFilter.java
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
e6c014d832 Update app/src/main/java/com/nextcloud/ui/fileactions/FileAction.kt
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
tobiasKaminsky
64ca4b1858 Check if e2e is available in DocumentsStorageProvider
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-21 11:20:38 +01:00
Nextcloud bot
ee78494df5
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-21 03:27:43 +00:00
Nextcloud bot
f1be37c61a
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-21 03:27:27 +00:00
dependabot[bot]
df3cd0c685
Bump detekt-gradle-plugin from 1.21.0 to 1.22.0
Bumps [detekt-gradle-plugin](https://github.com/detekt/detekt) from 1.21.0 to 1.22.0.
- [Release notes](https://github.com/detekt/detekt/releases)
- [Commits](https://github.com/detekt/detekt/commits)

---
updated-dependencies:
- dependency-name: io.gitlab.arturbosch.detekt:detekt-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-11-21 02:11:42 +00:00
Nextcloud bot
f661483e1d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-20 03:29:17 +00:00
Nextcloud bot
5cc64748f1
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-20 03:28:59 +00:00
Felix Nüsse
5b2cc6f2c5 Allow Pin to Home with BottomBarDialog
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-19 14:36:01 +01:00
Álvaro Brey
05b53f2add
Merge pull request #11050 from nextcloud/arbitrary-dao
Use Room DAO instead of ContentProvider for arbitrary data table access
2022-11-19 13:11:41 +01:00
Nextcloud bot
302ce683a7
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-19 03:34:53 +00:00
Nextcloud bot
3871917926
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-19 03:34:35 +00:00
Álvaro Brey
ec4067c199 ArbitraryDataProvider: distinguish between null value and nonexisting entities
Not the same thing!

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-18 10:39:41 +01:00
Álvaro Brey
9c218ed18a Fix nullability of types for ArbitraryDataProvider interface
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-18 10:39:41 +01:00
Álvaro Brey
f490823e4e Extract interface from ArbitraryDataProvider for better decoupling and testing
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-18 10:39:41 +01:00
Álvaro Brey
5499441738 Use Room DAO for ArbitraryDataProvider instead of contentResolver
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-18 10:39:41 +01:00
Nextcloud bot
13071ed5ae
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-18 03:27:40 +00:00
Nextcloud bot
a7a9da4bc2
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-18 03:27:19 +00:00
Álvaro Brey
aa355e7efd
Merge pull request #11054 from nextcloud/bump-master-3.24
Bump app version on master to 3.24
2022-11-17 14:49:52 +01:00
Álvaro Brey
ab13b9873c
Merge pull request #11052 from nextcloud/doNotAllowSharedEncryptedFolder
prohibit share of an encrypted folder
2022-11-17 14:47:23 +01:00
Álvaro Brey
b31e3c1061
Bump app version on master to 3.24
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 13:48:43 +01:00
Tobias Kaminsky
1b0a2cce72
also check for shared with me
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
2022-11-17 13:14:37 +01:00
tobiasKaminsky
66746a6b12
prohibit share of an encrypted folder
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-17 12:50:59 +01:00
Álvaro Brey
05200914d9
Merge pull request #11051 from nextcloud/chore/remove-unused-migration-code
chore: Remove unused legacy migration code
2022-11-17 12:26:16 +01:00
Álvaro Brey
b78c236a59
chore: Remove unused legacy migration code
This was leftover in the Room PR, where we removed support for DB version <24. As such, all the code supporting those older versions is unused now.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 10:24:47 +01:00
Álvaro Brey
75774ed2ce
Merge pull request #11008 from nextcloud/feature/file-actions-bottom-sheet
Redesign file actions menu as a BottomSheet
2022-11-17 09:50:13 +01:00
Álvaro Brey
c71ce3a3ee
Add screenshot test for FileActionsBottomSheet
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
a0ac194467
Fix lint
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
f8f0d46633
Fix FileMenuFilterIT
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
7cb85ec6a1
FileActionsBottomSheet: color loading animation with primary color
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
4523537587
File actions bottom sheet: show file thumbnail
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
829c10f9de
Fix FileMenuFilterIT for real
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
6b470f86bb
Fix mock order for FileMenuFilter
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
422c0a5011
Small spotbugs cleanup
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
a160ccd936
Clean up unused resources
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
b43df7c711
Minor cleanup
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
27e40440db
Fix bottom sheet background for PreviewImageFragment
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
6d97bd5145
Remove obsolete TODOs
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
36f918da7e
Fix icon tinting for fake placeholder menu iteFix icon tinting for fake placeholder menu itemm
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
0cc2e6875d
FileActionsBottomSheet: parse arguments in ViewModel, handle errors
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
702a9cedf0
FileActionsBottomSheet: fix things that were parameters, but shouldn't
- Result listener should be done through the fragmentResultListener API
- ComponentsGetter is attached on onAttach

This avoids crashes on config changes, etc

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
263d139fe2
FileMenuFilter: simplify and remove unneeded stuff for new approach
We're always starting from the full list and removing stuff now, so toShow makes no sense

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00