Commit graph

250 commits

Author SHA1 Message Date
Álvaro Brey
37a9c438cd
PreviewImageFragment: prevent crash when redrawing menu after file deletion
For some reason this is called again after deleting the file (probably a fragment-ktx update or something).
However at this point getFileById will return null and crash the rest of the method.

This adds some checks to prevent that.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-09-02 16:25:15 +02:00
Álvaro Brey
c962476d90
Merge pull request #10703 from nextcloud/addAccount
Restart account creation with AuthenticatorActivity, which helps to add account in restricted profiles, e.g. MDM or Samsung second users
2022-09-02 12:21:21 +02:00
tobiasKaminsky
a6dcf263aa
Restart account creation with AuthenticatorActivity, which helps to add account in restricted profiles, e.g. MDM or Samsung second users
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-09-02 11:10:45 +02:00
Dariusz Olszewski
e2a6957ac1 Avoid full folder refresh during onBrowseUp
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
2022-08-28 17:22:48 +02:00
Álvaro Brey
d6fb21c0bd
Merge pull request #10657 from nextcloud/revert-10148-proseMirror
Revert "Test proseMirror with custom user agent"
2022-08-25 17:07:58 +02:00
Álvaro Brey
61c2dbb3d6
Merge pull request #10584 from nextcloud/fix/syncedfolderutils-inconsistent-comparator
SyncedFolderUtils: solve inconsistent comparator crashes
2022-08-23 09:42:35 +02:00
Álvaro Brey
ce7ef477bb
SyncedFolderUtils: fix logic when numberOfFiles != actual file number
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-22 17:56:14 +02:00
Álvaro Brey
00644d9384 SyncedFolderUtils: solve inconsistent comparator
Calling lastModified() inside the comparator can produce inconsistent results if last modification date changes while sorting

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-22 16:07:48 +02:00
Álvaro Brey
7e3e760887 SyncedFolderUtils: convert to kotlin step 2 and deduplicate
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-22 16:07:48 +02:00
Álvaro Brey
3d7afa1b58 SyncedFolderUtils: convert to Kotlin step 1
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-22 16:07:48 +02:00
Álvaro Brey
abe583d7de Bump OUTDATED_SERVER_VERSION to Nextcloud 22
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-22 12:38:20 +00:00
Álvaro Brey
3836eeb088
Revert "Test proseMirror with custom user agent" 2022-08-22 11:41:08 +02:00
Álvaro Brey
9ab052d379 SaveCalendar: reuse property factory
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-19 15:38:50 +02:00
tobiasKaminsky
1a6ec16af8 Use 3.0.0
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-08-19 15:38:50 +02:00
Álvaro Brey
68c7eddf46
Use ArbitraryDataProvider to store backup preferences
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-19 13:00:14 +02:00
Álvaro Brey
7a1e8189da Actually persist backup preferences
Currently, the backup is always enabled if the permissions are granted, so the checkboxes make no sense.

This fixes that by actually persisting the checkbox status as a preference, and honoring that for schedulling/cancelling the backup jobs.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-18 16:26:20 +02:00
Álvaro Brey
2d3982060c
BackupFragment: request write_calendar permission for backup
Needed to ensure events have UIDs for ICS export

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-17 17:02:46 +02:00
Álvaro Brey
8c62cb1c0c FileMenuFilter: reorder conditionals for performance (Spotbugs)
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-08 13:57:57 +02:00
tobiasKaminsky
7c9941ac0c Only allow "unset encryption" when folder is empty
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-08-08 13:57:57 +02:00
Álvaro Brey
c99b5c1254
Merge pull request #10537 from nextcloud/followUpSameName
Check empty/same name on creating text files
2022-08-05 12:47:22 +02:00
tobiasKaminsky
db490b245f also check if folder
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
2022-08-04 15:58:25 +02:00
Álvaro Brey
64ddaf4405
ReceiveExternalFilesActivity: fix type of empty list container
It's now a NestedScrollView

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-04 15:57:07 +02:00
Álvaro Brey
8f8274cab2
Cleanup UriUploader a bit, and add tests for private paths
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-04 15:56:11 +02:00
Álvaro Brey
cd3bd0845a
Don't accept uris to upload from external apps if they contain this app's package name
Prevent leaks of files in this app's storage

Co-authored-by: Tobias Kaminsky <tobias@kaminsky.me>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-04 15:56:11 +02:00
Álvaro Brey
61f891201b
UriUploader: convert to Kotlin step 2
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-04 15:56:11 +02:00
Álvaro Brey
bbfb58f644
UriUploader: convert to Kotlin step 1
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-08-04 15:56:06 +02:00
Álvaro Brey
cad6992121
Merge pull request #10579 from nextcloud/exportAlsoFromVideoImage
Also handle export from video/image correctly
2022-08-04 11:28:37 +02:00
Álvaro Brey
ac948df165
Merge pull request #10430 from Tiam-Abderezai/bugfix/10405/check_context_in_PreviewImageFragment
Fix #10405 Context check for ImagePreviewFragment
2022-08-03 16:30:45 +02:00
tobiasKaminsky
135459cf6a Also handle export from video/image correctly
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-08-03 13:10:58 +00:00
Tiam
e38e70f3f1 Fix #10405
Show only error snackbar if context is available
Signed-off-by: Tiam Abderezai <tiam.abderezai@gmail.com>

Signed-off-by: Tiam <tiam.abderezai@gmail.com>
2022-07-31 05:51:56 -04:00
tobiasKaminsky
f70e830deb
Fix not entering folder upon creation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-07-26 09:02:31 +02:00
Tobias Kaminsky
a36699d7df
Merge pull request #10556 from nextcloud/fixReceiveFile
Fix receive file
2022-07-25 12:01:46 +02:00
tobiasKaminsky
0af94d2b62
Fix npe by migrating to binding
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-07-25 07:59:01 +02:00
tobiasKaminsky
6e02f6e2b8 Log to Log_OC
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-07-22 06:03:16 +00:00
Álvaro Brey
5ba739d8df
Don't allow focus on empty view and restore mis-updated screenshot
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-07-13 16:53:34 +02:00
Álvaro Brey
a920ba3c27
Merge pull request #10497 from nextcloud/fix/empty-view-scrolling
Allow scrolling empty views
2022-07-13 15:54:35 +02:00
Álvaro Brey
73cc4aa4f3
Make empty list views scrollable
This will prevent them from being cut when vertical space is not enough, for example in landscape mode

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-07-13 11:11:07 +02:00
tobiasKaminsky
82fcf2e3a0
Fix missing update of storage path, so that files/folders were only locally changed, but update not reflected in UI
add IT test

update search lists after renaming

extract string to variable

Remove local/storageManager files after each test run

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-07-11 15:19:56 +02:00
tobiasKaminsky
3cae976597
Allow to delete encrypted folders
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-07-11 09:27:11 +02:00
Tobias Kaminsky
d31f3f7988
Merge pull request #10483 from nextcloud/fix/share-link-email-crash
FileDetailsSharingProcessFragment: avoid crashing when modifying existing shares
2022-07-11 07:54:19 +02:00
Álvaro Brey
9445a6c3e3
OCFileListFragment: remove all the "resetHeaderScrollngState" calls
Now handled with a listener in FileDisplayActivity

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-07-08 16:41:17 +02:00
Tobias Kaminsky
f6a99ef9ca
Merge pull request #10357 from nextcloud/warnOnExistingFile
When during renaming the same name already exists in same folder: show an error, disable confirm button
2022-07-08 08:38:31 +02:00
Tobias Kaminsky
546f69cfe4
Merge pull request #10490 from nextcloud/endlessRefresh
add broadcastReceiver when switching from media -> on device
2022-07-08 08:34:26 +02:00
Tobias Kaminsky
97e220a83f
Merge pull request #10481 from nextcloud/fix/share-link-crash
FileActivity: fix crash when creating share link from FileDetailsFragment
2022-07-07 14:34:09 +02:00
Tobias Kaminsky
f253876d57
Merge pull request #10487 from nextcloud/fix/folder-picker-activity-menu
FolderPickerActivity: call super.onCreateOptionsMenu inside overriding method
2022-07-07 14:32:49 +02:00
Tobias Kaminsky
4fc60c2ae1
Merge pull request #10489 from nextcloud/fix/crash-status-dialog-darkmode
SetStatusDialogFragment: fix nullability of itemSelected parameter
2022-07-07 14:32:10 +02:00
tobiasKaminsky
c3fd318437
add broadcastReceiver when switching from media -> on device
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-07-07 14:20:41 +02:00
Tobias Kaminsky
5baa1c8f45
Merge pull request #10484 from nextcloud/media-view-options
Media view filter options
2022-07-07 12:14:15 +02:00
Álvaro Brey
1b968c2695
SetStatusDialogFragment: fix nullability of itemSelected parameter
Prevents crash when fragment is recreated (like when switching dark mode)

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-07-07 11:46:25 +02:00
tobiasKaminsky
389e33d524
correct formatting
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-07-07 10:17:54 +02:00