Commit graph

19718 commits

Author SHA1 Message Date
Álvaro Brey
0cc2e6875d
FileActionsBottomSheet: parse arguments in ViewModel, handle errors
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
702a9cedf0
FileActionsBottomSheet: fix things that were parameters, but shouldn't
- Result listener should be done through the fragmentResultListener API
- ComponentsGetter is attached on onAttach

This avoids crashes on config changes, etc

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
263d139fe2
FileMenuFilter: simplify and remove unneeded stuff for new approach
We're always starting from the full list and removing stuff now, so toShow makes no sense

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
7c53e77e57
FileActionsBottomSheet: additional filtering in FileDetailFragment
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
dd94167733
FileActionsBottomSheet: show loading animation, load items in background
Since we're going to load the files in background too, it's a good idea to start doing this already

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
0e0935bef6
FileActionsBottomSheet: add drag handle for accesibility
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
5ff16b9ba5
Show lock info in bottom sheet
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
1aa248d1bf
FileActionsBottomSheet: Display file name or file count as bottom sheet title
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
e7ff6df581
FileActionsBottomSheet: make scrollable in case full list doesn't fit in screen
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
a1265bdae7
FileActionsBottomSheet: handle additional filtering for preview fragments
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
689a4bda6a
Extract responsibilities from FileMenuFilter static methods to utility classes.
God class count -= 1

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:56 +01:00
Álvaro Brey
e41d474e89
FileActionsBottomSheet: use ViewModel
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:46 +01:00
Álvaro Brey
5b628f520c
Set icons for file actions
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:09 +01:00
Álvaro Brey
f2d0acdba3
Use bottom sheet for file actions
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:02 +01:00
Nextcloud bot
1cd0bbf75e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-17 03:29:03 +00:00
Nextcloud bot
937aa10fc8
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-17 03:28:49 +00:00
Tobias Kaminsky
aacd4865ad daily dev 20221117
Update Nextcloud Android library
2022-11-17 02:39:51 +01:00
Tobias Kaminsky
5c10198f68 Merge remote-tracking branch 'origin/master' into dev 2022-11-17 02:32:35 +01:00
Álvaro Brey
2651dcee0a
Merge pull request #11041 from nextcloud/fix/storage-permission-loop
Fix storage permission loop when permission denied, and remember permission asked
2022-11-16 21:01:55 +01:00
Álvaro Brey
08e2006737
Merge pull request #10996 from nextcloud/cache-walled-check
Cache walled check for 10 minutes
2022-11-16 21:00:58 +01:00
Álvaro Brey
b32ea65774 WalledCheckCache: use current epoch instead of millis since boot to avoid problems on reboot
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-16 14:17:56 +01:00
Álvaro Brey
f3a810600d WalledCheckCache: rename field and parameter for clarity
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-16 14:17:56 +01:00
Álvaro Brey
4118cd69c1 Cache walled check for 10 minutes
Tentative cache time, accepting other proposals. My rationale for 10 minutes was that 6 checks an hour seems like not too much,
while not locking the app for too long in case there's an error and the cache is not cleared on network change.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-16 14:17:56 +01:00
Álvaro Brey
2ad11ad7f5
Merge pull request #11040 from nextcloud/fix/home-icon
Fix toolbar home icon being arrow in places where it should be hamburger menu
2022-11-16 12:38:25 +01:00
Álvaro Brey
e0ef3bf0b5
Merge pull request #10953 from nextcloud/chore/bump-uploader
FileUploader: bump down min sdk for upload worker for 3.23
2022-11-16 12:37:45 +01:00
Álvaro Brey
9e1d3e0b08
Merge pull request #11039 from nextcloud/fix/newest-files-nav
FileDisplayActivity: fix restoring selected menu item when resuming
2022-11-16 12:36:45 +01:00
Álvaro Brey
d71773dbbb
Merge pull request #11046 from nextcloud/fix/remove-favorites-gone
OCFileListFragment: also reset search type when resetting search event
2022-11-16 12:35:01 +01:00
Álvaro Brey
13bcd6bfdd
Merge pull request #11037 from nextcloud/e2eEncryptedOption
Only show "set encrypted" if folder is empty and has no empty files/folder in it
2022-11-16 12:34:34 +01:00
Álvaro Brey
2654e88a52
OCFileListFragment: also reset search type when resetting search event
Fixes an issue where it was persisted after coming back from Favorites, and
the fragment was incorrectly deleting favorite files from the list when unfavoriting.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-16 10:49:16 +01:00
tobiasKaminsky
e7ce821465 Only show "set encrypted" if folder is empty and has no empty files/folder in it
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-16 09:34:04 +00:00
Álvaro Brey
38a5283f98 PermissionUtil: remember permission requested when requesting media storage permissions
For devices under SDK 30, permission was asked on every startup, which is not desired, and is different from the
behaviour above SDK 30. This fixes that.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-16 07:54:36 +00:00
Álvaro Brey
fc5f0ff836 UploadFilesActivity: request permission on onStart instead of onResume
onResume is always called after permission dialog is closed, so it causes a loop

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-16 07:54:36 +00:00
Nextcloud bot
17f6e3beb8
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-16 03:27:16 +00:00
Nextcloud bot
b1dbfeaa3a
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-16 03:27:01 +00:00
Tobias Kaminsky
18588e9cc1 daily dev 20221116
Bump mockitoVersion from 4.8.1 to 4.9.0
Bump daggerVersion from 2.44.1 to 2.44.2
Bump leakcanary-android from 2.9.1 to 2.10
Bump daggerVersion from 2.44 to 2.44.1
Update Nextcloud Android library
Update 3rd-party dependencies
2022-11-16 02:40:56 +01:00
Tobias Kaminsky
3ecad40356 Merge remote-tracking branch 'origin/master' into dev 2022-11-16 02:33:51 +01:00
Álvaro Brey
ea4a8a35a7
Merge pull request #10977 from nextcloud/enter-the-room
Setup Room database
2022-11-15 16:24:23 +01:00
Álvaro Brey
2581764c3d
Fix toolbar back icon being arrow in places where it should be hamburger menu
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-15 15:59:27 +01:00
Álvaro Brey
18f4209971
FileDisplayActivity: fix restoring selected menu item when resuming
Not needed as it will be correctly selected elsewhere, and was causing wrong caching

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-15 15:55:02 +01:00
Álvaro Brey
47bf01f052
Merge pull request #11033 from nextcloud/fix/noid/jumping-file-list
File list "jumps" after scrolling when an asynchronous operation finishes
2022-11-15 11:51:21 +01:00
Álvaro Brey
f049603f35 Delete database migration code under database v24 (app v2.0.0)
Migration from such old app versions is broken anyway, not only in the database, but also in sharedprefs

Additionally, configure destructive migration for unsupported versions in Room

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-15 10:02:46 +00:00
Álvaro Brey
ec07d26334 Add migrations for capabilities and files tables as well
They both have unused columns that were not removed in previous migrations, and this makes Room unhappy

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-15 10:02:46 +00:00
Álvaro Brey
b84639672b spotbugs: ignore Room autogenerated classes
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-15 10:02:46 +00:00
github-actions
07bc1e8fd0 Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: github-actions <github-actions@github.com>
2022-11-15 10:02:46 +00:00
Álvaro Brey
cc9b38b972 Clean up creation, injection and migrations for room database
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-15 10:02:46 +00:00
Álvaro Brey
da60c7f6b2 FileContentProvider: secure projectionMap manually in the absence of projectionMap
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-15 10:02:46 +00:00
Álvaro Brey
73ba1e2421 Export Room schemas
Needed to enable auto-upgrades later

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-15 10:02:46 +00:00
Álvaro Brey
ebe35c9f49 DocumentsStorageProviderIT: suppress part of a test
See added comment for explanation

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-15 10:02:46 +00:00
Álvaro Brey
fdab7afbfd Fix column types and implement migrations
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-15 10:02:46 +00:00
Álvaro Brey
d0ab9ff67b Setup base Room configuration
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-15 10:02:46 +00:00