Commit graph

15306 commits

Author SHA1 Message Date
tobiasKaminsky
10f6ec94fa
Add to jetified-dagger-lint-aar-2.28.1 for custom lint check
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-29 16:59:20 +02:00
tobiasKaminsky
738291b2fa
Bump to dagger 2.28.1
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-29 16:31:15 +02:00
dependabot-preview[bot]
14fd15e9ae
Bump daggerVersion from 2.27 to 2.28
Bumps `daggerVersion` from 2.27 to 2.28.

Updates `dagger` from 2.27 to 2.28
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.27...dagger-2.28)

Updates `dagger-android` from 2.27 to 2.28
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.27...dagger-2.28)

Updates `dagger-android-support` from 2.27 to 2.28
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.27...dagger-2.28)

Updates `dagger-compiler` from 2.27 to 2.28
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.27...dagger-2.28)

Updates `dagger-android-processor` from 2.27 to 2.28
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.27...dagger-2.28)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-29 16:31:15 +02:00
Tobias Kaminsky
4073cd235c
Merge pull request #6341 from nextcloud/fragmentContainerView
Replace fragment by FragmentContainerView
2020-06-29 16:30:40 +02:00
tobiasKaminsky
cc517ffcfd
Lint ignore
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-29 16:00:44 +02:00
tobiasKaminsky
98d1b5e2b9
split up delete old commit to always delete them
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-29 16:00:44 +02:00
tobiasKaminsky
3102c23d2c
always delete old comments
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-29 16:00:44 +02:00
tobiasKaminsky
32a0d1c309
Replace fragment by FragmentContainerView
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-29 16:00:44 +02:00
Tobias Kaminsky
212b3a6ef9
Merge pull request #6385 from nextcloud/fixDeleteOnSuccess
type -> TYPE
2020-06-29 15:59:58 +02:00
tobiasKaminsky
fd7b722ac4
type -> TYPE
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-29 15:59:36 +02:00
Tobias Kaminsky
0207e70323
Merge pull request #6384 from nextcloud/dronePermission
make deleteOutdatedComments.sh executable
2020-06-29 15:42:14 +02:00
tobiasKaminsky
fb5ae37a38
make deleteOutdatedComments.sh executable
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-29 15:41:55 +02:00
Tobias Kaminsky
ced60bf59b
Merge pull request #6366 from nextcloud/deleteOutdatedComments
Delete outdated comments in case of success
2020-06-29 10:28:59 +02:00
Tobias Kaminsky
3c609a329f
Merge pull request #6332 from nextcloud/enh/darkThemeOptimizations
Enh/dark theme optimizations
2020-06-29 10:28:36 +02:00
Tobias Kaminsky
9a0d1085ed
Merge pull request #6382 from nextcloud/dependabot/gradle/gradle.plugin.com.github.spotbugs.snom-spotbugs-gradle-plugin-4.4.4
Bump spotbugs-gradle-plugin from 4.4.3 to 4.4.4
2020-06-29 10:00:45 +02:00
Tobias Kaminsky
a5142483a4
Merge pull request #6381 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.10.0
Bump detekt-gradle-plugin from 1.9.1 to 1.10.0
2020-06-29 10:00:31 +02:00
Tobias Kaminsky
1edaffeafe
Merge pull request #6380 from nextcloud/dependabot/gradle/net.bytebuddy-byte-buddy-1.10.13
Bump byte-buddy from 1.10.12 to 1.10.13
2020-06-29 10:00:12 +02:00
Tobias Kaminsky
b2ff37505e
Merge pull request #6244 from nextcloud/blackNavBar
black nav bar on image preview
2020-06-29 09:59:06 +02:00
Nextcloud bot
ebbedb46a0
[tx-robot] updated from transifex 2020-06-29 03:26:45 +00:00
dependabot-preview[bot]
dfe2e5dbd4
Bump spotbugs-gradle-plugin from 4.4.3 to 4.4.4
Bumps spotbugs-gradle-plugin from 4.4.3 to 4.4.4.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-29 01:14:26 +00:00
dependabot-preview[bot]
c1f5817f3f
Bump detekt-gradle-plugin from 1.9.1 to 1.10.0
Bumps detekt-gradle-plugin from 1.9.1 to 1.10.0.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-29 01:13:56 +00:00
dependabot-preview[bot]
9f23230bf1
Bump byte-buddy from 1.10.12 to 1.10.13
Bumps [byte-buddy](https://github.com/raphw/byte-buddy) from 1.10.12 to 1.10.13.
- [Release notes](https://github.com/raphw/byte-buddy/releases)
- [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md)
- [Commits](https://github.com/raphw/byte-buddy/compare/byte-buddy-1.10.12...byte-buddy-1.10.13)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-29 01:13:16 +00:00
Nextcloud bot
fbfdf1104a
[tx-robot] updated from transifex 2020-06-28 03:27:05 +00:00
Nextcloud bot
bf587f1a65
[tx-robot] updated from transifex 2020-06-27 03:26:25 +00:00
Chris Narkiewicz
dbae9443eb
Provide DeckApi via dependency injection framework
- renamed integration packate to integrations (plural)
- created DI module for integrations
- added provider for DeckApi
- inject DeckApi to background job factory

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-06-26 23:43:43 +01:00
Chris Narkiewicz
e13a3ca7cb
Migate file details and share details to User model
UserAccountManager:
 - added userOwnsFile API that replaces accountOwnsFile
 - deprecated accountOwnsFile

FileDisplayActivity:
 - simplified initFragmentWithFile by passing non-null instanecs
   of user and file and thus avoiding numerous redundant null-checks
 - fragments are initialized using User model instead of Account
 - transfer and download callbacks use getUser() instead of getAccount()
   and pass user instance to framents

ShareActivity
 - initlize fragment using user model instead of account
 - close acivity immediately if current user is not available
   (cannot reach such state not, but historically account was nullable)

FileDetailTabAdapter
 - framents are initialized using User model instead of Account

FileDetailActivitiesFragment
 - migrated to User
 - removed dependency on constants from FileActivity

FileDetailFragment
 - migrated to User
 - removed dependency on constants from FileActivity

FileDetailsSharingFragment
 - migrated to User
 - removed dependency on constants from FileActivity

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-06-26 23:07:40 +01:00
nextcloud-android-bot
79f4270bb9 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-26 13:35:51 +00:00
Andy Scherzinger
5f73a5ec75
update screenshots
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:30 +02:00
Andy Scherzinger
0ad81bdd29
remove element color references
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:29 +02:00
Andy Scherzinger
8af257d54f
remove unused method
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:27 +02:00
Andy Scherzinger
a7088c8c87
improve edge case FAB coloring
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:25 +02:00
Andy Scherzinger
5b76892ab1
move primary action button theming to new theming method
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:24 +02:00
Andy Scherzinger
7005cdef2e
Introduce light/dark theme / black/white primary-color-aware primary-button theming
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:22 +02:00
Andy Scherzinger
643454c1d7
proper coloring of drawer items in black/white edge case scenarios
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:21 +02:00
Andy Scherzinger
20d2ef989d
proper button coloring for dark theme + black primary color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:14 +02:00
Andy Scherzinger
dfc94f4505
Merge pull request #6354 from nextcloud/noShare
Enhance FileDetailSharingFragment
2020-06-26 13:27:16 +02:00
tobiasKaminsky
8f0e4eab60
Delete outdated comments in case of success
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-26 12:51:47 +02:00
Andy Scherzinger
93d0875883
Merge pull request #6253 from nextcloud/noNothingIfNoActivity
PreviewImageFragment: if we have no activity, do nothing
2020-06-26 11:13:58 +02:00
Joris Bodin
947e4a1b10
Remove duplacation
Signed-off-by: Joris Bodin <joris.bodin@infomaniak.com>
2020-06-26 11:05:44 +02:00
tobiasKaminsky
c55e9b8fd2
black nav bar on image preview
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-26 11:05:44 +02:00
Andy Scherzinger
2b5c39095d
lint: remove unused resource
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 11:03:09 +02:00
tobiasKaminsky
348ae4435a
Enhance FileDetailSharingFragment:
- remove no users text
- disable search view if reshare is not allowed
- show note icon

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-26 11:03:03 +02:00
Tobias Kaminsky
a22b0724ae
Merge pull request #6367 from nextcloud/fixTypeInReport
type -> TYPE
2020-06-26 10:58:58 +02:00
tobiasKaminsky
c42c24be80
type -> TYPE
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-26 10:58:34 +02:00
Tobias Kaminsky
7e03aa39b5
Merge pull request #6365 from nextcloud/fixDeleteCommits
fix deleting outdated comments
2020-06-26 10:36:11 +02:00
tobiasKaminsky
097434916e
fix deleting outdated comments
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-26 10:35:48 +02:00
Tobias Kaminsky
728de81736
Merge pull request #6263 from nextcloud/scrollPart2
Hide on scrolling for activities and notifications
2020-06-26 08:39:57 +02:00
Chris Narkiewicz
5609b5041e
Fix NPE in OCFileListFragment when OCFile is null
1. Fixed NPE
2. Audited all use of nullable field in all called APIs
3. Updated called APIs nullability documentation

Fixes #6282

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-06-25 22:55:08 +01:00
tobiasKaminsky
d36c2d35a5
Hide on scrolling for activities and notifications
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 23:44:03 +02:00
tobiasKaminsky
741cc24d11
fix #5468
if we have no activity, do nothing

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 23:36:05 +02:00