Commit graph

15459 commits

Author SHA1 Message Date
Chris Narkiewicz
5609b5041e
Fix NPE in OCFileListFragment when OCFile is null
1. Fixed NPE
2. Audited all use of nullable field in all called APIs
3. Updated called APIs nullability documentation

Fixes #6282

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-06-25 22:55:08 +01:00
tobiasKaminsky
d36c2d35a5
Hide on scrolling for activities and notifications
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 23:44:03 +02:00
tobiasKaminsky
741cc24d11
fix #5468
if we have no activity, do nothing

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 23:36:05 +02:00
Andy Scherzinger
5288548e70
Merge pull request #6338 from nextcloud/legacyLoginFlow
Removed legacy login
2020-06-25 23:33:57 +02:00
nextcloud-android-bot
e0d5676151 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-25 21:18:34 +00:00
tobiasKaminsky
7ed4e2b24e
changes due to CR
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 22:57:48 +02:00
tobiasKaminsky
58ba15ac95
Removed legacy login
cleaned up a bit AuthenticatorActivity

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 22:57:22 +02:00
Andy Scherzinger
fe1cd33c26
Merge pull request #6344 from nextcloud/ocp
fix OCP_OVERLY_CONCRETE_PARAMETER
2020-06-25 20:30:34 +02:00
Andy Scherzinger
c3f838d445
Merge pull request #6349 from nextcloud/dependabot/gradle/gradle.plugin.com.github.spotbugs.snom-spotbugs-gradle-plugin-4.4.3
Bump spotbugs-gradle-plugin from 4.3.0 to 4.4.3
2020-06-25 20:29:45 +02:00
Andy Scherzinger
2f60b75fc5
add null check 2020-06-25 18:55:50 +02:00
nextcloud-android-bot
f6e7c44596 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-25 16:55:05 +00:00
tobiasKaminsky
1017e3ac3b
fix OCP_OVERLY_CONCRETE_PARAMETER
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 18:45:28 +02:00
Andy Scherzinger
2913918232
Merge pull request #6361 from nextcloud/fixZoom
Fix zoom, toggle background
2020-06-25 17:12:00 +02:00
tobiasKaminsky
ca7350fa8a
use fixed spotbug version
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 16:52:12 +02:00
dependabot-preview[bot]
2c5fb2b2f9
Bump spotbugs-gradle-plugin from 4.3.0 to 4.4.3
Bumps spotbugs-gradle-plugin from 4.3.0 to 4.4.3.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-25 16:52:12 +02:00
Tobias Kaminsky
d70502f747
Merge pull request #6262 from nextcloud/hideOnScrolling
Hide on scrolling
2020-06-25 16:18:40 +02:00
tobiasKaminsky
38c28332e2
fix tests
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 15:57:46 +02:00
tobiasKaminsky
bd5c9dfa1e
make function puplic for testing
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 15:22:58 +02:00
tobiasKaminsky
db4a7ee8f5
Fix zoom, toggle background
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 15:17:54 +02:00
Andy Scherzinger
066fef03c2
Merge pull request #6359 from nextcloud/photoBugfix
use view instead of linear layout as common parent
2020-06-25 13:44:32 +02:00
nextcloud-android-bot
741fb410f1 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-25 11:13:55 +00:00
nextcloud-android-bot
961e6c179a
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-25 13:00:04 +02:00
tobiasKaminsky
22657040bd
Removed possible NPE
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:59:54 +02:00
tobiasKaminsky
a9dc3f5787
removed duplicated sort/switch grid buttons
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:59:54 +02:00
tobiasKaminsky
e5ec91b5a7
Changes due to CR
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:59:54 +02:00
tobiasKaminsky
1ecd64f128
Hide on scrolling, fix https://github.com/nextcloud/android/issues/6238
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:59:54 +02:00
tobiasKaminsky
6dfb4c7ef6
use view instead of linear layout as common parent
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:48:40 +02:00
Nextcloud bot
56a1fc868d
[tx-robot] updated from transifex 2020-06-25 03:28:24 +00:00
Andy Scherzinger
83d4aaf1ab
Merge pull request #6345 from nextcloud/usbr
fix USBR_UNNECESSARY_STORE_BEFORE_RETURN
2020-06-24 23:18:08 +02:00
Andy Scherzinger
01d9d2e437
Merge pull request #6347 from nextcloud/uselessParent
Remove useless parents
2020-06-24 23:15:04 +02:00
nextcloud-android-bot
98d930b8ab Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-24 21:00:09 +00:00
nextcloud-android-bot
0fa902d2d2 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-24 20:58:48 +00:00
tobiasKaminsky
1f5352f2ec
Remove useless parents
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-24 22:05:37 +02:00
tobiasKaminsky
72fce1dd1e
fix USBR_UNNECESSARY_STORE_BEFORE_RETURN
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-24 21:54:56 +02:00
Andy Scherzinger
9e633b91b5
Merge pull request #6342 from nextcloud/view-binding
View binding
2020-06-24 20:28:20 +02:00
Andy Scherzinger
37fdd97c29
Merge pull request #6355 from nextcloud/unshareOnBottom
on user share permission: unshare as destructive option on bottom
2020-06-24 20:22:20 +02:00
Andy Scherzinger
cb0ae700db
Merge pull request #6346 from nextcloud/urf
fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
2020-06-24 17:21:41 +02:00
nextcloud-android-bot
9f3e1857db Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-24 15:17:33 +00:00
Andy Scherzinger
f0a608acde
remove unused constants
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-24 17:00:38 +02:00
tobiasKaminsky
4a791dda86
fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-24 16:45:15 +02:00
Andy Scherzinger
3e05624064
Merge pull request #6351 from nextcloud/castException
rich workspace not in folder picker activity
2020-06-24 12:52:36 +02:00
Andy Scherzinger
33dfc9651a
Merge pull request #6353 from nextcloud/userSearchText
Use same search hint as on server
2020-06-24 12:49:21 +02:00
tobiasKaminsky
14172fd1f0
on user share permission: unshare as destructive option on bottom
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-24 11:51:53 +02:00
tobiasKaminsky
b18ff7404e
Use same search hint as on server
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-24 10:58:24 +02:00
Tobias Kaminsky
ed8819ec86
Merge pull request #6327 from nextcloud/combineShare
Combined ShareActivity with FileDetailSharingFragment as much as possible
2020-06-24 10:43:24 +02:00
tobiasKaminsky
a424706368
rich workspace not in folder picker activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-24 07:56:58 +02:00
Andy Scherzinger
7ced94d42e
Merge pull request #6343 from nextcloud/lsc
fix LSC_LITERAL_STRING_COMPARISON
2020-06-24 06:56:54 +02:00
Stefan Niedermann
0aed8aaa86 #6247 View Binding - Fix new SpotBugs performance warning (unread field)
Signed-off-by: Stefan Niedermann <info@niedermann.it>
2020-06-23 18:21:22 +02:00
nextcloud-android-bot
c5abe938bd Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-23 14:30:27 +00:00
tobiasKaminsky
4e52f7f970
fix LSC_LITERAL_STRING_COMPARISON
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-23 14:59:02 +02:00