AndyScherzinger
d1ba80eb4a
cleanup
2018-05-09 11:33:51 +02:00
AndyScherzinger
6013956150
organize imports
2018-05-09 11:33:50 +02:00
AndyScherzinger
7ff4f4e378
add initial loading of (all, not file specific) activities
2018-05-09 11:33:50 +02:00
AndyScherzinger
dd050b0dc6
new lines and license headers
2018-05-09 11:33:49 +02:00
AndyScherzinger
254ac96795
WiP for #2485
2018-05-09 11:33:48 +02:00
Nextcloud bot
14a127eb7f
[tx-robot] updated from transifex
2018-05-09 00:40:59 +00:00
Nextcloud bot
aa6fc038c7
[tx-robot] updated from transifex
2018-05-08 00:41:44 +00:00
Nextcloud bot
d82ff62d30
[tx-robot] updated from transifex
2018-05-07 00:41:01 +00:00
Nextcloud bot
57d96761ac
[tx-robot] updated from transifex
2018-05-05 00:42:00 +00:00
Andy Scherzinger
4ce3900025
Merge pull request #2548 from nextcloud/lastindexof_performance
...
datamodel: String function use should be optimized for single characters
2018-05-04 16:55:01 +02:00
Andy Scherzinger
6047604ad5
Merge pull request #2545 from nextcloud/ortiztouch-switchbug
...
ortiz.touch: End switch case with an unconditional break.
2018-05-04 16:51:24 +02:00
AndyScherzinger
d7f223685e
organize imports
2018-05-04 16:20:20 +02:00
AndyScherzinger
cd9bfb12b8
Fix CR
2018-05-04 16:15:17 +02:00
ardevd
b1ef83524c
Anonymous inner classes containing only one method should become lambdas
...
Before Java 8, the only way to partially support closures in Java was by using anonymous inner classes. But the syntax of anonymous classes may seem unwieldy and unclear.
With Java 8, most uses of anonymous inner classes should be replaced by lambdas to highly increase the readability of the source code.
2018-05-04 16:15:16 +02:00
ardevd
3a01e07afc
datamodel: String function use should be optimized for single characters
...
An lastIndexOf call with a single letter String can be made more performant by switching to a call with a char argument.
2018-05-04 09:18:30 +02:00
ardevd
58e4360630
ui: Corrected '&' to '&&' in boolean if statement.
...
The use of non-short-circuit logic in a boolean context is likely a mistake - one that could cause serious program errors as conditions are evaluated under the wrong circumstances.
2018-05-04 09:06:21 +02:00
ardevd
851d065ace
ortiz.touch: End switch case with an unconditional break.
...
When the execution is not explicitly terminated at the end of a switch case, it continues to execute the statements of the following case. While this is sometimes intentional, it often is a mistake which leads to unexpected behavior
2018-05-04 08:59:54 +02:00
Nextcloud bot
3c5cc68005
[tx-robot] updated from transifex
2018-05-04 00:43:52 +00:00
Andy Scherzinger
fdd9c9f942
Merge pull request #2540 from nextcloud/activities-ondestroy-override
...
activities: A couple of code quality fixes for the Activities component
2018-05-02 23:04:55 +02:00
eho
04da4de923
authentication: Renamed Bundle object in onCreate().
2018-05-02 19:19:25 +02:00
ardevd
8fd8577aea
authentication: Added @Override annotations to applicable methods.
...
Using the @Override annotation is useful for two reasons :
It elicits a warning from the compiler if the annotated method doesn't actually override anything, as in the case of a misspelling.
It improves the readability of the source code by making it obvious that methods are overridden.
2018-05-02 17:20:49 +02:00
ardevd
ffb9ad4151
data: Added private constructor for the Injection utility class.
...
Utility classes, which are collections of static members, are not meant to be instantiated. Even abstract utility classes, which can be extended, should not have public constructors.
Java adds an implicit public constructor to every class which does not define at least one explicitly. Hence, at least one non-public constructor should be defined.
2018-05-02 16:15:46 +02:00
ardevd
ab6fa36f9b
activities: Use isEmpty() to check whether the list of activities is empty.
...
Using Collection.size() to test for emptiness works, but using Collection.isEmpty() makes the code more readable and can be more performant
2018-05-02 16:12:47 +02:00
ardevd
4d786a3f41
activities: Added @Override annotation above the onDestroy() method signature.
...
Using the @Override annotation is useful for two reasons:
It elicits a warning from the compiler if the annotated method doesn't actually override anything, as in the case of a misspelling.
It improves the readability of the source code by making it obvious that methods are overridden.
2018-05-02 16:11:11 +02:00
Andy Scherzinger
66deeb7731
Merge branch 'master' into 2474-feature-mvp-activities
2018-05-02 15:39:15 +02:00
ardevd
385bb429c7
passcodemanager: Reordered auth type check statements.
2018-05-02 14:45:15 +02:00
ardevd
2f0464d6e4
passcodemanager: Simplified passcode/fingerprint auth timeout check.
2018-05-02 14:37:06 +02:00
ardevd
40e3c050b2
authentication:passcodemanager: long literal '0l' should be 0L.
...
The suffix L is preferred, because the letter l (ell) is often hard to distinguish from the digit 1 (one).
2018-05-02 14:34:08 +02:00
ardevd
6fcfa840b7
authentication:passcodemanager: Cleaned up variable naming.
2018-05-02 14:19:36 +02:00
ardevd
b8cde0fa86
authentication:passcodemanager: Stricter variable declaration.
2018-05-02 13:56:28 +02:00
ardevd
2615926163
authentication:passcodemanager: Simplified if-statements.
2018-05-02 13:55:07 +02:00
ardevd
81f72a50c4
authentication:passcodemanager: Stricter access declaration.
2018-05-02 13:54:39 +02:00
ardevd
786ffd2c44
authentication:passcodemanager: Explicit argument type removed.
2018-05-02 13:53:56 +02:00
ardevd
c8b3f1e168
data:activities Added newline at the bottom.
2018-05-02 13:50:18 +02:00
ardevd
81f4f2a767
authentication: Cleaned up variable name in PassCodeManager.
2018-05-02 13:45:17 +02:00
ardevd
c079d8c285
data:files Properly return callback.onError if remoteOcFile is null.
2018-05-02 13:08:22 +02:00
ardevd
49d0ccac7d
data:files Cleaned up onPostExecute() if-statements.
2018-05-02 12:54:43 +02:00
ardevd
9efa675c2a
activities: Removed hungarian variable name notation.
2018-05-02 12:38:33 +02:00
Nextcloud bot
0556586232
[tx-robot] updated from transifex
2018-04-30 00:41:33 +00:00
eho
07770a2268
activities: Added copyright headers
2018-04-29 19:49:54 +02:00
Nextcloud bot
8a1cb0b37a
[tx-robot] updated from transifex
2018-04-29 00:44:16 +00:00
Nextcloud bot
f84db51efa
[tx-robot] updated from transifex
2018-04-28 00:42:16 +00:00
Nextcloud bot
cd48dd7335
[tx-robot] updated from transifex
2018-04-27 00:42:51 +00:00
AndyScherzinger
6f60447665
lint: fix implicitly using the default locale is a common source of bugs: Use toLowerCase(Locale) instead. For strings meant to be internal use Locale.ROOT, otherwise Locale.getDefault().
2018-04-26 18:01:40 +02:00
AndyScherzinger
9916aecfa9
lint: fix set android:baselineAligned="false" on this element for better performance
2018-04-26 18:01:39 +02:00
AndyScherzinger
b8a4c4e8d6
lint: fix the image ic_favorite.png varies significantly in its density-independent (dip) size across the various density versions (ic_ needs to comply with standard icon sizes)
2018-04-26 18:01:39 +02:00
AndyScherzinger
34e9b55632
lint: fix the image ic_account_circle.png varies significantly in its density-independent (dip) size across the various density versions
2018-04-26 18:01:38 +02:00
AndyScherzinger
ee736ce214
lint: fix This tag and its children can be replaced by one <TextView/> and a compound drawable _and_ unnecessary parent element
2018-04-26 18:01:37 +02:00
AndyScherzinger
4a8de18d49
lint: fix attribute networkSecurityConfig is only used in API level 24 and higher (current min is 14)
2018-04-26 18:01:37 +02:00
AndyScherzinger
6b6716dc72
lint: fix attribute splitTrack is only used in API level 21 and higher (current min is 14)
2018-04-26 18:01:36 +02:00
