Álvaro Brey
123cf4ad65
Merge pull request #10138 from nextcloud/dependabot/gradle/byteBuddyVersion-1.12.10
...
Bump byteBuddyVersion from 1.12.9 to 1.12.10
2022-05-02 12:10:55 +02:00
Álvaro Brey
9a2cbcbba4
FileDisplayActivity: wait until OCFileListFragment is initialized to trigger browseToRoot()
...
This solves a bug which caused a "Directory does not exist" popup when coming back from Gallery,
as it tried to call browseToRoot on GalleryFragment due it being executed before the fragment transaction.
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-02 11:02:46 +02:00
Álvaro Brey Vilas
13e061e7d7
PreviewMediaFragment: Remove margin from top bar
...
Not needed since previous commit fixing scroll bugs, creates unwanted space
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 07:55:34 +00:00
Álvaro Brey Vilas
7a2c735795
Fix contents cut off when scrolling is locked
...
Don't need to touch the coordinator params, just set scroll flags properly
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 07:55:34 +00:00
Álvaro Brey
2bb8c91965
Merge pull request #10132 from nextcloud/chore/cleanup-repositories
...
build: Clean up repository configuration
2022-05-02 09:45:42 +02:00
dependabot[bot]
f4546d1ceb
Bump byteBuddyVersion from 1.12.9 to 1.12.10
...
Bumps `byteBuddyVersion` from 1.12.9 to 1.12.10.
Updates `byte-buddy` from 1.12.9 to 1.12.10
- [Release notes](https://github.com/raphw/byte-buddy/releases )
- [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md )
- [Commits](https://github.com/raphw/byte-buddy/compare/byte-buddy-1.12.9...byte-buddy-1.12.10 )
Updates `byte-buddy-android` from 1.12.9 to 1.12.10
- [Release notes](https://github.com/raphw/byte-buddy/releases )
- [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md )
- [Commits](https://github.com/raphw/byte-buddy/compare/byte-buddy-1.12.9...byte-buddy-1.12.10 )
---
updated-dependencies:
- dependency-name: net.bytebuddy:byte-buddy
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: net.bytebuddy:byte-buddy-android
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-05-02 01:26:20 +00:00
Nextcloud bot
ddb96e7b17
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-01 04:10:03 +00:00
Álvaro Brey
e33e801bd8
Merge pull request #10128 from nextcloud/fix/calendar-picker-rotation
...
Fix expiration date picker layout when rotating screen
2022-04-29 17:42:31 +02:00
nextcloud-android-bot
1ea61c6fe6
Analysis: update lint results to reflect reduced error/warning count
...
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-04-29 15:07:40 +00:00
Álvaro Brey Vilas
2560d1be3c
Inject ThemeColorUtils into ThemeableSwitchPreference too
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 16:56:56 +02:00
Álvaro Brey Vilas
b58749d459
Fix ThemeUtils injection for MediaControlView
...
Inflation of this view was failing as there was no proper constructor
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 16:50:35 +02:00
Álvaro Brey Vilas
2bd8fb4240
build: Update last 2 libraries that used JCenter
...
Both of these are present in mavenCentral with a different groupId.
For both of them, the version bump is only for the groupId change, there are no breaking changes otherwise.
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 16:13:04 +02:00
Álvaro Brey Vilas
9463d2e668
build: Clean up repository configuration
...
- Put jitpack.io at the bottom, so that it is the last one checked. For libraries that are both in jitpack and elsewhere,
this should prevent a lot of errors especially in CI due to jitpack unreliability.
- Don't use gradle plugin portal as a mirror for JCenter. JCenter is still up as read-only, and using the gradle plugin portal
hides the fact that we have stop using jcenter libraries.
- For buildscripts, use gradlePluginPortal() instead of manual maven config
- Don't have repository configuration in both app/build.gradle and project build.gradle. Use project gradle instead
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 16:07:55 +02:00
Álvaro Brey Vilas
7e31a71ba0
FileDetailsSharing: Preserve selected date when recreating expiration date dialog
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 11:12:07 +00:00
Álvaro Brey Vilas
85dcbe542e
FileDetailsSharingProcess: force recreation of date picked on config changes
...
See added comment for details
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 11:12:07 +00:00
Álvaro Brey Vilas
8c2fc3ee87
ExpirationDatePickerDF: customize buttons on onStart instead of showing dialog on onCreate
...
That is how DialogFragment is supposed to work
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 11:12:07 +00:00
Álvaro Brey
3148d94262
Merge pull request #10129 from nextcloud/chore/leakcanary-disabled-default
...
build: Disable LeakCanary unless manually activated with a property
2022-04-29 12:14:34 +02:00
Álvaro Brey Vilas
21ed337184
build: Disable LeakCanary unless manually activated with a property
...
Use `./gradlew installGplayDebug -P "leakCanary"`, for example, to activate it.
LeakCanary dramatically slows down normal development work due to app freezes for memory dumps.
This way we can avoid that, but still use it when we want to check for leaks. I don't think leaks should be a primary focus right now,
since we have other stuff to work on first.
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 11:43:11 +02:00
Álvaro Brey
caf89f7908
Merge pull request #9876 from nextcloud/ThemeColorUtilsToDI
...
Move all Theme classes to DI
2022-04-29 11:22:27 +02:00
Álvaro Brey Vilas
4ff54bb48b
Fix and update testBottomSheet screenshot test
...
We can't edit the capability in FDA directly
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
bdd1daa10e
SyncFileNotEnoughSpaceDialogFragment needs injector
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
e023cedd7f
Fix GalleryAdapterTest
...
GalleryAdapter needs theme stuff now
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
3ff35d46e6
Fix some spotbugs stuff
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
56584c06e6
Fix detekt
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
42c28dce70
ThemeModule: convert to Kotlin and fix copyright
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
nextcloud-android-bot
e2c3091fc0
Analysis: update lint results to reflect reduced error/warning count
...
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-04-29 06:38:14 +00:00
tobiasKaminsky
17828cb3b4
remove some spotbugs warnings
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
f627f3d976
Fix injection ofr RenameFileDialogFragment
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
6bd7d808f4
Put OCFileListBottomSheetDialog into a DialogFragment
...
Can't inject things into a Dialog
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:13 +00:00
tobiasKaminsky
74e17ee7c6
Fixes after rebase
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Fixes after rebase
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Fixes after rebase
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Fix after rebase
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-29 06:38:13 +00:00
Álvaro Brey Vilas
75cb8a767c
Remove SyncedFoldersActivity.java
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:13 +00:00
tobiasKaminsky
349a045b46
Move all Theme classes to DI
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Move all Theme classes to DI
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Move all Theme classes to DI
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-29 06:38:13 +00:00
Nextcloud bot
0a802b51da
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-29 04:11:37 +00:00
Álvaro Brey
c81c1c83aa
Merge pull request #10117 from nextcloud/chore/screenshot-test-reliability
...
Screenshot tests reliability improvements
2022-04-28 14:05:23 +02:00
Álvaro Brey
87ed56f4d9
Merge pull request #10080 from nextcloud/thumbnailFetch
...
Parallel thumbnail fetching
2022-04-28 11:11:08 +02:00
Álvaro Brey Vilas
bc44b2c524
PasscodeActivityIT: add short sleep after closing keyboard
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-28 11:09:19 +02:00
tobiasKaminsky
73bb12f78a
Parallel thumbnail fetching
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-28 08:10:54 +00:00
Álvaro Brey Vilas
011d6c3ceb
ActivitiesActivityIT.error: more sleep
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-28 09:03:35 +02:00
Álvaro Brey Vilas
236925de99
Screenshot tests reliability improvements
...
Add more sleeps to SetupEncryptionDialogFragment.error and TrashBinActivity.empty, which fail frequently
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-28 09:03:29 +02:00
Tobias Kaminsky
a2d2c1a3c7
Merge pull request #10122 from nextcloud/fix/activity-constructor
...
Fixes for tests due changes in Activity constructor in library
2022-04-28 08:03:57 +02:00
Álvaro Brey Vilas
d79b20dbc5
ActivitiesPresenterTest: Activity no longer has empty constructor
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 19:02:43 +02:00
Álvaro Brey Vilas
98177e3eb3
Fix crash in screenshot test due to changes in library
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 19:02:26 +02:00
Álvaro Brey
c20c3e4066
Merge pull request #10014 from nextcloud/spotbugs-improvements
...
Spotbugs improvements
2022-04-27 11:34:35 +02:00
Álvaro Brey
23dd1f30f1
Merge pull request #10113 from nextcloud/chore/unit-tests-gh-actions
...
Run unit tests in GH actions
2022-04-27 11:21:49 +02:00
Álvaro Brey
176fb24d5b
Merge pull request #10084 from nextcloud/dependabot/gradle/com.google.firebase-firebase-messaging-23.0.3
...
Bump firebase-messaging from 23.0.2 to 23.0.3
2022-04-27 11:12:02 +02:00
Álvaro Brey Vilas
7073746309
Use defusedxml for xml parsing instead of etree
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 11:03:59 +02:00
Álvaro Brey Vilas
6eff01d735
Fix some codacy warnings
...
- Quote some strings in analysis-wrapper
- Cleanup unneeded checks in spotbugs-up
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 10:53:30 +02:00
Álvaro Brey Vilas
79fc8c61d9
codecov: add flag to integration test coverage so the UI is clearer
...
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 10:19:23 +02:00
dependabot[bot]
f93e65872a
Bump firebase-messaging from 23.0.2 to 23.0.3
...
Bumps firebase-messaging from 23.0.2 to 23.0.3.
---
updated-dependencies:
- dependency-name: com.google.firebase:firebase-messaging
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-04-27 08:09:10 +00:00
Álvaro Brey Vilas
3879d90eec
Ditch findbugs-results.txt: use the stable branch XML as single source of truth
...
Poor man's baseline
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-27 08:07:32 +00:00