Commit graph

12732 commits

Author SHA1 Message Date
Andy Scherzinger
1074bcf46a
Merge pull request #3879 from nextcloud/pmdRuleset
PMD ruleset
2019-04-12 07:52:31 +02:00
tobiasKaminsky
09da127d29
- rename ruleset
- add test_test to MainApp to test Codacy

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-12 07:44:25 +02:00
Tobias Kaminsky
8e1ebca9c5 daily dev 20190412
b52ce7e85c Merge pull request #3873 from nextcloud/codacy
32b04cb07e remove unused variable
35ff763950 codacy: combine statements
8353ef42bb Merge pull request #3864 from nextcloud/connectivityutils-powermock-test
477bc797aa removed placeholder test class
aa98015739 Merge branch 'connectivityutils-powermock-test' of github.com:nextcloud/android into connectivityutils-powermock-test
d760206654 Removed placeholder test class
3d9e379b43 Merge pull request #3841 from nextcloud/owncloudsession-unit-tests
a97eb3b45b - use lombok - remove m prefix - correct assert output - add licence
7e38b60ca0 utils: Restricted access declarations for OwnCloudSession class.
8712c9e783 tests: added unit tests for the OwnCloudSession class
0013ee8309 Merge pull request #3878 from nextcloud/dependabot/gradle/org.mockito-mockito-core-2.27.0
a34761ba3a code review changes
dac5897894 codacy: make newRemotePath a local variable
659775dc25 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
2ea4b352e3 combine statements
d19b7742d6 remove m/s-prefixes, make use of lombok
a05ba1a54f reformatting var declarations
d41a8a9054 spotbugs: Exceptional return value ignored
38466e01d3 reformatting
47a74a13fd remove unused HookActvity
c6498ae6b4 Use Butterknife for Log Activity
92219048da remove unused method
b41cca2840 add log statement to parent class
a3c7e7b74a use interface instead of implementation
88da903e59 daily dev 20190411
2019-04-12 03:34:47 +02:00
Andy Scherzinger
b52ce7e85c
Merge pull request #3873 from nextcloud/codacy
Further code improvements
2019-04-11 19:15:35 +02:00
Andy Scherzinger
4278f64e47
Fix #3881 by checking for result being null
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 18:08:16 +02:00
Andy Scherzinger
32b04cb07e
remove unused variable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 17:32:48 +02:00
Andy Scherzinger
35ff763950
codacy: combine statements
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 14:44:09 +02:00
Andy Scherzinger
8353ef42bb
Merge pull request #3864 from nextcloud/connectivityutils-powermock-test
test: added PowerMocked unit tests for the ConnectivityUtils class.
2019-04-11 14:34:38 +02:00
ardevd
477bc797aa
removed placeholder test class
Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-04-11 13:15:36 +02:00
ardevd
aa98015739
Merge branch 'connectivityutils-powermock-test' of github.com:nextcloud/android into connectivityutils-powermock-test
Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-04-11 13:14:42 +02:00
ardevd
d760206654
Removed placeholder test class
Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-04-11 13:14:23 +02:00
Andy Scherzinger
3d9e379b43
Merge pull request #3841 from nextcloud/owncloudsession-unit-tests
Unit tests for the OwnCloudSession class.
2019-04-11 08:24:32 +02:00
tobiasKaminsky
a97eb3b45b
- use lombok
- remove m prefix
- correct assert output
- add licence

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-11 08:14:11 +02:00
ardevd
7e38b60ca0
utils: Restricted access declarations for OwnCloudSession class.
Follow the principle of least-privilege.

Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-04-11 08:14:10 +02:00
ardevd
8712c9e783
tests: added unit tests for the OwnCloudSession class
Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-04-11 08:14:04 +02:00
Andy Scherzinger
0013ee8309
Merge pull request #3878 from nextcloud/dependabot/gradle/org.mockito-mockito-core-2.27.0
Bump mockito-core from 2.26.0 to 2.27.0
2019-04-11 07:46:20 +02:00
Andy Scherzinger
a34761ba3a
code review changes
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 07:39:25 +02:00
Andy Scherzinger
dac5897894
codacy: make newRemotePath a local variable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 07:35:42 +02:00
nextcloud-android-bot
659775dc25
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 07:35:41 +02:00
Andy Scherzinger
2ea4b352e3
combine statements
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 07:35:40 +02:00
Andy Scherzinger
d19b7742d6
remove m/s-prefixes, make use of lombok
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 07:35:39 +02:00
Andy Scherzinger
a05ba1a54f
reformatting var declarations
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 07:35:38 +02:00
Andy Scherzinger
d41a8a9054
spotbugs: Exceptional return value ignored
use lombok

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 07:35:37 +02:00
Andy Scherzinger
38466e01d3
reformatting
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 07:35:35 +02:00
Andy Scherzinger
47a74a13fd
remove unused HookActvity
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 07:35:34 +02:00
Andy Scherzinger
c6498ae6b4
Use Butterknife for Log Activity
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 07:35:33 +02:00
Andy Scherzinger
92219048da
remove unused method
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 07:35:32 +02:00
Andy Scherzinger
b41cca2840
add log statement to parent class
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 07:35:31 +02:00
Andy Scherzinger
a3c7e7b74a
use interface instead of implementation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 07:35:21 +02:00
Tobias Kaminsky
88da903e59 daily dev 20190411
5aba8fe28a Merge pull request #3866 from nextcloud/tests-powerutils
58702f0ce5 Merge pull request #3867 from nextcloud/codacy
b5723187f1 remove typo
2859054633 codacy: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.
2de1f7e5d9 codacy: Avoid unused private methods such as 'allFiles()'.
a5d4c2d8ad codacy: No need to call String.valueOf to append to a string.
7bc663efbc codacy: Avoid using Literals in Conditional Statements
39e113f251 codacy: This call to Collection.toArray() may be optimizable
2c55f2ee49 codacy: Avoid declaring a variable if it is unreferenced before a possible exit point.
cd1469317d codacy: This statement should have braces
73aea003ec codacy: A class which only has private constructors should be final
e1ec691d4a codacy: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.
3e5d6700ab Merge pull request #3858 from nextcloud/devWithChangelog
0bf2f8c479 show changelog in dev
c0186e7191 Merge pull request #3868 from nextcloud/changelog360
6ab3b599be Release 3.6.0
5bf97c0bfd daily dev 20190410
2019-04-11 03:33:42 +02:00
dependabot[bot]
811b676f18
Bump mockito-core from 2.26.0 to 2.27.0
Bumps [mockito-core](https://github.com/mockito/mockito) from 2.26.0 to 2.27.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v2.26.0...v2.27.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-11 01:12:18 +00:00
Andy Scherzinger
5aba8fe28a
Merge pull request #3866 from nextcloud/tests-powerutils
test: added unit tests for the PowerUtils class.
2019-04-10 12:52:41 +02:00
ardevd
bbf779917d
removed hungarian notation
Signed-off-by: ardevd <edvard.holst@gmail.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-10 12:41:23 +02:00
ardevd
5f0b551330
removed hungarian notation
Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-04-10 12:37:49 +02:00
Andy Scherzinger
58702f0ce5
Merge pull request #3867 from nextcloud/codacy
Codacy improvements
2019-04-10 12:26:50 +02:00
tobiasKaminsky
71844294c7
show current codacy issue count
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-10 11:37:41 +02:00
Andy Scherzinger
b5723187f1
remove typo
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-10 11:16:44 +02:00
Andy Scherzinger
2859054633
codacy: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-10 11:16:02 +02:00
Andy Scherzinger
2de1f7e5d9
codacy: Avoid unused private methods such as 'allFiles()'.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-10 11:16:01 +02:00
Andy Scherzinger
a5d4c2d8ad
codacy: No need to call String.valueOf to append to a string.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-10 11:16:00 +02:00
Andy Scherzinger
7bc663efbc
codacy: Avoid using Literals in Conditional Statements
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-10 11:15:59 +02:00
Andy Scherzinger
39e113f251
codacy: This call to Collection.toArray() may be optimizable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-10 11:15:59 +02:00
Andy Scherzinger
2c55f2ee49
codacy: Avoid declaring a variable if it is unreferenced before a possible exit point.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-10 11:15:58 +02:00
Andy Scherzinger
cd1469317d
codacy: This statement should have braces
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-10 11:15:57 +02:00
Andy Scherzinger
73aea003ec
codacy: A class which only has private constructors should be final
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-10 11:15:57 +02:00
Andy Scherzinger
e1ec691d4a
codacy: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-10 11:15:56 +02:00
Andy Scherzinger
3e5d6700ab
Merge pull request #3858 from nextcloud/devWithChangelog
show changelog in dev
2019-04-10 11:15:03 +02:00
tobiasKaminsky
0bf2f8c479
show changelog in dev
Signed-off-by: tobiasKaminsky tobias@kaminsky.me
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-10 10:52:26 +02:00
Andy Scherzinger
c0186e7191
Merge pull request #3868 from nextcloud/changelog360
Changelog release 3.6.0
2019-04-10 10:41:47 +02:00
Andy Scherzinger
6ab3b599be
Release 3.6.0
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-10 09:16:09 +02:00