Commit graph

689 commits

Author SHA1 Message Date
nextcloud-android-bot
c8cf7bbfe7 Analysis: update Spotbugs results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-04-12 07:23:20 +00:00
tobiasKaminsky
7817a3b8d5
Let us no longer create java files
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-08 10:17:44 +02:00
tobiasKaminsky
c18bf9983e
correct location of different build.gradle files
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-22 07:58:39 +01:00
Álvaro Brey
138d3a03a9
Merge pull request #9972 from nextcloud/fix/search-loading
Fix search loading animation and display
2022-03-17 13:04:10 +01:00
Álvaro Brey
b70eeaae3a
Merge pull request #9977 from nextcloud/chore/ktlint-gradle
Use ktlint plugin instead of manual ktlint tasks
2022-03-16 13:05:23 +01:00
nextcloud-android-bot
a64986e2e3
Analysis: update lint results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-03-16 11:40:41 +01:00
Álvaro Brey Vilas
3597fb0a53
Use ktlint plugin instead of manual ktlint tasks
- Recommended by ktlint
 - Analyzes sources for all sourcesets without extra config
 - Less gradle code to maintain

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-16 11:30:39 +01:00
tobiasKaminsky
d9b8b3baf8
Add NDK to buildDev
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-16 07:56:39 +01:00
Álvaro Brey Vilas
91c46090e8
Increase findbugs-results.txt
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 14:09:57 +01:00
Álvaro Brey Vilas
a860761144
Increase lint and spotbugs
Lint is expected, spotbugs is false positive

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 13:22:52 +01:00
Álvaro Brey Vilas
d23d20f31b
Fix git hooks for new source location
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:42:11 +01:00
Álvaro Brey Vilas
797316b75a
Fix screenshot screens for new source location
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:38:56 +01:00
Álvaro Brey Vilas
b7c0e94b3d
Fix scripts/buildDev for new source location
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:30:59 +01:00
Álvaro Brey Vilas
4c28ac03ff
Fix scripts/androidScreenshotTest for new source location
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:28:21 +01:00
Álvaro Brey Vilas
0282a98528
Fix generate_metadata.py
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:16:42 +01:00
Álvaro Brey Vilas
b55c452f5f
Fix uploadReport.sh for new structure
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:15:06 +01:00
Álvaro Brey Vilas
516544115c
Fix screenshot tests after subproject change
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:14:46 +01:00
Álvaro Brey Vilas
dd4085cf96
Fix analysis script for new project structure
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:12:47 +01:00
tobiasKaminsky
e32de23933
fix qa
fix lint
fix uploadArtifact.sh

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-11 11:11:43 +01:00
Álvaro Brey Vilas
b4c241cef9
Update analysis.yml
Analysis: don't add "skip ci" to drone commit messages

Messes up Github Actions and doesn't work on Drone anyway

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

analysis: Fix commiter name and email

Not drone anymore

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-09 15:02:44 +01:00
nextcloud-android-bot
3f61f6767f Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-03-09 09:34:24 +00:00
Álvaro Brey
4a621176a4
Merge pull request #9922 from nextcloud/syncedfolders-async
SyncedFoldersActivity: asynchronous loading
2022-03-09 10:01:20 +01:00
Álvaro Brey Vilas
2a8123210a
Analysis scripts: fix push
I am TIRED of fighting with this scripts and Github actions

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-08 13:16:53 +01:00
nextcloud-android-bot
0a97b9b797
Drone: update FindBugs results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-03-04 17:50:11 +01:00
nextcloud-android-bot
0ad73f845d
Drone: update Lint results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-03-04 17:49:54 +01:00
Unpublished
3c002fa0c3
Allow EditorWebView accessing URLs with custom certificate
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>

Drone: update Lint results to reflect reduced error/warning count

Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>

Drone: update FindBugs results to reflect reduced error/warning count

Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-03-01 16:26:37 +01:00
nextcloud-android-bot
a990e6c2c8 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-02-25 13:54:05 +00:00
nextcloud-android-bot
99854accf6 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-02-25 12:49:47 +00:00
nextcloud-android-bot
2854b72f77 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-02-21 16:47:54 +00:00
nextcloud-android-bot
28e8c0d1ad Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-02-21 16:46:46 +00:00
Unpublished
2bd0bf0f14 Update findbugs-results.txt
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>
2022-02-20 13:22:48 +01:00
nextcloud-android-bot
905b21e04a
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
ebf59510fc remove gplay.gradle, use gplayImplementation instead
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-01-27 12:15:37 +00:00
Álvaro Brey Vilas
96c55a6d9f
FileSortOrder*: convert to Kotlin
Need more kotlin in the codebase and these were simple enough

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:49:07 +01:00
nextcloud-android-bot
d51268d7b8
Drone: update FindBugs results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-01-26 14:09:47 +01:00
nextcloud-android-bot
af2059660f Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-01-26 12:08:19 +00:00
Álvaro Brey Vilas
494cceab8e
Analysis: fix checkout and commit generation
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:54:24 +01:00
Álvaro Brey Vilas
5a65c65e76
uploadReport: update shot path
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-25 10:41:06 +01:00
Álvaro Brey Vilas
9fa63c7547
Run analysis workflow in github actions
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-13 09:29:43 +01:00
tobiasKaminsky
719551505e
Fix DialogFragmentIT test
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-01-10 10:12:44 +01:00
Álvaro Brey
9433e2968e Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Álvaro Brey <drone@nextcloud.com>
2021-12-22 08:51:21 +00:00
Álvaro Brey Vilas
3775e13b5c
Increase lint due to dependencies
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 18:50:46 +01:00
Álvaro Brey Vilas
f81779285e Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: Álvaro Brey Vilas <drone@nextcloud.com>
2021-12-10 13:05:22 +00:00
Álvaro Brey Vilas
3b023e9be5
Update analysis results
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-10 13:08:06 +01:00
Álvaro Brey Vilas
d84d82b176 Increase findbugs
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-01 10:47:22 +01:00
Álvaro Brey Vilas
8f6c7fe4d9
Increase findbugs result
Was missing in a previous PR

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-26 11:02:55 +01:00
Álvaro Brey Vilas
815e946adc
Increase spotbugs result due to new spotbugs version
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-25 09:19:13 +01:00
Álvaro Brey Vilas
be54fa0bce
Update spotbugs results
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:56:04 +01:00
Álvaro Brey Vilas
14c1e8d718
build.gradle: Refactor spotbugs setup
- Don't duplicate tasks. Use the ones that spotbugs provides and link them to their sourcesets
 - Add dependencies to compileSources to the spotbugs tasks
 - Update spotbugs plugin

This results in a much higher amount of issues. They were probably not being properly scanned earlier.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-05 16:12:05 +01:00
tobiasKaminsky
3823eccfe6
AccountManagerService needs to be exported
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-27 08:49:05 +02:00
drone
05d98ccc4b Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2021-10-26 06:02:19 +00:00
drone
16b37bcc05
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 16:06:17 +02:00
tobiasKaminsky
042c413569
Calendar backup/import
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 13:02:12 +02:00
drone
8b53b54d48 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2021-10-25 06:02:10 +00:00
Tobias Kaminsky
f55c7c8785
Merge pull request #9093 from nextcloud/more-hooks-improvements
pre-push hook: Exclude merges from signoff check
2021-10-22 08:37:19 +02:00
Tobias Kaminsky
150cb04483
Merge pull request #9048 from nextcloud/codecov-uploader-update
codecov: Use new codecov uploader instead of the deprecated bash uploader
2021-10-21 11:46:22 +02:00
Tobias Kaminsky
9b18d0d6cb
Merge pull request #9098 from nextcloud/drone-commit-signoff
scripts: Have Drone properly signoff commits so that it doesn't break DCO
2021-10-21 10:59:23 +02:00
Álvaro Brey Vilas
a52c9e0761
codecov: Use new codecov uploader instead of the deprecated bash uploader
Ref: https://docs.codecov.com/docs/about-the-codecov-bash-uploader

Old bash uploader has been deprecated and will start failing on September 2021,
with it completely failing from February 2022.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-20 11:43:37 +02:00
drone
0cbe866a3a Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-10-18 09:55:18 +00:00
Álvaro Brey Vilas
a90487a261
scripts: Have Drone properly signoff commits so that it doesn't break DCO
Use git env variables to force a valid email

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-15 10:42:12 +02:00
drone
7645b18c1e Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-10-14 12:46:12 +00:00
Álvaro Brey Vilas
267c4c2b72
pre-push hook: Exclude merges from signoff check
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-13 09:55:07 +02:00
Andy Scherzinger
9c432b5655 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-06 08:26:25 +00:00
Andy Scherzinger
ec59542f5a bump score due to AGP upgrade
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-06 08:26:25 +00:00
Álvaro Brey
7fd8724473 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2021-09-29 12:28:59 +00:00
Álvaro Brey Vilas
3010bb2977 scripts/drone: Use deleteOldComments everywhere
This removes duplication between deleteOldComments and deleteOutdatedComments.

Additionally, deleteOutdatedComments was broken anyway, and IT/drone test comments were not being deleted.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-09-29 08:30:58 +00:00
tobiasKaminsky
a57f8eb989
Enhance screenshot handling
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-09-29 09:16:10 +02:00
Andy Scherzinger
cfae25c137
Merge pull request #8818 from binsky08/add-sso-patch-method
add custom PatchMethod class to use http PATCH requests with the Nextcloud SSO api
2021-09-27 12:09:28 +02:00
Álvaro Brey Vilas
a38edb92dd
Improvements to git hooks
- pre-commit: Suppress all output and show reduced results.
   This is more concise and avoids unreadable errors when committing from an IDE
 - pre-push: Format with shell formatter, fix typo

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-09-27 11:42:20 +02:00
Álvaro Brey Vilas
556982ad8b
Add simple git hooks and gradle task to install them
- Pre-commit hook checks ktlint and detekt
 - Pre-push hook checks signoff

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-09-24 14:07:11 +02:00
Timo Triebensky
5e6e3d4800
Merge branch 'master' into add-sso-patch-method 2021-09-21 11:39:25 +02:00
Álvaro Brey Vilas
ab692d92a7
scripts: Fix deleteOldComments.sh
* Get comments from github-actions, not only our android bot
 * Fix count (was broken for 0 comments) and only try to delete if count > 0

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-09-14 10:49:07 +02:00
Álvaro Brey Vilas
6c176c4802 deleteOldComments: fix github token var name
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-09-14 07:50:24 +00:00
Álvaro Brey Vilas
a621e29f18 Revert "scripts: Remove deleteOldComments.sh"
This reverts commit 131373f066.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-09-14 07:50:24 +00:00
drone
8a59cd9c87 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-09-13 09:51:17 +00:00
drone
50e0cef895 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-09-08 10:39:22 +00:00
Álvaro Brey Vilas
131373f066
scripts: Remove deleteOldComments.sh
Only used by screenShotTest.yml, but uploadReports.sh already
has a function for the same purpose.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-09-06 12:08:27 +02:00
Álvaro Brey Vilas
f3f14bfcc4
scripts:uploadReport: Fix git token usage
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-09-06 11:29:46 +02:00
Álvaro Brey Vilas
47689c938c
scripts:uploadReport: Fix github authorization
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-09-03 13:09:43 +02:00
Álvaro Brey Vilas
4121cd9e50
androidScreenshotTest: Use full path to emulator
In some systems (like mine) emulator will fail if not called by full path

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-09-03 12:37:55 +02:00
Álvaro Brey Vilas
6ab58b7b1a
scripts: androidScreenshotTest: Fail on first error
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-09-03 12:29:58 +02:00
tobiasKaminsky
a35a6a3417
Revert Shot to get screenshots again
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-09-03 07:48:47 +02:00
Andy Scherzinger
a1700664d2
bump due to spotbugs update
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-08-19 21:53:15 +02:00
binsky
f25d85a33e increase SpotBugs to 464 to accept the new PatchMethod class for the SSO api
Signed-off-by: binsky <timo@binsky.org>
2021-08-12 15:50:47 +02:00
tobiasKaminsky
947d0c5115
Somehow SpotBugs needs to be on 462.
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-08-05 15:02:46 +02:00
Andy Scherzinger
e95c94939b
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-24 15:23:44 +02:00
tobiasKaminsky
870e979f12
Correctly return exit code
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-07-22 07:40:54 +02:00
tobiasKaminsky
8ac7d46e0f
Correctly return exit code
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-07-22 07:40:20 +02:00
Tobias Kaminsky
e47c4a7758
Merge pull request #8711 from nextcloud/deleteoutdatedComments
Delete outdated comments before running
2021-07-21 08:44:25 +02:00
Andy Scherzinger
be1a52a813
bump spotbugs score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-17 22:33:02 +02:00
Andy Scherzinger
8516e6a4d5
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-17 16:52:25 +02:00
Andy Scherzinger
10a6e519cb
Drone: update Lint/spotbugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-17 14:16:40 +02:00
tobiasKaminsky
14f7dbb3db
Delete outdated comments before running
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-07-16 11:07:23 +02:00
tobiasKaminsky
0a287e0b45 alwas upload code coverage
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-06-30 06:33:40 +00:00
tobiasKaminsky
1ea436e4dd
Use ExoPlayer for audio/video player
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-06-02 10:09:09 +02:00
Andy Scherzinger
5bbbae7165
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-01 18:27:58 +02:00
tobiasKaminsky
8e0aebf3f0
uploadReport.sh: fix flavor case
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-05-27 11:11:37 +02:00
tobiasKaminsky
419cb69b08
Fix not null fix
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-05-27 10:16:06 +02:00
drone
1d563cd69e Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-05-26 22:11:07 +00:00
tobiasKaminsky
fb7bba8fe4
analysis-wrapper.sh: fix not Null check
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-05-26 08:43:22 +02:00