7946 commits

Author	SHA1	Message	Date
Andy Scherzinger	8353ef42bb	Merge pull request #3864 from nextcloud/connectivityutils-powermock-test ... test: added PowerMocked unit tests for the ConnectivityUtils class.	2019-04-11 14:34:38 +02:00
ardevd	477bc797aa	removed placeholder test class ... Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-04-11 13:15:36 +02:00
tobiasKaminsky	a97eb3b45b	- use lombok ... - remove m prefix - correct assert output - add licence Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-04-11 08:14:11 +02:00
ardevd	7e38b60ca0	utils: Restricted access declarations for OwnCloudSession class. ... Follow the principle of least-privilege. Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-04-11 08:14:10 +02:00
ardevd	8712c9e783	tests: added unit tests for the OwnCloudSession class ... Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-04-11 08:14:04 +02:00
Andy Scherzinger	a34761ba3a	code review changes ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-11 07:39:25 +02:00
Andy Scherzinger	dac5897894	codacy: make newRemotePath a local variable ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-11 07:35:42 +02:00
Andy Scherzinger	2ea4b352e3	combine statements ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-11 07:35:40 +02:00
Andy Scherzinger	d19b7742d6	remove m/s-prefixes, make use of lombok ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-11 07:35:39 +02:00
Andy Scherzinger	a05ba1a54f	reformatting var declarations ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-11 07:35:38 +02:00
Andy Scherzinger	d41a8a9054	spotbugs: Exceptional return value ignored ... use lombok Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-11 07:35:37 +02:00
Andy Scherzinger	38466e01d3	reformatting ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-11 07:35:35 +02:00
Andy Scherzinger	47a74a13fd	remove unused HookActvity ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-11 07:35:34 +02:00
Andy Scherzinger	c6498ae6b4	Use Butterknife for Log Activity ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-11 07:35:33 +02:00
Andy Scherzinger	92219048da	remove unused method ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-11 07:35:32 +02:00
Andy Scherzinger	b41cca2840	add log statement to parent class ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-11 07:35:31 +02:00
Andy Scherzinger	a3c7e7b74a	use interface instead of implementation ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-11 07:35:21 +02:00
Andy Scherzinger	5aba8fe28a	Merge pull request #3866 from nextcloud/tests-powerutils ... test: added unit tests for the PowerUtils class.	2019-04-10 12:52:41 +02:00
ardevd	bbf779917d	removed hungarian notation ... Signed-off-by: ardevd <edvard.holst@gmail.com> Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-10 12:41:23 +02:00
Andy Scherzinger	b5723187f1	remove typo ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-10 11:16:44 +02:00
Andy Scherzinger	2859054633	codacy: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-10 11:16:02 +02:00
Andy Scherzinger	2de1f7e5d9	codacy: Avoid unused private methods such as 'allFiles()'. ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-10 11:16:01 +02:00
Andy Scherzinger	a5d4c2d8ad	codacy: No need to call String.valueOf to append to a string. ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-10 11:16:00 +02:00
Andy Scherzinger	7bc663efbc	codacy: Avoid using Literals in Conditional Statements ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-10 11:15:59 +02:00
Andy Scherzinger	39e113f251	codacy: This call to Collection.toArray() may be optimizable ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-10 11:15:59 +02:00
Andy Scherzinger	2c55f2ee49	codacy: Avoid declaring a variable if it is unreferenced before a possible exit point. ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-10 11:15:58 +02:00
Andy Scherzinger	cd1469317d	codacy: This statement should have braces ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-10 11:15:57 +02:00
Andy Scherzinger	73aea003ec	codacy: A class which only has private constructors should be final ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-10 11:15:57 +02:00
Andy Scherzinger	e1ec691d4a	codacy: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-04-10 11:15:56 +02:00
Nextcloud bot	a260345c86	[tx-robot] updated from transifex	2019-04-10 00:51:17 +00:00
ardevd	94fb4ad349	minor cleanup ... Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-04-09 20:37:36 +02:00
ardevd	ffeaa7f766	added file header ... Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-04-09 20:36:14 +02:00
ardevd	81184d0266	test: added unit tests for the PowerUtils util class. ... Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-04-09 20:35:04 +02:00
ardevd	e03dfc695d	updated tests ... Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-04-09 19:57:02 +02:00
ardevd	e17e5f6bd7	test: added PowerMocked unit tests for the ConnectivityUtils class. ... Added necessary PowerMock dependencies in addition to a JSON dependency which is required in order to unit test with JSON objects. The default JSON library is part of AOSP and would need to be mocked which is not what we want. Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-04-09 14:59:18 +02:00
ardevd	6b2ddd97fe	added GPL header ... Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-04-09 10:55:46 +02:00
ardevd	2f6cf091df	tests: added unit tests for the ConnectivityUtils util class. ... The isOnlineWithWifi() method is fully covered by these tests. Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-04-09 10:55:46 +02:00
tobiasKaminsky	8713f4e3c1	As we can have now any preview (if there is a preview generator), we also need a fallback for any mimetype ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-04-09 10:06:15 +02:00
Tobias Kaminsky	0548dfb77a	Merge pull request #3847 from nextcloud/fixOldLogin ... revert to old auth login method: do not use weblogin suffix	2019-04-09 09:31:15 +02:00
Nextcloud bot	01df8d4a27	[tx-robot] updated from transifex	2019-04-09 00:50:46 +00:00
Andy Scherzinger	30cad20f86	Merge pull request #3839 from nextcloud/simplified-string-utils ... Minor refactor of StringUtils class. Added unit tests.	2019-04-08 13:27:57 +02:00
tobiasKaminsky	1646e46bde	remove test prefix name ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-04-08 11:55:46 +02:00
Nextcloud bot	1f22645137	[tx-robot] updated from transifex	2019-04-08 00:52:12 +00:00
tobiasKaminsky	f932ab3f5b	added nullable ... add null checks Signed-off-by: tobiasKaminsky <tobias@kaminsky.me> wip Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-04-05 09:51:25 +01:00
ardevd	c40788b11d	removed unused imports. ... Leaving unused imports in reduces the code's readability, since their presence can be confusing.	2019-04-05 10:33:20 +02:00
ardevd	7d97b267af	updated assertion failure text. return empty string if arguments are null	2019-04-05 10:24:32 +02:00
Nextcloud bot	4bcaf8414e	[tx-robot] updated from transifex	2019-04-05 00:51:44 +00:00
tobiasKaminsky	ed7cf414da	revert to old auth login method: do not use weblogin suffix ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-04-04 21:30:21 +01:00
Nextcloud bot	347f30674f	[tx-robot] updated from transifex	2019-04-04 00:51:24 +00:00
ardevd	44e1cd846c	utils: replaced string concatenation with String.format. ... Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-04-03 09:56:05 +02:00
ardevd	fa047b751b	tests: added unit tests for the StringUtils class. ... Provides full test coverage of said class. Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-04-03 09:56:04 +02:00
ardevd	1c92e8c88b	utils: Removed dependency on android.text.TextUtils. ... Depending upon android.text.TextUtils for simply checking if a string is empty seems unnecessary and makes unit testing harder. Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-04-03 09:56:03 +02:00
Nextcloud bot	e88df10983	[tx-robot] updated from transifex	2019-04-03 00:53:20 +00:00
Andy Scherzinger	cbb4234771	Merge pull request #3791 from nextcloud/ezaquarii/inject-app-preferences-into-activities ... Inject AppPreferences into activities and fragments	2019-04-02 12:33:08 +02:00
Nextcloud bot	ed84655a05	[tx-robot] updated from transifex	2019-04-02 09:11:34 +00:00
Chris Narkiewicz	8761e50b0f	Inject AppPreferences into activities and fragments ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-04-01 15:51:47 +01:00
Andy Scherzinger	78323554e6	Merge pull request #3821 from nextcloud/npeCheckOnNote ... NPE check on note	2019-04-01 09:47:22 +02:00
Andy Scherzinger	b4e1e57859	Merge pull request #3820 from nextcloud/fixNotificationResultCheck ... Check result also for 202 (accepted)	2019-04-01 09:43:59 +02:00
Tobias Kaminsky	caf89285eb	Merge pull request #3818 from nextcloud/filedatastoragemanager-string-comparison ... datamodel: use equals for string comparison.	2019-04-01 09:14:22 +02:00
tobiasKaminsky	b0f9c5ea68	NPE check on note, it should never be null due to our fetch, which fails back to "" (empty string), but there are few crash reports on google… ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-04-01 08:31:26 +02:00
tobiasKaminsky	b2a2fa494c	check result also for 202 (accepted) ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-04-01 08:21:24 +02:00
Nextcloud bot	52ab9b95b3	[tx-robot] updated from transifex	2019-04-01 00:53:38 +00:00
ardevd	3968be4a58	fixed inverted comparison ... Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-03-31 22:24:33 +02:00
ardevd	e797e5ced8	datamodel: use equals for string comparison. ... It is almost always a mistake to compare two instances of java.lang.String using reference equality == or !=, because it is not comparing actual value but locations in memory. Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-03-31 21:55:47 +02:00
Nextcloud bot	7f523dfbcd	[tx-robot] updated from transifex	2019-03-31 01:52:59 +00:00
Nextcloud bot	83cdb1f28b	[tx-robot] updated from transifex	2019-03-30 01:52:07 +00:00
Nextcloud bot	789ccd9cea	[tx-robot] updated from transifex	2019-03-29 01:52:28 +00:00
tobiasKaminsky	816a10735a	- unify icons ... - add svg, convert to android xml, removed png Signed-off-by: tobiasKaminsky <tobias@kaminsky.me> Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> fix after rebase Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> renamed user -> ic_user (icon) make favorite mutable Signed-off-by: tobiasKaminsky <tobias@kaminsky.me> Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> replace further png resources with xml drawables Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> fixes after rebase Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> allow for vector compat Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> add missing icon Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> add yet another missing icon Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> lint: When using VectorDrawableCompat, you need to use app:srcCompat Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> lint: When using VectorDrawableCompat, you need to use app:srcCompat Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> fix lint Signed-off-by: tobiasKaminsky <tobias@kaminsky.me> Drone: update Lint results to reflect reduced error/warning count [skip ci] Signed-off-by: nextcloud-android-bot <android@nextcloud.com> improve findbugs score Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> use correct icon for user account settings within drawer menu Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> icons needs to be grey600 by default, don't tint grey600 to not tint avatars Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> codacy: organize imports Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> programmatically set in-View drawables, in-view drawables can't be set via XML when supporting pre-lollipop Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> codacy: Useless parentheses & organize imports Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> organize imports Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> codacy: useless paranthesis Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> revert programmatically set do not use vectorDrawables.useSupportLibrary Signed-off-by: tobiasKaminsky <tobias@kaminsky.me> use 128dp for talk Signed-off-by: tobiasKaminsky <tobias@kaminsky.me> Revert "lint: When using VectorDrawableCompat, you need to use app:srcCompat" This reverts commit 80068e7d37f3a8c6b7096c51543bda68443e4341. Revert "lint: When using VectorDrawableCompat, you need to use app:srcCompat" This reverts commit 0130e9a96d2602ad4b5d33aae67f34a458366d70. revert srcCompat Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-28 10:14:01 +01:00
tobiasKaminsky	d14ce0218e	do not show avatar if ownerId is null ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-28 06:57:32 +01:00
Tobias Kaminsky	505be99946	Merge pull request #3788 from nextcloud/filemenufilter-null-passed-to-method ... files: avoid possible dereference of null pointer.	2019-03-27 10:53:32 +01:00
Tobias Kaminsky	3b88b7b464	Merge pull request #3787 from nextcloud/authtokentype_always_null ... authentication: Added missing variable assignment.	2019-03-27 10:33:01 +01:00
ardevd	f1f3d74ce6	getCapability marked with @NonNull and associated npe check removed. ... Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-03-27 10:29:52 +01:00
ardevd	c59b41d761	operations: properly close FileOutputStream. ... Classes that implement the Closeable interface or its super-interface, AutoCloseable, needs to be closed after use. try-with-resources does this for you automatically. Signed-off-by: ardevd <edvard.holst@gmail.com> Signed-off-by: nextcloud-android-bot <android@nextcloud.com> Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-27 09:34:19 +01:00
Andy Scherzinger	23c9ea0cf4	Merge pull request #3790 from nextcloud/private-constructor-in-util-classes ... Added private constructors to hide implicit public ones.	2019-03-27 08:57:35 +01:00
Nextcloud bot	43ccc1f39f	[tx-robot] updated from transifex	2019-03-27 01:45:03 +00:00
ardevd	37165b2ac5	Added private constructors to hide implicit public ones. ... Utility classes, which are collections of static members, are not meant to be instantiated. Even abstract utility classes, which can be extended, should not have public constructors. Java adds an implicit public constructor to every class which does not define at least one explicitly. Hence, at least one non-public constructor should be defined. Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-03-26 22:32:25 +01:00
ardevd	b96414d794	files: avoid possible dereference of null pointer. ... it seems the `capability` object can be null. In which case it is probably a bad idea to pass a null object into `getRichDocumentsDirectEditing()`. Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-03-26 14:34:29 +01:00
ardevd	dd04bf9e93	authentication: Added missing variable assignment. ... The `mAuthTokenType` variable is declared and assigned a null value but no value is subsequently assigned, making the null check later on redundant. The `AccountAuthenticator.KEY_AUTH_TOKEN_TYPE` extra value should therefore be assigned the `mAuthTokenType` value I'm assuming. Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-03-26 14:31:59 +01:00
ardevd	1f11845d35	Revert auto-formatting fixes ... Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-03-26 11:19:31 +01:00
ardevd	b1def8cae5	ui:activity: Properly close InputStreamReader. ... The InputStreamReader needs to be closed after use. Ideally, use try-with-resources instead. Signed-off-by: ardevd <edvard.holst@gmail.com>	2019-03-26 11:19:07 +01:00
Nextcloud bot	c739114c55	[tx-robot] updated from transifex	2019-03-26 01:43:09 +00:00
Nextcloud bot	8c066c99ff	[tx-robot] updated from transifex	2019-03-25 01:45:40 +00:00
Nextcloud bot	9c992d98ff	[tx-robot] updated from transifex	2019-03-24 01:46:58 +00:00
Nextcloud bot	6acb39ed56	[tx-robot] updated from transifex	2019-03-23 01:45:08 +00:00
Nextcloud bot	272316512c	[tx-robot] updated from transifex	2019-03-22 08:45:00 +00:00
Andy Scherzinger	3f392964bf	Merge pull request #3771 from nextcloud/moveSharedPref ... Combine sharedPreferences in MainApp	2019-03-22 08:55:11 +01:00
Andy Scherzinger	d29cd223d4	Merge pull request #3780 from nextcloud/firstRunWizard ... UI improvement on first run	2019-03-22 08:51:20 +01:00
tobiasKaminsky	1b2c41b7e4	combine sharedPreferences in MainApp ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-22 08:47:36 +01:00
Andy Scherzinger	5dc3faae90	Merge pull request #3768 from nextcloud/furtherHardening ... further hardening of SSO	2019-03-22 08:32:30 +01:00
tobiasKaminsky	65d8129971	removed two not-needed initializations for appPreferences ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-22 07:50:15 +01:00
Chris Narkiewicz	8fbe2ee38e	Integrate Dagger 2 ... Closes #3751 Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-22 07:50:15 +01:00
Tobias Kaminsky	d26d56a853	Merge pull request #3778 from nextcloud/NC12minimumSupported ... Increase minimum server version	2019-03-22 07:42:49 +01:00
tobiasKaminsky	96f4ba8c5a	use N12 for minimum ... warn if older than NC14 Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-22 07:30:36 +01:00
Nextcloud bot	6be7876c05	[tx-robot] updated from transifex	2019-03-22 01:46:44 +00:00
tobiasKaminsky	f99c7f2ddd	ReceiveExternalFiles: ... - fix no upload possible after creation new folder - obey canWrite permission for folder creation Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-21 15:04:39 +01:00
Andy Scherzinger	86abe6f18d	Fixes #3776 - allowing state loss when closing dialog while stopping activity ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-03-21 10:01:40 +01:00
Andy Scherzinger	60c7c3b24a	Merge pull request #3773 from nextcloud/consistentDelete ... Also favorited files can be deleted locally	2019-03-21 07:52:33 +01:00
Nextcloud bot	92eecb8069	[tx-robot] updated from transifex	2019-03-21 01:54:50 +00:00
tobiasKaminsky	fd45854d65	also favorited files can be deleted locally ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-20 11:00:32 +01:00
tobiasKaminsky	92bbcfb973	show notes on receiving shares ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-20 08:20:37 +01:00
Tobias Kaminsky	23c0ca50ef	Merge pull request #3756 from nextcloud/2806-lock ... Rephrase term "Lock"	2019-03-19 08:45:18 +01:00
tobiasKaminsky	c52f9c842f	further hardening, include account name to check ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-18 12:33:40 +01:00
Nextcloud bot	3395ceb069	[tx-robot] updated from transifex	2019-03-18 01:52:10 +00:00
Nextcloud bot	a9e064d72b	[tx-robot] updated from transifex	2019-03-17 01:53:06 +00:00
Nextcloud bot	fbe49cbeb8	[tx-robot] updated from transifex	2019-03-16 01:52:40 +00:00
Andy Scherzinger	d427d3f0ff	Merge pull request #3749 from nextcloud/ezaquarii/refactor-legacy-migration-prefs ... Move legacy free pref to AppPreferences	2019-03-15 20:01:57 +01:00
Daniel Bailey	b94c94d958	Rephrase term "Lock" ... Rephrase term "Lock" to "App passcode" and update dialog to reflect change. Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>	2019-03-15 11:47:19 +00:00
Nextcloud bot	6555842f3a	[tx-robot] updated from transifex	2019-03-15 01:55:11 +00:00
Andy Scherzinger	ac760261dd	add apply() to pref change ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-03-14 09:54:49 +01:00
Nextcloud bot	0f872f2218	[tx-robot] updated from transifex	2019-03-14 01:47:33 +00:00
Andy Scherzinger	d5cecd2c77	update due to constructor change ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-03-13 22:16:15 +01:00
tobiasKaminsky	c0ef6cc003	only use ifPreviewIsAvailable for thumbnail generation ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-13 20:51:29 +01:00
Chris Narkiewicz	ee99611546	Move legacy free pref to AppPreferences ... Finally, the beast is dead... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-13 17:49:16 +00:00
Andy Scherzinger	77ccba1ada	Merge pull request #3735 from nextcloud/refactor-push-token-preference ... Move push token preference to AppPreferences	2019-03-13 16:22:21 +01:00
Nextcloud bot	b85f43552a	[tx-robot] updated from transifex	2019-03-13 01:47:29 +00:00
Andy Scherzinger	c1fe45749e	Merge pull request #3740 from nextcloud/ezaquarii/refactor-lock-prefs ... Move lock prefs to AppPreferences	2019-03-12 22:16:54 +01:00
Chris Narkiewicz	1a7d6012f9	Move lock prefs to AppPreferences ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-12 18:54:04 +00:00
Chris Narkiewicz	293dae52d2	Move push token preference to AppPreferences ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-12 15:42:39 +00:00
Andy Scherzinger	31d7639d3b	Merge pull request #3736 from nextcloud/refactor-reinit-keys-preference ... Move re-init keys pref to AppPreferences	2019-03-12 09:35:50 +01:00
Andy Scherzinger	4d972ad081	Merge pull request #3737 from nextcloud/refactor-hidden-files-pref ... Move hidden files pref to AppPreferences	2019-03-12 09:18:01 +01:00
Nextcloud bot	16a0818e04	[tx-robot] updated from transifex	2019-03-11 18:28:08 +00:00
Chris Narkiewicz	92d13f2f1a	Move hidden files pref to AppPreferences ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-11 17:02:27 +00:00
Andy Scherzinger	def9054858	Merge pull request #3734 from nextcloud/refactor-folder-layout-preference ... Move folder layout preference to AppPreferences	2019-03-11 17:32:26 +01:00
Chris Narkiewicz	be421830c2	Move re-init keys pref to AppPreferences ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-11 15:56:14 +00:00
Chris Narkiewicz	914220d005	Move folder layout preference to AppPreferences ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-11 14:37:35 +00:00
Andy Scherzinger	02e98f25a5	Merge pull request #3733 from nextcloud/remove-dead-code-from-preference-manager ... Remove dead code from preference manager	2019-03-11 14:42:35 +01:00
Andy Scherzinger	67eec757fb	Merge pull request #3731 from nextcloud/ezaquarii/fix-button-disabled-state-in-folder-sync-preferences-2 ... Fix button disabled state in folder sync preferences	2019-03-11 14:25:04 +01:00
Chris Narkiewicz	f87349d9c0	Remove dead code from preference manager ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-11 12:36:55 +00:00
Andy Scherzinger	38559be8fd	Merge pull request #3713 from nextcloud/ezaquarii/refactor-sort-order-preferences ... Move sort order preferences to AppPreferences interface	2019-03-11 13:15:33 +01:00
tobiasKaminsky	d6fbe864a1	use primary color on primary button ... swipe container without margin Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-11 12:00:44 +01:00
Nextcloud bot	1a5beb4328	[tx-robot] updated from transifex	2019-03-11 01:45:06 +00:00
Nextcloud bot	84c2dfb5e7	[tx-robot] updated from transifex	2019-03-10 01:47:13 +00:00
Chris Narkiewicz	e521d25d63	Move sort order preferences to AppPreferences interface ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-10 01:25:31 +00:00
Chris Narkiewicz	ef45b6f11d	Dim disabled Save button in custom folder sync prefs dialog ... Fixes #3664 Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-09 21:23:29 +00:00
Chris Narkiewicz	4429af9189	Fix uninitialized preferences in MainApp ... Fixes #3728 Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-09 15:57:32 +00:00
Nextcloud bot	86eeff2843	[tx-robot] updated from transifex	2019-03-09 01:44:42 +00:00
Chris Narkiewicz	f5b356cdf6	Move last seen version preference to AppPreferences interface ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-08 16:11:37 +00:00
Andy Scherzinger	62534afba7	Merge pull request #3725 from nextcloud/ssoDialog ... make SSO dialog nicer	2019-03-08 13:24:21 +01:00
tobiasKaminsky	9667eb61a2	make SSO dialog nicer ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-08 11:16:39 +01:00
Tobias Kaminsky	5582a51520	Merge pull request #3719 from nextcloud/ezaquarii/refactor-auto-upload-preferences ... Moved auto upload preferences to AppPreferences	2019-03-08 09:16:52 +01:00
Tobias Kaminsky	558fa2273a	Merge pull request #3717 from nextcloud/ezaquarii/refactor-lock-timestamp-preference ... Move lock timestamp pref to AppPreferences	2019-03-08 09:14:32 +01:00
Nextcloud bot	4a7071562b	[tx-robot] updated from transifex	2019-03-08 01:46:36 +00:00
Chris Narkiewicz	44625a08e4	Move lock timestamp pref to AppPreferences ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-07 19:39:38 +00:00
Chris Narkiewicz	5a8f0f64a0	Moved auto upload preferences to AppPreferences ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-07 18:16:44 +00:00
Andy Scherzinger	63b057d7de	Merge pull request #3718 from nextcloud/ezaquarii/refactor-uploader-behavior-preference ... Move uploader behavior pref to AppPreferences	2019-03-07 08:48:07 +01:00
Nextcloud bot	3b403fc094	[tx-robot] updated from transifex	2019-03-07 01:46:42 +00:00
Chris Narkiewicz	78833ef911	Move uploader behavior pref to AppPreferences ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-06 22:45:46 +00:00
Andy Scherzinger	599566363e	Merge pull request #3711 from nextcloud/ezaquarii/refactor-upload-preferences ... Move upload preferences to AppPreferences interface	2019-03-06 22:15:32 +01:00
Chris Narkiewicz	5dabec67bf	Move upload preferences to AppPreferences interface ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-06 16:10:08 +00:00
Nextcloud bot	f2f5e64eba	[tx-robot] updated from transifex	2019-03-06 12:05:14 +00:00
Andy Scherzinger	f8bc2a7a31	Merge pull request #3706 from nextcloud/fileDeleteWhileOffline ... abort sync if reading remote file fails	2019-03-05 23:07:35 +01:00
Andy Scherzinger	41b365234a	improve findbugs score ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-03-05 17:04:46 +01:00
Chris Narkiewicz	087ed97e1a	Move grid columns to AppPreferences interface ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-05 17:04:41 +01:00
Andy Scherzinger	b16d996c87	Merge pull request #3707 from nextcloud/waitForServer ... wait for server to get ready	2019-03-05 17:04:04 +01:00
tobiasKaminsky	711508ec29	wait for server to get ready ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-05 14:55:19 +01:00
tobiasKaminsky	6542334c4e	abort sync if reading remote file fails ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-05 13:48:48 +01:00
Chris Narkiewicz	b5f357819f	Move show media scan notifications to AppPreferences interface ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-05 13:15:26 +01:00
Andy Scherzinger	ce14d3116c	Merge pull request #3705 from nextcloud/preferences ... change Preferences to SettingsActivity	2019-03-05 12:38:55 +01:00
Tobias Kaminsky	f8601fc9db	Merge pull request #3704 from nextcloud/verboseError ... Integration Tests: Show log in case of error	2019-03-05 12:01:44 +01:00
tobiasKaminsky	eb727d4f12	change Preferences to SettingsActivity ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-05 11:34:50 +01:00
tobiasKaminsky	6ecc023708	show info in case of error ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-05 11:18:18 +01:00
Andy Scherzinger	b784d84121	Merge pull request #3698 from nextcloud/ezaquarii/refactor-show-detailed-timestamp-preference ... Move showDetailedTimestampPreference to AppPreferences interface	2019-03-05 10:25:13 +01:00
Chris Narkiewicz	79da94ad62	Move showDetailedTimestampPreference to AppPreferences interface ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>	2019-03-05 08:49:05 +00:00
Tobias Kaminsky	090cfb5087	Merge pull request #3695 from nextcloud/menuHeader ... Improve Navigation Header Layout	2019-03-05 08:48:02 +01:00
Andy Scherzinger	c28ee84781	Merge pull request #3668 from ezaquarii/refactor-legacy-instant-upload-prefs-removal ... Refactor legacy instant upload prefs removal	2019-03-04 20:42:48 +01:00
Chris Narkiewicz	a003c4b953	Refactor legacy instant upload prefs removal ... Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com> Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-03-04 15:47:21 +00:00
Tobias Kaminsky	6681f447db	Merge 8c9af3ca91 into ef8789d2a7	2019-03-04 13:26:59 +00:00
tobiasKaminsky	8c9af3ca91	fix federated sharing ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-03-04 14:26:44 +01:00
Andy Scherzinger	d572179d74	Resolves #3689 ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-03-04 14:00:47 +01:00
Nextcloud bot	ef8789d2a7	[tx-robot] updated from transifex	2019-03-04 01:44:33 +00:00
Nextcloud bot	8f49110b1a	[tx-robot] updated from transifex	2019-03-03 01:45:24 +00:00
Nextcloud bot	2340870c30	[tx-robot] updated from transifex	2019-03-02 01:45:24 +00:00
Nextcloud bot	13523a0ed3	[tx-robot] updated from transifex	2019-03-01 01:52:05 +00:00
Andy Scherzinger	5c56014f89	codacy: Avoid instantiating new objects inside loops ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-02-28 09:03:23 +01:00
Andy Scherzinger	5676e0435b	codacy: No need to call String.valueOf to append to a string. ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-02-28 09:03:22 +01:00
Andy Scherzinger	233b4a0e63	codacy: Avoid declaring a variable if it is unreferenced before a possible exit point. ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-02-28 09:03:21 +01:00
Andy Scherzinger	4af1a57723	codacy: Avoid unused private fields ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-02-28 09:03:21 +01:00
Andy Scherzinger	f21f4eff22	codacy: This for loop can be replaced by a foreach loop ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-02-28 09:03:20 +01:00
Andy Scherzinger	1ea191fc59	codacy: Useless parentheses ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-02-28 09:03:20 +01:00
Andy Scherzinger	f9d9a18b87	codacy: Avoid using redundant field initializer ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-02-28 09:03:19 +01:00
Andy Scherzinger	07cc2fc7e7	codacy: Avoid using Literals in Conditional Statements ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-02-28 09:03:12 +01:00
Tobias Kaminsky	c4c6b8d2c6	Merge pull request #3662 from dan0xii/themeing.1 ... Fine tuned themeing	2019-02-28 08:28:50 +01:00
Nextcloud bot	ae71d59b7f	[tx-robot] updated from transifex	2019-02-28 01:53:11 +00:00
Daniel Bailey	a038c2c837	Code clean-up. ... * Misc. clean-up. * API 23 and newer will set the statusbar icons to "dark" if a light nextcloud server theme is defined via ThemeUtils.lightTheme(). Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>	2019-02-27 17:04:34 +00:00
Andy Scherzinger	2e4a43eecd	Merge pull request #3682 from nextcloud/deleteFilesAfterTest ... Enhance integration tests	2019-02-27 12:57:04 +01:00
tobiasKaminsky	b584ab79d2	- remove files after test ... - use new AndroidJunit4 Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-02-27 11:43:47 +01:00
tobiasKaminsky	bf86cf6a41	Show shared user ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-02-27 11:10:14 +01:00
Nextcloud bot	5b64410074	[tx-robot] updated from transifex	2019-02-27 01:51:26 +00:00
tobiasKaminsky	1f9c49bb70	- use localized date pattern ... - use translated strings Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-02-26 17:58:44 +01:00
tobiasKaminsky	f4f53cf254	reformat so that all indention are correct ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-02-26 11:40:43 +01:00
Tobias Kaminsky	aac5514c03	Merge pull request #3653 from nextcloud/storages ... Add storage path chooser for local file picker	2019-02-26 07:33:59 +01:00
tobiasKaminsky	6d92a87a50	add break to switch statement ... Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>	2019-02-26 07:25:22 +01:00
Nextcloud bot	ffe3ca5a55	[tx-robot] updated from transifex	2019-02-26 01:50:19 +00:00
tobiasKaminsky	860e8e7ff4	WIP storage picker ... improved icons/layout for storage path chooser use dir name for external sdcard, add only if exists ignore findbugs regarding hardcoded storage path and use better var names improve codacy sccore, make interla storage paths a set setup path chooser in picker action bar when storage location has been chosen add missing licenses header, set correct year show local storage path picker dialog if folder to navigate into is not readable fix crashing app due to open dialog Signed-off-by: tobiasKaminsky <tobias@kaminsky.me> Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-02-25 16:38:41 +01:00
Andy Scherzinger	904d89712f	implement code review changes ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2019-02-25 13:12:33 +01:00
Daniel Bailey	3dea959d5e	Attempt to deal with server set themes of either all white or all black. ... Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>	2019-02-25 12:55:04 +01:00
Daniel Bailey	7df8f8ba45	Fine tuned themeing ... The main activity's search view and various edittext views now show the server set theme colour for highlighted text, highlighted text selector handles and focus underline. Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>	2019-02-25 12:54:56 +01:00
Andy Scherzinger	3e6d01965b	Merge pull request #3663 from nextcloud/useLocalCredentials ... Use test credentials from ~/.gradle/gradle.properties	2019-02-25 09:50:04 +01:00
Nextcloud bot	c408370deb	[tx-robot] updated from transifex	2019-02-25 01:50:42 +00:00
Nextcloud bot	136c7d8aa3	[tx-robot] updated from transifex	2019-02-24 01:54:12 +00:00