b52ce7e85c Merge pull request #3873 from nextcloud/codacy
32b04cb07e remove unused variable
35ff763950 codacy: combine statements
8353ef42bb Merge pull request #3864 from nextcloud/connectivityutils-powermock-test
477bc797aa removed placeholder test class
aa98015739 Merge branch 'connectivityutils-powermock-test' of github.com:nextcloud/android into connectivityutils-powermock-test
d760206654 Removed placeholder test class
3d9e379b43 Merge pull request #3841 from nextcloud/owncloudsession-unit-tests
a97eb3b45b - use lombok - remove m prefix - correct assert output - add licence
7e38b60ca0 utils: Restricted access declarations for OwnCloudSession class.
8712c9e783 tests: added unit tests for the OwnCloudSession class
0013ee8309 Merge pull request #3878 from nextcloud/dependabot/gradle/org.mockito-mockito-core-2.27.0
a34761ba3a code review changes
dac5897894 codacy: make newRemotePath a local variable
659775dc25 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
2ea4b352e3 combine statements
d19b7742d6 remove m/s-prefixes, make use of lombok
a05ba1a54f reformatting var declarations
d41a8a9054 spotbugs: Exceptional return value ignored
38466e01d3 reformatting
47a74a13fd remove unused HookActvity
c6498ae6b4 Use Butterknife for Log Activity
92219048da remove unused method
b41cca2840 add log statement to parent class
a3c7e7b74a use interface instead of implementation
88da903e59 daily dev 20190411
5aba8fe28a Merge pull request #3866 from nextcloud/tests-powerutils
58702f0ce5 Merge pull request #3867 from nextcloud/codacy
b5723187f1 remove typo
2859054633 codacy: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.
2de1f7e5d9 codacy: Avoid unused private methods such as 'allFiles()'.
a5d4c2d8ad codacy: No need to call String.valueOf to append to a string.
7bc663efbc codacy: Avoid using Literals in Conditional Statements
39e113f251 codacy: This call to Collection.toArray() may be optimizable
2c55f2ee49 codacy: Avoid declaring a variable if it is unreferenced before a possible exit point.
cd1469317d codacy: This statement should have braces
73aea003ec codacy: A class which only has private constructors should be final
e1ec691d4a codacy: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.
3e5d6700ab Merge pull request #3858 from nextcloud/devWithChangelog
0bf2f8c479 show changelog in dev
c0186e7191 Merge pull request #3868 from nextcloud/changelog360
6ab3b599be Release 3.6.0
5bf97c0bfd daily dev 20190410
Added necessary PowerMock dependencies in addition to a JSON dependency which is required in order to unit test with JSON objects. The default JSON library is part of AOSP and would need to be mocked which is not what we want.
Signed-off-by: ardevd <edvard.holst@gmail.com>
- add svg, convert to android xml, removed png
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
fix after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
renamed user -> ic_user (icon)
make favorite mutable
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
replace further png resources with xml drawables
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
fixes after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
allow for vector compat
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
add missing icon
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
add yet another missing icon
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
lint: When using VectorDrawableCompat, you need to use app:srcCompat
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
lint: When using VectorDrawableCompat, you need to use app:srcCompat
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
fix lint
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
improve findbugs score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
use correct icon for user account settings within drawer menu
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
icons needs to be grey600 by default, don't tint grey600 to not tint avatars
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
codacy: organize imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
programmatically set in-View drawables, in-view drawables can't be set via XML when supporting pre-lollipop
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
codacy: Useless parentheses & organize imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
organize imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
codacy: useless paranthesis
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
revert programmatically set
do not use vectorDrawables.useSupportLibrary
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
use 128dp for talk
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Revert "lint: When using VectorDrawableCompat, you need to use app:srcCompat"
This reverts commit 80068e7d37f3a8c6b7096c51543bda68443e4341.
Revert "lint: When using VectorDrawableCompat, you need to use app:srcCompat"
This reverts commit 0130e9a96d2602ad4b5d33aae67f34a458366d70.
revert srcCompat
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>