Commit graph

1175 commits

Author SHA1 Message Date
Nextcloud bot
c3b1957ef8
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-01 03:32:57 +00:00
Tobias Kaminsky
980bb736a0 daily dev 20221201
Bump mockkVersion from 1.13.2 to 1.13.3
Update 3rd-party dependencies
2022-12-01 02:38:18 +01:00
Tobias Kaminsky
ab3bf3e7ca Merge remote-tracking branch 'origin/master' into dev 2022-12-01 02:31:51 +01:00
Álvaro Brey
13f37c04f8
Revert "Bump targetSdk to 32"
This reverts commit 8c8723c7c5.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-30 12:21:37 +01:00
Álvaro Brey
5d4b7a6d04
Merge pull request #11113 from nextcloud/fix-crash-when-disabling-airplane-mode
Fix crash when disabling airplane mode
2022-11-30 09:33:56 +01:00
Nextcloud bot
cf148a0558
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-30 06:35:10 +00:00
Tobias Kaminsky
013f6dc7d2
Merge pull request #11075 from nextcloud/chore/sdk-32
Bump targetSdk to 32
2022-11-30 07:24:33 +01:00
Tobias Kaminsky
c2fc3424bc daily dev 20221130
Bump kotlin_version from 1.7.21 to 1.7.22
Update Nextcloud Android library
Update 3rd-party dependencies
2022-11-30 03:45:47 +01:00
Tobias Kaminsky
5b89024800 Merge remote-tracking branch 'origin/master' into dev 2022-11-30 03:37:33 +01:00
Chris Narkiewicz
45567fb6d4
Fix crash when disabling airplane mode
Fixes #11096

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2022-11-29 20:17:38 +00:00
Álvaro Brey
f74f59220c
Merge pull request #11089 from nextcloud/fix/video-fullscreen-buffer
Video preview: use fullscreen dialog for video instead of new activity
2022-11-29 13:33:10 +01:00
Álvaro Brey
bbaf8d369d
Merge pull request #11073 from nextcloud/chore/strictmode-optional
Disable StrictMode by default
2022-11-29 13:23:52 +01:00
Nextcloud bot
d584c8416b
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-29 03:32:20 +00:00
Tobias Kaminsky
7ba1a9fa5b daily dev 20221129
Bump mockito-kotlin from 4.0.0 to 4.1.0
Update 3rd-party dependencies
2022-11-29 02:38:13 +01:00
Tobias Kaminsky
eddd776d4b Merge remote-tracking branch 'origin/master' into dev 2022-11-29 02:32:10 +01:00
Álvaro Brey
3f990c3f21 PreviewVideoFullscreenDialog: workaround for rotated videos on sdk < 29
See comments in added code for explanation

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
bdc0fc71e5 PreviewVideoFullscreenDialog: use listeners to control transfer, and pause the video while transfer is happening
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
efa7d9e317 Remove unused theme
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
b55d5768de Fix lint and spotbugs
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
bbb85513e1 Video preview: use fullscreen dialog for video instead of new activity
This allows transfering the playback directly between Player views, thus avoiding creating
a new ExoPlayer, re-starting the stream, having to pass playing status/current position, etc.

Additionally:
- Always enable buffering animation so it's clear when a video is loading
- Add padding to fullscreen duration numbers so they don't get cut off on rounded screens

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Tobias Kaminsky
397ba74274 use getParentFragmentManager
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
2022-11-28 14:18:09 +00:00
tobiasKaminsky
831bffe571 show only one setup dialog, prevents strange situation on double tapping
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-28 14:18:09 +00:00
Álvaro Brey
e85737f41d Disable StrictMode by default
StrictMode is not a good fit for the state of our app, since we are way too far from async operations or correct threading.
As a result, we find ourselves disabling the strict mode manually every time we actually want to work on something, as otherwise the
logspam drowns everything else.

With this PR I propose to disable StrictMode unless a prop is set in the Gradle build, which will also control LeakCanary.
Running `./gradlew installGplayDebug -P perfAnalysis` will install the app with both LeakCanary and StrictMode enabled.
This allows us to analyze performance problems on demand, without making our daily work harder.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 15:09:04 +01:00
Andy Scherzinger
c66491a02f
update screenshot test results
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-11-28 13:03:10 +01:00
Valdnet
d184aa6690
i18n: Correct spelling
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:32 +01:00
Valdnet
1433dec21b
i18n: Change to lower case
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:32 +01:00
Valdnet
e57bf0eb2a
i18n: Correct spelling
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:31 +01:00
Valdnet
a65b896ce6
i18n: Change name of encryption
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:19 +01:00
Nextcloud bot
759b799e37
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-28 03:33:17 +00:00
Nextcloud bot
adcfaf381b
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-28 03:33:00 +00:00
Nextcloud bot
b9e1bb3f81
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-27 03:30:59 +00:00
Nextcloud bot
cf17a9fbfc
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-27 03:30:41 +00:00
Nextcloud bot
23d0b40d5b
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-26 03:30:47 +00:00
Nextcloud bot
5d9e0e6e0a
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-26 03:30:27 +00:00
Tobias Kaminsky
72c8248a43 daily dev 20221126
Bump com.diffplug.spotless from 6.11.0 to 6.12.0
Update Nextcloud Android library
Update 3rd-party dependencies
2022-11-26 03:43:42 +01:00
Tobias Kaminsky
eb2b9ec935 Merge remote-tracking branch 'origin/master' into dev 2022-11-26 03:36:27 +01:00
Álvaro Brey
16023016d7
Merge pull request #11091 from nextcloud/dependabot/gradle/com.diffplug.spotless-6.12.0
Bump com.diffplug.spotless from 6.11.0 to 6.12.0
2022-11-25 14:01:12 +01:00
Tobias Kaminsky
161bc98bde
Merge pull request #11031 from nextcloud/e2eUX
E2e ux
2022-11-25 11:30:43 +01:00
Nextcloud bot
02762bb2f0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-25 08:27:05 +00:00
Nextcloud bot
f6c083ace7
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-25 08:26:49 +00:00
Nextcloud bot
b9cdb01b16
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-25 03:36:17 +00:00
Nextcloud bot
209404f058
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-25 03:35:56 +00:00
Tobias Kaminsky
a5883ef743 daily dev 20221125
Update Nextcloud Android library
2022-11-25 03:40:59 +01:00
dependabot[bot]
766ed4492c
Bump com.diffplug.spotless from 6.11.0 to 6.12.0
Bumps com.diffplug.spotless from 6.11.0 to 6.12.0.

---
updated-dependencies:
- dependency-name: com.diffplug.spotless
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-11-25 02:01:32 +00:00
tobiasKaminsky
393e34d28c
restart SettingsActivity after changing e2e settings
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-24 15:40:26 +01:00
tobiasKaminsky
3f82d37415
revert to master library
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-24 15:40:26 +01:00
tobiasKaminsky
f49252c87e
hide e2e options after removing local e2e setup
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-24 15:40:26 +01:00
Álvaro Brey
b110735dcc
NextcloudDatabase: enable automigration for new db version
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
30d38dee23
Restore database v65 schema from master
Mistakenly changed!

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
0d098255d9
Pass through SetupEncryptionDF result to SettingsActivity
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
6b4d6a6dfd
SettingsActivity: fix conditional to show e2e encrypt option
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
tobiasKaminsky
e3a7453846
properly handle stage 2: key exists, but e2e is not setup on this device
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-24 15:40:26 +01:00
Álvaro Brey
1b945b6131
SetupEncryptionDialogFragment: use builtin onCancel for setting cancel result
This captures back button as well

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
b1b05f740e
SetupEncryptionActivity: give transparent background to make it more seamless
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
09aac00330
SetupEncryptionActivity: finish activity when error happens
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
6568d1d272
Close SetupEncryptionActivity when dialog is dismissed
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
fc446b1deb
Update screenshots for SettingsActivity
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Tobias Kaminsky
9f1f21ee8c
Update app/src/main/res/values/strings.xml
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
2022-11-24 15:40:26 +01:00
tobiasKaminsky
5b4aba11f5
Better show different states of E2E
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-24 15:40:24 +01:00
Tobias Kaminsky
4a6f4707e4 daily dev 20221124 2022-11-24 02:38:15 +01:00
Tobias Kaminsky
1bfee60543 Merge remote-tracking branch 'origin/master' into dev 2022-11-24 02:31:58 +01:00
Álvaro Brey
1c4a1063f1
Merge pull request #10928 from nextcloud/test/calendar-skip-empty
Fix issues with calendar exporting
2022-11-23 22:11:31 +01:00
Álvaro Brey
c938a929c1
Merge pull request #11067 from nextcloud/fix/gallery-crash
GalleryFragment: fix crash when scrolling slowly until the end of the list
2022-11-23 22:10:20 +01:00
Álvaro Brey
f797260f76
Merge pull request #11068 from nextcloud/fix/favorites-back-navigation
FileDisplayActivity: fix drawer menu item when browsing back from favorite folder
2022-11-23 22:08:51 +01:00
Álvaro Brey
eaae4a0f9c
Merge pull request #11069 from nextcloud/fix/video-fullscreen-stuck
Misc fixes for video player
2022-11-23 22:07:43 +01:00
Álvaro Brey
09319ac7c3
Merge pull request #11074 from nextcloud/fix/calendar-backup-wrong-account
CalendarBackupWork: upload to configured account, not current account
2022-11-23 22:06:54 +01:00
Álvaro Brey
b0a3d6cc7e
Merge pull request #11059 from nextcloud/feature/3175/shortcuts_bottombar
Allow Pin to Home with file actions bottom sheet
2022-11-23 18:56:38 +01:00
Álvaro Brey
8c8723c7c5
Bump targetSdk to 32
32 is just a feature release of android 13 and no important changes are documented.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 11:46:14 +01:00
Álvaro Brey
38e83cd03c Keep screen on while video is playing
Fixes #9059

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 10:31:49 +00:00
Álvaro Brey
625ada4c17 Add default error and completion handler to Exoplayer in preview fragment/activity
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 10:31:49 +00:00
Álvaro Brey
250e8129dd
CalendarBackupWork: upload to configured account, not current account
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 11:13:03 +01:00
Álvaro Brey
7d8e37a8a0
FileDisplayActivity: also update sort group after browsing up
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 10:26:16 +01:00
Álvaro Brey
850e9e7ec3 CalendarBackupWork: log amount of calendars
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 08:12:10 +00:00
Álvaro Brey
b3eab117db calendar export: port some changes from upstream
Ignore deleted events, and fix alarm triggers

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 08:12:10 +00:00
Álvaro Brey
008ee4e0cd SaveCalendar: don't try to export empty calendars
Causes crashes

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 08:12:10 +00:00
Nextcloud bot
39f094af95
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-23 03:35:13 +00:00
Nextcloud bot
958a0e30eb
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-23 03:34:56 +00:00
Álvaro Brey
7bf90d364b
FileDisplayActivity: fix drawer menu item when browsing back from favorite folder
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 16:50:42 +01:00
Felix Nüsse
ea2a1a9163 extract string resource
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-22 16:31:15 +01:00
Álvaro Brey
c1ce254692
GalleryFragment: fix crash when scrolling slowly until the end of the list
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 13:52:54 +01:00
Álvaro Brey
8f1369cba2
ShortcutUtil: use system utilities to get pixel size for dimens instead of manually calculating them
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 11:00:12 +01:00
Álvaro Brey
52e1e8cef5
ShortcutUtil: use ShortcutManagerCompat to avoid min SDK requirement
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 10:53:09 +01:00
Álvaro Brey
2e3ef2eace
strings.xml: Remove unused string to appease Lint
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 10:16:07 +01:00
Álvaro Brey
280a92be51
Fix style and static analysis issues
- Rename ShortcutUtils.kt to ShortcutUtil.kt to match contained class
- Remove unused const
- Fix formatting with spotless

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 10:14:27 +01:00
Álvaro Brey
8a24ea03a0
Inject ShortcutUtil instead of manually creating it
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 10:11:02 +01:00
Nextcloud bot
bf328c9430
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-22 03:37:03 +00:00
Nextcloud bot
ca2d593d67
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-22 03:36:46 +00:00
Tobias Kaminsky
e4139af585 daily dev 20221122
Bump detekt-gradle-plugin from 1.21.0 to 1.22.0
Update Nextcloud Android library
Update 3rd-party dependencies
2022-11-22 03:41:11 +01:00
Tobias Kaminsky
b3b9b66917 Merge remote-tracking branch 'origin/master' into dev 2022-11-22 03:35:00 +01:00
Álvaro Brey
619563b34a
Merge pull request #11061 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.22.0
Bump detekt-gradle-plugin from 1.21.0 to 1.22.0
2022-11-21 17:26:27 +01:00
Felix Nüsse
d555847fea extract and explain constant integer values for icon size
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
c19a256a97 Update shortcututils to use existing FolderIcon-function
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
758bfe1e17 Implement errorchecking and remove deprecations as suggested by @AlvaroBrey
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
f81340f63d Add check for version in FileMenuFilter and ActionChoosen()
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
a25069eff3 Remove checks from shortcutUtils and move the same
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
e4d51be54c Update app/src/main/res/values/strings.xml
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
3e5ac3068c Update app/src/main/java/com/owncloud/android/files/FileMenuFilter.java
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
e6c014d832 Update app/src/main/java/com/nextcloud/ui/fileactions/FileAction.kt
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
tobiasKaminsky
64ca4b1858 Check if e2e is available in DocumentsStorageProvider
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-21 11:20:38 +01:00
Nextcloud bot
ee78494df5
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-21 03:27:43 +00:00
Nextcloud bot
f1be37c61a
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-21 03:27:27 +00:00
dependabot[bot]
df3cd0c685
Bump detekt-gradle-plugin from 1.21.0 to 1.22.0
Bumps [detekt-gradle-plugin](https://github.com/detekt/detekt) from 1.21.0 to 1.22.0.
- [Release notes](https://github.com/detekt/detekt/releases)
- [Commits](https://github.com/detekt/detekt/commits)

---
updated-dependencies:
- dependency-name: io.gitlab.arturbosch.detekt:detekt-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-11-21 02:11:42 +00:00
Tobias Kaminsky
e8eef0f736 daily dev 20221121 2022-11-21 02:37:13 +01:00
Tobias Kaminsky
704ee11f7e Merge remote-tracking branch 'origin/master' into dev 2022-11-21 02:31:32 +01:00
Nextcloud bot
f661483e1d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-20 03:29:17 +00:00
Nextcloud bot
5cc64748f1
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-20 03:28:59 +00:00
Felix Nüsse
5b2cc6f2c5 Allow Pin to Home with BottomBarDialog
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-19 14:36:01 +01:00
Álvaro Brey
05b53f2add
Merge pull request #11050 from nextcloud/arbitrary-dao
Use Room DAO instead of ContentProvider for arbitrary data table access
2022-11-19 13:11:41 +01:00
Nextcloud bot
302ce683a7
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-19 03:34:53 +00:00
Nextcloud bot
3871917926
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-19 03:34:35 +00:00
Álvaro Brey
ec4067c199 ArbitraryDataProvider: distinguish between null value and nonexisting entities
Not the same thing!

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-18 10:39:41 +01:00
Álvaro Brey
9c218ed18a Fix nullability of types for ArbitraryDataProvider interface
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-18 10:39:41 +01:00
Álvaro Brey
f490823e4e Extract interface from ArbitraryDataProvider for better decoupling and testing
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-18 10:39:41 +01:00
Álvaro Brey
5499441738 Use Room DAO for ArbitraryDataProvider instead of contentResolver
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-18 10:39:41 +01:00
Nextcloud bot
13071ed5ae
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-18 03:27:40 +00:00
Nextcloud bot
a7a9da4bc2
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-18 03:27:19 +00:00
Tobias Kaminsky
ffdf45afba daily dev 20221118
Update Nextcloud Android library
2022-11-18 02:39:51 +01:00
Tobias Kaminsky
b52cf18d8a Merge remote-tracking branch 'origin/master' into dev 2022-11-18 02:32:54 +01:00
Álvaro Brey
aa355e7efd
Merge pull request #11054 from nextcloud/bump-master-3.24
Bump app version on master to 3.24
2022-11-17 14:49:52 +01:00
Álvaro Brey
ab13b9873c
Merge pull request #11052 from nextcloud/doNotAllowSharedEncryptedFolder
prohibit share of an encrypted folder
2022-11-17 14:47:23 +01:00
Álvaro Brey
b31e3c1061
Bump app version on master to 3.24
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 13:48:43 +01:00
Tobias Kaminsky
1b0a2cce72
also check for shared with me
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
2022-11-17 13:14:37 +01:00
tobiasKaminsky
66746a6b12
prohibit share of an encrypted folder
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-17 12:50:59 +01:00
Álvaro Brey
b78c236a59
chore: Remove unused legacy migration code
This was leftover in the Room PR, where we removed support for DB version <24. As such, all the code supporting those older versions is unused now.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 10:24:47 +01:00
Álvaro Brey
c71ce3a3ee
Add screenshot test for FileActionsBottomSheet
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
a0ac194467
Fix lint
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
f8f0d46633
Fix FileMenuFilterIT
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
7cb85ec6a1
FileActionsBottomSheet: color loading animation with primary color
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
4523537587
File actions bottom sheet: show file thumbnail
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
829c10f9de
Fix FileMenuFilterIT for real
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:59 +01:00
Álvaro Brey
6b470f86bb
Fix mock order for FileMenuFilter
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
422c0a5011
Small spotbugs cleanup
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
a160ccd936
Clean up unused resources
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
b43df7c711
Minor cleanup
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
27e40440db
Fix bottom sheet background for PreviewImageFragment
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
6d97bd5145
Remove obsolete TODOs
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
36f918da7e
Fix icon tinting for fake placeholder menu iteFix icon tinting for fake placeholder menu itemm
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
0cc2e6875d
FileActionsBottomSheet: parse arguments in ViewModel, handle errors
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:58 +01:00
Álvaro Brey
702a9cedf0
FileActionsBottomSheet: fix things that were parameters, but shouldn't
- Result listener should be done through the fragmentResultListener API
- ComponentsGetter is attached on onAttach

This avoids crashes on config changes, etc

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
263d139fe2
FileMenuFilter: simplify and remove unneeded stuff for new approach
We're always starting from the full list and removing stuff now, so toShow makes no sense

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
7c53e77e57
FileActionsBottomSheet: additional filtering in FileDetailFragment
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
dd94167733
FileActionsBottomSheet: show loading animation, load items in background
Since we're going to load the files in background too, it's a good idea to start doing this already

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
0e0935bef6
FileActionsBottomSheet: add drag handle for accesibility
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
5ff16b9ba5
Show lock info in bottom sheet
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
1aa248d1bf
FileActionsBottomSheet: Display file name or file count as bottom sheet title
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
e7ff6df581
FileActionsBottomSheet: make scrollable in case full list doesn't fit in screen
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
a1265bdae7
FileActionsBottomSheet: handle additional filtering for preview fragments
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:57 +01:00
Álvaro Brey
689a4bda6a
Extract responsibilities from FileMenuFilter static methods to utility classes.
God class count -= 1

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:56 +01:00
Álvaro Brey
e41d474e89
FileActionsBottomSheet: use ViewModel
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:46 +01:00
Álvaro Brey
5b628f520c
Set icons for file actions
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-17 09:13:09 +01:00