mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-12-18 15:01:57 +03:00
Code Issues Projects Releases Packages Wiki Activity
10908 commits 221 branches 1585 tags 637 MiB
Commit graph

6689 commits

Author SHA1 Message Date
Hari
6625d4f3b7
Fix crash when no credentials are available 2018-06-10 21:36:21 +02:00
Hari
4cd916848b
Disable lock after user confirms credentials 2018-06-10 21:36:21 +02:00
Hari
62ceb226f6
Fix codestyle and follow suggestions 2018-06-10 21:36:20 +02:00
Hari
a832abd87e
Remove fingerprint authentication 2018-06-10 21:36:20 +02:00
Hari
9e6dfb644c
Add support for default credentials 2018-06-10 21:36:19 +02:00
Andy Scherzinger
8c8832991f
Merge pull request #2682 from nextcloud/filedetailsactivity-cleanup 
ui:fragment: Use isEmpty() to check if list of activities is empty.
 2018-06-10 21:34:26 +02:00
Nextcloud bot
3c3eeeb986
[tx-robot] updated from transifex 2018-06-10 00:47:45 +00:00
eho
d5b500559e fragment:util: Added private constructor to hide the inherit public one 
Utility classes, which are collections of static members, are not meant to be instantiated.

Java adds an implicit public constructor to every class which does not define at least one explicitly. Hence, at least one non-public constructor should be defined.
 2018-06-09 23:06:12 +02:00
eho
06e85e8819 ui:fragment Inverted if-statement for increased readability. 2018-06-09 22:56:10 +02:00
Andy Scherzinger
9d963cec33
Merge pull request #2686 from nextcloud/correctException 
Use correct exception
 2018-06-09 18:55:48 +02:00
AndyScherzinger
fb094e7628
renamed due to CR 2018-06-09 14:23:17 +02:00
AndyScherzinger
eb6821dc25
codacy: organize imports 2018-06-09 14:23:17 +02:00
AndyScherzinger
f863ea9adc
extract UI init and show/hide parts in separate methods for a better overview 2018-06-09 14:23:16 +02:00
AndyScherzinger
7fb487f717
remove unused import 2018-06-09 14:23:16 +02:00
AndyScherzinger
05a0167255
extract open file intent creation into a separate method 2018-06-09 14:23:15 +02:00
AndyScherzinger
7d4a2ecfa8
change call order to not create unneeded objects before the checks haven't succeeded 2018-06-09 14:23:15 +02:00
AndyScherzinger
015aa06d79
use a more specific input param 2018-06-09 14:23:14 +02:00
AndyScherzinger
d663535ce6
extract credentials update notification 2018-06-09 14:23:14 +02:00
Andy Scherzinger
080acb2f8e
Merge pull request #2694 from nextcloud/whiteBadge 
Tint badge to element color
 2018-06-09 14:22:33 +02:00
tobiasKaminsky
59f1253a86
do not use static context 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-06-09 13:35:15 +02:00
Nextcloud bot
fe4b113b80
[tx-robot] updated from transifex 2018-06-09 00:47:24 +00:00
Nextcloud bot
711dd895e2
[tx-robot] updated from transifex 2018-06-08 00:47:35 +00:00
tobiasKaminsky
537a3b7eb9
tint badge to element color 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-06-07 14:57:21 +02:00
Nextcloud bot
bc374c8741
[tx-robot] updated from transifex 2018-06-07 00:46:20 +00:00
AndyScherzinger
c439e84880
make sort by date package private 2018-06-06 14:38:52 +02:00
AndyScherzinger
34568caba7
120character print margin 2018-06-06 14:37:46 +02:00
AndyScherzinger
9ce8b19aed
use method expression lambdas to further shorten the code 2018-06-06 14:37:00 +02:00
AndyScherzinger
379c461f33
Also use lambda for sorting 2018-06-06 14:33:05 +02:00
eho
51eab2457d
util: Use lambdas where applicable in the FileSortOrderByName/Size classes. 2018-06-06 14:27:51 +02:00
eho
754419090d
util: Made FileSortOrderByName and FileSortOrderBySize package private. 
- Follows principle of least privilege.
 2018-06-06 14:27:51 +02:00
Nextcloud bot
bb9a6a5364
[tx-robot] updated from transifex 2018-06-06 00:47:06 +00:00
Andy Scherzinger
0b2c986c0f
Merge pull request #2648 from nextcloud/resumeDetailView 
File detail view: store file/account when suspending fragments
 2018-06-05 16:39:26 +02:00
tobiasKaminsky
60a0df7020
use correct exception 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-06-05 14:52:12 +02:00
tobiasKaminsky
b4b1790ef6
Use context instead of static getAppContext 2018-06-05 13:19:17 +02:00
AndyScherzinger
c5e5868eec
ignore restricted API lint error for tinting a spinner icon 2018-06-05 12:58:42 +02:00
AndyScherzinger
119b8a5943
fix zip icon tinting after rebase 2018-06-05 12:46:37 +02:00
tobiasKaminsky
7ae333635a
tint search view in upload activity 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-06-05 12:35:02 +02:00
tobiasKaminsky
df01428150
tint spinner 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-06-05 12:35:02 +02:00
tobiasKaminsky
ebb04db951
tint action bar icon 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-06-05 12:35:01 +02:00
tobiasKaminsky
1c6fec7192
tint remove file dialog buttons 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-06-05 12:35:01 +02:00
tobiasKaminsky
8b2d082d32
tint pin elements 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-06-05 12:35:00 +02:00
tobiasKaminsky
9bb708dd08
tint "report button" 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-06-05 12:35:00 +02:00
tobiasKaminsky
b13a3ae680
tint also upload file list 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-06-05 12:34:59 +02:00
tobiasKaminsky
c32e47f4ce
White theming 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-06-05 12:34:51 +02:00
Mario Đanić
b48a6e8d8e
Merge pull request #2626 from nextcloud/menuHelper 
Shorten code and improve readability via a menu helper
 2018-06-05 07:56:06 +02:00
Mario Đanić
c5bca087f2
Merge pull request #2631 from nextcloud/tintZip 
tint zip icon same as folder icon
 2018-06-05 07:55:00 +02:00
Mario Đanić
648b02ee8a
Merge pull request #2649 from nextcloud/finishPreferences 
Explicitly finish preferences
 2018-06-05 07:53:40 +02:00
Mario Đanić
f123c269f0
Merge pull request #2651 from nextcloud/resultOnStoppedAsync 
Do not process result of async task if activity is stopped
 2018-06-05 07:53:09 +02:00
Mario Đanić
2d4cb825f9
Merge pull request #2661 from nextcloud/rewordEmptyActivity 
Reword empty activity message
 2018-06-05 07:52:31 +02:00
eho
62fe30134c util: Added @Override annotation where applicable. 
Using the @Override annotation is useful for two reasons :

It elicits a warning from the compiler if the annotated method doesn't actually override anything, as in the case of a misspelling.
It improves the readability of the source code by making it obvious that methods are overridden.
 2018-06-04 16:10:08 +02:00
eho
b1e032cd6c ui:fragment: Use isEmpty() to check if list of activities is empty. 
Using Collection.size() to test for emptiness works, but using Collection.isEmpty() makes the code more readable and can be more performant
 2018-06-04 16:07:29 +02:00
AndyScherzinger
4c6ffea5e4
massively shorten code and improve readability via a menu helper 2018-06-04 15:21:59 +02:00
AndyScherzinger
eb7e5f735d
lint: ignore setJavaScriptEnabled 2018-06-04 13:20:33 +02:00
AndyScherzinger
afc32f1cf1
fix he->iw and id->in 2018-06-02 22:23:21 +02:00
Nextcloud bot
18755ba08c
[tx-robot] updated from transifex 2018-06-02 00:45:28 +00:00
Nextcloud bot
f7f988bc15
[tx-robot] updated from transifex 2018-05-31 00:47:30 +00:00
tobiasKaminsky
6cf37f3a0d
reword empty activity 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-30 13:45:50 +02:00
tobiasKaminsky
8d7b16b3ca
do not process result of async task if activity is stopped 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-30 11:07:34 +02:00
Andy Scherzinger
8c5f564253
Merge pull request #2650 from nextcloud/explicitAllowGCM 
Explicitly allow gcm on gplay
 2018-05-30 10:32:22 +02:00
tobiasKaminsky
c1b1bc8fab
explicitly allow gcm on gplay 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-30 09:25:43 +02:00
tobiasKaminsky
7f28bad63e
explicitly finish preferences 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-30 08:23:49 +02:00
tobiasKaminsky
e718f49dea
store file/account when suspending fragments 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-30 07:29:52 +02:00
tobiasKaminsky
cf8478b80d
as we use singleTop, we shall not start a new activity 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-30 06:34:11 +02:00
Nextcloud bot
d598c3afcf
[tx-robot] updated from transifex 2018-05-30 00:47:59 +00:00
Nextcloud bot
455a92849f
[tx-robot] updated from transifex 2018-05-29 11:28:08 +00:00
Nextcloud bot
46fb12a68f
[tx-robot] updated from transifex 2018-05-29 10:02:22 +00:00
AndyScherzinger
058eff9627
restore prematurely deleted strings 2018-05-29 11:38:59 +02:00
Nextcloud bot
9a65471805
[tx-robot] updated from transifex 2018-05-29 09:05:28 +00:00
AndyScherzinger
ba0aff41a7
Fix comment again 2018-05-29 09:14:22 +02:00
AndyScherzinger
c3209d817d
fix further review comments 2018-05-29 09:13:09 +02:00
AndyScherzinger
84401e73a7
fix menu filter 2018-05-29 09:01:41 +02:00
AndyScherzinger
f731e4d59b
java imports, unused java been removed... 2018-05-29 08:38:58 +02:00
AndyScherzinger
cf1b8f8f85
Fix theming issue with date picker dialog 2018-05-29 08:31:50 +02:00
AndyScherzinger
892db9f689
raise font size on file name 2018-05-29 07:58:41 +02:00
AndyScherzinger
d72eb2a4b7
fix codacy 2018-05-29 07:58:41 +02:00
AndyScherzinger
a3daf0642e
fix lint again 2018-05-29 07:58:41 +02:00
AndyScherzinger
f201a2dd66
first changes due to designers review 2018-05-29 07:58:40 +02:00
AndyScherzinger
d8c4be0604
fix lint for item divider, plus code formatting 2018-05-29 07:58:39 +02:00
AndyScherzinger
952db5a34b
added javaDoc for public methods 2018-05-29 07:58:39 +02:00
AndyScherzinger
5154280f00
fix refreshing OC file list after sharing info changes 2018-05-29 07:58:38 +02:00
AndyScherzinger
5c4a450b11
use file details sharing tab for files also via the share bottom sheet (only if FileDisplayActivity is the parent) 2018-05-29 07:58:38 +02:00
AndyScherzinger
abc2be7a23
further shortened the label 2018-05-29 07:58:37 +02:00
AndyScherzinger
f2edf5a7f5
shorten edit label 2018-05-29 07:58:37 +02:00
AndyScherzinger
90a129d232
use nicer UI element names 2018-05-29 07:58:36 +02:00
AndyScherzinger
e7a0f493f2
rewrite sharee list to recycler view, show can edit in list items 2018-05-29 07:58:36 +02:00
AndyScherzinger
c738d9e46a
optimize layout/design 2018-05-29 07:58:35 +02:00
AndyScherzinger
48992266fa
minor size optimizations 2018-05-29 07:58:35 +02:00
AndyScherzinger
cb6c56e391
save accent color 2018-05-29 07:58:34 +02:00
AndyScherzinger
ab973579cb
remove method call of formerly dropped method 2018-05-29 07:58:33 +02:00
AndyScherzinger
20d0307ca7
use general fallback theming for popup menu (checkable menu items) 2018-05-29 07:58:32 +02:00
AndyScherzinger
9e0e83872b
update license headers 2018-05-29 07:58:32 +02:00
AndyScherzinger
a00b89f972
add javaDoc comment 2018-05-29 07:58:31 +02:00
AndyScherzinger
42a0e28ee7
add ability to set expiration date for user shares 2018-05-29 07:58:31 +02:00
AndyScherzinger
2d55824cf6
fix name and javaDoc of updateMethod 2018-05-29 07:58:30 +02:00
AndyScherzinger
bb7c090d6e
remove unused legacy method 2018-05-29 07:58:30 +02:00
AndyScherzinger
d08a944b10
hide sync for folders 2018-05-29 07:58:29 +02:00
AndyScherzinger
f2dd5ea2a6
proper error snackbars for sharing errors, move feed back results to the sharing fragment+refresh 2018-05-29 07:58:29 +02:00
tobiasKaminsky
cab6555703
app restarts now after account switching 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-29 07:58:28 +02:00
tobiasKaminsky
d0b9d58ec8
account switch on drawer without "singleTop" works again 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-29 07:58:28 +02:00
AndyScherzinger
17093482fb
sort menu items according to webUI 2018-05-29 07:58:27 +02:00
AndyScherzinger
0e41ed7889
Use AppCompat checkbox 2018-05-29 07:58:27 +02:00
tobiasKaminsky
cc8914ed0f
type, code formatting 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-29 07:58:26 +02:00
AndyScherzinger
dba1042369
remove unused string 2018-05-29 07:58:26 +02:00
AndyScherzinger
b3f980c99d
show proper error view if activities failed to load 2018-05-29 07:58:25 +02:00
AndyScherzinger
d0dbc9e36a
remove unused import 2018-05-29 07:58:25 +02:00
AndyScherzinger
0a545dd9a6
fix NPEs in calling UI thread and within UI threads 2018-05-29 07:58:25 +02:00
AndyScherzinger
de51ba1aca
remove legacy code after refactoring to a helper class 2018-05-29 07:58:24 +02:00
AndyScherzinger
431549e66e
slice filter menu method 2018-05-29 07:58:24 +02:00
AndyScherzinger
fe234cd942
open file details with sharing tab active for folders 2018-05-29 07:58:23 +02:00
AndyScherzinger
5ea05288eb
cleanup + fix lint issues 2018-05-29 07:58:22 +02:00
AndyScherzinger
5f64479d30
add the ability to set expiration date on shares not just links 2018-05-29 07:58:22 +02:00
AndyScherzinger
7f85bffa93
fix codacy + revert to handling name-to-color exceptions 2018-05-29 07:58:21 +02:00
AndyScherzinger
1a32758e27
implement changes sharing data / fixed unsetting of exp. date 2018-05-29 07:58:21 +02:00
AndyScherzinger
7800d33ff5
move stuff to helper class 2018-05-29 07:58:20 +02:00
AndyScherzinger
8397a48dde
hide file listing option if share is not editable 2018-05-29 07:58:20 +02:00
AndyScherzinger
b7b7237d69
fix flag detection 2018-05-29 07:58:19 +02:00
AndyScherzinger
236924ccc2
add hide file listing 2018-05-29 07:58:19 +02:00
AndyScherzinger
f5d9af71b9
WiP expiration Date, permission text calculation 2018-05-29 07:58:18 +02:00
AndyScherzinger
072e646552
reformatted code for line length 120 2018-05-29 07:58:18 +02:00
AndyScherzinger
607bc12b56
add unset of password for share link 2018-05-29 07:58:17 +02:00
tobiasKaminsky
391368947c
add sharee works 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-29 07:58:17 +02:00
AndyScherzinger
362061bef3
fixed 2 NPEs 2018-05-29 07:58:17 +02:00
AndyScherzinger
d7e8f6141a
WiP share link functionality 2018-05-29 07:58:16 +02:00
AndyScherzinger
1a99f655b1
add content description to preview image 2018-05-29 07:58:16 +02:00
AndyScherzinger
a0b74069fa
replace anonymous classes with lambdas 2018-05-29 07:58:15 +02:00
AndyScherzinger
4a22b932b1
fix send menu action + send/share dialog extension 2018-05-29 07:58:15 +02:00
AndyScherzinger
11edb451b0
use own, distinct menu definition, fix strings, use relative date 2018-05-29 07:58:14 +02:00
tobiasKaminsky
90529c5841
fix not needed try/catch blocks 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-29 07:58:14 +02:00
tobiasKaminsky
5589b8c0e9
add avatar icons on sharee list 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-29 07:58:13 +02:00
AndyScherzinger
a29d73102b
fix theming issue 2018-05-29 07:58:13 +02:00
AndyScherzinger
a2c0b180ec
lint: Inefficient layout weight 2018-05-29 07:58:12 +02:00
AndyScherzinger
27d04c8823
organize imports 2018-05-29 07:58:12 +02:00
AndyScherzinger
2c30e3842f
Wip user/group search (not fully working yet) 2018-05-29 07:58:11 +02:00
AndyScherzinger
72681e95b2
add proper permission editing for folders 2018-05-29 07:58:11 +02:00
AndyScherzinger
5054df0ba3
updating of permissions for file/folder (folder not reachable yet) 2018-05-29 07:58:10 +02:00
AndyScherzinger
5200dd0881
WiP permission handling (Don't use for productive shares yet!) 2018-05-29 07:58:10 +02:00
AndyScherzinger
c86f007601
add listener interface + organized imports 2018-05-29 07:58:09 +02:00
AndyScherzinger
cd200b2e9f
empty menu implementation per sharee 2018-05-29 07:58:09 +02:00
AndyScherzinger
c9328dcc25
add new lines 2018-05-29 07:58:08 +02:00
AndyScherzinger
6831678051
butterknife for the sharing tabs of file details 2018-05-29 07:58:08 +02:00
AndyScherzinger
23fb0ef264
lambda: use method reference 2018-05-29 07:58:07 +02:00
AndyScherzinger
6bb7dc86c7
butterknife for details fragment + proper empty content handling 2018-05-29 07:58:07 +02:00
Nextcloud bot
59dca8f7db
[tx-robot] updated from transifex 2018-05-29 00:47:01 +00:00
tobiasKaminsky
364c92cfcc
tint zip icon same as folder icon 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-28 14:28:00 +02:00
Nextcloud bot
c6ef1607af
[tx-robot] updated from transifex 2018-05-28 00:47:46 +00:00
Nextcloud bot
ca38015e38
[tx-robot] updated from transifex 2018-05-26 00:52:14 +00:00
Andy Scherzinger
27b503d2cd
Merge pull request #2622 from nextcloud/preview-bitmap-npe 
ui:preview Verify that bitmap is not null before setting imageDrawable.
 2018-05-25 12:59:28 +02:00
Andy Scherzinger
cc96f3aa1a
Merge pull request #2621 from nextcloud/activity-return-null 
ui:activity: Removed @NonNull annotation for method where null can be returned
 2018-05-25 11:56:18 +02:00
Andy Scherzinger
a56885f477
Merge pull request #2619 from nextcloud/manageaccounts-unused-override 
ui:activity Removed unused override method in ManageAccountsActivity
 2018-05-25 11:55:30 +02:00
AndyScherzinger
427664d7ce
Cleanup unused code, housekeeping post #2616 (codacy hasn't detected the unused code...) 2018-05-25 10:08:51 +02:00
eho
ca46f6ed6b ui:preview Verify that bitmap is not null before setting imageDrawable. 
A reference to null should never be dereferenced/accessed. Doing so will cause a NullPointerException to be thrown
 2018-05-25 09:51:45 +02:00
eho
324382dcc0 ui:activity: Removed @NonNull annotation for method where null can be returned. 
The return value is marked @NonNull and is therefore assumed to only return non-null values. Therefore setting one of these values to null, or failing to set such a class field in a constructor, could cause NullPointerExceptions at runtime. In this case, view might be null.
 2018-05-25 09:46:03 +02:00
eho
384b86b205 ui:activity Removed unused override method 
Overriding a method just to call the same method from the super class without performing any other actions is useless and misleading.
 2018-05-25 09:32:59 +02:00
Nextcloud bot
989ec9e0e2
[tx-robot] updated from transifex 2018-05-25 00:53:41 +00:00
Andy Scherzinger
38e19c99c7
Merge pull request #2613 from nextcloud/overflowMenu 
setting the menu item order according to the webUI
 2018-05-24 18:50:56 +02:00
AndyScherzinger
bd7c54eb06
fix fav menu item texts 2018-05-24 18:10:03 +02:00
Tobias Kaminsky
4665fee915
Merge 6256d21aa6 into cd315095d1 2018-05-24 12:35:28 +00:00
tobiasKaminsky
6256d21aa6
Remove analytics 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-24 14:34:08 +02:00
AndyScherzinger
a2f1aafca3
Revert "add null check" 
This reverts commit e55f0e43b9.
 2018-05-24 13:52:54 +02:00
AndyScherzinger
e55f0e43b9
add null check 2018-05-24 13:23:27 +02:00
AndyScherzinger
d00935bd70
codacy: remove unused import 2018-05-24 13:16:16 +02:00
AndyScherzinger
cd3953b32f
remove unused orderCategory 2018-05-24 13:06:30 +02:00
AndyScherzinger
caddb104b4
Fixes #1749 setting the menu item order according to the webUI 2018-05-24 12:50:25 +02:00
Nextcloud bot
cd315095d1
[tx-robot] updated from transifex 2018-05-24 00:53:17 +00:00
Andy Scherzinger
031a0a242c
Merge pull request #2603 from nextcloud/disable-analytics-via-manifest 
Disable analytics via manifest
 2018-05-23 19:18:51 +02:00
Andy Scherzinger
8c754f5987
Merge pull request #2312 from nextcloud/integrationTests 
Add support for integration tests
 2018-05-23 18:51:34 +02:00
Mario Danic
d727b72a65
Disable analytics via manifest 
Signed-off-by: Mario Danic <mario@lovelyhq.com>
 2018-05-23 16:35:52 +02:00
tobiasKaminsky
ebdd4207ed
move disabled tests to its own package 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-23 08:58:21 +02:00
AndyScherzinger
a733f515ed
ownCloud->Nextcloud + new line 2018-05-23 08:51:36 +02:00
tobiasKaminsky
76d3747748
Add support for integration tests 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-23 08:51:35 +02:00
Mario Đanić
51dca0208a
Merge pull request #2490 from nextcloud/fixDoubleSearch 
Fix double search
 2018-05-23 08:50:54 +02:00
Nextcloud bot
aac3f6a21a
[tx-robot] updated from transifex 2018-05-23 00:53:24 +00:00
tobiasKaminsky
378626c9a9
fix double search 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-23 00:45:07 +02:00
Tobias Kaminsky
2c1ac42ff1
Merge pull request #2501 from nextcloud/userIdForWebdavSearch 
Use userId for webdav search
 2018-05-22 12:56:51 +02:00
Andy Scherzinger
1a193d765d
Merge pull request #2520 from nextcloud/doNotSortOnGetFolderContent 
Do not sort on getFolderContent
 2018-05-22 11:40:32 +02:00
Andy Scherzinger
3e08819215
Merge pull request #2544 from nextcloud/whiteBrander 
Brander with white primary color
 2018-05-22 11:36:59 +02:00
Tobias Kaminsky
6883098a1c
Merge pull request #2599 from nextcloud/2596-previewnavigation-overlap 
res:styles: Don't use a translucent navigation bar in the Preview activity
 2018-05-22 11:29:13 +02:00
Mario Đanić
e76824a872
Merge pull request #2600 from nextcloud/previewimagefragment-cleanup 
Minor cleanup of the PreviewImageFragment
 2018-05-22 11:17:49 +02:00
eho
5b68a221e9 datamodel: Don't try to be smarter than the JVM by calling the garbage collector. 
Calling System.gc() or Runtime.getRuntime().gc() is a bad idea for a simple reason: there is no way to know exactly what will be done under the hood by the JVM because the behavior will depend on its vendor, version and options:

Will the whole application be frozen during the call?
Is the -XX:DisableExplicitGC option activated?
Will the JVM simply ignore the call?

An application relying on these unpredictable methods is also unpredictable and therefore broken. The task of running the garbage collector should be left exclusively to the JVM.
 2018-05-22 11:16:23 +02:00
eho
f0b31af089 ui:preview Removed useless call to System.gc(). 
Calling System.gc() or Runtime.getRuntime().gc() is a bad idea for a simple reason: there is no way to know exactly what will be done under the hood by the JVM because the behavior will depend on its vendor, version and options.
 2018-05-22 11:14:33 +02:00
eho
e7d53a94e5 ui:preview Added final modifiers to applicable declarations. 2018-05-22 11:05:07 +02:00
eho
4ebf83fce6 ui:preview Simplified lambda expressions. 2018-05-22 11:04:13 +02:00
eho
9ecdcdd613 ui:preview Removed unused import. 2018-05-22 11:03:39 +02:00
eho
1896ffe66e ui:preview Removed single-use downloadFile() method. 2018-05-22 11:03:22 +02:00
eho
158451d316 ui:preview Removed unused public method switchToFullScreen() 2018-05-22 10:53:20 +02:00
eho
044b59c2f2 ui:preview Moved full screen toggle code to dedicated method. 
Reduces duplicate code.
 2018-05-22 10:53:00 +02:00
Mario Đanić
f2039686f4
Merge pull request #2602 from nextcloud/ui-preview-checkerboardrefactor 
ui:preview Simplified generateCheckerboardLayeredDrawable()
 2018-05-22 10:37:53 +02:00
eho
0ae79863e5 ui:preview Simplified layerDrawable dimension calculation even further. 2018-05-22 10:36:49 +02:00
eho
e61aa30b6f ui:preview Simplified layerDrawable dimension calculation. 2018-05-22 10:30:26 +02:00
Nextcloud bot
4f8669d6d4
[tx-robot] updated from transifex 2018-05-22 00:48:17 +00:00
eho
ab13851438 ui:preview Ensure getActivity() is not null before generating LayerDrawable. 2018-05-21 22:15:33 +02:00
eho
71466768f7 ui:preview Replaced setLayerHeight and setLayerWidth calls with setLayerSize(). 
Saves a few lines of code. Always a good thing.
 2018-05-21 22:14:32 +02:00
AndyScherzinger
637fc68581
reformat layouts due to review 2018-05-21 19:51:50 +02:00
eho
d5d6a6b4fd ui:preview Replaced anonymous types with lambdas. 2018-05-21 19:21:20 +02:00
eho
ea769e3ff7 ui:preview: Removed unused @Override method so that we simply inherit it. 
Overriding a method just to call the same method from the super class without performing any other actions is useless and misleading.
 2018-05-21 19:20:48 +02:00
eho
fdce4339a9 ui:preview Adjusted access declarations. Follow the principle of least privileged. 2018-05-21 19:19:29 +02:00
eho
a78ab4ba97 ui:preview Removed redundant variable. 2018-05-21 19:18:59 +02:00
eho
572ff50943 res:styles: Don't use a translucent navigation bar. 
This causes view elements at the bottom to overlap with the navigation bar which makes it impossible to interact with said elements.
 2018-05-21 19:13:21 +02:00
AndyScherzinger
86d60238fe
codacy: organize imports 2018-05-21 12:48:35 +02:00
tobiasKaminsky
77c253f48d
add ripple effect 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-21 12:48:35 +02:00