Commit graph

3807 commits

Author SHA1 Message Date
Nextcloud bot
9a1158d5a0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-14 04:18:12 +00:00
Chris Narkiewicz
edc8149c1f
Migrate Account to User in some APIs
Migrate remaining Account uses to User model when it was
possible without wider refactoring.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2022-06-13 23:37:16 +01:00
Ole Bittner
190cd24d3a
check for account in onResume mixin
Signed-off-by: Ole Bittner <dev@oleb.it>
2022-06-13 23:28:20 +02:00
tobiasKaminsky
60757a1853
Groupfolders cannot be encrypted
added test showing folder types

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-06-13 16:17:28 +02:00
Tobias Kaminsky
7854d48559
Merge pull request #10367 from nextcloud/moveMD5
move md5 function to tests, as md5 should never be used is production
2022-06-13 14:38:10 +02:00
Álvaro Brey
43215a0833 FileDetailsSharingProcessFragment: clean up last detekt issues
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-06-13 10:51:38 +00:00
Nextcloud bot
c56ccc8363
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-12 04:18:20 +00:00
Álvaro Brey
d432c8e46f
Merge pull request #10359 from nextcloud/enterCreatedFolder
When copy/move a file and creating a new folder we now go directly into this freshly created folder
2022-06-10 15:58:52 +02:00
Álvaro Brey
0f8a5b1bf3
Merge pull request #10353 from nextcloud/fix/invalid-folder-no-mediascan
FileDataStorageManager: don't add files to media scan in android 11+
2022-06-10 15:56:40 +02:00
Álvaro Brey
ede4790927
Merge pull request #10352 from nextcloud/fix/oob-gallery-scroll
GalleryFastScrollViewHelper: fix index out of bounds in getScrollOffset
2022-06-10 13:59:59 +02:00
tobiasKaminsky
ffdb26b4be
move md5 function to tests, as md5 should never be used is production
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-06-10 07:57:44 +02:00
Álvaro Brey
e644b12aee
Merge pull request #10355 from nextcloud/fix/synced-folders-adapter-performance
SyncedFoldersActivity: don't refresh entire adapter when toggling a folder from dialog
2022-06-09 11:44:07 +02:00
Tobias Kaminsky
266e45b098
Merge pull request #10343 from nextcloud/fix/community-report
Use different link for automated bugreport and manual report
2022-06-09 09:50:52 +02:00
tobiasKaminsky
67cb25a603
When copy/move a file and creating a new folder we now go directly into this freshly created folder
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-06-09 09:12:32 +02:00
Nextcloud bot
5538a5e734
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-09 04:22:28 +00:00
Álvaro Brey
fb4eaf11ff
SyncedFoldersActivity: don't refresh entire adapter when toggling a folder from dialog
It's enough to refresh its header, and it doesn't have to refresh all pictures

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-06-08 16:54:20 +02:00
Álvaro Brey
306bcb09ef
Merge pull request #10348 from nextcloud/file-uploader-downloader-migration-to-user
Migrate some FileUploader and FileDownloader APIs to User
2022-06-08 09:38:50 +02:00
Nextcloud bot
f6bb42141e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-08 04:24:38 +00:00
Chris Narkiewicz
1d81a705bf
Migrate some FileUploader and FileDownloader APIs to User
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2022-06-07 20:56:43 +01:00
Álvaro Brey
c9933d558e
FileDataStorageManager: don't add files to media scan in android 11+
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-06-07 10:20:17 +02:00
Álvaro Brey
301d9ae9a9
GalleryFastScrollViewHelper: fix index out of bounds in getScrollOffset
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-06-07 10:03:12 +02:00
Álvaro Brey
5944bfabdd
Merge pull request #10209 from nextcloud/migrate-remote-operation-execute-to-user
Migrate RemoteOperation.execute calls to User
2022-06-06 13:10:37 +02:00
Álvaro Brey
6f6bed084c
Use different link for automated bugreport and manual report
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-06-06 10:02:55 +02:00
Nextcloud bot
721f63971a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-06 04:25:53 +00:00
Chris Narkiewicz
35e164fa2d
Migrate RemoteOperation.execute calls to User
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2022-06-04 23:59:50 +01:00
Nextcloud bot
bd5a99a10e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-04 04:22:45 +00:00
Tobias Kaminsky
3fd8928327
Merge pull request #10307 from nextcloud/fix/choosetemplate-button-nullpointer
Fix NPE in ChooseTemplateDialogFragment
2022-06-03 07:29:32 +02:00
Álvaro Brey
4011fa7b7d
Exclude all activities except AuthenticatorActivity from security key listener (#10311)
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-06-03 07:28:27 +02:00
Álvaro Brey
0767e4fe43 GalleryAdapter: cleanup index out of bounds 2022-06-01 07:28:17 +00:00
tobiasKaminsky
0748ba19af Harden thumbnail generation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-06-01 07:28:17 +00:00
Nextcloud bot
d971d0a619
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-01 04:24:28 +00:00
Álvaro Brey
51aa8cbd35 ChooseTemplateDialogFragment: convert to Kotlin
Since I'm here...

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-31 09:34:18 +00:00
Álvaro Brey
3ce883466b Fix NPE in ChooseTemplateDialogFragment.checkEnablingCreateButton
This method can be called before positiveButton is initialized

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-31 09:34:18 +00:00
Nextcloud bot
d51a9426d4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-27 04:16:05 +00:00
Nextcloud bot
a13c4c1906
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-26 04:16:47 +00:00
Tobias Kaminsky
c1cf416872
Merge pull request #10148 from nextcloud/proseMirror
Test proseMirror with custom user agent
2022-05-25 15:40:54 +02:00
Nextcloud bot
78e689b2f1
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-25 04:51:04 +00:00
Nextcloud bot
2a3bc3b0dc
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-24 04:30:55 +00:00
Nextcloud bot
ea16420d37
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-23 04:15:15 +00:00
Nextcloud bot
748f2ac903
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-22 04:17:24 +00:00
tobiasKaminsky
8bd3243238
Do not set custom user agent for Text/ProseMirror
Use EditorUtils

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-05-20 11:39:38 +02:00
Nextcloud bot
294db08117
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-16 04:11:57 +00:00
Nextcloud bot
f3b80053f6
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-15 04:11:12 +00:00
Tobias Kaminsky
bd4b35d41b
Merge pull request #10228 from nextcloud/fix/getpopuptext-crash
OCFileListAdapter: skip popup text generation if no sortOrder is present
2022-05-12 12:22:27 +02:00
Álvaro Brey
b2630f532a
SetStatusDialogFragment: fix EmojiPopup after API changes
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-12 09:29:12 +02:00
tobiasKaminsky
6704bb0427
Fix Notification -> on device navigation path
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-05-12 09:26:14 +02:00
Álvaro Brey
0a1736dc75
OCFileListAdapter: skip popup text generation if no sortOrder is present
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-11 15:28:29 +02:00
Nextcloud bot
4cab92f48e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-10 04:24:14 +00:00
Álvaro Brey
e7ea566bb6
Merge pull request #10217 from nextcloud/fix/on-device-crash
Fix crash when navigating from Gallery to On device
2022-05-09 15:03:34 +02:00
Álvaro Brey Vilas
62d58d0a36
Fix and enable FDAScreenshotIT.showMediaThenAllFiles
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-09 13:24:33 +02:00
Álvaro Brey
1955e46a10
Fix crash when navigating from Gallery to On device
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-09 13:15:36 +02:00
Álvaro Brey
91efa194c1
Merge pull request #10191 from nextcloud/fix/some-detekt
Fix a bunch of Detekt issues
2022-05-09 10:04:47 +02:00
Álvaro Brey
454f7c6b96
Merge pull request #10168 from pelzvieh/patch-1
Make SAF root IDs stable through server version updates
2022-05-09 10:03:27 +02:00
tobiasKaminsky
c0c094c30e
Play video in gallery
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-05-09 08:17:12 +02:00
Nextcloud bot
0649f787b8
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-09 04:12:54 +00:00
Nextcloud bot
55cffc80d1
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-08 04:11:49 +00:00
Nextcloud bot
51eb6e8620
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-07 04:09:35 +00:00
Álvaro Brey
8ef80aa105
Fix DocumentsStorageProviderIT for new root ID
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-06 18:16:11 +02:00
Álvaro Brey
fb1469aeea
UriUtils: refactor to keep detekt happy
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-06 18:06:51 +02:00
Álvaro Brey
6297742f01
SyncedFoldersActivity: suppress detekt warning
This entire class is legacy and should be refactored

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-06 18:00:01 +02:00
Álvaro Brey
7adadbb53c
SetStatusDialogFragment: some easy & safe cleanups
Make detekt happy

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-06 17:57:43 +02:00
Álvaro Brey
9cff9725fc
HttpStreamFetcher: reduce nesting in loadData
Make detekt happy

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-06 17:22:18 +02:00
Álvaro Brey
02f23f326d
DocumentsStorageProvider: hash the accountName for rootId map
This should handle the fact that accountNames are of arbitrary length

MD5 is fine for this, as it should be quicker than SHA and the chance of collisions here is very low

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-06 17:05:53 +02:00
Álvaro Brey
3b3d23ff0a
DocumentsStorageProvider: fix build error due to missing import
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-06 17:05:34 +02:00
pelzvieh
43c4876ef3
Update app/src/main/java/com/owncloud/android/providers/DocumentsStorageProvider.java
Co-authored-by: Álvaro Brey <alvaro.brv@gmail.com>
2022-05-06 16:11:50 +02:00
Tobias Kaminsky
8d4ed0a862
Merge pull request #10181 from nextcloud/videoFullscreenPause
Correctly obey play/pause state
2022-05-06 14:43:43 +02:00
Álvaro Brey
b950be1f7d
Merge pull request #10178 from nextcloud/galleryLongRunning
Media search improvement
2022-05-06 13:47:09 +02:00
Álvaro Brey
ac208945e8
DocumentsStorageProvider: key can't be parsed into Int, since it's String now
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-06 13:13:50 +02:00
Álvaro Brey
8a9a9ec66d
GallerySearchTask: remove leftover testing code
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-06 13:04:50 +02:00
Álvaro Brey
27be297146
Merge pull request #10179 from nextcloud/throttleShareOverflowMenu
Throttle click on share icon
2022-05-06 12:55:50 +02:00
Álvaro Brey
db85ebba94
Merge pull request #10174 from nextcloud/new-fastscroll-lib
Fast scrolling fixes
2022-05-06 12:08:06 +02:00
Andreas Feldner
04a0ce1e71 Update DocumentsStorageProvider.java
Change root id for an nextcloud account to urlencoded user@uri. This is to avoid issues with unstable hashCodes.
2022-05-06 10:24:45 +02:00
Andreas Feldner
805ec3e61a Revert "Make Server's hashCode stable vs. version changes"
This reverts commit 5627e92619.
2022-05-06 09:17:32 +02:00
tobiasKaminsky
d33d5a20fd
Throttle click on share icon
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-05-06 09:11:10 +02:00
tobiasKaminsky
f34fff62a8
Fix #10176
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-05-06 07:55:29 +02:00
Nextcloud bot
73a18fbf6e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-06 04:11:46 +00:00
Álvaro Brey
ea4222a1ae
FileDisplayActivity: fix appbar for fast scroll
Adds padding at the bottom if appbar is not collapsed

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-05 15:51:58 +02:00
Álvaro Brey
09b95951c5
Fix fast scroll in gallery
Gallery has a grid layout + variable row height (due to section titles)

This is a no-no in all fastscroll libraries. However, the new one supports writing custom logic
to handle this, which is what this commit is.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-05 15:51:58 +02:00
Tobias Kaminsky
d374d87c24
Merge pull request #10163 from nextcloud/fix/previewmedia-exoplayer-null
PreviewMediaFragment: prevent crash due to onStop called before exoplayer initialization
2022-05-05 15:28:03 +02:00
Álvaro Brey
12312393b2
Replace fastscroll library
Smoother scrolling

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-05 11:03:00 +02:00
Nextcloud bot
d6f6f36d52
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-05 04:12:34 +00:00
pelzvieh
5627e92619
Make Server's hashCode stable vs. version changes
Bug #9906 seems to be triggered by a version change of the nextcloud server the client is connected to. It appears the most logical solution to make nextcloud object IDs stable against server version changes. These object IDs are derived from the User object using account/anonymous, and the referenced Server object. Providing a hashCode function in Server that ignores the server's version therefore provides stability of object IDs. This seems safe to do, as an URI is already designed to be an identificator.
2022-05-04 17:40:32 +02:00
Álvaro Brey
aac4a0cd67
PreviewMediaFragment: prevent crash due to onStop called before exoplayer initialization
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-04 11:23:54 +02:00
Nextcloud bot
1924041e4b
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-04 04:19:43 +00:00
Nextcloud bot
76ab52499d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-03 04:11:34 +00:00
Álvaro Brey
3c97b4b619
Merge pull request #10133 from nextcloud/fix/more-scrolling-bugs
Fix contents cut off when scrolling is locked
2022-05-02 18:10:53 +02:00
Álvaro Brey
f0b77e5751
Merge pull request #10052 from nextcloud/file_locking
File locking
2022-05-02 17:19:49 +02:00
Álvaro Brey
26aef8e462
Merge pull request #10134 from nextcloud/fix/dagger-mediacontrolview
Fix theme utils injection in custom views
2022-05-02 17:19:30 +02:00
Álvaro Brey Vilas
81ce812d86
Fix some licenses
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
3eb3079757
Fix spotbugs
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
f079f030cf
Remove unused resources
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
2cd2e29b86
FileMenuFilter: don't show lock options if there's no locking capability
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
db30142ad3
Fix lock info in actionMode menu when selecting a single, locked, file
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
f8ad9ae413
FileMenuFilter: don't show move, remove or rename options when file is locked
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
d90083fc07
Show file lock info in actions menu instead of separate dialog
Requested by design team

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
46ccddcef4
Combine lock indicator with overflow icon
Requested by design

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
a902fb6f84
FileMenuFilter: properly filter lock/unlock depending on lock status
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
a88b03a0c8
Show lock details when tapping on lock indicator
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
68b2535481
Retrieve and persist more locking attributes from remote files
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
356db04aa8
Add ability to toggle file lock from file context menu
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
fd2435379a
FileDataStorageManager: small cleanup
- Remove two unused methods
- Make some fields final

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
f5ecaf91d1
Show file locking status on list
Also includes a refactor of how ContentValues are created in FileDataStorageManager.

The code for that was triplicated. now it's not.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
b8cf8dade8
Store file locking capability
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:36 +02:00
Álvaro Brey
9a2cbcbba4
FileDisplayActivity: wait until OCFileListFragment is initialized to trigger browseToRoot()
This solves a bug which caused a "Directory does not exist" popup when coming back from Gallery,
as it tried to call browseToRoot on GalleryFragment due it being executed before the fragment transaction.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-02 11:02:46 +02:00
Álvaro Brey Vilas
13e061e7d7 PreviewMediaFragment: Remove margin from top bar
Not needed since previous commit fixing scroll bugs, creates unwanted space

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 07:55:34 +00:00
Álvaro Brey Vilas
7a2c735795 Fix contents cut off when scrolling is locked
Don't need to touch the coordinator params, just set scroll flags properly

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 07:55:34 +00:00
Nextcloud bot
ddb96e7b17
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-01 04:10:03 +00:00
Álvaro Brey Vilas
2560d1be3c
Inject ThemeColorUtils into ThemeableSwitchPreference too
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 16:56:56 +02:00
Álvaro Brey Vilas
b58749d459
Fix ThemeUtils injection for MediaControlView
Inflation of this view was failing as there was no proper constructor

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 16:50:35 +02:00
Álvaro Brey Vilas
7e31a71ba0 FileDetailsSharing: Preserve selected date when recreating expiration date dialog
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 11:12:07 +00:00
Álvaro Brey Vilas
85dcbe542e FileDetailsSharingProcess: force recreation of date picked on config changes
See added comment for details

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 11:12:07 +00:00
Álvaro Brey Vilas
8c2fc3ee87 ExpirationDatePickerDF: customize buttons on onStart instead of showing dialog on onCreate
That is how DialogFragment is supposed to work

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 11:12:07 +00:00
Álvaro Brey Vilas
bdd1daa10e SyncFileNotEnoughSpaceDialogFragment needs injector
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
3ff35d46e6 Fix some spotbugs stuff
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
56584c06e6 Fix detekt
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
42c28dce70 ThemeModule: convert to Kotlin and fix copyright
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
tobiasKaminsky
17828cb3b4 remove some spotbugs warnings
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
f627f3d976 Fix injection ofr RenameFileDialogFragment
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
6bd7d808f4 Put OCFileListBottomSheetDialog into a DialogFragment
Can't inject things into a Dialog

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:13 +00:00
tobiasKaminsky
74e17ee7c6 Fixes after rebase
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fixes after rebase

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fixes after rebase

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fix after rebase

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-29 06:38:13 +00:00
Álvaro Brey Vilas
75cb8a767c Remove SyncedFoldersActivity.java
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:13 +00:00
tobiasKaminsky
349a045b46 Move all Theme classes to DI
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Move all Theme classes to DI

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Move all Theme classes to DI

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-29 06:38:13 +00:00
Nextcloud bot
0a802b51da
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-29 04:11:37 +00:00
tobiasKaminsky
73bb12f78a Parallel thumbnail fetching
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-28 08:10:54 +00:00
Nextcloud bot
bd139f1afb
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-26 04:11:10 +00:00
Álvaro Brey
d45e12c2b8
Merge pull request #10089 from nextcloud/remove-account-usage-from-manage-acconuts-activity
Remove account use from ManageAccountsActivity
2022-04-25 16:47:34 +02:00
Nextcloud bot
98075eba14
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-24 04:13:03 +00:00
Chris Narkiewicz
042c3758ac
Remove account use from ManageAccountsActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2022-04-23 16:49:13 +01:00
Nextcloud bot
14aac48b90
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-23 04:00:20 +00:00
Nextcloud bot
7759475728
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-22 04:03:25 +00:00
Nextcloud bot
7cc0d53cff
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-21 04:01:23 +00:00
Álvaro Brey Vilas
9e29b5cbc4
Remove FilesFilter, as it is unused
Only created in OCFileListAdapter, and then unused

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-19 14:19:38 +02:00
Álvaro Brey Vilas
ca72520d54
MainApp: remove unused variable
Leftover

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-19 11:34:18 +02:00
Álvaro Brey Vilas
fb12a65949
Fix unit test for GalleryAdapter
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-19 10:59:14 +02:00
Álvaro Brey Vilas
ff3833c62f
OCFileListDelegate: fix detekt
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-18 18:40:25 +02:00
Álvaro Brey Vilas
0def0a8af8
Format with ktlint
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-18 18:21:35 +02:00
tobiasKaminsky
97d71d0383
Group media by month 2022-04-18 18:18:19 +02:00
Álvaro Brey
0e03400486
Merge pull request #10074 from nextcloud/equals
Replace equals with == on enums
2022-04-18 12:49:14 +02:00
Álvaro Brey
9a899ce3dc
Merge pull request #10070 from nextcloud/trashbinNav
Fix trashbin navigation
2022-04-18 12:30:48 +02:00
Nextcloud bot
58b34c3ee4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-16 03:59:30 +00:00
Nextcloud bot
df887ce4f2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-15 04:04:35 +00:00
tobiasKaminsky
a9608108ac
Replace equals with == on enums
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-13 10:19:30 +02:00
tobiasKaminsky
075e91d9ba
Replace equals with == on enums
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 09:15:33 +02:00
tobiasKaminsky
f57aa2037b
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:45:10 +02:00
tobiasKaminsky
3c69ae92bb
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:05:17 +02:00
tobiasKaminsky
e67fc70451
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:04:23 +02:00
tobiasKaminsky
930d3e61fd
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:04:23 +02:00
tobiasKaminsky
cf932e69e7
Fastscroll for all lists
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:04:23 +02:00
tobiasKaminsky
abc9f14555
Fix trashbin navigation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-11 08:33:00 +02:00
Nextcloud bot
7c6bce5617
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-08 04:05:40 +00:00
Álvaro Brey
d97edf023d
Merge pull request #10051 from nextcloud/fdroid-no-scan
Don't include document scanner in FDroid version
2022-04-07 12:46:08 +02:00
Álvaro Brey
ace6b49786
Merge pull request #10059 from nextcloud/exceptionHandling
Do not use ExceptionHandler on debug builds
2022-04-07 12:18:50 +02:00
tobiasKaminsky
df7e70a3f1
Do not use ExceptionHandler on debug builds
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-07 11:47:42 +02:00
Tobias Kaminsky
b84149ac7c
Merge pull request #10034 from nextcloud/fix/details-title-again
Better approach for avoiding state loss in FileDetailFragment
2022-04-07 11:07:11 +02:00
Tobias Kaminsky
69234dec5f
Merge pull request #10049 from nextcloud/fix/camera2_not_required
AndroidManifest: set camera2 feature to not required
2022-04-07 10:44:34 +02:00
Álvaro Brey
d781583c6c
Merge pull request #10007 from nextcloud/fixVideoStreaming
Use remoteId to properly fetch streaming video url
2022-04-07 10:36:07 +02:00
Álvaro Brey Vilas
9827612010
Don't include document scanner in FDroid version
Not allowed due to binary OpenCV

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-06 14:43:05 +02:00
Álvaro Brey Vilas
ba369f22ab
AndroidManifest: set camera2 feature to not required
Brought by document scanner lib, but not actually required. If set to required,
devices without this feature will not see the app in Play Store.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-06 09:26:39 +02:00
Álvaro Brey
5b8d11f738
Optimize loading time for Shared view (#10015)
* Don't load entire OCFiles in the Shared view, as it takes too long

Instead, build partially-filled OCFiles from the OCShares we get

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Load metadata of shared files only when attempting to interact with them

This was quite a big undertaking and required a whole new fragment

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Fix wrong usages of deprecaed OCShare shareType setter

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-04 18:52:21 +02:00
Tobias Kaminsky
b324f0d784
- no camera permission (#10042)
- scan document
- approve permission
- see scan document activity, previously it was wrong upload image activity

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-04 09:13:21 +00:00
Nextcloud bot
77507f9c9b
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-03 04:01:33 +00:00
Álvaro Brey Vilas
cd895ad2cf
Better approach for avoiding state loss in FileDetailFragment
Do not overwrite file when updating share information, instead of holding the file in FDA

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-31 15:04:19 +02:00
Nextcloud bot
7285ddc4cb
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-31 04:08:34 +00:00
Álvaro Brey
d9811e1f34
Merge pull request #10013 from nextcloud/fix/login-after-logout
Fix bugs when removing accounts
2022-03-30 18:29:24 +02:00
Nextcloud bot
9a94cb1e12
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-30 04:03:28 +00:00
Nextcloud bot
4b8bb8a707
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-28 04:02:23 +00:00
Nextcloud bot
ca751d0f71
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-27 04:01:42 +00:00
Nextcloud bot
3753ef361c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-25 05:41:13 +00:00
Álvaro Brey Vilas
a1901ca3e8
ManageAccountsActivity: go back to AuthenticatorActivity after removing last account
Instead of waiting for FileDisplayActivity to make a network request and fail

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 18:23:57 +01:00
Álvaro Brey Vilas
95046c4b5d
AccountRemovalWork: remove cached owncloudClient after removing account
Otherwise, the account (which is identified by account name only) will reuse old token, if login is done right after account removal.

Three hours of debugging for one line of code

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 18:22:11 +01:00
Álvaro Brey Vilas
2e593a034b
Fix FileDisplayActivity screenshot tests
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 10:38:08 +01:00
Álvaro Brey Vilas
154755af9b
Fix scrolling behaviour when changing dark mode
Also fixes "scrolling on top bar" for empty folders

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 10:38:07 +01:00
Álvaro Brey Vilas
b8bb261234
PreviewMediaFragment: fix crash when changing theme with audio fragment
Exoplayer is null when recreating

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 10:38:07 +01:00
Álvaro Brey Vilas
6a527a6e87
FileDisplayActivity: properly lock scrollbar for media preview
This locks the scrolling of the CoordinatorLayout AND removes the scroll flags from the AppbarLayout

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 10:38:07 +01:00
Álvaro Brey
d013464320
Merge pull request #9959 from nextcloud/shareFromMediaView
Fix sharing from media view
2022-03-23 09:30:26 +01:00
tobiasKaminsky
f522446d13
Correctly show edit share link
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-23 06:50:51 +01:00
Nextcloud bot
0c5a9fd155
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-23 03:59:59 +00:00
tobiasKaminsky
e481382c28
Use remoteId to properly fetch streaming video url
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-22 16:36:11 +01:00
Álvaro Brey Vilas
f6298f7904
FileDetialsSharing...: add minHeight to content instead of scrollview
This still keeps the minimum height, but doesn't center the content vertically which looked odd

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-22 10:10:55 +01:00
tobiasKaminsky
d91d2996ab
Fix sharing from media view
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-21 15:06:06 +01:00
Nextcloud bot
321a97acf7
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-21 03:59:20 +00:00
Nextcloud bot
98575bc8ca
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-20 04:00:57 +00:00
Nextcloud bot
d7dbef4085
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-19 04:01:55 +00:00
Nextcloud bot
6d1b14785c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-18 04:00:34 +00:00
Álvaro Brey
138d3a03a9
Merge pull request #9972 from nextcloud/fix/search-loading
Fix search loading animation and display
2022-03-17 13:04:10 +01:00
Álvaro Brey
e7e2ab8a96
Merge pull request #9976 from nextcloud/fix/receive-crash-no-account
ReceiveExternalFilesActivity: don't crash if no user present
2022-03-17 10:44:45 +01:00
Álvaro Brey Vilas
769816978a
OCFileListFragment: extract seach async task and convert it to kotlin
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-17 10:38:30 +01:00
Nextcloud bot
886400b5e0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-17 04:04:03 +00:00
Álvaro Brey Vilas
0af297735c
ExtendedListFragment: Remove ViewTreeObserver on search frame
This was incorrectly setting empty message when switching search types. And it makes no sense: search is only executed when submitted.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-16 11:40:41 +01:00
Álvaro Brey Vilas
e8e18609e5
OCFileListFragment: make search async task static, fix loading animation usage
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-16 11:40:41 +01:00
Tobias Kaminsky
eccd9205bd
Merge pull request #9970 from nextcloud/fix/share-screen-update
FileDisplayActivity: set file when opening FileDetailsFragment
2022-03-16 11:03:28 +01:00
Álvaro Brey
76d9bbfba3
Merge pull request #9432 from nextcloud/showCorrectNoShared
if no shared files are on server, show correct empty message
2022-03-16 10:45:08 +01:00
Álvaro Brey Vilas
3975839d53
ReceiveExternalFilesActivity: don't crash if no user present
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-16 10:38:37 +01:00
Nextcloud bot
e82fb2c6da
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-16 04:01:13 +00:00
tobiasKaminsky
080736af30
if no shared files are on server, show correct empty message
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-15 17:36:20 +01:00
Álvaro Brey Vilas
934953506f
FileDisplayActivity: set file when opening FileDetailsFragment
Solves issues when creating or removing shares, at which point the file would be re-set to the root folder

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-15 17:26:35 +01:00
Álvaro Brey Vilas
1a9014ee3b
FileDisplayActivity: always try to reload folder on onResume
This makes it so that the folder loads even without granting storage permission, which is the expected behaviour now

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 17:39:21 +01:00
Álvaro Brey Vilas
2a4316a298
PermissionUtil: ensure permission choice dialog doesn't overlap itself
(ensure only one instance of it is ever shown at the same time)

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 17:22:17 +01:00
Álvaro Brey Vilas
d8811c97a1
StoragePermissionDialogFragment: fix theming of buttons
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 17:18:07 +01:00
Álvaro Brey Vilas
db196c68a4
Design updates for storage permission dialog
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 17:04:18 +01:00
Álvaro Brey Vilas
ad5b443489
Choice between All Files and read-only external storage in SDK >=30
- Allow users to choose between MANAGE_EXTERNAL_STORAGE (full access) and READ_EXTERNAL_STORAGE (media read-only) in sdk >=30, with a dialog
- If All Files is not available (activity to manage not present, or permission not in manifest), request READ_EXTERNAL_STORAGE instead
- Misc improvements to permission request in UploadFilesActivity and SyncedFoldersActivity

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 17:04:17 +01:00
Álvaro Brey Vilas
7d2f0fa017
Make external storage permission optional
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-14 17:04:12 +01:00
tobiasKaminsky
05bd775171
only have one place for capability
update cache entry

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-14 13:23:14 +01:00
Nextcloud bot
d2f670369f
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-14 11:15:03 +00:00
Álvaro Brey Vilas
785767ae70
Screenshot tests for UploadFilesActivity
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 13:22:50 +01:00
Álvaro Brey Vilas
900145da05
Fix folder selection in custom autoupload folders
Hide checkboxes and keep choose button enabled. The flow to select folders is to navigate into them and tap "Choose", as is typical in file browsers.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 13:21:31 +01:00
Álvaro Brey Vilas
e57176f009
Move app source to subproject
Android Studio has started to fail for some stuff with that old structure (for example connected tests don't work).
It's about time to do this.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-11 11:10:51 +01:00