Commit graph

3775 commits

Author SHA1 Message Date
Tobias Kaminsky
b04c09e82b
Merge pull request #5695 from nextcloud/actImage
fix activity image loading
2020-03-23 06:48:11 +01:00
Daniel Bailey
19a5bc2f60
Fix for sso Grant/Deny dialog text color in dark mode.
Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2020-03-22 11:50:06 +00:00
tobiasKaminsky
c0c631fe64
fix activity image loading
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-19 20:33:48 +01:00
tobiasKaminsky
7eb0f66079
Add circle support for searching / displaying
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-19 19:12:23 +01:00
Daniel Bailey
7d2ad3afda
Fixes "Report a bug" button in community tab
Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2020-03-19 15:14:33 +00:00
tobiasKaminsky
1f805e5a57 Tint buttons in upload
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-19 14:48:29 +00:00
Daniel Bailey
28d35f26af Dark Mode Improvements
Removes conflicts between high contrast server themes and the dark mode.
Made primaryAccentColor() aware of the device theme so that it can
adjust the lightness accordingly.
Switch preference's track and thumb are more visible in device dark
mode.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2020-03-19 14:48:04 +00:00
tobiasKaminsky
4bf40b5860
fix wrong assumption how conflict dialog show work
updated tests

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-17 09:49:59 +01:00
Andy Scherzinger
682ed36006
Merge pull request #5629 from nextcloud/shareSize
adjust share size
2020-03-12 18:04:37 +01:00
Tobias Kaminsky
e1b0b521f9
Merge pull request #5482 from nextcloud/ezaquarii/migrate-contacts-backup-job-to-worker-api
Migrate contacts backup job to new background job manager API
2020-03-12 14:34:16 +01:00
Andy Scherzinger
6df2d58de5
Merge pull request #5634 from nextcloud/previewGradient
Add gradient to preview images in toolbar
2020-03-12 08:14:58 +01:00
Tobias Kaminsky
7ab1377744
Merge pull request #5623 from nextcloud/backButton
tint back button correctly
2020-03-12 07:38:26 +01:00
Tobias Kaminsky
c77f212fab
Merge pull request #5626 from nextcloud/darkRename
Correct font color in dark mode
2020-03-12 07:38:01 +01:00
Tobias Kaminsky
7b5e3607aa
Merge pull request #5632 from nextcloud/sortCrash
fix crash when sorting in folder picker
2020-03-12 07:37:30 +01:00
Chris Narkiewicz
500fdb919b
Migrate contacts backup job to new background job manager API
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-03-11 23:16:56 +00:00
Andy Scherzinger
2ede91bceb
Merge pull request #5625 from nextcloud/disabledFAB
Fix border of disabled FAB
2020-03-11 20:09:09 +01:00
Andy Scherzinger
ed8ef97ec3
add gradient to preview images in toolbar
Resolves #2883

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-03-11 18:48:38 +01:00
Andy Scherzinger
287ff2532e
Merge pull request #5612 from nextcloud/space
Fix exception on computing available space
2020-03-11 16:26:14 +01:00
tobiasKaminsky
221d3cc327
fix crash when sorting in folder picker
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-11 15:55:00 +01:00
tobiasKaminsky
8cb003b78e
adjust share size
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-11 14:53:37 +01:00
Andy Scherzinger
f7ffbe689f
Merge pull request #5608 from nextcloud/accountSwitchingTest
Fix account switching
2020-03-11 14:13:56 +01:00
tobiasKaminsky
52ba845e86
Correct font color in dark mode
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-11 10:43:43 +01:00
tobiasKaminsky
1b5d37b50c
Fix border of disabled FAB
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-11 10:06:21 +01:00
tobiasKaminsky
58ae52d108
tint back button correctly
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-11 08:39:58 +01:00
Andy Scherzinger
4920991618
Merge pull request #5617 from nextcloud/allFiles
All files shows root again
2020-03-11 00:00:59 +01:00
Andy Scherzinger
e891411a56
Merge pull request #5614 from nextcloud/postEncoding
Use UTF8 PostMethod everywhere
2020-03-10 22:52:20 +01:00
tobiasKaminsky
25a67fe4cb
All files shows root again
annotated functions with correct NonNull

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-10 11:56:34 +01:00
tobiasKaminsky
adae2e48da
Use UTF8 PostMethod everywhere
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-10 10:42:51 +01:00
tobiasKaminsky
3108759dac
Fix exception on computing available space
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-10 08:41:12 +01:00
tobiasKaminsky
14f6353cb3
Integration test for account switching
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-09 15:39:35 +01:00
tobiasKaminsky
593b684d4d
Use view bindings: https://developer.android.com/topic/libraries/view-binding
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-09 11:34:19 +01:00
tobiasKaminsky
8e45d953f1
Fix NPE on restoring file detail sharing fragment
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-09 08:51:23 +01:00
Andy Scherzinger
03c586bd94
remove unused dimens value
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-03-06 12:49:39 +01:00
Andy Scherzinger
be4efdd8ce
remove unneeded call
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-03-06 12:49:38 +01:00
Andy Scherzinger
3cfec4e0ba
remove sdk17 checks
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-03-06 12:49:37 +01:00
Tobias Kaminsky
581c12a867
Merge pull request #5546 from nextcloud/ezaquarii/migrations-manager
Migrations manager
2020-03-06 12:25:23 +01:00
Chris Narkiewicz
1ba288e5e6
Properly signal error when user id migration fails
Previous implementation was returning success status
when *any* account was migrated, despite possible
failures.

Return error when any account fails to be migrated.

The migration remines idempotent and can be re-run
again, until if finally succeeds.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-03-06 10:35:57 +01:00
Chris Narkiewicz
9ef27576e1
Enabled migration manager in MainApp
Migration manager added to DI.

Migration manager called in place of legacy migration code.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-03-06 10:35:57 +01:00
Chris Narkiewicz
1ab8d98d85
Support for optional migrations
Optional migrations care not causing migration failure
and can be applied again on next application run.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-03-06 10:35:57 +01:00
Chris Narkiewicz
b87bf1f10e
Migrations manager
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-03-06 10:35:56 +01:00
tobiasKaminsky
793dd901a2
remove unused class
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-06 09:59:34 +01:00
Tobias Kaminsky
2061207e25
Merge pull request #5531 from nextcloud/fix/AS36
Update to Android Studio 3.6
2020-03-05 09:58:46 +01:00
tobiasKaminsky
30ac72652e
Fix test
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-05 08:22:58 +01:00
tobiasKaminsky
7ca6f304ed
Use proper dialog instantiation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-03 10:31:04 +01:00
tobiasKaminsky
b8c4c68275
Fixes during CR
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-03 10:31:03 +01:00
tobiasKaminsky
628e58e65e
Fixe during CR
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-03 10:31:03 +01:00
tobiasKaminsky
ae08a42f8a
Enhance conflict dialog
- fix bug
- add ui tests
- add instrumented tests

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-03 10:31:03 +01:00
Tobias Kaminsky
3ae41ec9fa
Merge pull request #5549 from endre-borcsok/bugfix/crash_in_activities
Fixed crash in Activities tab.
2020-03-03 10:30:21 +01:00
Tobias Kaminsky
de7b7f5c06
Merge pull request #5345 from Charon77/deep_link
Allows deep linking to open files
2020-03-03 10:26:06 +01:00
Tobias Kaminsky
1e3c6d1080
Merge pull request #5537 from nextcloud/folderFileString
Split up share internal link
2020-03-03 09:45:22 +01:00
Tobias Kaminsky
3dde163c70
Merge pull request #5496 from nextcloud/fix/5232
properly colorize text preview gradient based on theme (day/night)
2020-03-03 09:44:37 +01:00
tobiasKaminsky
01b1e719ff
delombok everything
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-03 09:39:28 +01:00
Endre Borcsok
bf7d33066b Fixed crash in Activities tab.
Replaced Toast.makeText() methods to DisplayUtils.showSnackMessage().

Signed-off-by: Endre Borcsok <ebsoftmobile@gmail.com>
2020-03-02 20:49:53 +00:00
tobiasKaminsky
4013c47b48
Show slideshow as new activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-03-02 08:45:33 +01:00
tobiasKaminsky
78adcfb3d6
Split up share internal link
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-27 20:10:51 +01:00
Evans Jahja
0467cc37ca Allows deep linking to open files
Signed-off-by: Evans Jahja <evansjahja13@gmail.com>
2020-02-26 21:26:48 +07:00
Tobias Kaminsky
e1b8d525e5
Merge pull request #5445 from nextcloud/headMethod
add HEAD Method support for SSO
2020-02-21 08:37:16 +01:00
Andy Scherzinger
3ec795f0bf
properly colorize text preview gradient based on theme (day/night)
improve preview textview size/gradient position

Fixes #5232

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-02-20 18:30:59 +01:00
Tobias Kaminsky
be238a3f96
Merge pull request #5471 from nextcloud/richWorkspace18only
Show "add folder info" only if text app is available
2020-02-20 07:49:47 +01:00
Alice Gaudon
49f3a67251
ConflictsResolveActivity: code style and readability improvements
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-18 07:39:13 +01:00
Alice Gaudon
6540e3ef71
Upload list conflicts: replace trash icon with menu and add resolve action
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2020-02-18 07:38:35 +01:00
Alice Gaudon
a4ff1f11d7
Customize upload sync conflict notification strings
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2020-02-18 07:38:35 +01:00
Alice Gaudon
91ef307e7a
Fix database migration of field forceOverwrite to NameCollisionPolicy
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2020-02-18 07:38:35 +01:00
Alice Gaudon
52d089b18a
FileUploader: fix codacy issues and SpotBugs
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2020-02-18 07:38:35 +01:00
Alice Gaudon
ec27f840a6
FileUploader: code cleanup
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2020-02-18 07:38:35 +01:00
Alice Gaudon
7713a28a4f
FileUploader: require explicit NameCollisionPolicy and change default used value
- Changes NameConflictPolicy for manual uploads from default RENAME to ASK_USER
- Removal of helper class FileUploader.UploadRequester (methods become static and go to FileUploader)

Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2020-02-18 07:38:35 +01:00
Alice Gaudon
6783e8ab4c
Make file uploads ask the user what to do when the file already exists on remote
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2020-02-18 07:38:16 +01:00
Alice Gaudon
213002f44e
Make newly created synced folders auto upload existing files by default
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2020-02-18 07:37:54 +01:00
Chris Koying Browet
1b7bd72c49
ADD: [instantupload] setting to also upload existing files
Signed-off-by: Chris Koying Browet <cbro@semperpax.com>
2020-02-18 07:37:54 +01:00
Tobias Kaminsky
c243453168
Merge pull request #5465 from nextcloud/fix/create-folder-crash-autosync
Fixed crash during folder creation (autosync)
2020-02-18 07:28:12 +01:00
tobiasKaminsky
a93313ca19
added tests
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-17 15:05:14 +01:00
Kilian Périsset
467104c455
Replaced OCFile by File in getFolder() method 2020-02-17 14:45:14 +01:00
Kilian Périsset
c59f9c0b91
Formated the code + added header 2020-02-17 14:45:07 +01:00
Kilian Périsset
389090d3e8
Implemented tests for FolderPickerActivity 2020-02-17 14:45:07 +01:00
Kilian Périsset
511a16612d
Fixed bug relative to null folder in FolderPicker 2020-02-17 14:45:07 +01:00
Tobias Kaminsky
4616b0d40b
Merge pull request #5447 from nextcloud/ezaquarii/migrate-jobs-to-new-user-model
Migrate jobs to new user model
2020-02-17 10:40:04 +01:00
Chris Narkiewicz
0977c37916
Fix crash during text file creation
Fixes #5330

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-17 09:30:37 +01:00
Andy Scherzinger
490b292ad9
Merge pull request #5300 from nextcloud/sharedSearchAgain
Re-enable shared search and add ui test for list shares
2020-02-14 13:52:18 +01:00
tobiasKaminsky
7b4e1b82e3
change cancelContactBackupJobForAccount to user new User class
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-14 11:08:38 +01:00
tobiasKaminsky
87df2c8e1c
Show "add folder info" only if text app is available
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-14 10:31:23 +01:00
Chris Narkiewicz
0afc2645c4
Migrated jobs to new user model
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-02-14 06:22:20 +00:00
tobiasKaminsky
0569b0de65
Screenshot tests ManageAccountsActivity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-12 09:34:59 +01:00
Chris Narkiewicz
53024d1cd1
Migrate account list to new user model
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-02-12 07:31:38 +00:00
Tobias Kaminsky
f520f2f9a2
Merge pull request #5436 from nextcloud/ezaquarii/make-user-model-parcelable
Make user model parcelable
2020-02-11 09:26:26 +01:00
tobiasKaminsky
26d7b9c692
Fix after rebase
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-11 08:58:31 +01:00
tobiasKaminsky
c2750aabda
Add ui test for list shares
add test user to drone
switch back to master
use "waitForIdleSync" instead of sleep

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-11 08:57:09 +01:00
Chris Narkiewicz
4ce54bc21e
Make user model parcelable
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-02-10 15:49:12 +00:00
Tobias Kaminsky
5905b1c5a5
Merge pull request #5432 from nextcloud/ezaquarii/migrate-drawer-menu-utils-to-new-user-model
Migrate drawer menu utilities to new user model
2020-02-10 12:41:25 +01:00
Tobias Kaminsky
4be18adc2d
Merge pull request #5064 from nextcloud/ezaquarii/extract-account-logic-from-base-activity-into-mixin
Extract account logic from BaseActivity into a mixin
2020-02-10 12:33:04 +01:00
tobiasKaminsky
ebcbf0afac
add HEAD Method support for SSO
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-10 11:56:45 +01:00
tobiasKaminsky
6048243f41
Fix crash: Caused by: java.lang.ClassCastException: java.lang.Object[] cannot be cast to java.lang.Void[]
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-10 08:41:51 +01:00
Chris Narkiewicz
b5fb9c1374
Migrate drawer menu utilities to new user model
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-02-09 10:11:08 +00:00
Chris Narkiewicz
26f2d52a5a
Extract account logic from BaseActivity into a mixin
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-02-05 22:08:58 +00:00
Andy Scherzinger
c7669fe9db
Merge pull request #5393 from nextcloud/removeUnsetType
Remove UnsetType as we do not have bottom bar anymore…
2020-02-05 15:17:44 +01:00
Tobias Kaminsky
c5be0ad7e4
Merge pull request #5399 from nextcloud/extractArbitraryDataSet
extract ArbitraryDataSet class
2020-02-05 12:30:37 +01:00
Tobias Kaminsky
0936945b3c
Merge pull request #5328 from nextcloud/fix/not-enough-space-dialog
Added "not enough space dialog"
2020-02-05 12:14:40 +01:00
tobiasKaminsky
778fec9e21
extract openDrawer test into AbstractIT
rebased

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-05 11:12:48 +01:00
tobiasKaminsky
e118f9a516
Remove UnsetType as we do not have bottom bar anymore…
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-05 11:09:14 +01:00
tobiasKaminsky
c7ea6458bf
extract ArbitraryDataSet class
cleanup

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-05 10:58:05 +01:00
Tobias Kaminsky
7c84a9f929
Merge pull request #5296 from nextcloud/fix/defective-search
Fixed defective search
2020-02-05 10:56:19 +01:00
Kilian Périsset
f9a47e6b3b
Formated the code 2020-02-05 10:50:44 +01:00
tobiasKaminsky
1bf079d2cd
NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION: Method needlessly boxes a boolean constant
This method assigns a Boxed boolean constant to a primitive boolean variable, or assigns a primitive boolean constant to a Boxed boolean variable. Use the correct constant for the variable desired.

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-05 10:21:56 +01:00
Kilian Périsset
4e16e0431a
Merge branch 'fix/defective-search' of github.com:nextcloud/android into fix/defective-search 2020-02-04 18:23:49 +01:00
Kilian Périsset
8184dbf1ff
Change variables accessibility 2020-02-04 18:20:31 +01:00
tobiasKaminsky
88c4d6d2ab
Merge remote-tracking branch 'origin/fix/not-enough-space-dialog' into fix/not-enough-space-dialog 2020-02-04 11:24:19 +01:00
tobiasKaminsky
b74c9f2517
use correct storage location
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-04 11:24:10 +01:00
Tobias Kaminsky
f7220f4618
Merge pull request #5246 from siebica/master
Fix #2753 "Unresponsive App" error popup when syncing
2020-02-04 10:01:17 +01:00
tobiasKaminsky
f794f230b5
formatting
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-04 09:36:40 +01:00
Tobias Kaminsky
64c253be66
Merge pull request #5089 from cheecodes/master
Add check to make sure cursor is initialized
2020-02-04 09:12:33 +01:00
Tobias Kaminsky
0c272ad1d7
Merge pull request #5231 from nextcloud/roundedCorners
images: slightly rounded corners
2020-02-03 13:47:15 +01:00
tobiasKaminsky
f8ff0e106a
Auth activity with primary white color
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-02-03 06:08:05 +01:00
Kilian Périsset
badc7c92da
Formated the code of ExtendedListFragment.java
(In order to avoid issues)
2020-01-31 14:59:54 +01:00
Kilian Périsset
00e3ce6217
Removed translations (unneeded for this fix branch)
This reverts commit 938e4a6f44.

Signed-off-by: Kilian Périsset <kilian.perisset@infomaniak.com>
2020-01-31 14:54:11 +01:00
tobiasKaminsky
763ee606d1
use radius, and do not only test for it
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-30 21:39:54 +01:00
tobiasKaminsky
82dd14f6bc
extract doubled code
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-30 20:31:45 +01:00
Kilian Périsset
82baea3062
Normalized the code 2020-01-30 16:55:37 +01:00
Tobias Kaminsky
8dc162960b
Merge pull request #5209 from nextcloud/ooDownloadFile
OnlyOffice: make download possible
2020-01-30 15:30:04 +01:00
Kilian Périsset
4bed2adc2f
Merge branch 'fix/not-enough-space-dialog' of github.com:nextcloud/android into fix/not-enough-space-dialog 2020-01-29 10:39:52 +01:00
Kilian Périsset
52edda73f6
Formated the code and removed Pair 2020-01-29 10:39:45 +01:00
tobiasKaminsky
9d5e3da126
Merge remote-tracking branch 'origin/fix/not-enough-space-dialog' into fix/not-enough-space-dialog
# Conflicts:
#	src/main/java/com/owncloud/android/ui/dialog/SyncFileNotEnoughSpaceDialogFragment.java
2020-01-29 08:35:20 +01:00
tobiasKaminsky
8737d9b835
add ui test
- some small code changes
- removed unneeded code

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-28 16:02:19 +01:00
Kilian Périsset
e3c19410c8
Removed redundant code for Codacy grade 2020-01-28 14:05:50 +01:00
Kilian Périsset
1c44f2003d
Removed codacy issues 2020-01-28 13:59:24 +01:00
Kilian Périsset
03a307825d
Finished "Not Enough Space" dialog + Optimized UX 2020-01-27 15:29:46 +01:00
Tobias Kaminsky
b53c96cba0
Merge pull request #5218 from nextcloud/fix_multitask
Fix #5213 app is excluded from recent/current apps
2020-01-27 08:39:05 +01:00
Kilian Périsset
9fac55da6b
Added args for SyncFileNotEnoughSpaceFragment (unfinished)
Caption support is missing
2020-01-24 15:08:03 +01:00
Kilian Périsset
8e09c99f1f
Added dialog when sync is too heavy for device (unfinished) 2020-01-24 14:19:40 +01:00
Andy Scherzinger
e4f099237c
Merge pull request #5203 from nextcloud/directEditingPre5
prevent direct editing on < Lollipop
2020-01-23 18:54:06 +01:00
Kilian Périsset
579140b7c4
Cleaned a bit the code + Fixed cross display bug 2020-01-23 15:54:09 +01:00
Kilian Périsset
938e4a6f44
Added translations to prepare pre-search + Fixed fab bug 2020-01-22 18:58:43 +01:00
tobiasKaminsky
4fb140d275
round corners only in list view
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-22 13:45:31 +01:00
Andy Scherzinger
ce2971386d
Merge pull request #5270 from nextcloud/addSeparator
OC bottom list improvement
2020-01-21 22:46:26 +01:00
Kilian Périsset
10b661744a
Fixed onBackPressed bug (inactive button) + Refactored and optimized the code 2020-01-21 18:09:50 +01:00
tobiasKaminsky
289a83635d
OC bottom list improvement
- same padding
- add "create new" for creators

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-21 13:01:28 +01:00
tobiasKaminsky
491de101ac
Fix duplicated rich_workspace in dev version
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-21 09:17:34 +01:00
Sebastian-Ion TINCU
531c0187a8 Fix #2753 "Unresponsive App" error popup when syncing
Always start SyncFolderOperations as background services to prevent
ANRs when they take a little more time to complete.

Signed-off-by: Sebastian-Ion TINCU <5282265+siebica@users.noreply.github.com>
2020-01-20 12:56:06 +01:00
Kilian Périsset
2f02f6bdf4
Added locking and unlocking of Drawer in Videos Activities/Fragments 2020-01-20 12:30:02 +01:00
Andy Scherzinger
465b209ec9
Merge pull request #5216 from nextcloud/fix/lock-drawer-in-medias-activities
Locked and hid the drawer in Pictures Preview
2020-01-20 11:02:28 +01:00
tobiasKaminsky
1c483e140d
move create rich workspace into bottom sheet
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-18 18:08:54 +01:00
tobiasKaminsky
ef0b0fe9ee
images: slightly rounded corners
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-18 16:22:54 +01:00
Joris Bodin
97eda02db6
Fix #5213 2020-01-16 18:18:42 +01:00
Kilian Périsset
113575b7bf
Locked and hid the drawer in Pictures Preview 2020-01-16 15:27:09 +01:00
Kilian Périsset
dc3c030e94
Removed search icon in toolbar during media/video preview 2020-01-16 11:25:14 +01:00
tobiasKaminsky
af24dafd7b
OnlyOffice: make download possible
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-15 16:25:23 +01:00
tobiasKaminsky
4eec8905ae
prevent direct editing on < NOUGAT
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-15 10:05:17 +01:00
Tobias Kaminsky
6f86e497fc
Merge pull request #5193 from nextcloud/uploadInReadonlyFolder
Upload button: disable/grey when folder is read-only
2020-01-14 20:01:54 +01:00
Tobias Kaminsky
2011f5211b
Merge pull request #5157 from nextcloud/ezaquarii/fix-npe-in-get-user-in-user-account-manager
Fix NPE in UserAccountManagerImpl.getUser(CharSequence)
2020-01-14 17:21:12 +01:00
Tobias Kaminsky
4cb800ea13
Merge pull request #5187 from nextcloud/fab
FAB: show disabled correctly again
2020-01-14 17:14:53 +01:00
tobiasKaminsky
447cac9af9
Upload button: disable/grey when folder is read-only
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-14 16:29:09 +01:00
tobiasKaminsky
7ba3bf0cf9
FAB: show disabled correctly again
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-14 11:44:29 +01:00
Tobias Kaminsky
f68e9e06d7
Merge pull request #5181 from nextcloud/vCard30
Export vCard to version 3.0
2020-01-14 10:47:10 +01:00
Tobias Kaminsky
a8f41615d6
Merge pull request #5172 from nextcloud/preventNPE
prevent NPE
2020-01-14 10:00:51 +01:00
Andy Scherzinger
09183fec15
export vCard to 3.0 version
Resolves #4727

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-01-13 22:13:30 +01:00
Andy Scherzinger
f8c9af44a0
simplify if statement
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-01-13 20:34:53 +01:00
tobiasKaminsky
33b0861955
prevent NPE
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-13 20:34:52 +01:00
tobiasKaminsky
f01cdd65ae
UI enhancements to rich workspaces
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-13 19:06:49 +01:00
Chris Narkiewicz
fe404f0e25
Fix NPE in UserAccountManagerImpl.getUser(CharSequence)
Optional.of() called on nullable value causes NPE.
We should use Optional.ofNullable() instead, as the
argument can be null by design.

Fixes #5155

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-01-11 21:31:04 +00:00
Tobias Kaminsky
422a61d8de
Merge pull request #5136 from nextcloud/systemDefault
make "follow system" default for dark theme
2020-01-10 20:16:11 +01:00
Tobias Kaminsky
6e96e99dea
Merge pull request #5130 from nextcloud/createRichWorkspace
rich workspaces
2020-01-10 19:45:02 +01:00
tobiasKaminsky
c6d89edf85
only allow rich workspace creation on >= Lollipop
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-10 09:59:15 +01:00
tobiasKaminsky
87dae2ef04
show first run again
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-10 09:47:15 +01:00
Andy Scherzinger
8a343be9c6
Merge pull request #5133 from nextcloud/notificationTask
task needs to be a new object for every button
2020-01-09 18:22:42 +01:00
tobiasKaminsky
4b2002a9a3
better error description
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-09 16:10:58 +01:00
tobiasKaminsky
15ac231818
make "follow system" default for dark theme
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-09 15:53:03 +01:00
Andy Scherzinger
6cd1b751ee
Merge pull request #5121 from nextcloud/newIcon
new background icon
2020-01-09 15:44:15 +01:00
Andy Scherzinger
9fa4060360
Merge pull request #5128 from nextcloud/closeEditor
editor: click on snackbar closes webview for real
2020-01-09 15:20:51 +01:00
tobiasKaminsky
0e5a772e63
rich workspaces
- show button to create folder info
- bug fixes

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-09 15:17:19 +01:00
tobiasKaminsky
4b073e9283
task needs to be a new object for every button
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-09 14:54:00 +01:00
Tobias Kaminsky
383d892b52
Merge pull request #5017 from grote/5015-dp-remove-npe
Retrieve parent folder before removing document
2020-01-09 14:49:29 +01:00
tobiasKaminsky
56e6ed5888
editor: click on snackbar closes webview for real
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-09 11:34:37 +01:00
tobiasKaminsky
bbc2c8282b
new background icon
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-08 14:16:16 +01:00
tobiasKaminsky
9d2b80da1a
spinner: if primary color is white, use grey
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-08 10:21:30 +01:00
tobiasKaminsky
1ec8b067f0
- fix not clickable rich workspace area
- fix crash on first loading

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-08 08:42:29 +01:00
Tobias Kaminsky
9a47a4d30b
Merge pull request #5107 from nextcloud/whiteHeader
Fix white header with dark mode
2020-01-08 06:35:10 +01:00
Tobias Kaminsky
6cb0f10872
Merge pull request #4915 from nextcloud/createText
Create text
2020-01-08 06:24:12 +01:00
tobiasKaminsky
9556a69204
Better handling of parsing enum
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-07 11:57:10 +01:00
tobiasKaminsky
57b0d425b6
Fix text in option menu within image preview
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-07 10:12:34 +01:00
tobiasKaminsky
9c92762937
Fix white header with dark mode
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-07 09:28:24 +01:00
tobiasKaminsky
74f8a723b8
fixes from CI
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-07 08:23:48 +01:00
tobiasKaminsky
59585d0f5b
Direct editing support
- abstract EditorWebView
- support direct editing endpoint
Create new files via direct editing

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-07 08:23:41 +01:00
Tobias Kaminsky
b0758e4b74
Merge pull request #5054 from nextcloud/ezaquarii/fix-user-avatars-in-drawer
Fix account switch buttons in drawer header
2020-01-07 08:15:53 +01:00
Andy Scherzinger
f690417d37
Merge pull request #5102 from nextcloud/removeNC12
remove support for NC12
2020-01-06 19:23:53 +01:00
tobiasKaminsky
051423cf21
remove support for NC12
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-06 15:48:12 +01:00
Tobias Kaminsky
d7d1c475ae
Merge pull request #5031 from nextcloud/ezaquarii/fix-npe-crash-when-storage-manager-is-not-set
Fix NPE crash on startup when storage manager is not set
2020-01-06 15:35:27 +01:00
Tobias Kaminsky
b675942f1e
small typo 2020-01-06 15:16:38 +01:00
Tobias Kaminsky
9b79b85ff5
Merge pull request #5065 from nextcloud/ezaquarii/fix-crash-when-making-new-ods-file
Fix crash when adding new ODS file
2020-01-06 14:57:05 +01:00
Tobias Kaminsky
32ebe691f9
Merge pull request #5066 from nextcloud/ezaquarii/fix-shared-by-null-glitch
Fix "Shared by null" glitch in file details view
2020-01-06 14:55:07 +01:00
tobiasKaminsky
5fce6caea4
Removed unneeded try/catch
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-06 12:19:21 +01:00
tobiasKaminsky
a680697529
Removed unneeded try/catch
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-06 12:00:30 +01:00
tobiasKaminsky
154b9af533
adjusted to master
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-01-06 10:10:28 +01:00
Andy Scherzinger
a15f7248ff
Make hyperlinks clickable in markdown previews
Resolves: #5030

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-01-06 09:33:12 +01:00
Andy Scherzinger
5f70ea643e
Make hyperlinks clickable in markdown previews
Resolves: #5030

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-01-06 09:33:12 +01:00
Fabian Bettag
4e91c23bb5 Add check to make sure cursor is initialized
Fixes #4702
Fixes #4919

Signed-off-by: Fabian <fabian@chee.codes>
2020-01-02 17:51:14 +01:00
Torsten Grote
d82de88701
Retrieve parent folder before removing document
Otherwise trying to get the parent folder will cause a NPE

Fixes #5015

Signed-off-by: Torsten Grote <t@grobox.de>
2019-12-26 15:44:23 -03:00
Chris Narkiewicz
ef8497697a
Fix "Shared by null" glitch in file details view
When file is uploaded it has ownerId == null.
We shall interpret this condition file being
owned by the current user.

Fixes #5005

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-12-25 19:45:49 +00:00
Chris Narkiewicz
3cf3e3bd71
Fix crash when adding new ODS file
Crash was caused by async task callback firing when
Fragment is not attached to activity.

Check if fragment is attached before invoking
callback logic.

Fixes: #5020

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-12-25 16:39:05 +00:00
Chris Narkiewicz
89ccc01845
Fix account switch buttons in drawer header
This is a regression caused by using User.equals() to compare against
platform Account object.

- Migrated this functionality to User
- Refactored drawer setup code using CollectionsKt.filter()
  List<User>

Fixes #5053

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-12-22 13:43:04 +00:00
Tobias Kaminsky
6af95233fb
Merge pull request #4890 from nextcloud/directEditing
Direct editing support
2019-12-19 15:11:56 +01:00
tobiasKaminsky
b20767140f
fix during CI
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-19 09:10:23 +01:00
tobiasKaminsky
ec2cfef138
Direct editing support
- abstract EditorWebView
- support direct editing endpoint

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-19 08:57:39 +01:00
tobiasKaminsky
f2627a29a8
enable caching
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-19 08:57:39 +01:00
tobiasKaminsky
ddffaf7b49
use custom user agent for onlyOffice
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-19 08:57:39 +01:00
tobiasKaminsky
0178499596
remove unneeded static string
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-19 08:57:39 +01:00
tobiasKaminsky
95afe8c82a
use editor id to use any editor
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-19 08:57:38 +01:00
tobiasKaminsky
d05de9855a
use file path as parameter for open direct editing file
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-19 08:57:38 +01:00
tobiasKaminsky
300abba48b
make sure TextEditor is also only used ond >= Android 5, due to security reason of javascript interface
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-19 08:57:38 +01:00
tobiasKaminsky
994817ce97
get direct editing info from endpoint
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-19 08:57:38 +01:00
tobiasKaminsky
b31cee531b
prevent NPE
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-19 08:57:38 +01:00
tobiasKaminsky
d1611f6334
Direct editing support
- abstract EditorWebView
- support direct editing endpoint

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-19 08:57:38 +01:00
Chris Narkiewicz
3f3c5a1951
Fix NPE crash on startup when storage manager is not set
Fixes #4941

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-12-19 00:28:24 +00:00
Torsten Grote
574f50e684
Only trigger media scans when the file is a media file
Fixes #4999

Signed-off-by: Torsten Grote <t@grobox.de>
2019-12-16 16:31:10 -03:00
tobiasKaminsky
b065e9b85d
fix dark theme preference for dev version: use different preference name
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-16 08:23:54 +01:00
tobiasKaminsky
f61c70d796
only add account, but not go to main app.
Usage: start com.nextcloud.client/com.owncloud.android.authentication.AuthenticatorActivity with "onlyAdd" set to true as boolean

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-12 08:28:20 +01:00
tobiasKaminsky
8b61e74057
remove unneeded accountManager
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-12 06:50:52 +01:00
tobiasKaminsky
e5cd5ffcd6
use nextcloudClient.execute(…)
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-12 06:50:52 +01:00
tobiasKaminsky
066f4c25aa
Initial work on v2 with activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-12 06:50:52 +01:00
Tobias Kaminsky
1145c3813e
Merge pull request #4958 from Infomaniak/fix/see-detail-from-preview-nc
Fixed issue relative to Properties from ImagePreview
2019-12-10 09:32:23 +01:00
Tobias Kaminsky
fd3ff4cbcb
Merge pull request #4898 from siddharths2710/master
Refresh issue for file movment/file restore operations
2019-12-10 09:22:57 +01:00
Andy Scherzinger
8062340f63
Merge pull request #4657 from nextcloud/bumpSDK
bump to latest SDK
2019-12-09 17:51:09 +01:00
Tobias Kaminsky
1290bbe52e
Merge pull request #4918 from Infomaniak/fix/calendar-not-refreshed
Resolved issue relative to calendar refresh in link-sharing
2019-12-09 11:58:21 +01:00
Siddharth Srinivasan
aabc97de82 Renamed refresh methods and updated ETag parameter accordingly
Signed-off-by: Siddharth Srinivasan <13200018+siddharths2710@users.noreply.github.com>

Renamed refresh methods and updated ETag parameter accordingly with sign-off
2019-12-06 21:57:14 +05:30
Siddharth Srinivasan
c608f0081c Merge remote-tracking branch 'upstream/master'
Keep in line with upstream
2019-12-06 20:36:26 +05:30
Kilian Périsset
88fe5069eb
Fixed bug relative to activities icon + applied DRY 2019-12-06 15:10:41 +01:00
Kilian Périsset
9b94cc2b58
Fixed the indentation for ExpirationDatePicker 2019-12-06 12:46:50 +01:00
Kilian Périsset
65b82c2ee5
Allowed onbackpressed from properties (without redisplaying file) + Removed useless intent data 2019-12-06 12:07:53 +01:00
Kilian Périsset
25d9c46f82
Fixed bug relative to details from Image Preview 2019-12-06 11:52:47 +01:00
tobiasKaminsky
b01f71972f
fix #4955
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-06 08:25:50 +01:00
Kilian Périsset
acd5d48d96
Applied the expiration date in each instance of DatePicker 2019-12-05 11:52:33 +01:00
Andy Scherzinger
d006ac257e
Merge pull request #4923 from nextcloud/theming_sharing_box
fix wrong text color on edit text input on dark mode
2019-12-05 11:20:44 +01:00
tobiasKaminsky
1584de9769
use SystemClock.elapsedRealtime() everywhere
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-05 11:05:47 +01:00
Tobias Kaminsky
dda56defb4
Merge pull request #4933 from nextcloud/appLocking
Use SystemClock.elapsedRealtime() instead of System.currentTimeMillis()
2019-12-04 08:21:04 +01:00
Andy Scherzinger
cb00677172
Merge pull request #4926 from nextcloud/deleteChecksFor16
remove all checks for <= JELLY_BEAN as we have this as our new minimum.
2019-12-04 06:59:17 +01:00
Tobias Kaminsky
fd48163e22
Merge pull request #4922 from nextcloud/themeFollowOS
Dark mode: light, dark, follow system
2019-12-04 06:47:36 +01:00
tobiasKaminsky
5e687f2c17
Dark mode: light, dark, follow system
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-04 06:33:34 +01:00
tobiasKaminsky
fb69c1bd51
remove all checks for <= JELLY_BEAN as we have this as our new minimum.
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-04 06:15:30 +01:00
Tobias Kaminsky
7cf3ba93c6
Merge pull request #4925 from nextcloud/NotNull
replace org.jetbrains.annotations with androidx.annotations
2019-12-03 15:49:40 +01:00
Kilian Périsset
ba58d37aff
Changed indentation of Picker new instance 2019-12-03 14:15:37 +01:00
tobiasKaminsky
2f9c5e9761
replace org.jetbrains.annotations with androidx.annotations
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-03 13:31:02 +01:00
tobiasKaminsky
3cf0e6e5e4
replaced distinct by manually unique via HashMap
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-03 09:48:23 +01:00
tobiasKaminsky
83903ea1db
fix wrong sync status in auto upload on white theming
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-03 08:55:17 +01:00
tobiasKaminsky
e0bd44cf83
fix wrong text color on search input on dark mode
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-03 08:36:20 +01:00
Kilian Périsset
0b86d6a1d9
Resolved issue relative to calendar refresh in link-sharing 2019-12-02 18:40:58 +01:00
tobiasKaminsky
c612e2f547
Use SystemClock.elapsedRealtime() instead of System.currentTimeMillis()
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-02 07:52:17 +01:00
Siddharth Srinivasan
041a6787b8 Explicitly refreshing list on resume and on file move operation
Signed-off-by: Siddharth Srinivasan <siddharths2710phone@gmail.com>

Explicitly refreshing list on resume and on file move operation
2019-11-28 22:59:37 +05:30
Andy Scherzinger
d17c853493
re-add button/action and improve upon code review
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-11-27 21:43:53 +01:00
Andy Scherzinger
74bfe473c4
remove action button, use checkable menu item for shown/hidden state display
(design review)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-11-27 21:35:31 +01:00
Andy Scherzinger
7c62ad6b06
unify use of boolean, make use of lombok getter/setters, remove unneeded boolean boxing
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-11-27 21:35:05 +01:00
Andy Scherzinger
ca6918f9fc
show/hide improvements when list is completed hidden + nicer empty UI + action button
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-11-27 21:35:03 +01:00
Andy Scherzinger
23e44243da
show/hide auto upload list items
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-11-27 21:34:40 +01:00
Chris Narkiewicz
a7eb7148fa
Migrate simple cases of getCurrentAccount() to getUser()
Migrate trivially convertible uses of getCurrentAccount()
to new user model - getUser().

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-11-25 08:53:50 +00:00
Chris Narkiewicz
609b99666f
New user model
New non-nullable user model abstracts away all complexities of Nextcloud
user account and provides.

- backported java.util.Optional
- extended UserAccountManager with User getters
- deprecated CurrentAccountProvider.getCurrentAccount() method
- migrated connectivity service to new user model
- migrated UploadsStorageManager to new user model
- migrated OCFileListAdapter

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-11-21 19:58:57 +00:00
Tobias Kaminsky
94502f66b5
Merge pull request #4787 from ArisuOngaku/auto-upload-start-date-persistence
Make synced folder init/enable date persistent
2019-11-19 13:21:43 +01:00
Tobias Kaminsky
dbe12e6d20
Merge pull request #4789 from nextcloud/name_pattern_menus
Improve menu file name pattern
2019-11-18 15:26:35 +01:00
Tobias Kaminsky
77b6b178a9
Merge pull request #4841 from nextcloud/disableOldLoginMethod
allow to switch off old login method
2019-11-18 13:51:38 +01:00
tobiasKaminsky
b561f68834
allow to switch off old login method
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-11-18 10:13:09 +01:00
Alice Gaudon
65da616f81 FilesSyncHelper: use our own logging framework
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2019-11-15 07:56:17 +01:00
Andy Scherzinger
693f408276
Improve menu file name pattern
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-11-13 11:47:23 +01:00
Chris Narkiewicz
fb615ef279 Remove out-of-band setAccount/onAccountSet calls
Activity account is set in FilesActivity.onAccount(),
but related components are updated in BaseActivity.onStart().

1. Initialize account in BaseActivity.onCreate()
2. Update storage manager and capabilities immediately
   on account set, not waiting for onStart() lifecycle.
3. inline storage manager and capabilities update in setAccount()
4. Remove setAccount()/onAccountSet() calls that sets default
   account, as this duplicates BaseActivity.onCreate()

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-11-12 06:21:05 +00:00
Tobias Kaminsky
890789f0a7
Merge pull request #4797 from nextcloud/ezaquarii/replace-shared-preferences-with-app-preferences-in-base-activity
Replace BaseActivity.sharedPreferences with app preferences
2019-11-06 13:52:54 +01:00
Tobias Kaminsky
180bdee721
Merge pull request #4801 from Infomaniak/feature/resolve-set-as-wallpaper-issue
Fixing picture "set as wallpaper" issue in properties (duplicate)
2019-11-06 13:48:23 +01:00
Alice Gaudon
2e13212752 SyncedFolderProvider: pass Clock dependency via constructor instead of dagger
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2019-11-06 01:59:06 +01:00
Alice Gaudon
c2ea4de802 FileContentProvider: add dagger injection
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2019-11-06 01:50:32 +01:00
Alice Gaudon
7f4db3fdd0 Make synced folder init/enable date persistent
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2019-11-05 21:23:45 +01:00
Kilian Périsset
25aaf4b907
Applied ability to set as wallpaper from properties of a picture
Signed-off-by: Kilian Périsset <kilian.perisset@infomaniak.com>
2019-11-05 14:20:35 +01:00
Chris Narkiewicz
6b01382e7f
Replace BaseActivity.sharedPreferences with app preferences
- Eliminate access to shared preferences when setting dark theme.
- Extend AppPreferences interface to allow subscription for preference changes
- Improve preferences interface documentation

Fixes #4791

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-11-05 06:00:58 +00:00
Daniel Bailey
b0563b9310
Theming: Fix date picker button text colour
Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-11-04 14:52:54 +00:00
tobiasKaminsky
71264e19b8
use file/folder in "copy internal link" description
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-11-01 12:32:07 +01:00
Andy Scherzinger
fe353a7561
consistently use snake_case for color resources
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-30 16:13:29 +01:00
Andy Scherzinger
2a43da6bdf
Merge pull request #4746 from nextcloud/createChooser
use default open chooser with "just once", "always"
2019-10-29 16:23:00 +01:00
tobiasKaminsky
bee8770ce0
- fix typo in styles
- fix sign up with provider in dark primary color

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-29 11:27:03 +01:00
Tobias Kaminsky
cc710b09cb
Merge pull request #3459 from nextcloud/dark_theme
Dark theme
2019-10-29 11:18:48 +01:00
Andy Scherzinger
c1aa005db9
changes due to code review
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-29 11:05:44 +01:00
tobiasKaminsky
12fe91a6dd
use default open chooser with "just once", "always"
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-29 07:28:51 +01:00
Tobias Kaminsky
cabe2fcff0
Merge pull request #4725 from nextcloud/ssoHeaders
SSO: return response headers
2019-10-28 16:12:32 +01:00
Andy Scherzinger
2021da0a8b
proper contacts backup button theming
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 15:36:30 +01:00
Andy Scherzinger
48b43581cc
proper button theming for notification actions
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 15:36:06 +01:00
tobiasKaminsky
8e3931edf6
SSO: return response headers
new headers in parallel

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-28 14:48:24 +01:00
Daniel Bailey
9a9e0e6c42
Merge branch 'dark_theme' of github.com:nextcloud/android into dark_theme
Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-28 13:32:14 +00:00
Daniel Bailey
853d7cd113
Dark theme updates
TextInputLayout in share password dialog is styled to match the app.
Receive files picker shows server primary colour on Upload button.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-28 13:03:19 +00:00
Daniel Bailey
1615130093
Fix activity foreground text colour for >=API21.
Share expiration date picker now has buttons that are the primary
colour.

Theme change is now done in BaseActivity and ThemedPreferenceActivity.
This should help any activities in the back stack show the correct
theme.

Fixed style issues on firstrun and authenticator activities.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-28 12:59:32 +01:00
Andy Scherzinger
a518885612
add dark/light theming for activities headline
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:32 +01:00
Andy Scherzinger
57db615a33
icons with light background need to be keep with dark color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:29 +01:00
Andy Scherzinger
375fb97c06
use day/night color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:27 +01:00
Andy Scherzinger
9a88ee24d3
remove unused radio button preference code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:25 +01:00
Andy Scherzinger
e14dc52fa7
use correct color after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:22 +01:00
Daniel Bailey
6bb9a70603
Various improvements to dark theme
Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-28 12:59:22 +01:00
Andy Scherzinger
8f8b67f57f
don't tint avatars within the drawer menu
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:20 +01:00
Andy Scherzinger
b7e9d3f954
remove unused theme getter from interface
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:51 +01:00
Daniel Bailey
8d0ff8fecc
Corrects "Choose" button colour in FolderPickerActivity. Removes un-used import from NotificationListAdapter.
MaterialButtons.
SearchView highlight text colour.
First run activity, outlined button colour.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:50 +01:00
Daniel Bailey
c7049788f7
DatePickerDialog theme and style.
Button styling.
Small improvements to layouts and correction of spelling errors.
Sets edittext highlight colour to theme colour.

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:07 +01:00
Andy Scherzinger
30a5ec6ee1
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:07 +01:00
Andy Scherzinger
562338cad1
set background color for primary action buttons on upload and participate
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:06 +01:00
Andy Scherzinger
790e3fa2f8
findbugs: accesses list or array with constant index
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:04 +01:00
Andy Scherzinger
3d60c83ba2
use right colors for drawer menu item text and icons
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:04 +01:00
Daniel
27b8ed4327
Dark theme v1
Fixing migration to androidx
Dark theme styling
File details fragment tab text colour
File list overflow menu background colour

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:57:58 +01:00
Andy Scherzinger
2bb13a1545
move suppress annotation to newly created method
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-26 09:36:58 +02:00
Andy Scherzinger
a6fdec8656
shorten method
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-26 04:33:03 +02:00
Andy Scherzinger
1d3fca653f
codacy: Avoid declaring a variable if it is unreferenced before a possible exit point.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-26 04:22:34 +02:00
Andy Scherzinger
816991c172
codacy: avoid unused imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-26 04:20:27 +02:00
Andy Scherzinger
4f8fc49d15
Merge pull request #4730 from nextcloud/taskTwice
fix notification task, if it failed first
2019-10-25 10:18:10 +02:00
tobiasKaminsky
44fefe9064
fix notification task, if it failed first
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-25 09:16:58 +02:00
Andy Scherzinger
460b5a75cd
repect theming colors when rendering markdown
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-24 20:30:48 +02:00
Andy Scherzinger
75dd657ba8
Merge pull request #3905 from jmue/storageprovider
enhance DocumentsProvider
2019-10-24 19:18:59 +02:00
Andy Scherzinger
8a3ea78a55
Merge pull request #4701 from nextcloud/markdownPreview_SyntaxHighlighting
Markdown preview syntax highlighting
2019-10-24 16:11:04 +02:00
tobiasKaminsky
669ad540e5
minor refactoring due to codacy
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-24 13:24:14 +02:00
Andy Scherzinger
587c8f74a1
Merge pull request #4716 from nextcloud/davX5loginFlow
DavX5: support login flow
2019-10-24 10:36:15 +02:00
Andy Scherzinger
bf43a798df
add syntax highlighting to markdown rendering
* bump gradle memory due to GC mem limit during code generation (gradle.properties)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-24 09:29:41 +02:00
tobiasKaminsky
622cc45e72
use new login flow only when we have a server url
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-24 09:10:48 +02:00
tobiasKaminsky
ccd6dfaec0
NPE in setting note
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-24 08:47:11 +02:00
Jens Mueller
62f7c479fa
fix file creation time
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:37 +02:00
Jens Mueller
332e67c72d
refactor/cleanup
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:37 +02:00
Jens Mueller
8d24d80fdc
Revert "reduce contentresolver/sql queries"
This reverts commit ec5a73142dee30cd909db9e68b97ef65456f7c48.

Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:36 +02:00
Jens Mueller
5de451fa98
fix initialization of storage manager collection
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:35 +02:00
Jens Mueller
fa5e5dd8cd
notify storageprovider on account creation/removal
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:35 +02:00
Jens Mueller
cfd3aab952
reduce contentresolver/sql queries
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:34 +02:00
Jens Mueller
a2350598da
fix isChildDocument()
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:33 +02:00
tobiasKaminsky
b2eacc46b4
- fix error when temp folder does not yet exist
- do not use FileUploader for uploads

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-23 17:27:32 +02:00
Jens Mueller
a14747623d
move checks into toDocument()
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:32 +02:00
Jens Mueller
65655c5753
fix build
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:31 +02:00
Jens Mueller
fbff63bb02
fix lint warnings
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:30 +02:00
Jens Mueller
dddffce2a1
fix review comments
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:29 +02:00
Jens Mueller
e62879ac91
cleanup
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:28 +02:00
Jens Mueller
fe43e503a3
cleanup/fix review comments
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:28 +02:00
Jens Mueller
7f157a9ff1
enhance documents storage provider
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:24 +02:00
Andy Scherzinger
3dcbfa1236
Merge pull request #4712 from nextcloud/fetchRemoteFile
Fix possible IndexOutOfBoundsException if returned array is empty
2019-10-23 14:24:52 +02:00
tobiasKaminsky
2911a86263
DavX5: support login flow
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-23 13:47:33 +02:00
tobiasKaminsky
750c0a7677
Fix possible IndexOutOfBoundsException if returned array is empty
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-21 08:27:10 +02:00
Chris Narkiewicz
b7cdaf310b
Eliminate account status flags from BaseActivity
onAccountSet(stateWasRecovered) is no longer used anywhere,
so the flag mAccountWasRestored can be safely removed.

This intermediary step opens path to eliminating
out of band calls to onAccountSet().

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-20 23:27:41 +01:00
Tobias Kaminsky
954c76b11b
Merge pull request #4692 from nextcloud/markdownPreview
Markdown rendering
2019-10-18 10:21:01 +02:00
Andy Scherzinger
95e14df1d7
Add markdown rendering to TextPreview
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-17 19:57:51 +02:00
Chris Narkiewicz
5d6e316570
Remove onAccountSet from ReceiveExternalFilesActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-17 15:45:00 +01:00
Tobias Kaminsky
16cc46f4ed
Merge pull request #4687 from nextcloud/account-cleanup-upload-files-activity
Remove onAccountSet from UploadFilesActivity
2019-10-17 15:22:10 +02:00
Tobias Kaminsky
d9567a2bb6
Merge pull request #4686 from nextcloud/account-cleanup-image-video-preview
Remove onAccountSet from image and video preview activities
2019-10-17 15:21:54 +02:00
Tobias Kaminsky
2d9afe36c9
Merge pull request #4688 from nextcloud/account-cleanup-share-activity
Remove onAccountSet from ShareActivity
2019-10-17 15:21:44 +02:00
Tobias Kaminsky
f4a27cc5dc
Merge pull request #4693 from nextcloud/account-cleanup-file-display-activity
Remove onAccountSet from FileDisplayActivity
2019-10-17 14:58:13 +02:00
Tobias Kaminsky
d237a834b8
Merge pull request #4699 from nextcloud/removeUploadPathActivity
We do not use UploadPathActivity anymore(?)
2019-10-17 11:39:12 +02:00
Tobias Kaminsky
64c986eaf2
Merge pull request #4689 from nextcloud/account-cleanup-folder-picker-activity
Remove onAccountSet from FolderPickerActivity
2019-10-17 11:38:08 +02:00
tobiasKaminsky
ab904e336b
We do not use UploadPathActivity anymore(?)
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-17 08:23:15 +02:00
Chris Narkiewicz
451cec9f3a
Remove onAccountSet from ConflictsResolveActivity
Deprecated onAccountSet logic simply inlined in onStart.
No change of control flow.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 21:12:09 +01:00
Chris Narkiewicz
e5a6accf66
Remove onAccountSet from FileDisplayActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 21:07:50 +01:00
Chris Narkiewicz
b199a62b78
Remove onAccountSet from image and video preview activities
Both callbacks are directly called from onStart().
Since callback parameter is unused, inline the
callback code in onStart().

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:57:11 +01:00
Chris Narkiewicz
f428fb5810
Remove onAccountSet from UploadFilesActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:55:39 +01:00
Chris Narkiewicz
6a88a02f94
Remove onAccountSet from ShareActivity
Since onAccountSet is called directly from onStart,
we can inline the code in onStart safely.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:54:30 +01:00
Chris Narkiewicz
3519d04eea
Remove onAccountSet from FolderPickerActivity
Move onAccountSet body to onStart.
Unconditionally reset fragment state, since the
acctount restoration flag is no longer available.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:50:21 +01:00
Andy Scherzinger
e47daaffdc
Merge pull request #4684 from nextcloud/codacy2
more codacy fixes
2019-10-16 17:42:07 +02:00
Tobias Kaminsky
3ef96f8877
Merge pull request #4677 from nextcloud/deprecate-set-account-logic
Deprecate setAccount logic and remove accounWasSet flag
2019-10-16 14:57:46 +02:00
Andy Scherzinger
7f209618eb
codacy: shorten method length
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-15 16:38:01 +02:00
Andy Scherzinger
9beecfa184
codacy: Document empty constructor (rather make setting flag more explicit in this case)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-15 15:57:53 +02:00
Andy Scherzinger
670e9d3a61
codacy: Ensure you override both equals() and hashCode()
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-15 15:57:45 +02:00
Andy Scherzinger
862e5d4776
Merge pull request #4537 from nextcloud/ezaquarii/migrate-ncontentobserverjob-to-workmanager
Migrate NContentObserverJob to WorkManager
2019-10-15 15:23:15 +02:00
Andy Scherzinger
54e5ce3ae0
Merge pull request #4683 from nextcloud/fixSorting
fix sorting of synced folder: NPE if both enabled, but one has null folder name
2019-10-15 13:36:49 +02:00
tobiasKaminsky
1b0d548c69
fix sorting of synced folder: NPE if both enabled, but one has null folder name
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-15 09:56:55 +02:00
Andy Scherzinger
2ab45a72ac
codacy: Deeply nested if..then statements are hard to read
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-14 14:59:28 +02:00
Andy Scherzinger
2dabd04aa9
codacy: These nested if statements could be combined
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-14 14:59:28 +02:00
Andy Scherzinger
e0802a0da4
codacy: Avoid using Literals in Conditional Statements
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-14 14:59:27 +02:00
Andy Scherzinger
638a5b9fc0
codacy: Avoid unused imports such as 'androidx.fragment.app.Fragment'
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-14 14:59:26 +02:00
Andy Scherzinger
ab6424701b
codacy: Avoid unused method parameters such as 'appVersion'.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-14 14:59:26 +02:00
Chris Narkiewicz
c90626aaf5
Deprecate setAccount logic and remove accounWasSet flag
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-13 16:02:46 +01:00
tobiasKaminsky
8cc3ec7ad6
revert disabling of exception handler
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-10 17:15:08 +02:00
Tobias Kaminsky
f1cf050a81
Merge pull request #4626 from nextcloud/removeCustomEdit
remove CustomEditTextField
2019-10-10 17:07:26 +02:00
Andy Scherzinger
af7bf9b2f7
Merge pull request #4647 from nextcloud/fixVanishingImages
Fix vanishing images
2019-10-10 13:56:29 +02:00
tobiasKaminsky
a2f2da9c20
move logic completely into function
prevent double subfolders

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-10 12:01:35 +02:00
tobiasKaminsky
73fc5e47ed
OCFiles can be retrieved also by photo search, which then do not have a parent, nor a fileId as the are only virtual files
upon refreshing folder
- they were found in database, but only updated with fileId=-1.
- they were not found in parent folder, so we have to search them manually via file path

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-10 10:51:54 +02:00
tobiasKaminsky
cf74da7bda
- remove CustomEditTextField
- do not use fancy material header for textInput, but regular TextView
- do not show QR button on legacy login
- fix layout in tablet mode

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-10 08:25:22 +02:00
Tobias Kaminsky
07d0abe87e
Merge pull request #4644 from nextcloud/detectAuth
Allow broader check on CheckAuth
2019-10-09 21:06:00 +02:00
Tobias Kaminsky
9be019ce4c
Merge pull request #4637 from nextcloud/fixSingleAccountMode
Enhance single account mode
2019-10-09 21:03:04 +02:00
tobiasKaminsky
140eb3b664
Allow broader check on CheckAuth
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-09 19:52:36 +02:00
tobiasKaminsky
3d6d396ba9
fix disappearing account list on resume
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-09 15:15:33 +02:00
tobiasKaminsky
baefe67ea9
enhance single account mode
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-09 14:06:14 +02:00
Tobias Kaminsky
bb81d2349b
Merge pull request #4632 from nextcloud/npeInDetail
hardening on possible NPE due to null account/activity
2019-10-09 13:58:14 +02:00
Tobias Kaminsky
ad9daacb25
Merge pull request #4629 from nextcloud/ezaquarii/remove-sticky-headers-code
Remove sticky headers from activities list view
2019-10-09 13:36:21 +02:00
tobiasKaminsky
832e525f09
hardening on possible NPE due to null account/activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-09 08:15:32 +02:00
Tobias Kaminsky
f321cedb24
Merge pull request #4623 from nextcloud/fixSyncedFolderNofications
Fix recurring synced folder notifications
2019-10-09 07:38:07 +02:00
Chris Narkiewicz
73658bcfe1
Remove sticky headers from activities list view
This will prevent application from crashing on
adapter update.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-08 23:04:51 +01:00
Andy Scherzinger
1b6b909a8c
Merge pull request #4621 from nextcloud/gridCrash
prevent crash when grid column is -1
2019-10-08 09:43:15 +02:00
tobiasKaminsky
2a88933075
- fix wrong sql to detect already existing synced folder
- remember every media folder where a notification was shown

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-08 09:19:16 +02:00
tobiasKaminsky
02eaa886ae
prevent crash when grid column is -1
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-08 08:00:36 +02:00
Daniel Bailey
f5aa60bae9
Fix activity foreground text colour for >=API21.
Share expiration date picker now has buttons that are the primary
colour.

Theme change is now done in BaseActivity and ThemedPreferenceActivity.
This should help any activities in the back stack show the correct
theme.

Fixed style issues on firstrun and authenticator activities.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-07 16:43:36 +02:00
Andy Scherzinger
8aaf29a7c3
add dark/light theming for activities headline
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:35 +02:00
Andy Scherzinger
a2963d9fc3
icons with light background need to be keep with dark color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:32 +02:00
Andy Scherzinger
196e33998a
use day/night color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:27 +02:00
Andy Scherzinger
916580cb19
remove unused radio button preference code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:25 +02:00
Andy Scherzinger
dc0ca5cc84
use correct color after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:20 +02:00
Daniel Bailey
c43633ebb9
Various improvements to dark theme
Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-07 16:43:19 +02:00
Andy Scherzinger
eff6a5bed9
don't tint avatars within the drawer menu
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:16 +02:00
Andy Scherzinger
f53f246f6e
rebase fixing plus proper theming of legacy login fields
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:15 +02:00
Andy Scherzinger
55d5f2f41a
remove unused theme getter from interface
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:11 +02:00
Daniel Bailey
66144bb8b6
Corrects "Choose" button colour in FolderPickerActivity. Removes un-used import from NotificationListAdapter.
MaterialButtons.
SearchView highlight text colour.
First run activity, outlined button colour.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:09 +02:00
Daniel Bailey
9f7fa6b6b6
DatePickerDialog theme and style.
Button styling.
Small improvements to layouts and correction of spelling errors.
Sets edittext highlight colour to theme colour.

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:07 +02:00
Andy Scherzinger
b0734f5768
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:06 +02:00
Andy Scherzinger
34cef89ce8
set background color for primary action buttons on upload and participate
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:04 +02:00
Andy Scherzinger
1930e5dc74
findbugs: accesses list or array with constant index
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:02 +02:00
Andy Scherzinger
cab2b12594
use right colors for drawer menu item text and icons
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:01 +02:00
Daniel
44099c0792
Dark theme v1
Fixing migration to androidx
Dark theme styling
File details fragment tab text colour
File list overflow menu background colour

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:42:49 +02:00
Chris Narkiewicz
88113c02df
Fix NPE in Favorites when file has no local storage path
Fixes #4578

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-02 22:04:04 +01:00
Chris Narkiewicz
808c9098ea
Migrate NContentObserverJob to WorkManager
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-02 21:38:44 +01:00
Tobias Kaminsky
4f15e87412
Merge pull request #4592 from nextcloud/parentCheck
if parent is null, then do a regular check, no early exit
2019-10-02 09:03:07 +02:00
Tobias Kaminsky
b204db0f1a
Merge pull request #4577 from nextcloud/ezaquarii/fix-npe-in-preview-media-fragment
Fix NPE in PreviewMediaFragment
2019-10-02 09:02:35 +02:00
Tobias Kaminsky
9876c49001
Merge pull request #4415 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.0.1
Bump detekt-gradle-plugin from 1.0.0-RC14 to 1.0.1
2019-10-02 08:26:25 +02:00
tobiasKaminsky
f6e24eb067
if parent is null, then do a regular check, no early exit
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-02 08:02:44 +02:00