Commit graph

18032 commits

Author SHA1 Message Date
Álvaro Brey Vilas
96c55a6d9f
FileSortOrder*: convert to Kotlin
Need more kotlin in the codebase and these were simple enough

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:49:07 +01:00
Álvaro Brey Vilas
7baa0f8da4
LocalFileListAdapter: Also change sort order asynchronously
Changing sort  order is also slow.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
2baf63d809
AlphaNumComparator: optimize usage and resolve signature problems
- Methods had ambiguous signatures (parameterized compare<T> overlapped the various typed compare()). This made the compiler very confused.
 - In several places throughout the app, AlphaNumComparator was getting repeatedly instantiated just to manually call a typed compare(). This was very wasteful

To solve both problems, the typed compare() methods have been been made static.

The performance gains of not instantiating the comparator repeatedly are very noticeable. In a test loading a local folder for upload with 1000 files in it,
time of load is reduced from 28 seconds to 17 seconds.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
462da35fdb
LocalFileList: load local files asynchronously
Loading a large list of files (especially the sorting part) is S L O W.
This ensures it doesn't block the UI while loading.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey
618a770349
Merge pull request #9751 from nextcloud/fix/clear-data
Fix some crashes and weird behaviours when clearing data
2022-01-27 09:18:21 +01:00
Álvaro Brey
4a29c2e4c4
Merge pull request #9726 from nextcloud/fix/immutable-intents
Make PendingIntents immutable
2022-01-27 09:16:03 +01:00
nextcloud-android-bot
d51268d7b8
Drone: update FindBugs results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-01-26 14:09:47 +01:00
nextcloud-android-bot
af2059660f Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-01-26 12:08:19 +00:00
Álvaro Brey Vilas
c01fa0b170
Make more PendingIntents immutable
This should be all of them. Picked up by lint.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:56:05 +01:00
Álvaro Brey Vilas
27559efb79
Make PendingIntents immutable
Good practice for security

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:56:05 +01:00
Álvaro Brey
38c60b7618
Merge pull request #9758 from nextcloud/fix/analysis-again
Analysis: fix checkout and commit generation
2022-01-26 12:55:23 +01:00
Álvaro Brey Vilas
494cceab8e
Analysis: fix checkout and commit generation
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:54:24 +01:00
Álvaro Brey
7eaed66ebc
Merge pull request #9755 from nextcloud/dependabot/gradle/com.android.tools.build-gradle-7.1.0
Bump gradle from 7.0.4 to 7.1.0
2022-01-26 12:06:04 +01:00
Álvaro Brey Vilas
45fc831989
gplay/AndroidManifest: set exported value for service
picked up by lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
9d5395c8fd
ezvcard/ContactOperations: suppress locale lint in third_party class
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
043d839d70
build.gradle: Disable some translation errors in lint
Translations are handled in Transifex

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
a9ec1de015
manifest: Remove unneeded labels
Trips up lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
00586a5bde
BackgroundJobFactory: fix lint due to unchecked build version for ContentObserverJob
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
b6115a5fc1
lint: Fix getLayoutInflater calls
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
b07716c0e5
screenshotTest: uninstall app before running
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
9f2bdd5916
Analysis: use pull_request_target
Can't post reports otherwise as github token is readonly in pull_request

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
e35b6211f0
build.gradle: Run migrations for AGP 7.1.0
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:52 +01:00
dependabot[bot]
ae8752a4f7
Bump gradle from 7.0.4 to 7.1.0
Bumps gradle from 7.0.4 to 7.1.0.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-26 11:33:47 +01:00
Álvaro Brey
e6d64e5ed5
Merge pull request #9754 from nextcloud/dependabot/gradle/mockitoVersion-4.3.1
Bump mockitoVersion from 4.3.0 to 4.3.1
2022-01-26 10:45:40 +01:00
Álvaro Brey
41b3921643
Merge pull request #9744 from nextcloud/dependabot/gradle/com.karumi-shot-5.13.0
Bump shot from 5.11.2 to 5.13.0
2022-01-26 10:44:25 +01:00
Álvaro Brey Vilas
e1b41b5d77 ManageSpaceActivity: convert to Kotlin while we're here
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 08:32:49 +00:00
Álvaro Brey Vilas
db74d67168 ManageSpaceActivity: kill the app after finishing cleanup
This will prevent the file list still being on the Recents view and other stuff like that.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 08:32:49 +00:00
Álvaro Brey Vilas
83e56643f4 ManageSpaceActivity: remove user accounts when clearing data
This fixes crashes and unexpected states when restarting the app afterwards

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 08:32:49 +00:00
Nextcloud bot
750864d951
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-26 03:55:40 +00:00
dependabot[bot]
8e67653a38
Bump mockitoVersion from 4.3.0 to 4.3.1
Bumps `mockitoVersion` from 4.3.0 to 4.3.1.

Updates `mockito-core` from 4.3.0 to 4.3.1
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v4.3.0...v4.3.1)

Updates `mockito-android` from 4.3.0 to 4.3.1
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v4.3.0...v4.3.1)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.mockito:mockito-android
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-26 02:05:19 +00:00
Álvaro Brey Vilas
5a65c65e76
uploadReport: update shot path
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-25 10:41:06 +01:00
Álvaro Brey
d057d48a89
Merge pull request #9745 from nextcloud/dependabot/gradle/mockitoVersion-4.3.0
Bump mockitoVersion from 4.2.0 to 4.3.0
2022-01-25 09:44:30 +01:00
Álvaro Brey
a8feb7bb66
Merge pull request #9718 from nextcloud/fix/recent-files
Fix minor issues with recently modified view
2022-01-25 09:13:58 +01:00
Álvaro Brey
b7f1ebd74b
Merge pull request #9742 from nextcloud/fix/analysis-on-push
Run analysis workflow on push too
2022-01-25 09:07:25 +01:00
dependabot[bot]
4c44d469e0
Bump mockitoVersion from 4.2.0 to 4.3.0
Bumps `mockitoVersion` from 4.2.0 to 4.3.0.

Updates `mockito-core` from 4.2.0 to 4.3.0
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v4.2.0...v4.3.0)

Updates `mockito-android` from 4.2.0 to 4.3.0
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v4.2.0...v4.3.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.mockito:mockito-android
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-25 02:04:50 +00:00
dependabot[bot]
d328d89c2d
Bump shot from 5.11.2 to 5.13.0
Bumps [shot](https://github.com/karumi/shot) from 5.11.2 to 5.13.0.
- [Release notes](https://github.com/karumi/shot/releases)
- [Commits](https://github.com/karumi/shot/compare/5.11.2...5.13.0)

---
updated-dependencies:
- dependency-name: com.karumi:shot
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-25 02:04:25 +00:00
Álvaro Brey Vilas
22367838ab
Run analysis workflow on push too
Otherwise baseline results aren't generated

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-24 16:25:33 +01:00
Tobias Kaminsky
2476be69ba
Merge pull request #9737 from nextcloud/chore/bump-fastlane
Bump versions for fastlane and plugins
2022-01-24 14:51:09 +01:00
Álvaro Brey Vilas
1a735f1840
Fix default visibility of recently modified
Should be visible unless setup.xml disables is (which it does by default)

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-24 13:14:01 +01:00
Álvaro Brey Vilas
c45dd9f5ff
Remove recently added search
Was never fully implemented. Discarding in favor of recently modified.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-24 13:14:01 +01:00
Álvaro Brey Vilas
63c780999d
OCFileListFragment: restore search event on view restored
Partially reverts https://github.com/nextcloud/android/pull/9427, which deleted too much stuff

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-24 13:14:00 +01:00
Álvaro Brey Vilas
6a45a90019
OCFileListFragment: add recently modified to the list of valid search events
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-24 13:14:00 +01:00
Álvaro Brey Vilas
93f973cdc2
Bump versions for fastlane and plugins
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-24 12:09:29 +01:00
Álvaro Brey
dd94e20045
Merge pull request #9734 from nextcloud/dependabot/gradle/com.github.spotbugs.snom-spotbugs-gradle-plugin-5.0.5
Bump spotbugs-gradle-plugin from 5.0.4 to 5.0.5
2022-01-24 09:53:05 +01:00
dependabot[bot]
f0ea41a56b
Bump spotbugs-gradle-plugin from 5.0.4 to 5.0.5
Bumps [spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin) from 5.0.4 to 5.0.5.
- [Release notes](https://github.com/spotbugs/spotbugs-gradle-plugin/releases)
- [Commits](https://github.com/spotbugs/spotbugs-gradle-plugin/compare/5.0.4...5.0.5)

---
updated-dependencies:
- dependency-name: com.github.spotbugs.snom:spotbugs-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-24 08:13:52 +00:00
Nextcloud bot
43610aedba
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-24 03:52:57 +00:00
Tobias Kaminsky
70b93ed89c
Merge pull request #9723 from nextcloud/bump-minor-version
Bump version to 3.20.0 on master
2022-01-21 08:58:47 +01:00
Tobias Kaminsky
add4b08802
Merge pull request #9721 from nextcloud/chore/temurin
workflows: Use temurin JDK instead of adopt
2022-01-21 08:33:12 +01:00
Nextcloud bot
d8cbde9105
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-21 03:52:14 +00:00
Álvaro Brey Vilas
f4e979a385
Bump version to 3.20.0 on master
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-20 15:00:46 +01:00