Commit graph

10228 commits

Author SHA1 Message Date
Andy Scherzinger
92fbc7b63b
remove unused resource
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-10-06 11:28:28 +02:00
Torsten Grote
931aac7345
Ensure that upload notification gets cancelled
Normally, the notification gets cancelled when the service is destroyed.
But that does not always happen in practice, so we also cancel it after
every result.

Signed-off-by: Torsten Grote <t@grobox.de>
2020-10-05 13:28:55 -03:00
Nextcloud bot
44d97594cf
[tx-robot] updated from transifex 2020-10-05 03:40:04 +00:00
Nextcloud bot
13ca0d8442
[tx-robot] updated from transifex 2020-10-04 03:40:32 +00:00
Nextcloud bot
cde3ca4cf9
[tx-robot] updated from transifex 2020-10-03 03:42:11 +00:00
Andy Scherzinger
33d26c6322
spotbugs: Method does not presize the allocation of a collection
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-10-02 22:43:05 +02:00
Andy Scherzinger
9a730d8c0b
use a constant for equals statement
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-10-02 22:43:04 +02:00
tobiasKaminsky
cfdd3d4588
Add send multiple files, if downloaded
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-10-02 22:43:03 +02:00
Andy Scherzinger
61aaba5b33
Merge pull request #7011 from dassio/skip_upload
add skip option in case of name collision
2020-10-02 22:41:33 +02:00
tobiasKaminsky
6a5f5f4c41
add tests
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-10-02 16:10:17 +02:00
Andy Scherzinger
501eb7de89
Merge pull request #7030 from nextcloud/preventFirebaseCrashes
Prevent firebase crashes
2020-10-02 10:22:32 +02:00
tobiasKaminsky
b66adb9199
Prevent firebase crashes
https://firebase.google.com/docs/analytics/configure-data-collection?platform=android

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-10-02 08:53:05 +02:00
Nextcloud bot
b83bf828f2
[tx-robot] updated from transifex 2020-10-02 03:34:02 +00:00
tobiasKaminsky
b9d84c36f1
re-add flag_secure to prevent showing content if app is locked
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-10-01 20:38:15 +02:00
Andy Scherzinger
d6a02ce765
drop Android 4.3, new min version is Android 4.4
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-10-01 12:06:14 +02:00
Nextcloud bot
64659dae12
[tx-robot] updated from transifex 2020-10-01 03:41:31 +00:00
Tobias Kaminsky
d782da2fe9
Merge pull request #6917 from jmue/fixStaleFileContents
DocumentsStorageProvider: prevent opening stale file contents
2020-09-30 11:35:51 +02:00
Nextcloud bot
d3c33c1f95
[tx-robot] updated from transifex 2020-09-30 03:40:57 +00:00
Nextcloud bot
c3731a3e1e
[tx-robot] updated from transifex 2020-09-29 03:42:45 +00:00
Nextcloud bot
92e28a40d2
[tx-robot] updated from transifex 2020-09-28 03:39:14 +00:00
Nextcloud bot
ca1509cda5
[tx-robot] updated from transifex 2020-09-27 03:38:27 +00:00
Nextcloud bot
f38c84f11f
[tx-robot] updated from transifex 2020-09-26 03:39:23 +00:00
dassio
b408c74b04 add skip option in case of name collision
Signed-off-by: dassio <dassio@icloud.com>
2020-09-25 11:46:49 +01:00
tobiasKaminsky
2d0a8cceee
re-add grey200
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-25 12:20:20 +02:00
Tobias Kaminsky
01d6ab9c91
Merge pull request #7006 from nextcloud/errorTextSelectable
Stacktrace is selectable in error activity
2020-09-25 10:52:43 +02:00
Tobias Kaminsky
b5f75494c6
Merge pull request #7001 from nextcloud/mnemonic
enhance mnemonic on dark mode
2020-09-25 10:51:43 +02:00
Tobias Kaminsky
10de257720
Merge pull request #6997 from grote/4998-single-upload-notification
Re-use the existing foreground notification for FileUploader progress notifications
2020-09-25 07:42:15 +02:00
tobiasKaminsky
a29739c6de
enhance mnemonic on dark mode
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-25 07:41:33 +02:00
tobiasKaminsky
52472f500e
Stacktrace is selectable in error activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-25 07:35:35 +02:00
Tobias Kaminsky
f1e7a58767
Merge pull request #6999 from nextcloud/shimmerOnlyOnMedia
Do not show shimmer on folders
2020-09-25 07:24:49 +02:00
Nextcloud bot
86c54b1d1e
[tx-robot] updated from transifex 2020-09-25 03:43:13 +00:00
Torsten Grote
6dc30d88ba
Re-use the existing foreground notification for FileUploader progress
notifications

Signed-off-by: Torsten Grote <t@grobox.de>
2020-09-24 09:35:12 -03:00
tobiasKaminsky
950c393d69
Do not show shimmer on non-media files
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-24 13:08:06 +02:00
Tobias Kaminsky
c781447559
Merge pull request #6504 from nextcloud/sharingPart2
Sharing part2
2020-09-24 09:11:06 +02:00
Nextcloud bot
44f1a50cdb
[tx-robot] updated from transifex 2020-09-24 03:40:06 +00:00
tobiasKaminsky
e70aedaae7
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-23 15:52:12 +02:00
tobiasKaminsky
7fdda6ace0
use new server for tests
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-23 11:22:45 +02:00
tobiasKaminsky
5c9f5a5c4f
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-23 10:08:38 +02:00
tobiasKaminsky
ed90d07a17
detekt, ktlint
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-23 09:39:58 +02:00
Tobias Kaminsky
750e4de407
Merge pull request #6983 from nextcloud/sso
directly go back to app if SSO is used
2020-09-23 09:27:53 +02:00
tobiasKaminsky
92070d2934
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-23 09:26:04 +02:00
tobiasKaminsky
6a1292d690
Rename .java to .kt
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-23 09:26:04 +02:00
drone
b516eaf657 Merge commit 'c95615aeaa7090c5b4e6e07fdd6e790af31a5b00' 2020-09-23 06:14:57 +00:00
tobiasKaminsky
c95615aeaa
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-23 08:14:35 +02:00
Torsten Grote
f7e711d98d
Update DocumentsProvider roots when enabling/disabling app lock feature
Signed-off-by: Torsten Grote <t@grobox.de>
2020-09-22 16:50:10 -03:00
tobiasKaminsky
c8a49d99ba
Merge remote-tracking branch 'remotes/origin/master' into sharingPart2
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-22 08:14:43 +02:00
tobiasKaminsky
b01fdbab1b
New media scanner: only use with valid path
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-21 13:22:10 +02:00
tobiasKaminsky
07e4ac28df
directly go back to app if SSO is used
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-21 11:19:52 +02:00
Andy Scherzinger
c11e44257a
Merge pull request #6981 from nextcloud/webviewDebugOnDev
Add debug webview when using versionDev built
2020-09-21 09:21:10 +02:00
Tobias Kaminsky
7415f7ea2c
Merge pull request #6928 from nextcloud/doNotShowListHeaderOnResume
Do not show sortList group upon resume
2020-09-21 09:05:35 +02:00
tobiasKaminsky
9e2b101663
Add debug webview when using versionDev built
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-21 07:33:31 +02:00
Nextcloud bot
900e6f1c8d
[tx-robot] updated from transifex 2020-09-21 03:33:27 +00:00
Nextcloud bot
8c07a92615
[tx-robot] updated from transifex 2020-09-20 03:33:04 +00:00
Nextcloud bot
c5734bc1da
[tx-robot] updated from transifex 2020-09-19 03:35:30 +00:00
Nextcloud bot
8fe5ce3ce0
[tx-robot] updated from transifex 2020-09-18 03:32:21 +00:00
Tobias Kaminsky
5f8bd7d5f0
Merge pull request #6961 from nextcloud/comment
Fix not showing comments in file detail view
2020-09-17 16:31:05 +02:00
Tobias Kaminsky
1e09ae2787
Merge pull request #6947 from nextcloud/removeDualPane2
Remove dual pane for rich workspaces
2020-09-17 16:19:07 +02:00
Nextcloud bot
074af5c104
[tx-robot] updated from transifex 2020-09-17 04:15:06 +00:00
tobiasKaminsky
ea623aa01e
Remove dual pane for rich workspaces
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-16 11:00:46 +02:00
tobiasKaminsky
4ca33a8438
- removed test data
- added tests

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-16 10:36:06 +02:00
Nextcloud bot
f50a204a79
[tx-robot] updated from transifex 2020-09-16 03:29:18 +00:00
Andy Scherzinger
19df0c9695
Merge pull request #6866 from nextcloud/2charUI
UI test: sharees in file list
2020-09-15 13:52:17 +02:00
tobiasKaminsky
e0700c376c
new tests for avatars, shares in OCFileList
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-15 08:47:31 +02:00
Jens Mueller
69f3f804e2 fix ktlint
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2020-09-15 05:36:32 +02:00
Jens Mueller
a4b0e29d80 fix review comments
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2020-09-14 20:35:20 +02:00
tobiasKaminsky
d09490eb89
fix #6818
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-14 15:10:18 +02:00
tobiasKaminsky
75cd055676
remove unneeded parentheses
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-14 14:59:30 +02:00
tobiasKaminsky
27277f1970
open PreviewTextFragment within left fragment
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-14 14:59:30 +02:00
tobiasKaminsky
edaffa4c0f
detect tablet mode again
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-14 14:59:30 +02:00
Nextcloud bot
65145ca1c5
[tx-robot] updated from transifex 2020-09-13 03:20:33 +00:00
Nextcloud bot
9a1554f650
[tx-robot] updated from transifex 2020-09-12 03:21:07 +00:00
Jens Mueller
f9a82f9ed9 add integration test
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2020-09-12 00:09:51 +02:00
Jens Mueller
c00e7b3dbb fix review comments
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2020-09-12 00:02:49 +02:00
Tobias Kaminsky
fe3ef767cd
Merge pull request #6918 from jmue/storageProviderCleanup
unify context access
2020-09-11 10:47:16 +02:00
Tobias Kaminsky
caabf7b5dc
Merge pull request #6880 from grote/upload-retries
Don't disable upload retries for uploads from DocumentsProvider
2020-09-11 10:36:31 +02:00
Jens Mueller
a5272c5700 fix codacy comments
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2020-09-10 21:36:27 +02:00
Jens Mueller
cae0e77267 fix codacy comments
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2020-09-10 21:12:03 +02:00
tobiasKaminsky
eb839c3968
do not use internal FieldSetter
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-10 12:46:51 +02:00
Tobias Kaminsky
7f729e630e
Merge pull request #6892 from nextcloud/richWorkspacesTest
add tests for rich workspaces
2020-09-10 08:15:00 +02:00
Nextcloud bot
23cc09bc0b
[tx-robot] updated from transifex 2020-09-10 03:27:24 +00:00
Jens Mueller
e15f8fbc6c DocumentsStorageProvider: prevent opening stale file contents
fix #6883

Signed-off-by: Jens Mueller <tschenser@gmx.de>
2020-09-09 20:27:46 +02:00
Jens Mueller
b329bc9149 unify context access
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2020-09-09 20:17:30 +02:00
Torsten Grote
6699c2437a
Don't disable upload retries for uploads from DocumentsProvider
Signed-off-by: Torsten Grote <t@grobox.de>
2020-09-09 16:38:51 +02:00
tobiasKaminsky
6c7b96db53
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 16:37:20 +02:00
tobiasKaminsky
be357db8f1
codacy
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:52 +02:00
tobiasKaminsky
0d942cca55
ktlint
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:52 +02:00
tobiasKaminsky
1a32e9b268
detekt
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:52 +02:00
tobiasKaminsky
a6c898d2a5
cleanup
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:52 +02:00
tobiasKaminsky
50c7635869
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:49 +02:00
tobiasKaminsky
bd3f22f65d
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:35 +02:00
tobiasKaminsky
d6d0c5939c
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:35 +02:00
tobiasKaminsky
01f27dd08c
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:35 +02:00
tobiasKaminsky
4dfefee31a
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:35 +02:00
tobiasKaminsky
8b6171361a
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:35 +02:00
tobiasKaminsky
7b2ed741bd
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:35 +02:00
tobiasKaminsky
4f8de5731d
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:35 +02:00
tobiasKaminsky
a470bd1f56
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:35 +02:00
tobiasKaminsky
996b0f0e67
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:35 +02:00
tobiasKaminsky
20d24d8a6d
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:35 +02:00
tobiasKaminsky
82d36f0cab
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 13:06:35 +02:00
tobiasKaminsky
90efc2cdfc
add tests for rich workspaces:
as we will have light/dark screenshots for all, we do not have to do this here manually

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-09 12:59:55 +02:00
Nextcloud bot
1c9506c86f
[tx-robot] updated from transifex 2020-09-09 03:21:19 +00:00
Tobias Kaminsky
fdeca7c5a2
Merge pull request #6900 from nextcloud/fixCheckIfEnoughSpace
Fix npe on computing enough space with non-downloaded folder content
2020-09-08 14:38:15 +02:00
tobiasKaminsky
1547bc7b16
Fix npe on computing enough space with non-downloaded folder content
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-08 07:07:51 +02:00
Nextcloud bot
bcb82833d7
[tx-robot] updated from transifex 2020-09-08 03:21:15 +00:00
Tobias Kaminsky
51cf63b79b
Merge pull request #6886 from nextcloud/docImage
DocumentsStorageProvider: open thumbnail directly
2020-09-07 10:02:35 +02:00
Nextcloud bot
d031185f48
[tx-robot] updated from transifex 2020-09-05 03:30:42 +00:00
tobiasKaminsky
5db18a24d3
DocumentsStorageProvider: open thumbnail directly
fix #6884

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-04 08:15:34 +02:00
Tobias Kaminsky
77c0d4b054
Merge pull request #6533 from nextcloud/ocFileListTest
add TestActivity to launch fragments in it
2020-09-04 07:51:43 +02:00
Nextcloud bot
a3dbd08ac2
[tx-robot] updated from transifex 2020-09-04 03:31:08 +00:00
tobiasKaminsky
3972ddf98c
do not use preview, but directly show placeholder
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-03 15:53:04 +02:00
Tobias Kaminsky
8af7aefd81
Merge pull request #6871 from jmue/fix-share-scrollview
fix inplace scrollview in sharing fragment
2020-09-03 10:25:04 +02:00
Tobias Kaminsky
33ece4a557
Merge pull request #6817 from nextcloud/avatar
Avatar: use display name & adapted algorithm to server one
2020-09-03 10:21:57 +02:00
tobiasKaminsky
16d839c262
use longer sleep
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-03 10:08:10 +02:00
tobiasKaminsky
e07c2d169a
- use display name for avatar generation
- use new server algorithm
Ref: https://github.com/nextcloud/nextcloud-vue/blob/master/src/functions/usernameToColor/usernameToColor.js

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-03 09:19:03 +02:00
Nextcloud bot
546907ac57
[tx-robot] updated from transifex 2020-09-03 03:30:46 +00:00
tobiasKaminsky
68adfc6c4d
removed outdated search enums
longer pause

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-02 15:20:47 +02:00
Tobias Kaminsky
ebd39db114
Merge pull request #6822 from nextcloud/reduceFileActivity
Reduce extend of FileActivity, use DrawerActivity instead
2020-09-02 15:15:46 +02:00
Tobias Kaminsky
3b2eb969c4
Merge pull request #6870 from nextcloud/testUploadConditions
Fix not waiting for non-metered wifi
2020-09-02 13:38:29 +02:00
Tobias Kaminsky
1381f594f7
Merge pull request #6858 from nextcloud/fixAccountWarning
Fix crashing app when adding same account for second time when using qrCode
2020-09-02 13:37:36 +02:00
Tobias Kaminsky
f807397bdd
Merge pull request #6806 from nextcloud/grote/improve-documentsprovider-add-tests
Improve DocumentsProvider and add tests
2020-09-02 12:27:17 +02:00
Tobias Kaminsky
90978dda4a
Merge pull request #6875 from nextcloud/trashbinIT
fix Trashbin IT
2020-09-02 11:02:30 +02:00
tobiasKaminsky
430a94ff0e
fix Trashbin IT
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-02 10:12:19 +02:00
Tobias Kaminsky
47d66d6356
Merge pull request #6748 from nextcloud/noStickyBroadcasts
no sticky broadcast
2020-09-02 09:33:42 +02:00
tobiasKaminsky
86d1a2820f
fix spotbugs
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-02 09:31:32 +02:00
Tobias Kaminsky
75066c8673
Merge pull request #6798 from nextcloud/ezaquarii/fix-illegal-state-exception-when-stopping-audio-player
Start audio player using foreground service API on Android 26+
2020-09-02 09:04:28 +02:00
Nextcloud bot
0efd71d62c
[tx-robot] updated from transifex 2020-09-02 05:32:13 +00:00
Jens Mueller
031e506ec0 fix inplace scrollview in sharing fragment
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2020-09-01 17:17:53 +02:00
tobiasKaminsky
4e0c111395
removed unneeded layout
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-01 13:11:15 +02:00
tobiasKaminsky
e6a516f10a
Fix not waiting for non-metered wifi
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-01 12:35:20 +02:00
tobiasKaminsky
a3cb17a829
add TestActivity to launch fragments in it
fix wrong class cast exception message

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-31 17:05:57 +02:00
tobiasKaminsky
fc2e84a5b0
do not use scale larger than max scale
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-31 11:07:11 +02:00
tobiasKaminsky
ebf7097042
Fix crashing app when adding same account for second time when using qrCode
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-31 10:52:33 +02:00
Tobias Kaminsky
90a7e00c62
Merge pull request #6762 from nextcloud/enoughSpaceComputation
compute space: take downloaded folder into account
2020-08-31 08:25:44 +02:00
tobiasKaminsky
15dcad229c
no sticky broadcast:
- use local broadcast system instead
- no need to remove sticky broadcasts then

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-28 12:34:20 +02:00
Tobias Kaminsky
adff9511e9
Merge pull request #6819 from nextcloud/twoChars
Use two chars for avatars
2020-08-28 12:27:40 +02:00
Torsten Grote
27f48b331f
Instrumentation tests for DocumentsProvider
Note there's still some FIXMEs in the tests that hint at bugs discovered
by the tests.

Also this is very incomplete, but a good beginning for further tests.

Signed-off-by: Torsten Grote <t@grobox.de>
2020-08-27 11:18:14 -03:00
Torsten Grote
1fdea37c2b
Improve DocumentsProvider implementation
The initial goal was to make all operations completely synchronous,
so failures can be detected by apps using our DocumentsProvider.

However, `#openDocument()` could not be made fully synchronous,
because we need to wait for the ParcelFileDescriptor we are returning to
close before we can upload a file.
Nextcloud works with locally cached files that only get synchronized to
remote storage.

Things I have tried:

* Use the Handler from the calling I/O Thread:
  not guaranteed to have a prepared Looper,
  so can't always create Handler on that Thread
* Extend ParcelFileDescriptor and override its close() methods:
  For some reason they don't get called when the stream gets closed
* notify the content URI when the upload is complete,
  so callers can wait for the notification:
  works, but is non-standard.
  Other DPs are not doing it,
  so it requires Nextcloud specific code on caller side
  and is still hacky:
  what happens if notification doesn't come? Timeout, but for how long?
* use other ways to get a ParcelFileDescriptor on the file:
  couldn't find anything that would interface with Nextcloud's
  current architecture

Signed-off-by: Torsten Grote <t@grobox.de>
2020-08-27 11:18:13 -03:00
tobiasKaminsky
6fcc95d117
compute space: take downloaded folder into account
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-27 15:38:27 +02:00
Tobias Kaminsky
da2352974c
Merge pull request #6774 from nextcloud/noNullOnDataSet
arbitrary data set: store "" instead of null
2020-08-27 15:31:40 +02:00
Tobias Kaminsky
c149813e2b
Merge pull request #6805 from nextcloud/ezaquarii/fix-unresponsive-audio-player-controls-with-linear-layout
Fix unresponsive preview player controls
2020-08-27 15:31:12 +02:00
Tobias Kaminsky
8a5d58a64e
Merge pull request #6725 from grote/is-child-performance
Improve performance of DocumentsProvider#isChildDocument()
2020-08-27 15:29:15 +02:00
Nextcloud bot
9183e3c9d1
[tx-robot] updated from transifex 2020-08-27 03:31:06 +00:00
tobiasKaminsky
2a0f14231a
Reduce extend of FileActivity, use DrawerActivity instead
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-26 15:14:21 +02:00
tobiasKaminsky
12f827e063
Use two chars for avatars
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-26 10:41:27 +02:00
Tobias Kaminsky
8fc2bcdab0
Merge pull request #6807 from merttumer/master
Fix insert image file picker only opens once
2020-08-26 09:10:30 +02:00
Nextcloud bot
6b80669000
[tx-robot] updated from transifex 2020-08-26 03:31:16 +00:00
merttumer
e37635e602
Fix insert image file picker only opens once
When no image is selected from the intent we should set onReceiveValue to null and uploadMessage to null otherwise it does not open after closing it without selecting an image.
2020-08-25 22:51:12 +03:00
Chris Narkiewicz
6feedf881f
Start audio player using foreground service API on Android 26+
On API 26+ (Oreo, 8.0) running background services is restricted
by power saving mechanisms, causing occasional IllegalStateException
when service intent is rejected by the OS.

Migrate to startForegroundService API to mitigate this problem.
Audio player service is foreground by design.

Fixes #6665

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-08-25 18:55:13 +01:00
Chris Narkiewicz
6e6f8303a8
Fix unresponsive preview player controls
Media controls view were covered by a ScrollView
stealing all touch events. By changing it to FrameLayout,
touch events can reach media controls.

Content embedded inside ScrollView should not
exceed screen boundaries. If so - content must
be changed.

This fixes immediate problem with unresponsive media controls
reported in #6796 and #6782.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-08-25 18:24:58 +01:00
Torsten Grote
e8870334d2
Improve performance of DocumentsProvider#isChildDocument()
The old solution iterates through all parents of the child until it
finds the given parent or the storage root.
This has been show to be very expensive in empirical tests.

Therefore, this commit introduces a more efficient solution that simply
compares the file paths of child and given parent.
It also ensures that parent and child belong to the same account.

Reviewers need to take extra care that this change does not introduce
security issues by claiming a document is a child of a parent when it is
really not.

Signed-off-by: Torsten Grote <t@grobox.de>
2020-08-25 09:32:48 -03:00
tobiasKaminsky
a79a780129
arbitrary data set: store "" instead of null
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-25 08:43:32 +02:00
Tobias Kaminsky
a90cf6a364
Merge pull request #6786 from nextcloud/dependabot/gradle/com.pinterest-ktlint-0.38.0
Bump ktlint from 0.37.2 to 0.38.0
2020-08-24 10:09:55 +02:00
Tobias Kaminsky
ad7564b942
Merge pull request #6751 from grote/6726-documentsprovider-0-bytes
Reset last sync date of files written via DocumentsProvider
2020-08-24 09:51:10 +02:00
Tobias Kaminsky
3d083444fd
Merge pull request #6772 from nextcloud/crashOnBrokenThumbnail
return onError in onPostExecute (which runs on UI thread)
2020-08-24 09:32:13 +02:00
Tobias Kaminsky
e13b580611
Merge pull request #6775 from nextcloud/doNotPreviewHTML
do not preview html within our text view
2020-08-24 09:29:14 +02:00
Tobias Kaminsky
59e6722b11
Merge pull request #6771 from nextcloud/fixSyncConflictOnAutoUpload
Fix #5755
2020-08-24 09:02:14 +02:00
tobiasKaminsky
f0f467d2a1
fix code formatting according to new ktlint
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-24 08:36:43 +02:00
Nextcloud bot
d20a006ad6
[tx-robot] updated from transifex 2020-08-24 03:32:28 +00:00
Nextcloud bot
0b3826fcf8
[tx-robot] updated from transifex 2020-08-23 03:33:15 +00:00
Nextcloud bot
ce041065c5
[tx-robot] updated from transifex 2020-08-22 03:30:14 +00:00
Torsten Grote
64ec705398
Reset last sync date of files written via DocumentsProvider
The sync operation detects changes by comparing timestamps in
milliseconds. However, the local modification time only has a precision
of seconds (even though given in milliseconds).
When the DocumentsProvider is used programmatically, operations such as
a create and a subsequent write can happen within the same second
causing the sync operation to not detect the change and therefore
failing to upload a file causing data loss.

This commit also moves the file close listener to the thread used by the
DocumentsStorageProvider as this is more appropriate than the UI thread.

Fixes #6726

Signed-off-by: Torsten Grote <t@grobox.de>
2020-08-21 09:15:19 -03:00
tobiasKaminsky
856916e658
do not preview html within our text view
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-21 11:44:57 +02:00
tobiasKaminsky
c50798cd24
return onError in onPostExecute (which runs on UI thread)
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-21 10:46:11 +02:00
tobiasKaminsky
23b05f3a56
Fix #5755
- use correct name collision info by synced folder
- syncedFolder.getNameCollisionPolicyInt -> returns int
- syncedFolder.getNameColllisionPolicy -> returns enum
- remove not needed backgroundJobManager from FilesSyncWork.kt

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-21 09:21:32 +02:00
Nextcloud bot
bf460b7451
[tx-robot] updated from transifex 2020-08-21 03:31:44 +00:00
tobiasKaminsky
886d42dc0f
Fix crash on setting password
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-20 12:30:18 +02:00
Tobias Kaminsky
800da337e9
Merge pull request #6744 from nextcloud/mnemonicTest
fix mnemonic test
2020-08-20 10:39:10 +02:00
Nextcloud bot
b75b151906
[tx-robot] updated from transifex 2020-08-20 03:33:56 +00:00
tobiasKaminsky
43d2edec47
also fix FDA open test
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-19 10:22:06 +02:00
tobiasKaminsky
0ecc933d5f
fix mnemonic test
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-19 09:19:26 +02:00
Nextcloud bot
47898e5d0d
[tx-robot] updated from transifex 2020-08-19 03:34:36 +00:00
Tobias Kaminsky
5a1e57dbd1
Merge pull request #6724 from nextcloud/hideBigLoadingSpinner
Do not show big spinner when initial loading a folder that is known to be not empty
2020-08-18 09:38:39 +02:00
Tobias Kaminsky
5640c8c522
Merge pull request #6715 from nextcloud/fabOnSharing
hide FAB on sharing view
2020-08-18 08:45:05 +02:00
tobiasKaminsky
a6e0d2b8bf
Do not show big spinner when initial loading a folder that is known to be not empty, or on PhotoFragment
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-18 08:40:15 +02:00
Tobias Kaminsky
cd3cd7962a
Merge pull request #6701 from nextcloud/fix/dialogButtonTinting
Correct call order when tinting the dialog button
2020-08-18 08:30:27 +02:00
Tobias Kaminsky
872901fca4
Merge pull request #6714 from nextcloud/e2e_oldsupport
E2E: support old iv delimiter, read only
2020-08-18 07:54:28 +02:00
Nextcloud bot
0fe4115a67
[tx-robot] updated from transifex 2020-08-18 03:36:21 +00:00
tobiasKaminsky
c88cd18774
E2E: support old iv delimiter, read only
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-17 20:28:45 +02:00
Torsten Grote
8fbfc9028a
Ensure that mNotificationManager is not null when updating transfer progress
This might happen, if the FileUploader service is being destroyed,
so mNotificationManager is set to null.

The applied fix has been used in a couple of other places in this file
as well, so it is at least consistent.

Signed-off-by: Torsten Grote <t@grobox.de>
2020-08-17 11:03:39 -03:00
Andy Scherzinger
2bead6a747
make sure sorting is hidden too for details view
remove redundant calls

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-08-17 13:58:47 +02:00
tobiasKaminsky
2a48130c55
hide FAB on sharing view
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-17 11:22:29 +02:00
Nextcloud bot
f71827c014
[tx-robot] updated from transifex 2020-08-17 03:29:39 +00:00
tobiasKaminsky
be04dec3ea
add tests
- for error: UI test
- for mnemonic: we cannot capture dialog, so it is only an integration test

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-17 03:01:30 +02:00
Nextcloud bot
e26b403e42
[tx-robot] updated from transifex 2020-08-16 03:29:45 +00:00
Andy Scherzinger
f2f4265a42
Fixes #6675 correct call order when tinting the dialog button
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-08-14 10:09:21 +02:00
Nextcloud bot
d85063ef67
[tx-robot] updated from transifex 2020-08-14 03:46:02 +00:00
Nextcloud bot
f1dfd44f07
[tx-robot] updated from transifex 2020-08-13 03:32:10 +00:00
Nextcloud bot
f35ef1b320
[tx-robot] updated from transifex 2020-08-12 03:31:51 +00:00
Nextcloud bot
7daf2bfa5d
[tx-robot] updated from transifex 2020-08-11 03:31:28 +00:00
Tobias Kaminsky
7e08278246
Merge pull request #6667 from nextcloud/sortUpload
add sort option to UploadFilesActivity and FolderPickerActivity
2020-08-07 19:09:00 +02:00
tobiasKaminsky
bee0c7b4a1
add sort option to UploadFilesActivity and FolderPickerActivity
added UI tests

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-07 17:51:22 +02:00
Andy Scherzinger
babbd23bf2
Merge pull request #6669 from nextcloud/duplicatedFAB
removed FAB from text file preview and use FDA one
2020-08-07 14:17:34 +02:00
tobiasKaminsky
92301735af
removed FAB from text file preview and use FDA one
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-07 13:56:08 +02:00
Tobias Kaminsky
5d21b3668d
Merge pull request #6651 from nextcloud/fixLinkIcon
make + icon grey600 for proper icon coloring dark/light
2020-08-07 11:24:46 +02:00
Andy Scherzinger
cd2c2d858b
Merge pull request #6662 from nextcloud/npeExpirationDate
fix npe on setting expiration date on public share
2020-08-07 09:39:22 +02:00
tobiasKaminsky
898708cfc8
fix npe on setting expiration date on public share
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-07 09:04:47 +02:00
Nextcloud bot
ff0dd4ace4
[tx-robot] updated from transifex 2020-08-07 03:33:43 +00:00
Tobias Kaminsky
5b22cbe038
Merge pull request #6655 from nextcloud/ezaquarii/rename-downloader-to-transfer-manager
Rename Downloader to TransferManager
2020-08-06 14:01:49 +02:00
Nextcloud bot
2d1dc5775d
[tx-robot] updated from transifex 2020-08-06 03:32:34 +00:00
Chris Narkiewicz
b0053d1481
Rename Downloader to TransferManager
As the Downloader architecture can support any type of
asynchronous operations so we can easily support file uploads.

Rename Downloader to TransferManager to reflect this.
This is just a rename, without upload implementation.
Upload feature shall follow in separate PRs.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-08-06 00:05:52 +01:00
Andy Scherzinger
9db4585224
make + icon grey600 for proper icon coloring dark/light
Fixes #6647

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-08-05 12:43:26 +02:00
Andy Scherzinger
8d82203c15
Merge pull request #6646 from nextcloud/activityCompare
object.getId() can also be a string if RichObjects refers to an user
2020-08-05 12:23:04 +02:00
dependabot-preview[bot]
81d75ad5dd
Merge pull request #6645 from nextcloud/dependabot/gradle/com.google.android.material-material-1.2.0 2020-08-05 08:47:41 +00:00
tobiasKaminsky
5ad6cafb92
change test to directly launch SyncedFoldersActivity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-05 10:22:40 +02:00
tobiasKaminsky
c8863c61b0
object.getId() can also be a string if RichObjects refers to an user
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-05 08:30:33 +02:00
Nextcloud bot
433e1c0c16
[tx-robot] updated from transifex 2020-08-05 03:32:52 +00:00
Nextcloud bot
66d9465e11
[tx-robot] updated from transifex 2020-08-04 12:44:52 +00:00
Andy Scherzinger
a255c27f4f
Merge pull request #6627 from nextcloud/fixE2Esync
Sync of encrypted folders, in sync with RefreshFolderOperation.synchronizeData
2020-08-04 13:09:35 +02:00
Chris Narkiewicz
67e6c3402c Rename Download into Transfer
Extending Download into more generic Transfer that
can support both downloads and uploads.

Upload functionality is not provided in this PR - it's
only a rename.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2020-08-03 23:23:16 +01:00
Andy Scherzinger
d745a2cbbf
Merge pull request #6556 from nextcloud/trashbinLoadingTests
TrashbinActivity: viewbindings tests
2020-08-03 20:49:50 +02:00
Andy Scherzinger
111daf1162
Merge pull request #6623 from nextcloud/fixOClistOnAutoUpload
OCFileListFragment can be used witout FDA, and this crashed
2020-08-03 20:33:28 +02:00
tobiasKaminsky
f7ab5d90dc
TrashbinActivity:
- moved to ViewBindings
- add UI test for error/view

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-03 20:05:31 +02:00
Andy Scherzinger
607ed3115e
Merge pull request #6595 from nextcloud/hidCursor
Hide cursor to make UI test more stable
2020-08-03 19:16:14 +02:00
tobiasKaminsky
93104917a7
Sync of encrypted folders, in sync with RefreshFolderOperation.synchronizeData
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-03 12:08:36 +02:00
tobiasKaminsky
3c5549adac
OCFileListFragment can be used witout FDA, and this crashed
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-08-03 08:31:45 +02:00
Valdnet
68cae46c96
l10n: Add a period in the text string 2020-07-31 15:46:51 +02:00
tobiasKaminsky
e9733ad744
- fix dummy storage location
- dummy files are re-created if needed

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-31 10:55:21 +02:00
tobiasKaminsky
7f339f9fe0
updated tests
Upload:
- obey LOCAL_BEHAVIOUR_COPY
- correct storage path for encrypted files in subdirectories

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-31 10:55:21 +02:00
tobiasKaminsky
78128ff5dc
Hide cursor to make UI test more stable
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-31 08:32:58 +02:00
Tobias Kaminsky
ba0005d930
Merge pull request #6592 from nextcloud/fixDetekt
Fix detekt: Random Date is magic number in test
2020-07-31 08:29:52 +02:00
Tobias Kaminsky
6469fdb658
Merge pull request #6585 from nextcloud/nullColor
parseColor("") throws IndexOutOfBounds, so catch all Exceptions is better
2020-07-31 08:13:28 +02:00
tobiasKaminsky
0d381c8233
Random Date is magic number in test
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-31 08:07:15 +02:00
tobiasKaminsky
07aff36578
added test cases
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-31 07:45:04 +02:00
Andy Scherzinger
6f38bf7a8b
Merge pull request #6586 from nextcloud/friendlyName
Fix crash when showing default storage friendly name
2020-07-30 17:11:38 +02:00
Andy Scherzinger
5f426223b2
Merge pull request #6580 from nextcloud/bige2eTest
E2E test with random files that are big enought to use chunked uploads
2020-07-30 17:08:05 +02:00
tobiasKaminsky
60b1f3702e
Fix crash when showing default storage friendly name
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-30 15:35:57 +02:00
tobiasKaminsky
528cd23cc0
parseColor("") throws IndexOutOfBounds, so catch all Exceptions is better
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-30 15:16:26 +02:00
Tobias Kaminsky
e35dfbffc9
Merge pull request #6579 from nextcloud/openVCF
open vcf works again
2020-07-30 15:02:58 +02:00
Tobias Kaminsky
afc54de8f1
Merge pull request #6557 from nextcloud/onDevice
wrong storage location
2020-07-30 14:54:02 +02:00
tobiasKaminsky
2c96094f21
E2E test with random files that are big enought to use chunked uploads
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-30 13:41:24 +02:00
tobiasKaminsky
75c8359781
open vcf works again
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-30 09:17:02 +02:00
Andy Scherzinger
372e478bfd
Merge pull request #6552 from nextcloud/contactsBackupTest
Contacts backup tests
2020-07-30 07:15:34 +02:00
Nextcloud bot
be3c0db309
[tx-robot] updated from transifex 2020-07-30 03:32:43 +00:00
Andy Scherzinger
663c0beda5
Merge pull request #6395 from cotechde/webauthn
add passwordless WebAuthn logins
2020-07-29 21:25:48 +02:00
Andy Scherzinger
a930d9b6e1
reformat code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-07-29 14:42:41 +02:00
tobiasKaminsky
8ef4e04312
only remove nextcloud accounts (no permission for others)
contact backup job: better rename than ask user, as we want to have backup not delayed
add test for contacts backup/import/vcard

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-29 14:42:41 +02:00
tobiasKaminsky
29a0c138c7
Remove all uploads after test for sure
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-29 13:00:50 +02:00
Tobias Kaminsky
0976f7abe2
Merge pull request #6566 from nextcloud/uiTestsColor
Test different primary colors / dark mode
2020-07-29 11:53:25 +02:00
tobiasKaminsky
c9c0ae9e46
Allow to run different colors on dark/light mode
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-29 11:20:25 +02:00
Andy Scherzinger
e02b9adf8a
hide sort/list group on previews
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-07-29 08:20:53 +02:00
Andy Scherzinger
130503a6e3
optimize sorting/layout bar spacing for home/search bar
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-07-29 08:20:52 +02:00
Andy Scherzinger
af924761b7
optimize toolbar layout
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-07-29 08:20:51 +02:00
Andy Scherzinger
e7cd9ce6bc
properly reset header for preview fragments
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-07-29 08:20:51 +02:00
Andy Scherzinger
ddd7b901da
proper coloring and sizing for toolbar_standard.xml(s)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-07-29 08:20:46 +02:00
Nextcloud bot
0a062ea937
[tx-robot] updated from transifex 2020-07-29 03:34:20 +00:00
Andy Scherzinger
774beec484
lint: Use ResourcesCompat.getDrawable()
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-07-28 21:20:44 +02:00
Andy Scherzinger
6b6e7c7f2c
lint: remove unused resources
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-07-28 21:17:16 +02:00
Andy Scherzinger
d1bd1dd16e
use proper testing date within this century
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-07-28 17:44:26 +02:00
Andy Scherzinger
ed229267d2
improve notification icon dark theming
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-07-28 17:28:15 +02:00