Commit graph

18246 commits

Author SHA1 Message Date
Álvaro Brey Vilas
d1d3a49a6b
OCFileListFragment: set title when attached to activity
This prevents wrong title while search isn't started yet (such as when returning to a search fragment from a preview fragment)

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-28 16:32:46 +01:00
Nextcloud bot
204cd5a2c5
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-28 03:54:54 +00:00
Valdnet
f28bc6f9f9
i18n: Change to a capital letter
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-01-27 17:12:02 +01:00
tobiasKaminsky
ebf59510fc remove gplay.gradle, use gplayImplementation instead
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-01-27 12:15:37 +00:00
Álvaro Brey
88605985a0
Merge pull request #9743 from nextcloud/fix/media-dark-duplicated
Fix crashes and double loading in GalleryFragment when changing dark theme
2022-01-27 12:35:35 +01:00
Álvaro Brey
3e97e1e212
Merge pull request #9761 from nextcloud/fix/local-files-freeze
Improve freezes in local files screens when folder contains many files
2022-01-27 12:34:35 +01:00
Álvaro Brey
6ccd2f91de
Merge pull request #9760 from nextcloud/fix/passcode-cancel
PassCodeActivity: enable cancel button when re-created in confirmation step
2022-01-27 12:33:57 +01:00
Álvaro Brey
c2bdea7f74
Merge pull request #9762 from nextcloud/dependabot/gradle/androidx.fragment-fragment-ktx-1.4.1
Bump fragment-ktx from 1.4.0 to 1.4.1
2022-01-27 10:23:14 +01:00
Álvaro Brey Vilas
f3de5f9862
LocalFileListAdapter: fix case where directory==null
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:49:07 +01:00
Álvaro Brey Vilas
96c55a6d9f
FileSortOrder*: convert to Kotlin
Need more kotlin in the codebase and these were simple enough

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:49:07 +01:00
dependabot[bot]
dc7f3f88e1
Bump fragment-ktx from 1.4.0 to 1.4.1
Bumps fragment-ktx from 1.4.0 to 1.4.1.

---
updated-dependencies:
- dependency-name: androidx.fragment:fragment-ktx
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-27 08:38:05 +00:00
Álvaro Brey Vilas
7baa0f8da4
LocalFileListAdapter: Also change sort order asynchronously
Changing sort  order is also slow.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
2baf63d809
AlphaNumComparator: optimize usage and resolve signature problems
- Methods had ambiguous signatures (parameterized compare<T> overlapped the various typed compare()). This made the compiler very confused.
 - In several places throughout the app, AlphaNumComparator was getting repeatedly instantiated just to manually call a typed compare(). This was very wasteful

To solve both problems, the typed compare() methods have been been made static.

The performance gains of not instantiating the comparator repeatedly are very noticeable. In a test loading a local folder for upload with 1000 files in it,
time of load is reduced from 28 seconds to 17 seconds.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
462da35fdb
LocalFileList: load local files asynchronously
Loading a large list of files (especially the sorting part) is S L O W.
This ensures it doesn't block the UI while loading.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
c5ebc05964
PassCodeActivity: enable cancel button when re-created in confirmation step
Prevents a bug where the cancel button would stop working if the device was rotated

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:20:00 +01:00
Álvaro Brey
618a770349
Merge pull request #9751 from nextcloud/fix/clear-data
Fix some crashes and weird behaviours when clearing data
2022-01-27 09:18:21 +01:00
Álvaro Brey
4a29c2e4c4
Merge pull request #9726 from nextcloud/fix/immutable-intents
Make PendingIntents immutable
2022-01-27 09:16:03 +01:00
nextcloud-android-bot
d51268d7b8
Drone: update FindBugs results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-01-26 14:09:47 +01:00
nextcloud-android-bot
af2059660f Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-01-26 12:08:19 +00:00
Álvaro Brey Vilas
c01fa0b170
Make more PendingIntents immutable
This should be all of them. Picked up by lint.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:56:05 +01:00
Álvaro Brey Vilas
27559efb79
Make PendingIntents immutable
Good practice for security

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:56:05 +01:00
Álvaro Brey
38c60b7618
Merge pull request #9758 from nextcloud/fix/analysis-again
Analysis: fix checkout and commit generation
2022-01-26 12:55:23 +01:00
Álvaro Brey Vilas
494cceab8e
Analysis: fix checkout and commit generation
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:54:24 +01:00
Álvaro Brey
7eaed66ebc
Merge pull request #9755 from nextcloud/dependabot/gradle/com.android.tools.build-gradle-7.1.0
Bump gradle from 7.0.4 to 7.1.0
2022-01-26 12:06:04 +01:00
Álvaro Brey Vilas
45fc831989
gplay/AndroidManifest: set exported value for service
picked up by lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
9d5395c8fd
ezvcard/ContactOperations: suppress locale lint in third_party class
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
043d839d70
build.gradle: Disable some translation errors in lint
Translations are handled in Transifex

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
a9ec1de015
manifest: Remove unneeded labels
Trips up lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
00586a5bde
BackgroundJobFactory: fix lint due to unchecked build version for ContentObserverJob
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
b6115a5fc1
lint: Fix getLayoutInflater calls
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
b07716c0e5
screenshotTest: uninstall app before running
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
9f2bdd5916
Analysis: use pull_request_target
Can't post reports otherwise as github token is readonly in pull_request

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
e35b6211f0
build.gradle: Run migrations for AGP 7.1.0
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:52 +01:00
dependabot[bot]
ae8752a4f7
Bump gradle from 7.0.4 to 7.1.0
Bumps gradle from 7.0.4 to 7.1.0.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-26 11:33:47 +01:00
Álvaro Brey
e6d64e5ed5
Merge pull request #9754 from nextcloud/dependabot/gradle/mockitoVersion-4.3.1
Bump mockitoVersion from 4.3.0 to 4.3.1
2022-01-26 10:45:40 +01:00
Álvaro Brey
41b3921643
Merge pull request #9744 from nextcloud/dependabot/gradle/com.karumi-shot-5.13.0
Bump shot from 5.11.2 to 5.13.0
2022-01-26 10:44:25 +01:00
Álvaro Brey Vilas
e1b41b5d77 ManageSpaceActivity: convert to Kotlin while we're here
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 08:32:49 +00:00
Álvaro Brey Vilas
db74d67168 ManageSpaceActivity: kill the app after finishing cleanup
This will prevent the file list still being on the Recents view and other stuff like that.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 08:32:49 +00:00
Álvaro Brey Vilas
83e56643f4 ManageSpaceActivity: remove user accounts when clearing data
This fixes crashes and unexpected states when restarting the app afterwards

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 08:32:49 +00:00
Nextcloud bot
750864d951
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-26 03:55:40 +00:00
dependabot[bot]
8e67653a38
Bump mockitoVersion from 4.3.0 to 4.3.1
Bumps `mockitoVersion` from 4.3.0 to 4.3.1.

Updates `mockito-core` from 4.3.0 to 4.3.1
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v4.3.0...v4.3.1)

Updates `mockito-android` from 4.3.0 to 4.3.1
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v4.3.0...v4.3.1)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.mockito:mockito-android
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-26 02:05:19 +00:00
Álvaro Brey Vilas
5a65c65e76
uploadReport: update shot path
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-25 10:41:06 +01:00
Álvaro Brey Vilas
80928a2799 GalleryFragment: force refresh on create, prevent unneeded refresh animations
This fixes bugs with double-loading and weird animations

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-25 08:50:29 +00:00
Álvaro Brey Vilas
7181249667 GalleryFragment: prevent NPE when recreating fragment
getStorageManager() is not available in onCreate

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-25 08:50:29 +00:00
Álvaro Brey
d057d48a89
Merge pull request #9745 from nextcloud/dependabot/gradle/mockitoVersion-4.3.0
Bump mockitoVersion from 4.2.0 to 4.3.0
2022-01-25 09:44:30 +01:00
Álvaro Brey
a8feb7bb66
Merge pull request #9718 from nextcloud/fix/recent-files
Fix minor issues with recently modified view
2022-01-25 09:13:58 +01:00
Álvaro Brey
b7f1ebd74b
Merge pull request #9742 from nextcloud/fix/analysis-on-push
Run analysis workflow on push too
2022-01-25 09:07:25 +01:00
dependabot[bot]
4c44d469e0
Bump mockitoVersion from 4.2.0 to 4.3.0
Bumps `mockitoVersion` from 4.2.0 to 4.3.0.

Updates `mockito-core` from 4.2.0 to 4.3.0
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v4.2.0...v4.3.0)

Updates `mockito-android` from 4.2.0 to 4.3.0
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v4.2.0...v4.3.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.mockito:mockito-android
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-25 02:04:50 +00:00
dependabot[bot]
d328d89c2d
Bump shot from 5.11.2 to 5.13.0
Bumps [shot](https://github.com/karumi/shot) from 5.11.2 to 5.13.0.
- [Release notes](https://github.com/karumi/shot/releases)
- [Commits](https://github.com/karumi/shot/compare/5.11.2...5.13.0)

---
updated-dependencies:
- dependency-name: com.karumi:shot
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-25 02:04:25 +00:00
Álvaro Brey Vilas
22367838ab
Run analysis workflow on push too
Otherwise baseline results aren't generated

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-24 16:25:33 +01:00