mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-12-23 01:00:26 +03:00
Code Issues Projects Releases Packages Wiki Activity
23173 commits 221 branches 1589 tags 640 MiB
Commit graph

11611 commits

Author SHA1 Message Date
Álvaro Brey Vilas
781fe1912c
FileDownloader: EXTRA_USER should be User, not Account 
Fixes #9935

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-03-08 16:30:51 +01:00
Álvaro Brey
59751c2fda
Merge pull request #9921 from akallabeth/download_async_task 
Fix #9842: Run network operations in async task
 2022-03-08 13:04:41 +01:00
Álvaro Brey Vilas
bfffad6bf4
DocumentsStorageProvider: clean up download threading 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-03-08 11:33:24 +01:00
akallabeth
a8c85a376d
Fix #9842: Run DocumentProvider.openDocument network operations in async task 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-03-08 11:33:19 +01:00
Álvaro Brey Vilas
b5f727f945 RetryTestRule: don't modify in scripts, use buildConfigField instead 
Modifying code in scripts is bad

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-03-08 09:43:38 +00:00
Álvaro Brey
fb6d8f8263
Merge pull request #9898 from nextcloud/chore/no-more-second-fragment 
FileDisplayActivity: finally get rid of secondFragment
 2022-03-08 10:23:26 +01:00
Nextcloud bot
4a9338d4fe
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-03-08 03:58:09 +00:00
Álvaro Brey Vilas
6b3742a131
SyncedFoldersActivity: cancel loading when activity stops 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-03-07 14:47:18 +01:00
Nextcloud bot
02dbe46d78
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-03-05 03:54:31 +00:00
Álvaro Brey Vilas
dc4f4bc512
SyncedFolderAdapter: load thumbnails in parallel instead of sequentially 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-03-04 17:29:51 +01:00
Álvaro Brey Vilas
c488b0b330
SyncedFoldersActivity: load content asynchronously 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-03-04 17:21:32 +01:00
Álvaro Brey Vilas
6b67362b7b
SyncedFoldersActivity: convert to Kotlin (step 2) 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-03-04 17:09:50 +01:00
Álvaro Brey Vilas
aad327de21
SyncedFoldersActivity: conver to Kotlin (step 1) 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-03-04 16:23:45 +01:00
Nextcloud bot
c08cfd9c8f
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-03-03 03:55:42 +00:00
Álvaro Brey
3383a6781a
Merge pull request #9884 from nextcloud/creationTime 
Correct handling of creation timestamp
 2022-03-02 12:52:16 +01:00
Álvaro Brey
263413d53f
Merge pull request #9881 from nextcloud/customCertInEditorWebView 
Allow accessing URLs with custom cert in editor
 2022-03-02 10:32:09 +01:00
Álvaro Brey
d9c605e425
Merge pull request #9896 from nextcloud/fix/preview-shared 
PreviewImageActivity: don't try to use virtual folder is type is NONE
 2022-03-01 16:56:15 +01:00
Álvaro Brey
4dfd837257
Merge pull request #9897 from nextcloud/fix/selection-clear-titlebar 
OCFileListFragment: don't reset title after clearing action mode (multiselect)
 2022-03-01 16:55:27 +01:00
Unpublished
3c002fa0c3
Allow EditorWebView accessing URLs with custom certificate 
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>

Drone: update Lint results to reflect reduced error/warning count

Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>

Drone: update FindBugs results to reflect reduced error/warning count

Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
 2022-03-01 16:26:37 +01:00
Álvaro Brey Vilas
39094c0ef7
UploadFileOperation: fix creationTimestamp type 
Thanks, spotbugs

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-28 17:48:34 +01:00
Álvaro Brey Vilas
7ff1d0d7d3
GalleryFragment: restore title and fab on resume 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-28 17:33:08 +01:00
Álvaro Brey Vilas
eeee11e427 PreviewImageActivity: don't try to use virtual folder is type is NONE 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-28 14:11:09 +00:00
Álvaro Brey Vilas
967327e321 OCFileListFragment: don't reset title after clearing action mode (multiselect) 
This breaks the title when in a virtual folder. There's no need for this, as the title is preserved anyway

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-28 14:10:57 +00:00
tobiasKaminsky
6d6339ebf6 Correct handling of creation timestamp 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-28 14:10:39 +00:00
Álvaro Brey Vilas
dd4770669f FileDisplayActivity: finally get rid of secondFragment 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-28 14:10:19 +00:00
Álvaro Brey Vilas
ba21b3a43f
OCFile: fix NPE in getLocalId when remoteID is null 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-28 12:51:05 +01:00
Nextcloud bot
b8aa447056
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-28 04:13:54 +00:00
Nextcloud bot
76c5dded8f
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-26 03:53:55 +00:00
tobiasKaminsky
8401427d96
Remove not needed toString() call 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Update src/main/java/com/owncloud/android/db/OCUpload.java

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
 2022-02-25 14:46:27 +01:00
tobiasKaminsky
7c7e7e845d remoteId not needed when deleting a file 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-25 12:49:47 +00:00
Nextcloud bot
5d943ad24b
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-25 03:53:59 +00:00
Álvaro Brey Vilas
1a0d3ed65b
Cleanup 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-24 11:49:20 +01:00
Álvaro Brey Vilas
5d07c4c6e4
Better exception report template 
With markdown now

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-24 11:42:55 +01:00
Álvaro Brey Vilas
4cc4418bec
ExceptionHandler: format entire stack trace recursively 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-24 11:03:32 +01:00
tobiasKaminsky
53a04af735
Add stacktrace directly to github issue 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-24 11:03:26 +01:00
Álvaro Brey
9b3c08efcd
Merge pull request #9880 from nextcloud/fixLoggerImpl 
Fix LoggerImpl to also log throwable
 2022-02-24 10:15:58 +01:00
Nextcloud bot
b124793817
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-24 03:56:56 +00:00
Unpublished
f50def5e0d Fix LoggerImpl to also log throwable 
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>
 2022-02-23 22:02:59 +01:00
Unpublished
fcd1ab88b5 Migrate from Parceler to kotlin-parcelize 
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>
 2022-02-23 17:08:32 +01:00
Álvaro Brey
00009680a3
Merge pull request #9859 from nextcloud/fix/video-stacking 
Misc fixes for video player
 2022-02-22 12:09:26 +01:00
Nextcloud bot
8f6e8f4927
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-22 03:56:19 +00:00
Álvaro Brey Vilas
71c0f657e2
PreviewVideoActivity: improve button UX 
- Add ripple on button click
 - Only show play OR pause button depending on playback state

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-21 17:39:43 +01:00
Álvaro Brey Vilas
87e508d2b1
Restore fast forward/rewind buttons in fullscreen video 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
7d89d68df6
PreviewVideoActivity: convert to Kotlin 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
329dea57a3
PreviewMediaFragment: fix restoring seek position when returning from fullscreen stream 
The stream asynctask was just ignoring the saved time

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
11e472b18b
PreviewVideoActivity: fix control buttons 
For some reason only previous/next were working.

Manually bind play and pause, and remove the rest

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
22555a901a
PreviewVideoActivity: pause player when activity stops 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
e419144456
PreviewVideoActivity: ensure player is stopped when closing fullscreen 
This already worked for onBackPressed

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
686748dda2
PreviewMediaFragment: stop video when stopping activity, and don't recreate existing player 
This avoids multiple instances of the player opening when minimizing the app, for example.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-21 17:39:42 +01:00
Álvaro Brey
c9018f8ba6
Merge pull request #9862 from nextcloud/fixLeakedCloseableViolation 
Fix LeakedCloseableViolations in getScaledBitmap
 2022-02-21 11:36:38 +01:00
Álvaro Brey
cb9d9ff1a2
Merge pull request #9858 from nextcloud/fix/preview-share 
Fix UX issues with toolbar in preview media fragment when using the "share" option
 2022-02-21 09:46:28 +01:00
Nextcloud bot
e4da58cfd2
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-21 03:55:57 +00:00
Unpublished
67397a4d7b Fix LeakedCloseableViolations in getScaledBitmap 
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>
 2022-02-20 12:56:28 +01:00
Nextcloud bot
5250b7380c
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-20 03:55:24 +00:00
Nextcloud bot
c704f59b37
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-19 03:55:54 +00:00
Álvaro Brey Vilas
7625275b07
Fix toolbar in PreviewMediaFragment after coming back from sharing fragment 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-18 13:48:17 +01:00
Álvaro Brey Vilas
66125d6a27
FileDisplayActivity: fix coordinator scrolling when opening share details from media preview 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-18 13:31:15 +01:00
thelittlefireman
9e7a9b410f
Add scan document feature 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-17 10:10:36 +01:00
Nextcloud bot
ee000f7b4e
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-17 03:55:25 +00:00
Tobias Kaminsky
1e33020f80
Merge pull request #9783 from nextcloud/mediaEnhancement 
Enhance media tab
 2022-02-16 10:42:33 +01:00
Álvaro Brey
f9febe24ad
Fallback pdf viewer (#9806) 
* Basic PDF preview

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Preview pdf: add dividers between pages

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Prefer third-party pdf viewers over fallback viewer

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Zoomable view for pdf pages

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

pdf preview: Show tip to indicate that zooming on images is possible

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: screenshot test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Fix spotbugs and lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewPdfFragment: fix screenshot test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewPdfFragment: fix toolbar when resuming

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewBitmapActivity: add screenshot test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewPdfFragment: fix crash in screenshot tests

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: rename tests

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* pdf preview: Update copyright headers

Oops

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: use grey for background instead of black

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: add scrollbar

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: show zoom tip 3 times instead of only once

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: fix lint and improve styling

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-15 15:04:16 +01:00
Tobias Kaminsky
9723c0458e
Merge pull request #9816 from nextcloud/pin 
Improve PIN lockout handling
 2022-02-15 14:54:08 +01:00
tobiasKaminsky
ea863cd04c
Fix test, satisfy spotbugs 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-15 14:52:55 +01:00
Álvaro Brey Vilas
df3c98a0c4
PassCodeManager: use abstracted Clock implementation rather than system clock directly 
Improves testability

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-15 11:23:36 +01:00
Álvaro Brey Vilas
aafa7780f6
PassCodeActivity: update lock timestamp when lock has just been set 
Prevents asking for pass immediately after setting it

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-15 10:27:11 +01:00
tobiasKaminsky
607d008a75
Make use of upload and creation timestamp 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-15 09:43:32 +01:00
tobiasKaminsky
3584b90bc6
Show empty message if no results 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-15 09:36:52 +01:00
tobiasKaminsky
b2bfd985da
Remove not needed check 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-15 09:23:50 +01:00
tobiasKaminsky
0624e7eef3
Satisfy CI 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-15 08:37:25 +01:00
Nextcloud bot
ac68a9269e
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-15 05:33:30 +00:00
Álvaro Brey Vilas
8b03556f71
PassCodeManager: convert to Kotlin, clean up, use injection 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-14 18:28:56 +01:00
Álvaro Brey Vilas
579af4ab30
PassCodeManager: don't count passcode/credentials activity towards activity counter 
This prevents repetition attacks

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-14 17:28:46 +01:00
Álvaro Brey
6d6183b3b0
Merge pull request #9208 from nextcloud/flaky-tests-again 
Add RetryTestRule to DrawerActivityIT
 2022-02-14 11:16:18 +01:00
Álvaro Brey
69033e25e9
Merge pull request #9823 from nextcloud/chore/mockitokotlin2 
Chore: replace `com.nhaarman.mockitokotlin2` with `org.mockito.kotlin`
 2022-02-14 11:09:47 +01:00
Tobias Kaminsky
b81027d057
Merge pull request #9791 from nextcloud/fix/shares-downloading-crash 
FileActivity: fix crash on share operations when FileDetailFragment is second fragment
 2022-02-14 09:06:22 +01:00
Tobias Kaminsky
c41f87d281
Merge pull request #9822 from nextcloud/chore/conflicts-dialog-logs 
ConflictsResolveActivity: Add log messages when dialog can't be created
 2022-02-14 09:00:28 +01:00
Tobias Kaminsky
1d4bc98de7
Merge pull request #9812 from nextcloud/avatarSize 
Use 512px for avatar
 2022-02-14 08:47:33 +01:00
Tobias Kaminsky
8b0674e29f
Merge pull request #9808 from nextcloud/resumeText 
resuming TextEditor after splitting screens works now again
 2022-02-14 08:40:09 +01:00
Tobias Kaminsky
541e55ff1c
Merge pull request #9821 from nextcloud/fix/db-upgrade-crash 
FileContentProvider: fix crash on certain upgrades
 2022-02-14 08:30:47 +01:00
tobiasKaminsky
fa73725815 Pin: use activity paused also, as stopped is sometimes too slow 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-14 07:30:00 +00:00
tobiasKaminsky
556f856ac3
Update adapter after finish search (success/failure) 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-14 07:35:51 +01:00
tobiasKaminsky
e17beb00ad
Do not show meta info (favorite, download status) in media view 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-14 07:35:51 +01:00
tobiasKaminsky
256656af5d
correctly return result 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-14 07:35:51 +01:00
tobiasKaminsky
307a407631
fix reloading bug 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-14 07:35:51 +01:00
tobiasKaminsky
07885c3a18
refactor/ clean up 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-14 07:35:51 +01:00
tobiasKaminsky
5140d8d99f
sql typo 
fix not showing images

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-14 07:35:51 +01:00
tobiasKaminsky
3bfc373e50
Enhance media tab 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-14 07:35:50 +01:00
Nextcloud bot
6b8ce02a2e
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-14 03:55:09 +00:00
Nextcloud bot
bbf1032845
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-12 03:55:56 +00:00
Álvaro Brey Vilas
2a6398adda
Chore: replace com.nhaarman.mockitokotlin2 with org.mockito.kotlin 
It has been integrated into the main mockito org, and the old ID no longer receives updates

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-11 18:32:15 +01:00
tobiasKaminsky
e20555f5d0 resuming TextEditor after splitting screens works now again 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-11 16:59:13 +00:00
Álvaro Brey Vilas
c506cda8a6 FileDisplayActivity: ditch secondFragment for FileDetailsFragment, use leftFragment instead 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-11 16:49:57 +00:00
Álvaro Brey Vilas
d82a989378 FileActivity: fix crash on share operations when FileDetailFragment is second fragment 
When a file is downloaded, FileDetailFragment is opened as SECOND_FRAGMENT instead of LIST_OF_FILES, which breaks this logic.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-11 16:49:57 +00:00
Álvaro Brey Vilas
9cf0f1d6fa
ConflictsResolveActivity: Add log messages when dialog can't be created 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-11 17:33:58 +01:00
Álvaro Brey Vilas
b5d338fb8d
FileContentProvider: fix crash on certain upgrades 
checkIfColumnExists should not use getColumnIndexOrThrow, as it's supposed to check if the index doesn't exist

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-11 13:57:03 +01:00
tobiasKaminsky
7ddbb65ca2 Use 512px for avatar 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-11 11:09:23 +00:00
tobiasKaminsky
1c9a3e0208 For display with >= 600dp use higher file icon resolution 
use this resolution also default thumbnails

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-02-11 11:09:20 +00:00
Álvaro Brey
4d9c878d4f
Merge pull request #9801 from nextcloud/chore/test-sort-order 
Update sorting tests
 2022-02-07 09:21:24 +01:00
Nextcloud bot
73c01d1ef4
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-07 03:54:38 +00:00
Nextcloud bot
559c41d880
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-05 03:54:13 +00:00
Álvaro Brey Vilas
08e7a761dc
NaturalSortTest: shuffle instead of duplicating parameters 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-04 13:55:07 +01:00
Álvaro Brey Vilas
64d386786c
Rename TestSorting to OCFileSortTest, conver to Kotlin, parameterize 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-04 13:55:07 +01:00
Álvaro Brey Vilas
bed01a2f0c
TestSorting: refactor and simplify since it's now only for OCFiles 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-04 13:12:52 +01:00
Álvaro Brey Vilas
e7e603f4d8
Move string sort tests from TestSorting to NaturalSortTest 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-04 13:02:42 +01:00
Álvaro Brey Vilas
d40fc88754
Move TestSorting to unit tests 
No reason for it to be an instrumented test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-04 12:54:45 +01:00
Álvaro Brey Vilas
91297b7ce0
Test AlphanumComparator 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-02-04 10:49:08 +01:00
Nextcloud bot
927babb3bf
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-04 03:55:25 +00:00
Nextcloud bot
c437db409e
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-03 03:55:06 +00:00
Nextcloud bot
dba8da00f0
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-02 03:55:45 +00:00
Nextcloud bot
190332ceaa
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-02-01 03:55:35 +00:00
Álvaro Brey
1ecbf61cc7
Merge pull request #9776 from nextcloud/fix/activity-title 
OCFileListFragment: set title when attached to activity
 2022-01-31 15:42:16 +01:00
Álvaro Brey
0c5afce10e
Merge pull request #9770 from nextcloud/Valdnet-patch-1 
i18n: Change to a capital letter
 2022-01-31 13:43:46 +01:00
Álvaro Brey Vilas
d1d3a49a6b
OCFileListFragment: set title when attached to activity 
This prevents wrong title while search isn't started yet (such as when returning to a search fragment from a preview fragment)

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-28 16:32:46 +01:00
Nextcloud bot
204cd5a2c5
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-28 03:54:54 +00:00
Valdnet
f28bc6f9f9
i18n: Change to a capital letter 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-01-27 17:12:02 +01:00
Álvaro Brey
88605985a0
Merge pull request #9743 from nextcloud/fix/media-dark-duplicated 
Fix crashes and double loading in GalleryFragment when changing dark theme
 2022-01-27 12:35:35 +01:00
Álvaro Brey
3e97e1e212
Merge pull request #9761 from nextcloud/fix/local-files-freeze 
Improve freezes in local files screens when folder contains many files
 2022-01-27 12:34:35 +01:00
Álvaro Brey Vilas
f3de5f9862
LocalFileListAdapter: fix case where directory==null 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-27 09:49:07 +01:00
Álvaro Brey Vilas
96c55a6d9f
FileSortOrder*: convert to Kotlin 
Need more kotlin in the codebase and these were simple enough

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-27 09:49:07 +01:00
Álvaro Brey Vilas
7baa0f8da4
LocalFileListAdapter: Also change sort order asynchronously 
Changing sort  order is also slow.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
2baf63d809
AlphaNumComparator: optimize usage and resolve signature problems 
- Methods had ambiguous signatures (parameterized compare<T> overlapped the various typed compare()). This made the compiler very confused.
 - In several places throughout the app, AlphaNumComparator was getting repeatedly instantiated just to manually call a typed compare(). This was very wasteful

To solve both problems, the typed compare() methods have been been made static.

The performance gains of not instantiating the comparator repeatedly are very noticeable. In a test loading a local folder for upload with 1000 files in it,
time of load is reduced from 28 seconds to 17 seconds.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
462da35fdb
LocalFileList: load local files asynchronously 
Loading a large list of files (especially the sorting part) is S L O W.
This ensures it doesn't block the UI while loading.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
c5ebc05964
PassCodeActivity: enable cancel button when re-created in confirmation step 
Prevents a bug where the cancel button would stop working if the device was rotated

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-27 09:20:00 +01:00
Álvaro Brey
618a770349
Merge pull request #9751 from nextcloud/fix/clear-data 
Fix some crashes and weird behaviours when clearing data
 2022-01-27 09:18:21 +01:00
Álvaro Brey Vilas
c01fa0b170
Make more PendingIntents immutable 
This should be all of them. Picked up by lint.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-26 12:56:05 +01:00
Álvaro Brey Vilas
27559efb79
Make PendingIntents immutable 
Good practice for security

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-26 12:56:05 +01:00
Álvaro Brey Vilas
45fc831989
gplay/AndroidManifest: set exported value for service 
picked up by lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
9d5395c8fd
ezvcard/ContactOperations: suppress locale lint in third_party class 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
a9ec1de015
manifest: Remove unneeded labels 
Trips up lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
00586a5bde
BackgroundJobFactory: fix lint due to unchecked build version for ContentObserverJob 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
b6115a5fc1
lint: Fix getLayoutInflater calls 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
e1b41b5d77 ManageSpaceActivity: convert to Kotlin while we're here 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-26 08:32:49 +00:00
Álvaro Brey Vilas
db74d67168 ManageSpaceActivity: kill the app after finishing cleanup 
This will prevent the file list still being on the Recents view and other stuff like that.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-26 08:32:49 +00:00
Álvaro Brey Vilas
83e56643f4 ManageSpaceActivity: remove user accounts when clearing data 
This fixes crashes and unexpected states when restarting the app afterwards

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-26 08:32:49 +00:00
Nextcloud bot
750864d951
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-26 03:55:40 +00:00
Álvaro Brey Vilas
80928a2799 GalleryFragment: force refresh on create, prevent unneeded refresh animations 
This fixes bugs with double-loading and weird animations

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-25 08:50:29 +00:00
Álvaro Brey Vilas
7181249667 GalleryFragment: prevent NPE when recreating fragment 
getStorageManager() is not available in onCreate

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-25 08:50:29 +00:00
Álvaro Brey Vilas
1a735f1840
Fix default visibility of recently modified 
Should be visible unless setup.xml disables is (which it does by default)

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-24 13:14:01 +01:00
Álvaro Brey Vilas
c45dd9f5ff
Remove recently added search 
Was never fully implemented. Discarding in favor of recently modified.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-24 13:14:01 +01:00
Álvaro Brey Vilas
63c780999d
OCFileListFragment: restore search event on view restored 
Partially reverts https://github.com/nextcloud/android/pull/9427, which deleted too much stuff

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-24 13:14:00 +01:00
Álvaro Brey Vilas
6a45a90019
OCFileListFragment: add recently modified to the list of valid search events 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-24 13:14:00 +01:00
Nextcloud bot
43610aedba
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-24 03:52:57 +00:00
Nextcloud bot
d8cbde9105
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-21 03:52:14 +00:00
Álvaro Brey
717ad59140
Merge pull request #9651 from nextcloud/gallerySearch 
Use capability in SearchRemoteOperation
 2022-01-20 10:59:29 +01:00
Tobias Kaminsky
84507a39aa
Merge pull request #9719 from nextcloud/fix/ipv4-cache 
Clear DNS cache on network changes
 2022-01-20 09:42:56 +01:00
tobiasKaminsky
a9cec44b1f
Use capability in SearchRemoteOperation 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-01-20 09:10:33 +01:00
Nextcloud bot
2956fafabc
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-20 03:54:30 +00:00
Álvaro Brey Vilas
7299b598d4
Clear DNS cache on network changes 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-19 16:34:09 +01:00
redgloboli
0f62399615
Remove IRC info from app and docs 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-18 16:26:58 +01:00
Álvaro Brey
c6b9da0ee3
Merge pull request #9694 from nextcloud/fix/sqlite-row-too-big 
FileContentProvider: use projections for helper queries
 2022-01-18 14:48:40 +01:00
Álvaro Brey Vilas
2d544486d3
Add integration test for folders with large amounts of files 
This test reproduces the SQLiteCursor crashes.

Co-authored-by: Tobias Kaminsky <tobias@kaminsky.me>
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-18 14:14:11 +01:00
Tobias Kaminsky
b80baef535
remove not used videos drawer entry (#9708) 
* remove not used videos drawer entry

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

* Remove unused resource

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

Co-authored-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-18 09:05:02 +01:00
Tobias Kaminsky
e091a15089
Merge pull request #9710 from nextcloud/fix/crash-on-remove-all-accounts 
SessionMixin: set currentAccount to null when no accounts are available
 2022-01-18 08:38:29 +01:00
Nextcloud bot
8d868c3fff
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-18 04:11:52 +00:00
Álvaro Brey
92f3b6df87
Merge pull request #9691 from nextcloud/fix/sync-conflict 
Improvements in sync conflict resolution
 2022-01-17 20:03:24 +01:00
Álvaro Brey Vilas
107dcd35c4
SessionMixin: set currentAccount to null when no accounts are available 
Prevents a crash when removing the last account

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-17 16:02:05 +01:00
Álvaro Brey
1419406cd2
Merge pull request #9606 from nextcloud/fix/backup-fragment-crash 
Fix NPE in BackupFragment when fragment exits while refresh is happening
 2022-01-17 14:53:35 +01:00
Álvaro Brey Vilas
c5b75f68b0 ConflictsResolveActivity: remove upload is KEEP_SERVER and shouldDeleteLocal 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-17 13:30:47 +00:00
wknds
b4c1620aed removed a check in KEEP_SERVER switch clause. 1) The check prevents solving file conflicts (keep server) correctly. 2) The check involves FileUploader.LOCAL_BEHAVIOUR_DELETE, intended use is for media file uploads. 2022-01-17 13:30:47 +00:00
wknds
e6b6c6ff56 :Conflict files are removed from the upload storage manager after downloaded successfully. 2022-01-17 13:30:47 +00:00
Álvaro Brey
60e44986a0
Merge pull request #9692 from nextcloud/chore/screenshot-test-activities 
Screenshot tests: Improve Activities activity tests
 2022-01-17 14:29:31 +01:00
Álvaro Brey Vilas
6f1d434e80 DocumentsStorageProviderIT: add timeout to testServerChangedFileContent() 
This test sometimes hangs forever, resulting in (for example) CI builds being killed.
This way, only this test fails and the rest of the suite continues.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-17 08:57:45 +00:00
Nextcloud bot
e13dc5db81
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-17 03:49:57 +00:00
Nextcloud bot
1b948c35e0
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-16 03:53:38 +00:00
Nextcloud bot
2623be496d
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-15 03:52:25 +00:00
Álvaro Brey Vilas
62218fbb16
Add RetryTestRule to DrawerActivityIT 
Flaky test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-14 13:28:49 +01:00
Álvaro Brey Vilas
f83ccb781d Fix NPE in BackupFragment when fragment exits while refresh is happening 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-14 10:48:16 +00:00
Álvaro Brey Vilas
23a67aea4a
FileContentProvider: make projection map unmodifiable 
Just in case

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-14 08:54:33 +01:00
Álvaro Brey Vilas
94533fd8aa
FileContentProvider: fix formatting 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-14 08:51:54 +01:00
Álvaro Brey Vilas
45b7c222e6
FileContentProvider: make projection arrays and map static 
This improves performance as they aren't created on every call

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-13 16:12:03 +01:00
Álvaro Brey Vilas
405789dc9b
FileContentProvider: use projections for queries 
This limits the amount of data in the resulting cursor and helps prevent CursorTooBig exceptions.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-13 15:47:40 +01:00
Álvaro Brey Vilas
d7d029b6ad
ActivitiesActivityIT: add waitForIdleSync() after sleeps 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-13 12:48:16 +01:00
Álvaro Brey Vilas
5631d79b41
Screenshot tests: Improve Activities activity tests 
Force-close snackbar to not have the timing break tests

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-13 11:07:47 +01:00
Álvaro Brey
010942f0a2
Merge pull request #9677 from nextcloud/fix/send-multiple-files 
Fix sending multiple files
 2022-01-13 09:34:04 +01:00
Álvaro Brey Vilas
53feb14714
SendFilesDialogTest: assert adapter is not null 
Just in case

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-13 09:06:09 +01:00
Nextcloud bot
ab23c04def
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-13 03:53:34 +00:00
Álvaro Brey Vilas
9d856da33a
Improve testing for SendFilesDialog 
* Add tests for mixed type files
 * Add integration tests, not only screenshot

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-12 15:50:20 +01:00
Álvaro Brey Vilas
61f8115d79
SendFilesDialog: Show error if no app can send multiple files 
Otherwise an empty bottom fragment shows up, which is not good UX

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-12 13:08:48 +01:00
Álvaro Brey Vilas
93d7c7f9f7
IntentUtil: fix sending multiple files 
- Use `ACTION_SEND_MULTIPLE`
 - Set type to `*/*` if not all files share a type
 - Use use a `ParcelableArrayListExtra` for `EXTRA_STREAM`

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-12 13:08:42 +01:00
Tobias Kaminsky
a639e8441c
Merge pull request #9043 from nextcloud/updateScreenshotsTests 
Update screenshots tests
 2022-01-12 08:57:22 +01:00
Nextcloud bot
ae9bd40427
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-12 03:52:57 +00:00
Álvaro Brey
0d46d951e7
Merge pull request #9622 from sandeep021/sandeepBranch 
Fix sliders theming for calendar backup settings
 2022-01-11 10:13:55 +01:00
Nextcloud bot
e4d26e44d4
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-11 03:53:46 +00:00
sandeepyadav
333b844878 removed redundant changes 
Signed-off-by: sandeepyadav <sandeep.yadav@hummingwave.com>
 2022-01-10 23:10:54 +05:30
sandeepyadav
ce11af238f removed redundant changes 
Signed-off-by: sandeepyadav <sandeep.yadav@hummingwave.com>
 2022-01-10 23:10:54 +05:30
sandeepyadav
10d44368db made all the suggested changes - removed xml unnecessary lines 
Signed-off-by: sandeepyadav <sandeep.yadav@hummingwave.com>
 2022-01-10 23:10:54 +05:30
sandeepyadav
fb26ddd88f made all the suggested changes 
Signed-off-by: sandeepyadav <sandeep.yadav@hummingwave.com>
 2022-01-10 23:10:54 +05:30
Tobias Kaminsky
e8ce558a4e
Merge pull request #9642 from nextcloud/fix/9640 
ChooseTemplateDialog: Fix crash on prefillFilenameIfEmpty
 2022-01-10 12:03:51 +01:00
Álvaro Brey
c9246210de
Merge pull request #9674 from nextcloud/fixUploadingFailingScreenshots 
Fix failing username/password upon uploading failing screenshots
 2022-01-10 11:30:26 +01:00
tobiasKaminsky
719551505e
Fix DialogFragmentIT test 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-01-10 10:12:44 +01:00
Álvaro Brey
a037786328
Merge pull request #9667 from nextcloud/rakekniven-patch-2 
l10n: fixed grammar
 2022-01-10 10:04:46 +01:00
Tobias Kaminsky
879286d05f
Merge pull request #9666 from nextcloud/fix/favorites-selection-breaking 
FileOperationsHelper: fix aliasing when toggling favorite files
 2022-01-10 07:44:54 +01:00
Nextcloud bot
67da5e0a6f
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-08 03:50:50 +00:00
rakekniven
065d19163f
l10n: fixed grammar 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-01-07 21:33:51 +01:00
Álvaro Brey Vilas
0f9e4feb79
FileOperationsHelper: fix aliasing when toggling favorite files 
Don't modify the original collection of files. Instead filter a clone.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-07 18:27:55 +01:00
Nextcloud bot
6faceec5a5
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-07 14:05:13 +00:00
Álvaro Brey
d3502b7bba
Merge pull request #9572 from nextcloud/provider-uri-permissions 
URI permissions
 2022-01-07 13:26:03 +01:00
Álvaro Brey
afaa537a45
Merge pull request #9646 from nextcloud/run-contacts-backup-only-when-network-is-connected 
Run contacts backup job only when network is connected
 2022-01-07 11:07:59 +01:00
Álvaro Brey
3a72604a78
Merge pull request #9591 from nextcloud/fix/settings-activity-it 
SettingsActivityIT: fix showMnemonic running on wrong thread
 2022-01-07 09:40:06 +01:00
Álvaro Brey
ebd608c179
Merge pull request #9607 from nextcloud/fix/accesing-result-data 
AuthenticatorAsyncTask: check if user info result is success before proceeding
 2022-01-07 08:47:48 +01:00
Nextcloud bot
e9029b28ed
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-07 03:53:42 +00:00
Nextcloud bot
8acf55d0f1
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-06 03:53:53 +00:00
Chris Narkiewicz
b6ceec7904
Run contacts backup job only when network is connected 
Apply network constrains to prevent daily backup
job being started without network.

Backup job restart is required to apply new constraints.

Similar migration has been applied in the past, but migration
manager does not support re-applying steps again.

Migrations manager has been refactored to make migration
step re-applying easier, as more job restarts can be
required in the future.

Fixes #9632

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2022-01-05 22:01:41 +00:00
Tobias Kaminsky
7d4fa2994c
Merge pull request #9644 from nextcloud/cleanUpAccountRemoval 
Clean up AccountRemovalWork
 2022-01-05 15:05:32 +01:00
Álvaro Brey Vilas
4265f06160
FileOperationsHelper: remove duplicated flags in openFile 
Already set for all intents a bit below

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-04 15:32:32 +01:00
tobiasKaminsky
90d66c4339
Clean up AccountRemovalWork 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-01-04 13:08:44 +01:00
Nextcloud bot
6d6445a1f6
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-04 03:52:56 +00:00
Álvaro Brey Vilas
29d9ba4e52 AuthenticatorAsyncTask: check if user info result is success before proceeding 
This will not fix failed logins but at least it will not crash the app.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-03 18:32:11 +00:00
Álvaro Brey
a3a8170151
Merge pull request #9582 from nextcloud/fix/media-return-after-pause 
Player: don't try to pause a non-running media player
 2022-01-03 16:56:37 +01:00
Álvaro Brey Vilas
1a7ee3e179
ChooseTemplateDialog: Fix crash on prefillFilenameIfEmpty 
Don't do anything if the filename is not empty.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2022-01-03 09:43:24 +01:00
Nextcloud bot
a3b3f18abd
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2022-01-01 03:52:26 +00:00
sandeepyadav
eaf605b2be fixed the visibility of slider of dark theme 
issue# 9170
 2021-12-27 13:35:40 +05:30
Nextcloud bot
042b93766e
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-27 03:52:10 +00:00
Nextcloud bot
5d32890848
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-25 03:52:43 +00:00
Nextcloud bot
552a657350
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-24 03:55:33 +00:00
Nextcloud bot
afc83b8310
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-23 03:53:42 +00:00
Álvaro Brey Vilas
130c004945
FileDataStorageManager: remove obsolete TODO 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-22 09:52:09 +01:00
Álvaro Brey
98465ab3fb
Merge pull request from GHSA-vjp2-f63v-w479 
Harden FileContentProvider's public Uri paths
 2021-12-22 09:43:11 +01:00
Álvaro Brey Vilas
9c7d212d52
Fix for too many thumbnails in autoupload settings 
This patch is twofold:
- Keep using SQL limit until android 11 (which is where it becomes mandatory to not use it)
- Force MediaProvider to stop querying images after limit has been reached, even if cursor contains more.
This handles the edge case of Android versions over 11 which don't properly implement the limit argument

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-21 17:22:10 +01:00
Álvaro Brey Vilas
bc90eb3db1
Remove obsolete TODO 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-21 16:02:50 +01:00
Álvaro Brey Vilas
724b75d5d3
FileContentProvider: Use SQLiteTokenizer for sortOrder verification too 
More reliable than just splitting by spaces.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-21 15:06:05 +01:00
Álvaro Brey Vilas
b3aeab9004
FileContentProvider: prevent injection through selection parameters (where) 
For this, I've backported the SQLiteTokenizer class from AOSP, use it to get tokens from the query,
and filter out invalid tokens.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-21 14:15:34 +01:00
Nextcloud bot
c479f2fdf6
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-21 03:54:15 +00:00
Álvaro Brey Vilas
6aae8feeac
FileContentProvider: prevent injection in sortOrder argument for query() 
For this, allow strictly only valid grammar and column names

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-20 18:38:50 +01:00
Álvaro Brey Vilas
830ada4617
FileContentProvider: remove unused method 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-20 18:03:56 +01:00
Álvaro Brey Vilas
43adc856a4
FileContentProvider: don't verify projectionArray in query() 
query() is already using a projection map and strict mode for those cases, so we're just duplicating work here.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-20 17:58:54 +01:00
Álvaro Brey Vilas
05371be6d7
FileContentProvider: prevent injection through Uri arguments 
For this, ensure query arguments are used instead of segment concatenation

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-20 17:53:55 +01:00
tobiasKaminsky
72937cf341
FileContentProvider: prevent injection via ContentValues arguments 
For this, verify all column names for ContentValues keys. Values are safe by default.

Co-authored-by: Tobias Kaminsky <tobias.kaminsky@nextcloud.com>
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-20 17:40:11 +01:00
Álvaro Brey Vilas
87e859858b
SettingsActivityIT: fix showMnemonic running on wrong thread 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-20 15:24:21 +01:00
Nextcloud bot
4183ee59f8
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-20 03:56:38 +00:00
Nextcloud bot
14a6324c05
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-19 03:59:20 +00:00
Nextcloud bot
26f80ddcbf
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-18 03:53:54 +00:00
Álvaro Brey Vilas
37dfb5eb2c
Player: don't try to pause a non-running media player 
Fixes an issue triggered by pausing, and then minimizing and coming back to the app.

Right now state is still lost (file returns to the beginning) but as a stopgap it's OK.
In the future, the state machine and how it interacts with the fragment should be reworked.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-17 16:22:39 +01:00
Álvaro Brey Vilas
b1aa3dcdaf
Centralize creation of ACTION_SEND intents and explicitly grant READ_URI permission to them 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-16 15:22:16 +01:00
Álvaro Brey
3de9432651
Merge pull request #9534 from gabmert/naming-conflicts 
Change naming in conflicts to location instead of date
 2021-12-16 09:35:43 +01:00
Nextcloud bot
d3db0af0f5
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-16 03:53:43 +00:00
gabriel
5500585c1a naming in conflicts by location instead of date 
Signed-off-by: gabriel <74419649+gabmert@users.noreply.github.com>
 2021-12-15 23:13:42 +01:00
Álvaro Brey
6fc583b4cd
Merge pull request #9362 from nextcloud/dependabot/gradle/workRuntime-2.7.1 
Bump workRuntime from 2.5.0 to 2.7.1
 2021-12-15 19:49:17 +01:00
Álvaro Brey
369f62fc92
Merge pull request #9162 from nextcloud/dependabot/gradle/androidx.lifecycle-lifecycle-viewmodel-ktx-2.4.0 
Bump lifecycle-viewmodel-ktx from 2.3.1 to 2.4.0
 2021-12-15 19:23:03 +01:00
Álvaro Brey Vilas
8a445be869
Manifest: update code to disable WorkManagerInitializer 
See: https://developer.android.com/jetpack/androidx/releases/work#version_260_3

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 19:01:36 +01:00
Álvaro Brey Vilas
14fbc2ab78
ViewModelFactory: fix compile errors for viewmodel-ktx changes 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 18:45:06 +01:00
Álvaro Brey Vilas
f5132af345
Fix mockito imports 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 16:08:36 +01:00
Álvaro Brey
508c193dfa
Merge pull request #9448 from nextcloud/fix/share-open-in 
Sharing: better way to send files from file details view
 2021-12-15 13:48:42 +01:00
Álvaro Brey
3b947b981b
Merge pull request #9435 from nextcloud/fix/multi-tap-overflow 
OcFileListFragment: throttle overflow menu clicks
 2021-12-15 13:08:16 +01:00
Álvaro Brey
82a53642a9
Merge pull request #9528 from nextcloud/huaweiFlavor 
Huawei flavor
 2021-12-15 13:07:32 +01:00
Álvaro Brey Vilas
13ddc3ddc6
Delete unused string 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 12:59:58 +01:00
Álvaro Brey Vilas
a86aa19851
Fix tests 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 12:59:13 +01:00
Álvaro Brey Vilas
7d258f9793
FileMenuFilter: Allow "Send" for single files if in file detail fragment 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 12:33:26 +01:00
Álvaro Brey Vilas
038ac7b3c5
FileDetailSharingFragment: remove misleading "Open in..." option 
This only triggered the share file dialog, which should be opened elsewhere.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 12:33:15 +01:00
Álvaro Brey Vilas
23815a4b6d
Fix ktlint 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 12:21:04 +01:00