Commit graph

166 commits

Author SHA1 Message Date
Álvaro Brey Vilas
2cd2e29b86
FileMenuFilter: don't show lock options if there's no locking capability
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
db30142ad3
Fix lock info in actionMode menu when selecting a single, locked, file
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
f8ad9ae413
FileMenuFilter: don't show move, remove or rename options when file is locked
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
d90083fc07
Show file lock info in actions menu instead of separate dialog
Requested by design team

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:43 +02:00
Álvaro Brey Vilas
46ccddcef4
Combine lock indicator with overflow icon
Requested by design

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
a902fb6f84
FileMenuFilter: properly filter lock/unlock depending on lock status
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
a88b03a0c8
Show lock details when tapping on lock indicator
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
68b2535481
Retrieve and persist more locking attributes from remote files
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
356db04aa8
Add ability to toggle file lock from file context menu
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
fd2435379a
FileDataStorageManager: small cleanup
- Remove two unused methods
- Make some fields final

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
f5ecaf91d1
Show file locking status on list
Also includes a refactor of how ContentValues are created in FileDataStorageManager.

The code for that was triplicated. now it's not.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:42 +02:00
Álvaro Brey Vilas
b8cf8dade8
Store file locking capability
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 12:49:36 +02:00
Álvaro Brey
9a2cbcbba4
FileDisplayActivity: wait until OCFileListFragment is initialized to trigger browseToRoot()
This solves a bug which caused a "Directory does not exist" popup when coming back from Gallery,
as it tried to call browseToRoot on GalleryFragment due it being executed before the fragment transaction.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-05-02 11:02:46 +02:00
Álvaro Brey Vilas
13e061e7d7 PreviewMediaFragment: Remove margin from top bar
Not needed since previous commit fixing scroll bugs, creates unwanted space

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 07:55:34 +00:00
Álvaro Brey Vilas
7a2c735795 Fix contents cut off when scrolling is locked
Don't need to touch the coordinator params, just set scroll flags properly

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-05-02 07:55:34 +00:00
Nextcloud bot
ddb96e7b17
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-05-01 04:10:03 +00:00
Álvaro Brey Vilas
2560d1be3c
Inject ThemeColorUtils into ThemeableSwitchPreference too
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 16:56:56 +02:00
Álvaro Brey Vilas
b58749d459
Fix ThemeUtils injection for MediaControlView
Inflation of this view was failing as there was no proper constructor

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 16:50:35 +02:00
Álvaro Brey Vilas
7e31a71ba0 FileDetailsSharing: Preserve selected date when recreating expiration date dialog
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 11:12:07 +00:00
Álvaro Brey Vilas
85dcbe542e FileDetailsSharingProcess: force recreation of date picked on config changes
See added comment for details

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 11:12:07 +00:00
Álvaro Brey Vilas
8c2fc3ee87 ExpirationDatePickerDF: customize buttons on onStart instead of showing dialog on onCreate
That is how DialogFragment is supposed to work

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 11:12:07 +00:00
Álvaro Brey Vilas
bdd1daa10e SyncFileNotEnoughSpaceDialogFragment needs injector
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
3ff35d46e6 Fix some spotbugs stuff
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
56584c06e6 Fix detekt
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
42c28dce70 ThemeModule: convert to Kotlin and fix copyright
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
tobiasKaminsky
17828cb3b4 remove some spotbugs warnings
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
f627f3d976 Fix injection ofr RenameFileDialogFragment
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:14 +00:00
Álvaro Brey Vilas
6bd7d808f4 Put OCFileListBottomSheetDialog into a DialogFragment
Can't inject things into a Dialog

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:13 +00:00
tobiasKaminsky
74e17ee7c6 Fixes after rebase
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fixes after rebase

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fixes after rebase

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Fix after rebase

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-29 06:38:13 +00:00
Álvaro Brey Vilas
75cb8a767c Remove SyncedFoldersActivity.java
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-29 06:38:13 +00:00
tobiasKaminsky
349a045b46 Move all Theme classes to DI
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Move all Theme classes to DI

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Move all Theme classes to DI

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-29 06:38:13 +00:00
Nextcloud bot
0a802b51da
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-29 04:11:37 +00:00
tobiasKaminsky
73bb12f78a Parallel thumbnail fetching
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-28 08:10:54 +00:00
Nextcloud bot
bd139f1afb
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-26 04:11:10 +00:00
Álvaro Brey
d45e12c2b8
Merge pull request #10089 from nextcloud/remove-account-usage-from-manage-acconuts-activity
Remove account use from ManageAccountsActivity
2022-04-25 16:47:34 +02:00
Nextcloud bot
98075eba14
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-24 04:13:03 +00:00
Chris Narkiewicz
042c3758ac
Remove account use from ManageAccountsActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2022-04-23 16:49:13 +01:00
Nextcloud bot
14aac48b90
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-23 04:00:20 +00:00
Nextcloud bot
7759475728
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-22 04:03:25 +00:00
Nextcloud bot
7cc0d53cff
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-21 04:01:23 +00:00
Álvaro Brey Vilas
9e29b5cbc4
Remove FilesFilter, as it is unused
Only created in OCFileListAdapter, and then unused

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-19 14:19:38 +02:00
Álvaro Brey Vilas
ca72520d54
MainApp: remove unused variable
Leftover

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-19 11:34:18 +02:00
Álvaro Brey Vilas
fb12a65949
Fix unit test for GalleryAdapter
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-19 10:59:14 +02:00
Álvaro Brey Vilas
ff3833c62f
OCFileListDelegate: fix detekt
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-18 18:40:25 +02:00
Álvaro Brey Vilas
0def0a8af8
Format with ktlint
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-18 18:21:35 +02:00
tobiasKaminsky
97d71d0383
Group media by month 2022-04-18 18:18:19 +02:00
Álvaro Brey
0e03400486
Merge pull request #10074 from nextcloud/equals
Replace equals with == on enums
2022-04-18 12:49:14 +02:00
Álvaro Brey
9a899ce3dc
Merge pull request #10070 from nextcloud/trashbinNav
Fix trashbin navigation
2022-04-18 12:30:48 +02:00
Nextcloud bot
58b34c3ee4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-16 03:59:30 +00:00
Nextcloud bot
df887ce4f2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-15 04:04:35 +00:00
tobiasKaminsky
a9608108ac
Replace equals with == on enums
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-13 10:19:30 +02:00
tobiasKaminsky
075e91d9ba
Replace equals with == on enums
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 09:15:33 +02:00
tobiasKaminsky
f57aa2037b
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:45:10 +02:00
tobiasKaminsky
3c69ae92bb
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:05:17 +02:00
tobiasKaminsky
e67fc70451
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:04:23 +02:00
tobiasKaminsky
930d3e61fd
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:04:23 +02:00
tobiasKaminsky
cf932e69e7
Fastscroll for all lists
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-12 08:04:23 +02:00
tobiasKaminsky
abc9f14555
Fix trashbin navigation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-11 08:33:00 +02:00
Nextcloud bot
7c6bce5617
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-08 04:05:40 +00:00
Álvaro Brey
d97edf023d
Merge pull request #10051 from nextcloud/fdroid-no-scan
Don't include document scanner in FDroid version
2022-04-07 12:46:08 +02:00
Álvaro Brey
ace6b49786
Merge pull request #10059 from nextcloud/exceptionHandling
Do not use ExceptionHandler on debug builds
2022-04-07 12:18:50 +02:00
tobiasKaminsky
df7e70a3f1
Do not use ExceptionHandler on debug builds
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-07 11:47:42 +02:00
Tobias Kaminsky
b84149ac7c
Merge pull request #10034 from nextcloud/fix/details-title-again
Better approach for avoiding state loss in FileDetailFragment
2022-04-07 11:07:11 +02:00
Tobias Kaminsky
69234dec5f
Merge pull request #10049 from nextcloud/fix/camera2_not_required
AndroidManifest: set camera2 feature to not required
2022-04-07 10:44:34 +02:00
Álvaro Brey
d781583c6c
Merge pull request #10007 from nextcloud/fixVideoStreaming
Use remoteId to properly fetch streaming video url
2022-04-07 10:36:07 +02:00
Álvaro Brey Vilas
9827612010
Don't include document scanner in FDroid version
Not allowed due to binary OpenCV

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-06 14:43:05 +02:00
Álvaro Brey Vilas
ba369f22ab
AndroidManifest: set camera2 feature to not required
Brought by document scanner lib, but not actually required. If set to required,
devices without this feature will not see the app in Play Store.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-06 09:26:39 +02:00
Álvaro Brey
5b8d11f738
Optimize loading time for Shared view (#10015)
* Don't load entire OCFiles in the Shared view, as it takes too long

Instead, build partially-filled OCFiles from the OCShares we get

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Load metadata of shared files only when attempting to interact with them

This was quite a big undertaking and required a whole new fragment

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Fix wrong usages of deprecaed OCShare shareType setter

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-04-04 18:52:21 +02:00
Tobias Kaminsky
b324f0d784
- no camera permission (#10042)
- scan document
- approve permission
- see scan document activity, previously it was wrong upload image activity

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-04-04 09:13:21 +00:00
Nextcloud bot
77507f9c9b
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-04-03 04:01:33 +00:00
Álvaro Brey Vilas
cd895ad2cf
Better approach for avoiding state loss in FileDetailFragment
Do not overwrite file when updating share information, instead of holding the file in FDA

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-31 15:04:19 +02:00
Nextcloud bot
7285ddc4cb
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-31 04:08:34 +00:00
Álvaro Brey
d9811e1f34
Merge pull request #10013 from nextcloud/fix/login-after-logout
Fix bugs when removing accounts
2022-03-30 18:29:24 +02:00
Nextcloud bot
9a94cb1e12
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-30 04:03:28 +00:00
Nextcloud bot
4b8bb8a707
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-28 04:02:23 +00:00
Nextcloud bot
ca751d0f71
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-27 04:01:42 +00:00
Nextcloud bot
3753ef361c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-25 05:41:13 +00:00
Álvaro Brey Vilas
a1901ca3e8
ManageAccountsActivity: go back to AuthenticatorActivity after removing last account
Instead of waiting for FileDisplayActivity to make a network request and fail

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 18:23:57 +01:00
Álvaro Brey Vilas
95046c4b5d
AccountRemovalWork: remove cached owncloudClient after removing account
Otherwise, the account (which is identified by account name only) will reuse old token, if login is done right after account removal.

Three hours of debugging for one line of code

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 18:22:11 +01:00
Álvaro Brey Vilas
2e593a034b
Fix FileDisplayActivity screenshot tests
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 10:38:08 +01:00
Álvaro Brey Vilas
154755af9b
Fix scrolling behaviour when changing dark mode
Also fixes "scrolling on top bar" for empty folders

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 10:38:07 +01:00
Álvaro Brey Vilas
b8bb261234
PreviewMediaFragment: fix crash when changing theme with audio fragment
Exoplayer is null when recreating

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 10:38:07 +01:00
Álvaro Brey Vilas
6a527a6e87
FileDisplayActivity: properly lock scrollbar for media preview
This locks the scrolling of the CoordinatorLayout AND removes the scroll flags from the AppbarLayout

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-23 10:38:07 +01:00
Álvaro Brey
d013464320
Merge pull request #9959 from nextcloud/shareFromMediaView
Fix sharing from media view
2022-03-23 09:30:26 +01:00
tobiasKaminsky
f522446d13
Correctly show edit share link
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-23 06:50:51 +01:00
Nextcloud bot
0c5a9fd155
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-23 03:59:59 +00:00
tobiasKaminsky
e481382c28
Use remoteId to properly fetch streaming video url
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-22 16:36:11 +01:00
Álvaro Brey Vilas
f6298f7904
FileDetialsSharing...: add minHeight to content instead of scrollview
This still keeps the minimum height, but doesn't center the content vertically which looked odd

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-22 10:10:55 +01:00
tobiasKaminsky
d91d2996ab
Fix sharing from media view
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-03-21 15:06:06 +01:00
Nextcloud bot
321a97acf7
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-21 03:59:20 +00:00
Nextcloud bot
98575bc8ca
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-20 04:00:57 +00:00
Nextcloud bot
d7dbef4085
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-19 04:01:55 +00:00
Nextcloud bot
6d1b14785c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-18 04:00:34 +00:00
Álvaro Brey
138d3a03a9
Merge pull request #9972 from nextcloud/fix/search-loading
Fix search loading animation and display
2022-03-17 13:04:10 +01:00
Álvaro Brey
e7e2ab8a96
Merge pull request #9976 from nextcloud/fix/receive-crash-no-account
ReceiveExternalFilesActivity: don't crash if no user present
2022-03-17 10:44:45 +01:00
Álvaro Brey Vilas
769816978a
OCFileListFragment: extract seach async task and convert it to kotlin
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-17 10:38:30 +01:00
Nextcloud bot
886400b5e0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-17 04:04:03 +00:00
Álvaro Brey Vilas
0af297735c
ExtendedListFragment: Remove ViewTreeObserver on search frame
This was incorrectly setting empty message when switching search types. And it makes no sense: search is only executed when submitted.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-16 11:40:41 +01:00
Álvaro Brey Vilas
e8e18609e5
OCFileListFragment: make search async task static, fix loading animation usage
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-16 11:40:41 +01:00
Tobias Kaminsky
eccd9205bd
Merge pull request #9970 from nextcloud/fix/share-screen-update
FileDisplayActivity: set file when opening FileDetailsFragment
2022-03-16 11:03:28 +01:00