Andy Scherzinger
27b503d2cd
Merge pull request #2622 from nextcloud/preview-bitmap-npe
...
ui:preview Verify that bitmap is not null before setting imageDrawable.
2018-05-25 12:59:28 +02:00
Andy Scherzinger
cc96f3aa1a
Merge pull request #2621 from nextcloud/activity-return-null
...
ui:activity: Removed @NonNull annotation for method where null can be returned
2018-05-25 11:56:18 +02:00
Andy Scherzinger
a56885f477
Merge pull request #2619 from nextcloud/manageaccounts-unused-override
...
ui:activity Removed unused override method in ManageAccountsActivity
2018-05-25 11:55:30 +02:00
Andy Scherzinger
c00412463c
Merge pull request #2623 from nextcloud/AnalyticsPostCleanup
...
Cleanup unused code, housekeeping post #2616
2018-05-25 11:22:31 +02:00
AndyScherzinger
427664d7ce
Cleanup unused code, housekeeping post #2616 (codacy hasn't detected the unused code...)
2018-05-25 10:08:51 +02:00
eho
ca46f6ed6b
ui:preview Verify that bitmap is not null before setting imageDrawable.
...
A reference to null should never be dereferenced/accessed. Doing so will cause a NullPointerException to be thrown
2018-05-25 09:51:45 +02:00
eho
324382dcc0
ui:activity: Removed @NonNull annotation for method where null can be returned.
...
The return value is marked @NonNull and is therefore assumed to only return non-null values. Therefore setting one of these values to null, or failing to set such a class field in a constructor, could cause NullPointerExceptions at runtime. In this case, view might be null.
2018-05-25 09:46:03 +02:00
eho
384b86b205
ui:activity Removed unused override method
...
Overriding a method just to call the same method from the super class without performing any other actions is useless and misleading.
2018-05-25 09:32:59 +02:00
Nextcloud bot
989ec9e0e2
[tx-robot] updated from transifex
2018-05-25 00:53:41 +00:00
Tobias Kaminsky
4f33aa4b00
daily dev 20180525
2018-05-25 00:32:08 +02:00
Andy Scherzinger
38e19c99c7
Merge pull request #2613 from nextcloud/overflowMenu
...
setting the menu item order according to the webUI
2018-05-24 18:50:56 +02:00
Andy Scherzinger
ef943ccc33
Merge pull request #2616 from nextcloud/removeAnalytics
...
Remove analytics
2018-05-24 18:40:31 +02:00
tobiasKaminsky
425a2372ad
ignore translations files
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-24 18:20:09 +02:00
AndyScherzinger
bd7c54eb06
fix fav menu item texts
2018-05-24 18:10:03 +02:00
nextcloud-android-bot
c47c07bc39
Drone: update Lint results to reflect reduced error/warning count [skip ci]
2018-05-24 13:28:03 +00:00
Tobias Kaminsky
4665fee915
Merge 6256d21aa6 into cd315095d1
2018-05-24 12:35:28 +00:00
tobiasKaminsky
6256d21aa6
Remove analytics
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-24 14:34:08 +02:00
AndyScherzinger
a2f1aafca3
Revert "add null check"
...
This reverts commit e55f0e43b9
2018-05-24 13:52:54 +02:00
AndyScherzinger
e55f0e43b9
add null check
2018-05-24 13:23:27 +02:00
AndyScherzinger
d00935bd70
codacy: remove unused import
2018-05-24 13:16:16 +02:00
AndyScherzinger
cd3953b32f
remove unused orderCategory
2018-05-24 13:06:30 +02:00
AndyScherzinger
caddb104b4
Fixes #1749 setting the menu item order according to the webUI
2018-05-24 12:50:25 +02:00
Nextcloud bot
cd315095d1
[tx-robot] updated from transifex
2018-05-24 00:53:17 +00:00
Tobias Kaminsky
5d41f14fbd
daily dev 20180524
2018-05-24 00:32:37 +02:00
Andy Scherzinger
031a0a242c
Merge pull request #2603 from nextcloud/disable-analytics-via-manifest
...
Disable analytics via manifest
2018-05-23 19:18:51 +02:00
Andy Scherzinger
8c754f5987
Merge pull request #2312 from nextcloud/integrationTests
...
Add support for integration tests
2018-05-23 18:51:34 +02:00
Mario Danic
d727b72a65
Disable analytics via manifest
...
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2018-05-23 16:35:52 +02:00
tobiasKaminsky
ebdd4207ed
move disabled tests to its own package
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-23 08:58:21 +02:00
nextcloud-android-bot
1c8daeb0f7
Drone: update Lint results to reflect reduced error/warning count [skip ci]
2018-05-23 08:51:36 +02:00
AndyScherzinger
a733f515ed
ownCloud->Nextcloud + new line
2018-05-23 08:51:36 +02:00
tobiasKaminsky
6a574d213a
bump test/espresso lib versions
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-23 08:51:35 +02:00
tobiasKaminsky
76d3747748
Add support for integration tests
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-23 08:51:35 +02:00
Mario Đanić
51dca0208a
Merge pull request #2490 from nextcloud/fixDoubleSearch
...
Fix double search
2018-05-23 08:50:54 +02:00
Nextcloud bot
aac3f6a21a
[tx-robot] updated from transifex
2018-05-23 00:53:24 +00:00
tobiasKaminsky
378626c9a9
fix double search
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-23 00:45:07 +02:00
Tobias Kaminsky
001f13d884
daily dev 20180523
2018-05-23 00:32:17 +02:00
Tobias Kaminsky
2c1ac42ff1
Merge pull request #2501 from nextcloud/userIdForWebdavSearch
...
Use userId for webdav search
2018-05-22 12:56:51 +02:00
Andy Scherzinger
1a193d765d
Merge pull request #2520 from nextcloud/doNotSortOnGetFolderContent
...
Do not sort on getFolderContent
2018-05-22 11:40:32 +02:00
Andy Scherzinger
3e08819215
Merge pull request #2544 from nextcloud/whiteBrander
...
Brander with white primary color
2018-05-22 11:36:59 +02:00
Tobias Kaminsky
6883098a1c
Merge pull request #2599 from nextcloud/2596-previewnavigation-overlap
...
res:styles: Don't use a translucent navigation bar in the Preview activity
2018-05-22 11:29:13 +02:00
Mario Đanić
e76824a872
Merge pull request #2600 from nextcloud/previewimagefragment-cleanup
...
Minor cleanup of the PreviewImageFragment
2018-05-22 11:17:49 +02:00
eho
5b68a221e9
datamodel: Don't try to be smarter than the JVM by calling the garbage collector.
...
Calling System.gc() or Runtime.getRuntime().gc() is a bad idea for a simple reason: there is no way to know exactly what will be done under the hood by the JVM because the behavior will depend on its vendor, version and options:
Will the whole application be frozen during the call?
Is the -XX:DisableExplicitGC option activated?
Will the JVM simply ignore the call?
An application relying on these unpredictable methods is also unpredictable and therefore broken. The task of running the garbage collector should be left exclusively to the JVM.
2018-05-22 11:16:23 +02:00
eho
f0b31af089
ui:preview Removed useless call to System.gc().
...
Calling System.gc() or Runtime.getRuntime().gc() is a bad idea for a simple reason: there is no way to know exactly what will be done under the hood by the JVM because the behavior will depend on its vendor, version and options.
2018-05-22 11:14:33 +02:00
eho
e7d53a94e5
ui:preview Added final modifiers to applicable declarations.
2018-05-22 11:05:07 +02:00
eho
4ebf83fce6
ui:preview Simplified lambda expressions.
2018-05-22 11:04:13 +02:00
eho
9ecdcdd613
ui:preview Removed unused import.
2018-05-22 11:03:39 +02:00
eho
1896ffe66e
ui:preview Removed single-use downloadFile() method.
2018-05-22 11:03:22 +02:00
eho
158451d316
ui:preview Removed unused public method switchToFullScreen()
2018-05-22 10:53:20 +02:00
eho
044b59c2f2
ui:preview Moved full screen toggle code to dedicated method.
...
Reduces duplicate code.
2018-05-22 10:53:00 +02:00
Mario Đanić
f2039686f4
Merge pull request #2602 from nextcloud/ui-preview-checkerboardrefactor
...
ui:preview Simplified generateCheckerboardLayeredDrawable()
2018-05-22 10:37:53 +02:00
