mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-12-19 07:22:06 +03:00
Code Issues Projects Releases Packages Wiki Activity
10796 commits 222 branches 1585 tags 637 MiB
Commit graph

6609 commits

Author SHA1 Message Date
AndyScherzinger
a29d73102b
fix theming issue 2018-05-29 07:58:13 +02:00
AndyScherzinger
a2c0b180ec
lint: Inefficient layout weight 2018-05-29 07:58:12 +02:00
AndyScherzinger
27d04c8823
organize imports 2018-05-29 07:58:12 +02:00
AndyScherzinger
2c30e3842f
Wip user/group search (not fully working yet) 2018-05-29 07:58:11 +02:00
AndyScherzinger
72681e95b2
add proper permission editing for folders 2018-05-29 07:58:11 +02:00
AndyScherzinger
5054df0ba3
updating of permissions for file/folder (folder not reachable yet) 2018-05-29 07:58:10 +02:00
AndyScherzinger
5200dd0881
WiP permission handling (Don't use for productive shares yet!) 2018-05-29 07:58:10 +02:00
AndyScherzinger
c86f007601
add listener interface + organized imports 2018-05-29 07:58:09 +02:00
AndyScherzinger
cd200b2e9f
empty menu implementation per sharee 2018-05-29 07:58:09 +02:00
AndyScherzinger
c9328dcc25
add new lines 2018-05-29 07:58:08 +02:00
AndyScherzinger
6831678051
butterknife for the sharing tabs of file details 2018-05-29 07:58:08 +02:00
AndyScherzinger
23fb0ef264
lambda: use method reference 2018-05-29 07:58:07 +02:00
AndyScherzinger
6bb7dc86c7
butterknife for details fragment + proper empty content handling 2018-05-29 07:58:07 +02:00
Nextcloud bot
59dca8f7db
[tx-robot] updated from transifex 2018-05-29 00:47:01 +00:00
tobiasKaminsky
364c92cfcc
tint zip icon same as folder icon 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-28 14:28:00 +02:00
Nextcloud bot
c6ef1607af
[tx-robot] updated from transifex 2018-05-28 00:47:46 +00:00
Nextcloud bot
ca38015e38
[tx-robot] updated from transifex 2018-05-26 00:52:14 +00:00
Andy Scherzinger
27b503d2cd
Merge pull request #2622 from nextcloud/preview-bitmap-npe 
ui:preview Verify that bitmap is not null before setting imageDrawable.
 2018-05-25 12:59:28 +02:00
Andy Scherzinger
cc96f3aa1a
Merge pull request #2621 from nextcloud/activity-return-null 
ui:activity: Removed @NonNull annotation for method where null can be returned
 2018-05-25 11:56:18 +02:00
Andy Scherzinger
a56885f477
Merge pull request #2619 from nextcloud/manageaccounts-unused-override 
ui:activity Removed unused override method in ManageAccountsActivity
 2018-05-25 11:55:30 +02:00
AndyScherzinger
427664d7ce
Cleanup unused code, housekeeping post #2616 (codacy hasn't detected the unused code...) 2018-05-25 10:08:51 +02:00
eho
ca46f6ed6b ui:preview Verify that bitmap is not null before setting imageDrawable. 
A reference to null should never be dereferenced/accessed. Doing so will cause a NullPointerException to be thrown
 2018-05-25 09:51:45 +02:00
eho
324382dcc0 ui:activity: Removed @NonNull annotation for method where null can be returned. 
The return value is marked @NonNull and is therefore assumed to only return non-null values. Therefore setting one of these values to null, or failing to set such a class field in a constructor, could cause NullPointerExceptions at runtime. In this case, view might be null.
 2018-05-25 09:46:03 +02:00
eho
384b86b205 ui:activity Removed unused override method 
Overriding a method just to call the same method from the super class without performing any other actions is useless and misleading.
 2018-05-25 09:32:59 +02:00
Nextcloud bot
989ec9e0e2
[tx-robot] updated from transifex 2018-05-25 00:53:41 +00:00
Andy Scherzinger
38e19c99c7
Merge pull request #2613 from nextcloud/overflowMenu 
setting the menu item order according to the webUI
 2018-05-24 18:50:56 +02:00
AndyScherzinger
bd7c54eb06
fix fav menu item texts 2018-05-24 18:10:03 +02:00
Tobias Kaminsky
4665fee915
Merge 6256d21aa6 into cd315095d1 2018-05-24 12:35:28 +00:00
tobiasKaminsky
6256d21aa6
Remove analytics 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-24 14:34:08 +02:00
AndyScherzinger
a2f1aafca3
Revert "add null check" 
This reverts commit e55f0e43b9.
 2018-05-24 13:52:54 +02:00
AndyScherzinger
e55f0e43b9
add null check 2018-05-24 13:23:27 +02:00
AndyScherzinger
d00935bd70
codacy: remove unused import 2018-05-24 13:16:16 +02:00
AndyScherzinger
cd3953b32f
remove unused orderCategory 2018-05-24 13:06:30 +02:00
AndyScherzinger
caddb104b4
Fixes #1749 setting the menu item order according to the webUI 2018-05-24 12:50:25 +02:00
Nextcloud bot
cd315095d1
[tx-robot] updated from transifex 2018-05-24 00:53:17 +00:00
Andy Scherzinger
031a0a242c
Merge pull request #2603 from nextcloud/disable-analytics-via-manifest 
Disable analytics via manifest
 2018-05-23 19:18:51 +02:00
Andy Scherzinger
8c754f5987
Merge pull request #2312 from nextcloud/integrationTests 
Add support for integration tests
 2018-05-23 18:51:34 +02:00
Mario Danic
d727b72a65
Disable analytics via manifest 
Signed-off-by: Mario Danic <mario@lovelyhq.com>
 2018-05-23 16:35:52 +02:00
tobiasKaminsky
ebdd4207ed
move disabled tests to its own package 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-23 08:58:21 +02:00
AndyScherzinger
a733f515ed
ownCloud->Nextcloud + new line 2018-05-23 08:51:36 +02:00
tobiasKaminsky
76d3747748
Add support for integration tests 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-23 08:51:35 +02:00
Mario Đanić
51dca0208a
Merge pull request #2490 from nextcloud/fixDoubleSearch 
Fix double search
 2018-05-23 08:50:54 +02:00
Nextcloud bot
aac3f6a21a
[tx-robot] updated from transifex 2018-05-23 00:53:24 +00:00
tobiasKaminsky
378626c9a9
fix double search 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-23 00:45:07 +02:00
Tobias Kaminsky
2c1ac42ff1
Merge pull request #2501 from nextcloud/userIdForWebdavSearch 
Use userId for webdav search
 2018-05-22 12:56:51 +02:00
Andy Scherzinger
1a193d765d
Merge pull request #2520 from nextcloud/doNotSortOnGetFolderContent 
Do not sort on getFolderContent
 2018-05-22 11:40:32 +02:00
Andy Scherzinger
3e08819215
Merge pull request #2544 from nextcloud/whiteBrander 
Brander with white primary color
 2018-05-22 11:36:59 +02:00
Tobias Kaminsky
6883098a1c
Merge pull request #2599 from nextcloud/2596-previewnavigation-overlap 
res:styles: Don't use a translucent navigation bar in the Preview activity
 2018-05-22 11:29:13 +02:00
Mario Đanić
e76824a872
Merge pull request #2600 from nextcloud/previewimagefragment-cleanup 
Minor cleanup of the PreviewImageFragment
 2018-05-22 11:17:49 +02:00
eho
5b68a221e9 datamodel: Don't try to be smarter than the JVM by calling the garbage collector. 
Calling System.gc() or Runtime.getRuntime().gc() is a bad idea for a simple reason: there is no way to know exactly what will be done under the hood by the JVM because the behavior will depend on its vendor, version and options:

Will the whole application be frozen during the call?
Is the -XX:DisableExplicitGC option activated?
Will the JVM simply ignore the call?

An application relying on these unpredictable methods is also unpredictable and therefore broken. The task of running the garbage collector should be left exclusively to the JVM.
 2018-05-22 11:16:23 +02:00
eho
f0b31af089 ui:preview Removed useless call to System.gc(). 
Calling System.gc() or Runtime.getRuntime().gc() is a bad idea for a simple reason: there is no way to know exactly what will be done under the hood by the JVM because the behavior will depend on its vendor, version and options.
 2018-05-22 11:14:33 +02:00
eho
e7d53a94e5 ui:preview Added final modifiers to applicable declarations. 2018-05-22 11:05:07 +02:00
eho
4ebf83fce6 ui:preview Simplified lambda expressions. 2018-05-22 11:04:13 +02:00
eho
9ecdcdd613 ui:preview Removed unused import. 2018-05-22 11:03:39 +02:00
eho
1896ffe66e ui:preview Removed single-use downloadFile() method. 2018-05-22 11:03:22 +02:00
eho
158451d316 ui:preview Removed unused public method switchToFullScreen() 2018-05-22 10:53:20 +02:00
eho
044b59c2f2 ui:preview Moved full screen toggle code to dedicated method. 
Reduces duplicate code.
 2018-05-22 10:53:00 +02:00
Mario Đanić
f2039686f4
Merge pull request #2602 from nextcloud/ui-preview-checkerboardrefactor 
ui:preview Simplified generateCheckerboardLayeredDrawable()
 2018-05-22 10:37:53 +02:00
eho
0ae79863e5 ui:preview Simplified layerDrawable dimension calculation even further. 2018-05-22 10:36:49 +02:00
eho
e61aa30b6f ui:preview Simplified layerDrawable dimension calculation. 2018-05-22 10:30:26 +02:00
Nextcloud bot
4f8669d6d4
[tx-robot] updated from transifex 2018-05-22 00:48:17 +00:00
eho
ab13851438 ui:preview Ensure getActivity() is not null before generating LayerDrawable. 2018-05-21 22:15:33 +02:00
eho
71466768f7 ui:preview Replaced setLayerHeight and setLayerWidth calls with setLayerSize(). 
Saves a few lines of code. Always a good thing.
 2018-05-21 22:14:32 +02:00
AndyScherzinger
637fc68581
reformat layouts due to review 2018-05-21 19:51:50 +02:00
eho
d5d6a6b4fd ui:preview Replaced anonymous types with lambdas. 2018-05-21 19:21:20 +02:00
eho
ea769e3ff7 ui:preview: Removed unused @Override method so that we simply inherit it. 
Overriding a method just to call the same method from the super class without performing any other actions is useless and misleading.
 2018-05-21 19:20:48 +02:00
eho
fdce4339a9 ui:preview Adjusted access declarations. Follow the principle of least privileged. 2018-05-21 19:19:29 +02:00
eho
a78ab4ba97 ui:preview Removed redundant variable. 2018-05-21 19:18:59 +02:00
eho
572ff50943 res:styles: Don't use a translucent navigation bar. 
This causes view elements at the bottom to overlap with the navigation bar which makes it impossible to interact with said elements.
 2018-05-21 19:13:21 +02:00
AndyScherzinger
86d60238fe
codacy: organize imports 2018-05-21 12:48:35 +02:00
tobiasKaminsky
77c253f48d
add ripple effect 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-21 12:48:35 +02:00
Andy Scherzinger
daee7d101b
Merge pull request #2593 from nextcloud/2583-feature-photoview 
Replaced legacy custom ImageView and ViewPager class with PhotoView and stock ViewPager
 2018-05-21 12:16:01 +02:00
eho
066936a5f3 ui:preview Use static string constants for mime types. 
Duplicating hard coded strings all over the place is generally a bad idea and will lead to typos.
 2018-05-21 10:43:43 +02:00
eho
a26f3b6b44 ui:preview Refactored image rendering. Show checkerboard with svg's as well. 2018-05-21 10:40:50 +02:00
eho
2b1cff9172 ui:preview Consolidate checkerboard LayerDrawable generation in dedicated method. 2018-05-20 21:35:22 +02:00
eho
6b7f748690 ui:preview Re-introduce the setImageDrawable call to load downloaded png's into imageView. 2018-05-20 21:21:00 +02:00
eho
d1520e6a5e ui:preview Cleaned up formatting. Extracted layerDrawable bounds setting to separate method. 2018-05-20 20:00:10 +02:00
eho
1ce4c51ed2 ui:preview Use equalsIgnoreCase() for svg mime check. 2018-05-20 19:51:25 +02:00
eho
295bd2f0f1 ui:preview Updated handling of downloaded gif's. 
Using a GifDrawable gives us animated gifs.
 2018-05-20 19:49:12 +02:00
eho
01cb5ffc67 res:layout Removed commented block of code. 
Use git to track legacy code instead of leaving commented code blocks in source.
 2018-05-20 19:15:54 +02:00
eho
89655f63c0 res:layout Removed unused namespace declaration. 2018-05-20 19:14:55 +02:00
eho
d89e2178f8 ui:preview remove useless return statement in void method. 2018-05-20 19:13:58 +02:00
eho
88c942584c ui:preview Use lambdas 2018-05-20 19:13:36 +02:00
Nextcloud bot
fbe64ef06a
[tx-robot] updated from transifex 2018-05-20 00:46:51 +00:00
eho
0bc74d79f2 Merge branch '2583-feature-photoview' of github.com:nextcloud/android into 2583-feature-photoview 2018-05-19 18:49:22 +02:00
eho
0231972869 ui:preview Correctly load svg files into PhotoView. 2018-05-19 18:46:55 +02:00
ardevd
d51f1206a3
Merge c52f8e25b3 into 9430466823 2018-05-19 16:23:58 +00:00
eho
c52f8e25b3 ui: Correctly load and display downloaded gif's. 2018-05-19 18:23:49 +02:00
Nextcloud bot
b9023355f8
[tx-robot] updated from transifex 2018-05-19 00:47:14 +00:00
eho
534ae55fd3 ui:preview Replaced TouchImageViewCustom objects with PhotoView equivalents. 
- Removed call to setPreviewImageFragment() as this is method no longer exists and doesnt seem to be required.
- Since PhotoView supports gif's out of the box, we should include that mimetype in the relevant if statement.
- Simplified the mime-type check.
 2018-05-18 20:26:26 +02:00
eho
9937ac1c7e res: Replaced TouchImageViewCustom widget with PhotoView widget 2018-05-18 20:16:13 +02:00
eho
5998a642ad Removed ImageViewCustom class. Replaced with PhotoView 2018-05-18 20:15:23 +02:00
eho
bc53e48c47 Removde TouchImageViewCustom class. 
It's being replaced by PhotoView.
 2018-05-18 20:14:25 +02:00
eho
ed405e94e1 ui:preview Updated resetZoom() method to properly reset zoom level on the PhotoView object. 
By calling setDisplayMatrix and setSuppMatrix, passing a new Matrix object to them, the original zoom level is restored.
 2018-05-18 20:11:56 +02:00
eho
3f1c724f42 ui:preview Replace deprecated setOnPageChangeListener() method with addOnPageChangeListener(). 2018-05-18 20:10:11 +02:00
eho
5147f09d6c ui:preview Replaced ExtendedViewPager references with their ViewPager equivalents. 2018-05-18 20:05:26 +02:00
eho
2e8c395037 res: Replace the custom ExtendedViewPager widget with stock ViewPager. 2018-05-18 20:02:36 +02:00
eho
c9c65ad6bc Removed ortiz.touch.* classes. 
They are being replaced by PhotoView and the stock Android View Pager API.
 2018-05-18 20:00:04 +02:00
Nextcloud bot
5769ba55fd
[tx-robot] updated from transifex 2018-05-18 00:51:13 +00:00
Nextcloud bot
3ae3052fd4
[tx-robot] updated from transifex 2018-05-17 00:51:37 +00:00
Andy Scherzinger
b11cb72dbc
Merge pull request #2570 from nextcloud/2569-mimetype-contextbug 
Verify context before getting file type icon.
 2018-05-16 14:26:00 +02:00
Andy Scherzinger
3aa1716d7e
Merge pull request #2582 from nextcloud/accountutils-cleanup 
Cleanup of the AccountUtils class.
 2018-05-16 14:23:44 +02:00
Andy Scherzinger
e344d28e67
Merge pull request #2579 from nextcloud/activities-cleanup 
Housekeeping of Activities Presenter and associated repository classes.
 2018-05-16 14:23:05 +02:00
tobiasKaminsky
9467fadc00
Brander with white primary color 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-16 11:24:47 +02:00
Nextcloud bot
f8987af4f7
[tx-robot] updated from transifex 2018-05-16 00:47:31 +00:00
Tobias Kaminsky
e2f34e6c0a
Merge pull request #2581 from nextcloud/mainapp-cleanup 
Mainapp cleanup
 2018-05-15 15:47:16 +02:00
ardevd
8919321eea authentication: Make the anonymous inner class a lambda. 
With Java 8, most uses of anonymous inner classes should be replaced by lambdas to highly increase the readability of the source code.
 2018-05-15 09:03:38 +02:00
ardevd
e5a1de5e50 authentication: Use single quotes around single character "lastIndexOf" calls. 
An indexOf or lastIndexOf call with a single letter String can be made more performant by switching to a call with a char argument.
 2018-05-15 09:02:55 +02:00
ardevd
75d10d6afb authentication: Use equalsIgnoreCase() instead of convoluted toLowerCase() 
Using toLowerCase() or toUpperCase() to make case insensitive comparisons is inefficient because it requires the creation of temporary, intermediate String objects.

In this case, it also made the fi statement complex and difficult to read.
 2018-05-15 09:01:56 +02:00
ardevd
21a4d56a44 authentication: Use a string constant instead of duplicating "select_oc_account" three times. 
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
 2018-05-15 08:58:39 +02:00
ardevd
27999b5b2c authentication: Added empty private constructor to AccountUtils. 
The private constructor hides the implicit public one
 2018-05-15 08:55:59 +02:00
ardevd
e2c0ccda6f mainapp: Add @Override annotation to onCreate() 2018-05-15 08:50:15 +02:00
ardevd
13a6adfbc1 mainapp: Removed unused import. 2018-05-15 08:48:42 +02:00
ardevd
5ecbd68667 touchimageview: Variable declaration should be separate. 
Declaring multiple variable on one line is difficult to read.
 2018-05-15 08:46:32 +02:00
ardevd
3485cbe3fb touchimageview: Removed empty statement. 
; has no meaning here.
 2018-05-15 08:44:15 +02:00
ardevd
89f985fccb touchimageview: Removed redundant static qualifier. 
Nested enum types are implicitly static
 2018-05-15 08:43:45 +02:00
Nextcloud bot
3b93315193
[tx-robot] updated from transifex 2018-05-15 00:46:24 +00:00
eho
fcd900021f util: Annotate getFileTypeIcon with Nullable. 
If context is null the drawable passed back will be null as well.
 2018-05-14 21:50:48 +02:00
ardevd
00badca7b3 ui:activities Fixed license header formatting. 2018-05-14 15:58:20 +02:00
ardevd
d0a4374646 data:activities Declare context before initializing Account object so that we can re-use the context variable. 2018-05-14 15:57:05 +02:00
ardevd
dd16750742 data:activities: Removed hard coded error message for no results. 
Reference the file_list_empty_headline_server_search string resource instead using the context passed from MainApp.
 2018-05-14 15:56:18 +02:00
ardevd
e80cef5be5 ui:activities ActivitiesPresenter formatting cleanup. 
- Fixed indentation and removed redundant newlines.
 2018-05-14 15:52:19 +02:00
ardevd
00d94c022b ui:activities Make ActivitiesPresenter package private. 2018-05-14 15:51:20 +02:00
tobiasKaminsky
b5bed7874e
fix again a null context 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-14 14:09:53 +02:00
Nextcloud bot
d094946b2d
[tx-robot] updated from transifex 2018-05-14 00:46:08 +00:00
Nextcloud bot
700d3bf7f3
[tx-robot] updated from transifex 2018-05-12 00:45:52 +00:00
ardevd
e705206ca6 utils: Replace deprecated getResources().getDrawable() with ContextCompat.getDrawable() 
Resources#getDrawable(int) method was deprecated in Marshmallow in favor of the new, Theme-aware replacement.
 2018-05-11 12:06:22 +02:00
ardevd
9aa4c254ed utils: Verify that context is not Null before calling context.getResources(). 2018-05-11 12:03:36 +02:00
Nextcloud bot
0a122b26ad
[tx-robot] updated from transifex 2018-05-11 00:44:29 +00:00
Nextcloud bot
baaecbb2bc
[tx-robot] updated from transifex 2018-05-10 00:49:10 +00:00
Tobias Kaminsky
a2c0ae798a
Merge pull request #2549 from nextcloud/contextNull 
Context null -> npe
 2018-05-09 16:23:23 +02:00
tobiasKaminsky
c362398591
fix local sorting 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-09 15:40:48 +02:00
Andy Scherzinger
c2ac4c4ddd
Merge pull request #2564 from nextcloud/bug-identical-sub-expression 
MainApp: Fixed auto upload state check.
 2018-05-09 15:10:35 +02:00
ardevd
cf9925249b MainApp: Fixed instant upload check. 
The if statement should check whether instant photo uploads or instant video uploads are enabled.
 2018-05-09 14:34:43 +02:00
Andy Scherzinger
35b7412bcd
Merge pull request #2565 from nextcloud/bug-authentication-urlnormalization 
authentication: Fixed HTTPS prefixed URL normalization.
 2018-05-09 14:28:12 +02:00
ardevd
3da9b5f12e authentication: Fixed HTTPS prefixed URL normalization. 
I'm assuming here that the if statement is supposed to be checking whether the normalized URL starts with HTTP or HTTPS. The current version seemingly has a typo which this commit fixes.
 2018-05-09 13:22:47 +02:00
ardevd
cd0268220e MainApp: Removed identical sub-expression in if statement. 
This is almost certainly a mistake. Using the same value on either side of a binary operator makes no sense.
 2018-05-09 13:12:22 +02:00
AndyScherzinger
200e5aac07
center tabs 2018-05-09 11:34:04 +02:00
AndyScherzinger
1349c2648c
fix lint issues 2018-05-09 11:34:02 +02:00
AndyScherzinger
e047df0f4a
fix theming/tinting for tab indicator 2018-05-09 11:34:02 +02:00
AndyScherzinger
70a9c9584d
add theming/tinting for sharing headers 2018-05-09 11:34:01 +02:00
AndyScherzinger
dc771a8d67
implemented pull-to-refresh for activities 2018-05-09 11:34:01 +02:00
AndyScherzinger
7c21f46b89
fix empty activities icon 2018-05-09 11:34:00 +02:00
AndyScherzinger
c7d8171be1
fix use of asyncDrawable 2018-05-09 11:33:59 +02:00
AndyScherzinger
27a2041db5
codacy cleanup + fixed javaDoc 2018-05-09 11:33:59 +02:00
AndyScherzinger
5934bbfe9a
also use standard character avatars for sharees instead of grey icons (just for iteration 1, soon tobe replaces by the new details&sharing implementation) 2018-05-09 11:33:58 +02:00
AndyScherzinger
adb9ab24ef
cleanup details fragment, use standard character avatars for sharees instead of grey icons (just for iteration 1) 2018-05-09 11:33:58 +02:00
AndyScherzinger
57e061ed8d
uncomment unused method/calls for use whenever we switch to glide 2018-05-09 11:33:57 +02:00
AndyScherzinger
941f621fcc
implement set available offline via menu 2018-05-09 11:33:57 +02:00
AndyScherzinger
60a497a9af
load center cropped preview image, hide type icon 2018-05-09 11:33:56 +02:00
tobiasKaminsky
0a8822a767
load resized image in header 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-09 11:33:56 +02:00
AndyScherzinger
ca7e60b9ea
codacy: combined nested if statements 2018-05-09 11:33:55 +02:00
AndyScherzinger
af4918deaf
WiP preview image in toolbar 2018-05-09 11:33:54 +02:00
AndyScherzinger
6952e647bc
further optimize menu item filtering code 2018-05-09 11:33:54 +02:00
AndyScherzinger
e42ff25b92
move menu filtering to menu filter helper 2018-05-09 11:33:53 +02:00
AndyScherzinger
ce66e125e2
simplify menu item filtering code 2018-05-09 11:33:53 +02:00
AndyScherzinger
46f226ba3a
move menu to file name, hide tags (to be implemented later) 2018-05-09 11:33:52 +02:00
tobiasKaminsky
19edfb183a
filter activity by file Id 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-09 11:33:51 +02:00
AndyScherzinger
d1ba80eb4a
cleanup 2018-05-09 11:33:51 +02:00
AndyScherzinger
6013956150
organize imports 2018-05-09 11:33:50 +02:00
AndyScherzinger
7ff4f4e378
add initial loading of (all, not file specific) activities 2018-05-09 11:33:50 +02:00
AndyScherzinger
dd050b0dc6
new lines and license headers 2018-05-09 11:33:49 +02:00
AndyScherzinger
254ac96795
WiP for #2485 2018-05-09 11:33:48 +02:00
Nextcloud bot
14a127eb7f
[tx-robot] updated from transifex 2018-05-09 00:40:59 +00:00
Nextcloud bot
aa6fc038c7
[tx-robot] updated from transifex 2018-05-08 00:41:44 +00:00
Nextcloud bot
d82ff62d30
[tx-robot] updated from transifex 2018-05-07 00:41:01 +00:00
Nextcloud bot
57d96761ac
[tx-robot] updated from transifex 2018-05-05 00:42:00 +00:00
Andy Scherzinger
4ce3900025
Merge pull request #2548 from nextcloud/lastindexof_performance 
datamodel: String function use should be optimized for single characters
 2018-05-04 16:55:01 +02:00
Andy Scherzinger
6047604ad5
Merge pull request #2545 from nextcloud/ortiztouch-switchbug 
ortiz.touch: End switch case with an unconditional break.
 2018-05-04 16:51:24 +02:00
AndyScherzinger
d7f223685e
organize imports 2018-05-04 16:20:20 +02:00
AndyScherzinger
cd9bfb12b8
Fix CR 2018-05-04 16:15:17 +02:00
ardevd
b1ef83524c
Anonymous inner classes containing only one method should become lambdas 
Before Java 8, the only way to partially support closures in Java was by using anonymous inner classes. But the syntax of anonymous classes may seem unwieldy and unclear.

With Java 8, most uses of anonymous inner classes should be replaced by lambdas to highly increase the readability of the source code.
 2018-05-04 16:15:16 +02:00
tobiasKaminsky
b5038e36fb
context null -> npe 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-05-04 14:10:47 +02:00
ardevd
3a01e07afc datamodel: String function use should be optimized for single characters 
An lastIndexOf call with a single letter String can be made more performant by switching to a call with a char argument.
 2018-05-04 09:18:30 +02:00
ardevd
58e4360630 ui: Corrected '&' to '&&' in boolean if statement. 
The use of non-short-circuit logic in a boolean context is likely a mistake - one that could cause serious program errors as conditions are evaluated under the wrong circumstances.
 2018-05-04 09:06:21 +02:00
ardevd
851d065ace ortiz.touch: End switch case with an unconditional break. 
When the execution is not explicitly terminated at the end of a switch case, it continues to execute the statements of the following case. While this is sometimes intentional, it often is a mistake which leads to unexpected behavior
 2018-05-04 08:59:54 +02:00
Nextcloud bot
3c5cc68005
[tx-robot] updated from transifex 2018-05-04 00:43:52 +00:00
Andy Scherzinger
fdd9c9f942
Merge pull request #2540 from nextcloud/activities-ondestroy-override 
activities: A couple of code quality fixes for the Activities component
 2018-05-02 23:04:55 +02:00
eho
04da4de923 authentication: Renamed Bundle object in onCreate(). 2018-05-02 19:19:25 +02:00
ardevd
8fd8577aea authentication: Added @Override annotations to applicable methods. 
Using the @Override annotation is useful for two reasons :

It elicits a warning from the compiler if the annotated method doesn't actually override anything, as in the case of a misspelling.
It improves the readability of the source code by making it obvious that methods are overridden.
 2018-05-02 17:20:49 +02:00
ardevd
ffb9ad4151 data: Added private constructor for the Injection utility class. 
Utility classes, which are collections of static members, are not meant to be instantiated. Even abstract utility classes, which can be extended, should not have public constructors.

Java adds an implicit public constructor to every class which does not define at least one explicitly. Hence, at least one non-public constructor should be defined.
 2018-05-02 16:15:46 +02:00
ardevd
ab6fa36f9b activities: Use isEmpty() to check whether the list of activities is empty. 
Using Collection.size() to test for emptiness works, but using Collection.isEmpty() makes the code more readable and can be more performant
 2018-05-02 16:12:47 +02:00
ardevd
4d786a3f41 activities: Added @Override annotation above the onDestroy() method signature. 
Using the @Override annotation is useful for two reasons:

It elicits a warning from the compiler if the annotated method doesn't actually override anything, as in the case of a misspelling.
It improves the readability of the source code by making it obvious that methods are overridden.
 2018-05-02 16:11:11 +02:00
Andy Scherzinger
66deeb7731
Merge branch 'master' into 2474-feature-mvp-activities 2018-05-02 15:39:15 +02:00
ardevd
385bb429c7 passcodemanager: Reordered auth type check statements. 2018-05-02 14:45:15 +02:00
ardevd
2f0464d6e4 passcodemanager: Simplified passcode/fingerprint auth timeout check. 2018-05-02 14:37:06 +02:00
ardevd
40e3c050b2 authentication:passcodemanager: long literal '0l' should be 0L. 
The suffix L is preferred, because the letter l (ell) is often hard to distinguish from the digit 1 (one).
 2018-05-02 14:34:08 +02:00
ardevd
6fcfa840b7 authentication:passcodemanager: Cleaned up variable naming. 2018-05-02 14:19:36 +02:00
ardevd
b8cde0fa86 authentication:passcodemanager: Stricter variable declaration. 2018-05-02 13:56:28 +02:00
ardevd
2615926163 authentication:passcodemanager: Simplified if-statements. 2018-05-02 13:55:07 +02:00
ardevd
81f72a50c4 authentication:passcodemanager: Stricter access declaration. 2018-05-02 13:54:39 +02:00
ardevd
786ffd2c44 authentication:passcodemanager: Explicit argument type removed. 2018-05-02 13:53:56 +02:00
ardevd
c8b3f1e168 data:activities Added newline at the bottom. 2018-05-02 13:50:18 +02:00
ardevd
81f4f2a767 authentication: Cleaned up variable name in PassCodeManager. 2018-05-02 13:45:17 +02:00
ardevd
c079d8c285 data:files Properly return callback.onError if remoteOcFile is null. 2018-05-02 13:08:22 +02:00
ardevd
49d0ccac7d data:files Cleaned up onPostExecute() if-statements. 2018-05-02 12:54:43 +02:00
ardevd
9efa675c2a activities: Removed hungarian variable name notation. 2018-05-02 12:38:33 +02:00
Nextcloud bot
0556586232
[tx-robot] updated from transifex 2018-04-30 00:41:33 +00:00
eho
07770a2268 activities: Added copyright headers 2018-04-29 19:49:54 +02:00
Nextcloud bot
8a1cb0b37a
[tx-robot] updated from transifex 2018-04-29 00:44:16 +00:00
Nextcloud bot
f84db51efa
[tx-robot] updated from transifex 2018-04-28 00:42:16 +00:00
Nextcloud bot
cd48dd7335
[tx-robot] updated from transifex 2018-04-27 00:42:51 +00:00
AndyScherzinger
6f60447665
lint: fix implicitly using the default locale is a common source of bugs: Use toLowerCase(Locale) instead. For strings meant to be internal use Locale.ROOT, otherwise Locale.getDefault(). 2018-04-26 18:01:40 +02:00
AndyScherzinger
9916aecfa9
lint: fix set android:baselineAligned="false" on this element for better performance 2018-04-26 18:01:39 +02:00
AndyScherzinger
b8a4c4e8d6
lint: fix the image ic_favorite.png varies significantly in its density-independent (dip) size across the various density versions (ic_ needs to comply with standard icon sizes) 2018-04-26 18:01:39 +02:00
AndyScherzinger
34e9b55632
lint: fix the image ic_account_circle.png varies significantly in its density-independent (dip) size across the various density versions 2018-04-26 18:01:38 +02:00
AndyScherzinger
ee736ce214
lint: fix This tag and its children can be replaced by one <TextView/> and a compound drawable _and_ unnecessary parent element 2018-04-26 18:01:37 +02:00
AndyScherzinger
4a8de18d49
lint: fix attribute networkSecurityConfig is only used in API level 24 and higher (current min is 14) 2018-04-26 18:01:37 +02:00
AndyScherzinger
6b6716dc72
lint: fix attribute splitTrack is only used in API level 21 and higher (current min is 14) 2018-04-26 18:01:36 +02:00
AndyScherzinger
ea2ed935f9
lint: Fix the resource R.string.upload_list_loading appears to be unused 2018-04-26 18:01:35 +02:00
AndyScherzinger
3e1d80af43
lint: fix the resource R.layout.list_fragment_expandable appears to be unused 2018-04-26 18:01:35 +02:00
AndyScherzinger
8ec30ad52f
lint: fix possible overdraw: Root element paints background @color/background_color with a theme that also paints a background (inferred theme is @style/Theme.ownCloud.Toolbar) 2018-04-26 18:01:30 +02:00
Andy Scherzinger
ab3230775a
Merge pull request #2512 from nextcloud/2507-bugfix-intentmode 
Preferences: Don't start FileDisplayActivity when pressing the back button
 2018-04-26 17:57:50 +02:00
tobiasKaminsky
a63c29ac5f
do not sort on getFolderContent 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-04-26 13:37:51 +02:00
AndyScherzinger
bca8c493ab
Fix CR 2018-04-26 13:18:45 +02:00
AndyScherzinger
382f4942ae
Fix CR 2018-04-26 13:16:01 +02:00
AndyScherzinger
9ef32d8847
Fix CR 2018-04-26 13:16:01 +02:00
AndyScherzinger
1167d46d93
added more information on initial connection error 2018-04-26 13:16:00 +02:00
eho
7982c08c13
Preferences: Don't launch a new intent when hitting the back button. 
It doesn't really make sense to launch a hard coded activity when navigating back from the Preferences activity. The expected behavior is probably to return the user to the previous activity rather than always throwing them back to the FileDisplayActivity.
 2018-04-26 11:24:55 +02:00
tobiasKaminsky
f6c650d046
Activites -> Activities 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2018-04-26 11:13:18 +02:00
ardevd
e4b20211ec data: Removed unused private fields. 2018-04-26 10:18:20 +02:00
ardevd
da931e44dc activities: Set nextPageUrl to null when manually refreshing activities. 
When the user swipes the recycler view to refresh the list of activities we want the list to be cleared and populated with the newest activities without loading all the other paginated activities that might have been loaded up to that point. Therefore we set the nextPageUrl variable to null in the setOnRefreshListener for the swipeRefreshLayout.
 2018-04-26 08:45:07 +02:00
ardevd
6f106952f9 activities: Updated usage of the loadActivities() contract method. 2018-04-26 08:39:20 +02:00
ardevd
c68edcf7a8 activities: Fixed typo in contract interface method. 2018-04-26 08:38:24 +02:00
Nextcloud bot
884917653e
[tx-robot] updated from transifex 2018-04-26 00:42:56 +00:00
AndyScherzinger
13baa9c32f
removed margin left to really center headline, added empty line at the end of the file 2018-04-24 19:25:28 +02:00
artem-p
fdb1fb6e97
increase spacing above and below the top header 2018-04-24 19:25:28 +02:00
artem-p
7af202ded8
position whats new details title and text 2018-04-24 19:25:28 +02:00
artem-p
2ac1a3ae4a
whats new title is not bold 2018-04-24 19:25:25 +02:00
Nextcloud bot
309f1e6f97
[tx-robot] updated from transifex 2018-04-24 09:09:48 +00:00
Andy Scherzinger
83934655b1
Merge pull request #2503 from nextcloud/2502-npefix 
adapter: Pass valid context to setImageDrawable()-call.
 2018-04-24 09:50:40 +02:00
Nextcloud bot
6cf36914d3
[tx-robot] updated from transifex 2018-04-24 00:42:46 +00:00
ardevd
eab58accd7 layout: Formatting fixes for the activity_list_layout xml. 2018-04-23 14:03:32 +02:00
ardevd
8168063ae4 data:files Simplified onPostExecute processing. 2018-04-23 13:47:56 +02:00
ardevd
162fdb9d8a tests: Added unit tests for the RemoteFilesRepository class. 
Provides 100% coverage of the RemoteFilesRepository class.
 2018-04-23 13:45:23 +02:00
ardevd
99122f1467 tests: Added unit tests for the RemoteActivitiesRepository class. 2018-04-23 13:40:31 +02:00
ardevd
ca6cd76f0b adapter: Pass valid context to setImageDrawable()-call. 
Fixes #2502.
 2018-04-23 13:26:23 +02:00
ardevd
9a9a4629e0 tests: Updated ActvitiesPresenter unit tests with the new interface methods. 2018-04-23 13:25:25 +02:00
ardevd
5998438f12 activities: Correctly handle the nextPageUrl parameter. 
This should be managed by the activity and not the data repository API since the latter has no track of state.
 2018-04-23 13:24:49 +02:00
ardevd
81a300077c test: Added unit tests for the Activities Presenter. 
This provides 100% coverage of the Activities Presenter class.
 2018-04-23 12:59:42 +02:00
ardevd
3fd750c871 activities: Removed legacy ActivitesList activity 2018-04-23 12:40:55 +02:00
ardevd
45755395c4 activities: Cleaned up activity class. 
Removed unused imports and objects.
 2018-04-23 12:40:45 +02:00
ardevd
dd9a029d18 activites: Any theming call has now context, instead of app context (from master) 2018-04-23 12:38:30 +02:00
ardevd
03e0e181a2 Merge remote-tracking branch 'origin/master' into 2474-feature-mvp-activities 2018-04-23 12:35:38 +02:00
ardevd
94fa9dc0bf activites: Use correct ActionListener method for showing File details. 2018-04-23 12:33:59 +02:00
ardevd
855e06c912 data:files Return descriptive error message if null is returned. 
TODO: Use string resources instead of hardcoded strings.
 2018-04-23 12:33:30 +02:00
ardevd
a2dad4ec4f data:activities: Fix onPostExecute success handling. 
Missing else block resulted in error message being returned every time.
 2018-04-23 12:27:33 +02:00
ardevd
5acfe5c201 activities: Refactored Remote file read operations. 
Use the File repository instead of the local AsyncTask implementation.
 2018-04-23 12:19:01 +02:00
ardevd
9fde4ba10d data: Added Injection class for injection data repositories. 2018-04-23 12:18:06 +02:00
ardevd
c0044bddc1 data:files Added file repository classes and interfaces. 
This provides a centralized asynchronous repository for all remote File operations. Currently only supports ReadRemoteFile as required by the activities activity.
 2018-04-23 12:17:46 +02:00