Commit graph

338 commits

Author SHA1 Message Date
Álvaro Brey Vilas
14c1e8d718
build.gradle: Refactor spotbugs setup
- Don't duplicate tasks. Use the ones that spotbugs provides and link them to their sourcesets
 - Add dependencies to compileSources to the spotbugs tasks
 - Update spotbugs plugin

This results in a much higher amount of issues. They were probably not being properly scanned earlier.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-05 16:12:05 +01:00
tobiasKaminsky
3823eccfe6
AccountManagerService needs to be exported
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-27 08:49:05 +02:00
drone
05d98ccc4b Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2021-10-26 06:02:19 +00:00
drone
16b37bcc05
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 16:06:17 +02:00
tobiasKaminsky
042c413569
Calendar backup/import
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 13:02:12 +02:00
drone
8b53b54d48 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2021-10-25 06:02:10 +00:00
Tobias Kaminsky
9b18d0d6cb
Merge pull request #9098 from nextcloud/drone-commit-signoff
scripts: Have Drone properly signoff commits so that it doesn't break DCO
2021-10-21 10:59:23 +02:00
drone
0cbe866a3a Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-10-18 09:55:18 +00:00
Álvaro Brey Vilas
a90487a261
scripts: Have Drone properly signoff commits so that it doesn't break DCO
Use git env variables to force a valid email

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-15 10:42:12 +02:00
drone
7645b18c1e Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-10-14 12:46:12 +00:00
Andy Scherzinger
9c432b5655 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-06 08:26:25 +00:00
Andy Scherzinger
ec59542f5a bump score due to AGP upgrade
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-06 08:26:25 +00:00
Álvaro Brey
7fd8724473 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2021-09-29 12:28:59 +00:00
Timo Triebensky
5e6e3d4800
Merge branch 'master' into add-sso-patch-method 2021-09-21 11:39:25 +02:00
drone
8a59cd9c87 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-09-13 09:51:17 +00:00
drone
50e0cef895 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-09-08 10:39:22 +00:00
Andy Scherzinger
a1700664d2
bump due to spotbugs update
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-08-19 21:53:15 +02:00
binsky
f25d85a33e increase SpotBugs to 464 to accept the new PatchMethod class for the SSO api
Signed-off-by: binsky <timo@binsky.org>
2021-08-12 15:50:47 +02:00
tobiasKaminsky
947d0c5115
Somehow SpotBugs needs to be on 462.
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-08-05 15:02:46 +02:00
Andy Scherzinger
e95c94939b
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-24 15:23:44 +02:00
Andy Scherzinger
be1a52a813
bump spotbugs score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-17 22:33:02 +02:00
Andy Scherzinger
8516e6a4d5
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-17 16:52:25 +02:00
Andy Scherzinger
10a6e519cb
Drone: update Lint/spotbugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-07-17 14:16:40 +02:00
tobiasKaminsky
1ea436e4dd
Use ExoPlayer for audio/video player
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-06-02 10:09:09 +02:00
Andy Scherzinger
5bbbae7165
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-06-01 18:27:58 +02:00
tobiasKaminsky
419cb69b08
Fix not null fix
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-05-27 10:16:06 +02:00
drone
1d563cd69e Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-05-26 22:11:07 +00:00
tobiasKaminsky
fb7bba8fe4
analysis-wrapper.sh: fix not Null check
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-05-26 08:43:22 +02:00
Andy Scherzinger
7ffa52c037
bump lint score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-05-14 10:57:21 +02:00
Tobias Kaminsky
271845c0b0 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: Tobias Kaminsky <tobias@kaminsky.me>
2021-03-18 06:40:10 +00:00
drone
d597952522
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-02-23 23:52:26 +01:00
drone
01897a04d2
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-02-19 09:00:04 +01:00
Andy Scherzinger
71894243f0
codacy: Avoid declaring a variable if it is unreferenced before a possible exit point.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-02-18 14:58:19 +01:00
drone
a2d31e8ed0 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-02-11 18:01:52 +00:00
drone
7afbab6337 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-01-05 20:39:26 +00:00
drone
da8ecb5aa0 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-01-05 16:21:02 +00:00
Tobias Kaminsky
51af817b76
Merge pull request #7603 from nextcloud/bottomSheetImprovement
Bottom sheet improvement
2021-01-05 11:58:39 +01:00
tobiasKaminsky
38e27420c3
Detect dependencies with snapshot
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-01-05 09:38:34 +01:00
drone
47b63c94c3
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2021-01-04 17:48:43 +01:00
drone
badb394e19 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <noreply@drone>
2020-12-04 09:20:24 +00:00
nextcloud-android-bot
58f4c6833c Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-11-30 09:58:07 +00:00
nextcloud-android-bot
0849cf21bd
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-11-30 09:57:07 +01:00
nextcloud-android-bot
d25c201b63 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-11-25 21:22:03 +00:00
dependabot-preview[bot]
634e138fb4
Bump daggerVersion from 2.29.1 to 2.30.1
Bumps `daggerVersion` from 2.29.1 to 2.30.1.

Updates `dagger` from 2.29.1 to 2.30.1
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.29.1...dagger-2.30.1)

Updates `dagger-android` from 2.29.1 to 2.30.1
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.29.1...dagger-2.30.1)

Updates `dagger-android-support` from 2.29.1 to 2.30.1
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.29.1...dagger-2.30.1)

Updates `dagger-compiler` from 2.29.1 to 2.30.1
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.29.1...dagger-2.30.1)

Updates `dagger-android-processor` from 2.29.1 to 2.30.1
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.29.1...dagger-2.30.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-11-24 09:45:05 +01:00
nextcloud-android-bot
e3c756364d Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-11-20 22:23:26 +00:00
nextcloud-android-bot
f036bea63a Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-11-17 09:04:37 +00:00
nextcloud-android-bot
b466be9439
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-11-08 16:57:27 +01:00
nextcloud-android-bot
51837d7b0c
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-10-30 10:12:57 +01:00
tobiasKaminsky
0b8cf615e6
fix lint
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-10-29 20:28:47 +01:00
nextcloud-android-bot
12a7145e1a Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-10-29 06:22:20 +00:00
tobiasKaminsky
6b0f929605
fix analysis-wrapper.sh script
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-10-28 14:44:20 +01:00
tobiasKaminsky
b7a4d265cd
fix analysis-wrapper.sh script
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-10-28 14:44:19 +01:00
tobiasKaminsky
3809f2ab7b
add check for nonNull
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-10-28 14:44:17 +01:00
nextcloud-android-bot
55057a386d
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-10-28 14:44:17 +01:00
tobiasKaminsky
163422e6ff
fix tests
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-10-20 22:20:25 +02:00
nextcloud-android-bot
0bba77ded8 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-10-15 10:03:28 +00:00
nextcloud-android-bot
7b9d90733f Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-10-15 09:18:33 +00:00
nextcloud-android-bot
247dabb385 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-10-15 08:21:34 +00:00
nextcloud-android-bot
a8f3f9022e Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-10-14 06:37:49 +00:00
nextcloud-android-bot
5131ee762f Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-10-14 06:35:59 +00:00
Andy Scherzinger
1ca8136af9
bump lint score due to new lint checks / gradle version
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-10-13 11:19:33 +02:00
nextcloud-android-bot
3f067063ad Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-10-06 10:25:01 +00:00
nextcloud-android-bot
d0e66f95bd Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-10-01 10:40:51 +00:00
nextcloud-android-bot
58e16bcbbe Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-09-23 06:25:08 +00:00
nextcloud-android-bot
98c963cb10 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-09-22 06:25:59 +00:00
tobiasKaminsky
e07c2d169a
- use display name for avatar generation
- use new server algorithm
Ref: https://github.com/nextcloud/nextcloud-vue/blob/master/src/functions/usernameToColor/usernameToColor.js

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-09-03 09:19:03 +02:00
nextcloud-android-bot
9583fc87ec Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-08-27 15:52:23 +00:00
nextcloud-android-bot
8f1d7b5b95 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-07-28 19:28:59 +00:00
nextcloud-android-bot
94b26cc28e Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-07-09 14:50:07 +00:00
tobiasKaminsky
a884bab878
reduce log output for drone
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-07 11:48:25 +02:00
nextcloud-android-bot
a06057acfa Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-07-01 13:52:27 +00:00
tobiasKaminsky
4bb0a3c176
Edit label for public share
split up between public share and user shares

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-07-01 12:07:26 +02:00
tobiasKaminsky
f6e8636cfa
remove EditShareFragment.java
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-30 15:32:17 +02:00
nextcloud-android-bot
444dcd000e Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-30 07:55:26 +00:00
tobiasKaminsky
cc517ffcfd
Lint ignore
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-29 16:00:44 +02:00
tobiasKaminsky
32a0d1c309
Replace fragment by FragmentContainerView
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-29 16:00:44 +02:00
nextcloud-android-bot
79f4270bb9 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-26 13:35:51 +00:00
nextcloud-android-bot
e0d5676151 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-25 21:18:34 +00:00
nextcloud-android-bot
f6e7c44596 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-25 16:55:05 +00:00
nextcloud-android-bot
741fb410f1 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-25 11:13:55 +00:00
nextcloud-android-bot
961e6c179a
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-25 13:00:04 +02:00
Andy Scherzinger
83d4aaf1ab
Merge pull request #6345 from nextcloud/usbr
fix USBR_UNNECESSARY_STORE_BEFORE_RETURN
2020-06-24 23:18:08 +02:00
nextcloud-android-bot
98d930b8ab Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-24 21:00:09 +00:00
nextcloud-android-bot
0fa902d2d2 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-24 20:58:48 +00:00
nextcloud-android-bot
9f3e1857db Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-24 15:17:33 +00:00
Tobias Kaminsky
ed8819ec86
Merge pull request #6327 from nextcloud/combineShare
Combined ShareActivity with FileDetailSharingFragment as much as possible
2020-06-24 10:43:24 +02:00
nextcloud-android-bot
c5abe938bd Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-23 14:30:27 +00:00
tobiasKaminsky
7732ff065b
Combined ShareActivity with FileDetailSharingFragment as much as possible
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-23 10:47:43 +02:00
nextcloud-android-bot
3a28b84e9d Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-19 09:29:38 +00:00
tobiasKaminsky
94d7506cb5
fix after rebase
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-19 11:16:34 +02:00
tobiasKaminsky
5f185326ab
Fixed Lint:
MissingClass: Missing registered class
Range: Outside Range
UseAppTint: app:tint attribute should be used on ImageView
UseCompatLoadingForDrawables
UseCompatTextViewDrawableXml

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-19 11:03:22 +02:00
tobiasKaminsky
f6f401aa0d
change to newer spotbugs
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-19 11:03:07 +02:00
nextcloud-android-bot
8e5f893812 Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-06-17 12:12:39 +00:00
tobiasKaminsky
8cec637c24
manually increase findbugs
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-08 08:43:12 +02:00
tobiasKaminsky
32c7c0560c
Fix avatar tests after changes of UI
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-02 16:12:30 +02:00
tobiasKaminsky
fa8ffa1873
- disabling test_orchestrator
- E2E tests only on NC19+
- fixed Tests

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-05-26 11:18:58 +02:00
nextcloud-android-bot
a5b0c83f02 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-05-25 11:35:24 +00:00
tobiasKaminsky
df75e35db5
revert findbugs count
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-05-25 13:26:27 +02:00
nextcloud-android-bot
a87c54effa Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2020-05-25 09:43:14 +00:00
Tobias Kaminsky
b580352ccc
Merge pull request #6005 from nextcloud/randomE2E
E2E overhaul
2020-05-20 15:27:20 +02:00