Commit graph

3428 commits

Author SHA1 Message Date
Andy Scherzinger
8062340f63
Merge pull request #4657 from nextcloud/bumpSDK
bump to latest SDK
2019-12-09 17:51:09 +01:00
Tobias Kaminsky
1290bbe52e
Merge pull request #4918 from Infomaniak/fix/calendar-not-refreshed
Resolved issue relative to calendar refresh in link-sharing
2019-12-09 11:58:21 +01:00
Siddharth Srinivasan
aabc97de82 Renamed refresh methods and updated ETag parameter accordingly
Signed-off-by: Siddharth Srinivasan <13200018+siddharths2710@users.noreply.github.com>

Renamed refresh methods and updated ETag parameter accordingly with sign-off
2019-12-06 21:57:14 +05:30
Siddharth Srinivasan
c608f0081c Merge remote-tracking branch 'upstream/master'
Keep in line with upstream
2019-12-06 20:36:26 +05:30
Kilian Périsset
88fe5069eb
Fixed bug relative to activities icon + applied DRY 2019-12-06 15:10:41 +01:00
Kilian Périsset
9b94cc2b58
Fixed the indentation for ExpirationDatePicker 2019-12-06 12:46:50 +01:00
Kilian Périsset
65b82c2ee5
Allowed onbackpressed from properties (without redisplaying file) + Removed useless intent data 2019-12-06 12:07:53 +01:00
Kilian Périsset
25d9c46f82
Fixed bug relative to details from Image Preview 2019-12-06 11:52:47 +01:00
tobiasKaminsky
b01f71972f
fix #4955
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-06 08:25:50 +01:00
Kilian Périsset
acd5d48d96
Applied the expiration date in each instance of DatePicker 2019-12-05 11:52:33 +01:00
Andy Scherzinger
d006ac257e
Merge pull request #4923 from nextcloud/theming_sharing_box
fix wrong text color on edit text input on dark mode
2019-12-05 11:20:44 +01:00
tobiasKaminsky
1584de9769
use SystemClock.elapsedRealtime() everywhere
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-05 11:05:47 +01:00
Tobias Kaminsky
dda56defb4
Merge pull request #4933 from nextcloud/appLocking
Use SystemClock.elapsedRealtime() instead of System.currentTimeMillis()
2019-12-04 08:21:04 +01:00
Andy Scherzinger
cb00677172
Merge pull request #4926 from nextcloud/deleteChecksFor16
remove all checks for <= JELLY_BEAN as we have this as our new minimum.
2019-12-04 06:59:17 +01:00
Tobias Kaminsky
fd48163e22
Merge pull request #4922 from nextcloud/themeFollowOS
Dark mode: light, dark, follow system
2019-12-04 06:47:36 +01:00
tobiasKaminsky
5e687f2c17
Dark mode: light, dark, follow system
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-04 06:33:34 +01:00
tobiasKaminsky
fb69c1bd51
remove all checks for <= JELLY_BEAN as we have this as our new minimum.
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-04 06:15:30 +01:00
Tobias Kaminsky
7cf3ba93c6
Merge pull request #4925 from nextcloud/NotNull
replace org.jetbrains.annotations with androidx.annotations
2019-12-03 15:49:40 +01:00
Kilian Périsset
ba58d37aff
Changed indentation of Picker new instance 2019-12-03 14:15:37 +01:00
tobiasKaminsky
2f9c5e9761
replace org.jetbrains.annotations with androidx.annotations
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-03 13:31:02 +01:00
tobiasKaminsky
3cf0e6e5e4
replaced distinct by manually unique via HashMap
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-03 09:48:23 +01:00
tobiasKaminsky
83903ea1db
fix wrong sync status in auto upload on white theming
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-03 08:55:17 +01:00
tobiasKaminsky
e0bd44cf83
fix wrong text color on search input on dark mode
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-03 08:36:20 +01:00
Kilian Périsset
0b86d6a1d9
Resolved issue relative to calendar refresh in link-sharing 2019-12-02 18:40:58 +01:00
tobiasKaminsky
c612e2f547
Use SystemClock.elapsedRealtime() instead of System.currentTimeMillis()
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-12-02 07:52:17 +01:00
Siddharth Srinivasan
041a6787b8 Explicitly refreshing list on resume and on file move operation
Signed-off-by: Siddharth Srinivasan <siddharths2710phone@gmail.com>

Explicitly refreshing list on resume and on file move operation
2019-11-28 22:59:37 +05:30
Andy Scherzinger
d17c853493
re-add button/action and improve upon code review
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-11-27 21:43:53 +01:00
Andy Scherzinger
74bfe473c4
remove action button, use checkable menu item for shown/hidden state display
(design review)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-11-27 21:35:31 +01:00
Andy Scherzinger
7c62ad6b06
unify use of boolean, make use of lombok getter/setters, remove unneeded boolean boxing
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-11-27 21:35:05 +01:00
Andy Scherzinger
ca6918f9fc
show/hide improvements when list is completed hidden + nicer empty UI + action button
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-11-27 21:35:03 +01:00
Andy Scherzinger
23e44243da
show/hide auto upload list items
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-11-27 21:34:40 +01:00
Chris Narkiewicz
a7eb7148fa
Migrate simple cases of getCurrentAccount() to getUser()
Migrate trivially convertible uses of getCurrentAccount()
to new user model - getUser().

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-11-25 08:53:50 +00:00
Chris Narkiewicz
609b99666f
New user model
New non-nullable user model abstracts away all complexities of Nextcloud
user account and provides.

- backported java.util.Optional
- extended UserAccountManager with User getters
- deprecated CurrentAccountProvider.getCurrentAccount() method
- migrated connectivity service to new user model
- migrated UploadsStorageManager to new user model
- migrated OCFileListAdapter

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-11-21 19:58:57 +00:00
Tobias Kaminsky
94502f66b5
Merge pull request #4787 from ArisuOngaku/auto-upload-start-date-persistence
Make synced folder init/enable date persistent
2019-11-19 13:21:43 +01:00
Tobias Kaminsky
dbe12e6d20
Merge pull request #4789 from nextcloud/name_pattern_menus
Improve menu file name pattern
2019-11-18 15:26:35 +01:00
Tobias Kaminsky
77b6b178a9
Merge pull request #4841 from nextcloud/disableOldLoginMethod
allow to switch off old login method
2019-11-18 13:51:38 +01:00
tobiasKaminsky
b561f68834
allow to switch off old login method
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-11-18 10:13:09 +01:00
Alice Gaudon
65da616f81 FilesSyncHelper: use our own logging framework
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2019-11-15 07:56:17 +01:00
Andy Scherzinger
693f408276
Improve menu file name pattern
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-11-13 11:47:23 +01:00
Chris Narkiewicz
fb615ef279 Remove out-of-band setAccount/onAccountSet calls
Activity account is set in FilesActivity.onAccount(),
but related components are updated in BaseActivity.onStart().

1. Initialize account in BaseActivity.onCreate()
2. Update storage manager and capabilities immediately
   on account set, not waiting for onStart() lifecycle.
3. inline storage manager and capabilities update in setAccount()
4. Remove setAccount()/onAccountSet() calls that sets default
   account, as this duplicates BaseActivity.onCreate()

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-11-12 06:21:05 +00:00
Tobias Kaminsky
890789f0a7
Merge pull request #4797 from nextcloud/ezaquarii/replace-shared-preferences-with-app-preferences-in-base-activity
Replace BaseActivity.sharedPreferences with app preferences
2019-11-06 13:52:54 +01:00
Tobias Kaminsky
180bdee721
Merge pull request #4801 from Infomaniak/feature/resolve-set-as-wallpaper-issue
Fixing picture "set as wallpaper" issue in properties (duplicate)
2019-11-06 13:48:23 +01:00
Alice Gaudon
2e13212752 SyncedFolderProvider: pass Clock dependency via constructor instead of dagger
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2019-11-06 01:59:06 +01:00
Alice Gaudon
c2ea4de802 FileContentProvider: add dagger injection
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2019-11-06 01:50:32 +01:00
Alice Gaudon
7f4db3fdd0 Make synced folder init/enable date persistent
Signed-off-by: Alice Gaudon <alice@gaudon.pro>
2019-11-05 21:23:45 +01:00
Kilian Périsset
25aaf4b907
Applied ability to set as wallpaper from properties of a picture
Signed-off-by: Kilian Périsset <kilian.perisset@infomaniak.com>
2019-11-05 14:20:35 +01:00
Chris Narkiewicz
6b01382e7f
Replace BaseActivity.sharedPreferences with app preferences
- Eliminate access to shared preferences when setting dark theme.
- Extend AppPreferences interface to allow subscription for preference changes
- Improve preferences interface documentation

Fixes #4791

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-11-05 06:00:58 +00:00
Daniel Bailey
b0563b9310
Theming: Fix date picker button text colour
Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-11-04 14:52:54 +00:00
tobiasKaminsky
71264e19b8
use file/folder in "copy internal link" description
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-11-01 12:32:07 +01:00
Andy Scherzinger
fe353a7561
consistently use snake_case for color resources
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-30 16:13:29 +01:00
Andy Scherzinger
2a43da6bdf
Merge pull request #4746 from nextcloud/createChooser
use default open chooser with "just once", "always"
2019-10-29 16:23:00 +01:00
tobiasKaminsky
bee8770ce0
- fix typo in styles
- fix sign up with provider in dark primary color

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-29 11:27:03 +01:00
Tobias Kaminsky
cc710b09cb
Merge pull request #3459 from nextcloud/dark_theme
Dark theme
2019-10-29 11:18:48 +01:00
Andy Scherzinger
c1aa005db9
changes due to code review
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-29 11:05:44 +01:00
tobiasKaminsky
12fe91a6dd
use default open chooser with "just once", "always"
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-29 07:28:51 +01:00
Tobias Kaminsky
cabe2fcff0
Merge pull request #4725 from nextcloud/ssoHeaders
SSO: return response headers
2019-10-28 16:12:32 +01:00
Andy Scherzinger
2021da0a8b
proper contacts backup button theming
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 15:36:30 +01:00
Andy Scherzinger
48b43581cc
proper button theming for notification actions
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 15:36:06 +01:00
tobiasKaminsky
8e3931edf6
SSO: return response headers
new headers in parallel

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-28 14:48:24 +01:00
Daniel Bailey
9a9e0e6c42
Merge branch 'dark_theme' of github.com:nextcloud/android into dark_theme
Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-28 13:32:14 +00:00
Daniel Bailey
853d7cd113
Dark theme updates
TextInputLayout in share password dialog is styled to match the app.
Receive files picker shows server primary colour on Upload button.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-28 13:03:19 +00:00
Daniel Bailey
1615130093
Fix activity foreground text colour for >=API21.
Share expiration date picker now has buttons that are the primary
colour.

Theme change is now done in BaseActivity and ThemedPreferenceActivity.
This should help any activities in the back stack show the correct
theme.

Fixed style issues on firstrun and authenticator activities.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-28 12:59:32 +01:00
Andy Scherzinger
a518885612
add dark/light theming for activities headline
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:32 +01:00
Andy Scherzinger
57db615a33
icons with light background need to be keep with dark color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:29 +01:00
Andy Scherzinger
375fb97c06
use day/night color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:27 +01:00
Andy Scherzinger
9a88ee24d3
remove unused radio button preference code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:25 +01:00
Andy Scherzinger
e14dc52fa7
use correct color after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:22 +01:00
Daniel Bailey
6bb9a70603
Various improvements to dark theme
Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-28 12:59:22 +01:00
Andy Scherzinger
8f8b67f57f
don't tint avatars within the drawer menu
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:20 +01:00
Andy Scherzinger
b7e9d3f954
remove unused theme getter from interface
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:51 +01:00
Daniel Bailey
8d0ff8fecc
Corrects "Choose" button colour in FolderPickerActivity. Removes un-used import from NotificationListAdapter.
MaterialButtons.
SearchView highlight text colour.
First run activity, outlined button colour.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:50 +01:00
Daniel Bailey
c7049788f7
DatePickerDialog theme and style.
Button styling.
Small improvements to layouts and correction of spelling errors.
Sets edittext highlight colour to theme colour.

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:07 +01:00
Andy Scherzinger
30a5ec6ee1
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:07 +01:00
Andy Scherzinger
562338cad1
set background color for primary action buttons on upload and participate
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:06 +01:00
Andy Scherzinger
790e3fa2f8
findbugs: accesses list or array with constant index
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:04 +01:00
Andy Scherzinger
3d60c83ba2
use right colors for drawer menu item text and icons
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:04 +01:00
Daniel
27b8ed4327
Dark theme v1
Fixing migration to androidx
Dark theme styling
File details fragment tab text colour
File list overflow menu background colour

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:57:58 +01:00
Andy Scherzinger
2bb13a1545
move suppress annotation to newly created method
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-26 09:36:58 +02:00
Andy Scherzinger
a6fdec8656
shorten method
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-26 04:33:03 +02:00
Andy Scherzinger
1d3fca653f
codacy: Avoid declaring a variable if it is unreferenced before a possible exit point.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-26 04:22:34 +02:00
Andy Scherzinger
816991c172
codacy: avoid unused imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-26 04:20:27 +02:00
Andy Scherzinger
4f8fc49d15
Merge pull request #4730 from nextcloud/taskTwice
fix notification task, if it failed first
2019-10-25 10:18:10 +02:00
tobiasKaminsky
44fefe9064
fix notification task, if it failed first
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-25 09:16:58 +02:00
Andy Scherzinger
460b5a75cd
repect theming colors when rendering markdown
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-24 20:30:48 +02:00
Andy Scherzinger
75dd657ba8
Merge pull request #3905 from jmue/storageprovider
enhance DocumentsProvider
2019-10-24 19:18:59 +02:00
Andy Scherzinger
8a3ea78a55
Merge pull request #4701 from nextcloud/markdownPreview_SyntaxHighlighting
Markdown preview syntax highlighting
2019-10-24 16:11:04 +02:00
tobiasKaminsky
669ad540e5
minor refactoring due to codacy
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-24 13:24:14 +02:00
Andy Scherzinger
587c8f74a1
Merge pull request #4716 from nextcloud/davX5loginFlow
DavX5: support login flow
2019-10-24 10:36:15 +02:00
Andy Scherzinger
bf43a798df
add syntax highlighting to markdown rendering
* bump gradle memory due to GC mem limit during code generation (gradle.properties)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-24 09:29:41 +02:00
tobiasKaminsky
622cc45e72
use new login flow only when we have a server url
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-24 09:10:48 +02:00
tobiasKaminsky
ccd6dfaec0
NPE in setting note
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-24 08:47:11 +02:00
Jens Mueller
62f7c479fa
fix file creation time
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:37 +02:00
Jens Mueller
332e67c72d
refactor/cleanup
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:37 +02:00
Jens Mueller
8d24d80fdc
Revert "reduce contentresolver/sql queries"
This reverts commit ec5a73142dee30cd909db9e68b97ef65456f7c48.

Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:36 +02:00
Jens Mueller
5de451fa98
fix initialization of storage manager collection
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:35 +02:00
Jens Mueller
fa5e5dd8cd
notify storageprovider on account creation/removal
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:35 +02:00
Jens Mueller
cfd3aab952
reduce contentresolver/sql queries
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:34 +02:00
Jens Mueller
a2350598da
fix isChildDocument()
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:33 +02:00
tobiasKaminsky
b2eacc46b4
- fix error when temp folder does not yet exist
- do not use FileUploader for uploads

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-23 17:27:32 +02:00
Jens Mueller
a14747623d
move checks into toDocument()
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:32 +02:00
Jens Mueller
65655c5753
fix build
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:31 +02:00
Jens Mueller
3693ad88c1
remove unused imports
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:30 +02:00
Jens Mueller
fbff63bb02
fix lint warnings
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:30 +02:00
Jens Mueller
dddffce2a1
fix review comments
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:29 +02:00
Jens Mueller
e62879ac91
cleanup
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:28 +02:00
Jens Mueller
fe43e503a3
cleanup/fix review comments
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:28 +02:00
Jens Mueller
7f157a9ff1
enhance documents storage provider
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:24 +02:00
Andy Scherzinger
3dcbfa1236
Merge pull request #4712 from nextcloud/fetchRemoteFile
Fix possible IndexOutOfBoundsException if returned array is empty
2019-10-23 14:24:52 +02:00
tobiasKaminsky
2911a86263
DavX5: support login flow
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-23 13:47:33 +02:00
tobiasKaminsky
750c0a7677
Fix possible IndexOutOfBoundsException if returned array is empty
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-21 08:27:10 +02:00
Chris Narkiewicz
b7cdaf310b
Eliminate account status flags from BaseActivity
onAccountSet(stateWasRecovered) is no longer used anywhere,
so the flag mAccountWasRestored can be safely removed.

This intermediary step opens path to eliminating
out of band calls to onAccountSet().

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-20 23:27:41 +01:00
Tobias Kaminsky
954c76b11b
Merge pull request #4692 from nextcloud/markdownPreview
Markdown rendering
2019-10-18 10:21:01 +02:00
Andy Scherzinger
95e14df1d7
Add markdown rendering to TextPreview
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-17 19:57:51 +02:00
Chris Narkiewicz
5d6e316570
Remove onAccountSet from ReceiveExternalFilesActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-17 15:45:00 +01:00
Tobias Kaminsky
16cc46f4ed
Merge pull request #4687 from nextcloud/account-cleanup-upload-files-activity
Remove onAccountSet from UploadFilesActivity
2019-10-17 15:22:10 +02:00
Tobias Kaminsky
d9567a2bb6
Merge pull request #4686 from nextcloud/account-cleanup-image-video-preview
Remove onAccountSet from image and video preview activities
2019-10-17 15:21:54 +02:00
Tobias Kaminsky
2d9afe36c9
Merge pull request #4688 from nextcloud/account-cleanup-share-activity
Remove onAccountSet from ShareActivity
2019-10-17 15:21:44 +02:00
Tobias Kaminsky
f4a27cc5dc
Merge pull request #4693 from nextcloud/account-cleanup-file-display-activity
Remove onAccountSet from FileDisplayActivity
2019-10-17 14:58:13 +02:00
Tobias Kaminsky
d237a834b8
Merge pull request #4699 from nextcloud/removeUploadPathActivity
We do not use UploadPathActivity anymore(?)
2019-10-17 11:39:12 +02:00
Tobias Kaminsky
64c986eaf2
Merge pull request #4689 from nextcloud/account-cleanup-folder-picker-activity
Remove onAccountSet from FolderPickerActivity
2019-10-17 11:38:08 +02:00
tobiasKaminsky
ab904e336b
We do not use UploadPathActivity anymore(?)
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-17 08:23:15 +02:00
Chris Narkiewicz
451cec9f3a
Remove onAccountSet from ConflictsResolveActivity
Deprecated onAccountSet logic simply inlined in onStart.
No change of control flow.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 21:12:09 +01:00
Chris Narkiewicz
e5a6accf66
Remove onAccountSet from FileDisplayActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 21:07:50 +01:00
Chris Narkiewicz
b199a62b78
Remove onAccountSet from image and video preview activities
Both callbacks are directly called from onStart().
Since callback parameter is unused, inline the
callback code in onStart().

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:57:11 +01:00
Chris Narkiewicz
f428fb5810
Remove onAccountSet from UploadFilesActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:55:39 +01:00
Chris Narkiewicz
6a88a02f94
Remove onAccountSet from ShareActivity
Since onAccountSet is called directly from onStart,
we can inline the code in onStart safely.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:54:30 +01:00
Chris Narkiewicz
3519d04eea
Remove onAccountSet from FolderPickerActivity
Move onAccountSet body to onStart.
Unconditionally reset fragment state, since the
acctount restoration flag is no longer available.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:50:21 +01:00
Andy Scherzinger
e47daaffdc
Merge pull request #4684 from nextcloud/codacy2
more codacy fixes
2019-10-16 17:42:07 +02:00
Tobias Kaminsky
3ef96f8877
Merge pull request #4677 from nextcloud/deprecate-set-account-logic
Deprecate setAccount logic and remove accounWasSet flag
2019-10-16 14:57:46 +02:00
Andy Scherzinger
7f209618eb
codacy: shorten method length
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-15 16:38:01 +02:00
Andy Scherzinger
9beecfa184
codacy: Document empty constructor (rather make setting flag more explicit in this case)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-15 15:57:53 +02:00
Andy Scherzinger
670e9d3a61
codacy: Ensure you override both equals() and hashCode()
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-15 15:57:45 +02:00
Andy Scherzinger
862e5d4776
Merge pull request #4537 from nextcloud/ezaquarii/migrate-ncontentobserverjob-to-workmanager
Migrate NContentObserverJob to WorkManager
2019-10-15 15:23:15 +02:00
Andy Scherzinger
54e5ce3ae0
Merge pull request #4683 from nextcloud/fixSorting
fix sorting of synced folder: NPE if both enabled, but one has null folder name
2019-10-15 13:36:49 +02:00
tobiasKaminsky
1b0d548c69
fix sorting of synced folder: NPE if both enabled, but one has null folder name
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-15 09:56:55 +02:00
Andy Scherzinger
2ab45a72ac
codacy: Deeply nested if..then statements are hard to read
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-14 14:59:28 +02:00
Andy Scherzinger
2dabd04aa9
codacy: These nested if statements could be combined
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-14 14:59:28 +02:00
Andy Scherzinger
e0802a0da4
codacy: Avoid using Literals in Conditional Statements
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-14 14:59:27 +02:00
Andy Scherzinger
638a5b9fc0
codacy: Avoid unused imports such as 'androidx.fragment.app.Fragment'
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-14 14:59:26 +02:00
Andy Scherzinger
ab6424701b
codacy: Avoid unused method parameters such as 'appVersion'.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-14 14:59:26 +02:00
Chris Narkiewicz
c90626aaf5
Deprecate setAccount logic and remove accounWasSet flag
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-13 16:02:46 +01:00
tobiasKaminsky
8cc3ec7ad6
revert disabling of exception handler
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-10 17:15:08 +02:00
Tobias Kaminsky
f1cf050a81
Merge pull request #4626 from nextcloud/removeCustomEdit
remove CustomEditTextField
2019-10-10 17:07:26 +02:00
Andy Scherzinger
af7bf9b2f7
Merge pull request #4647 from nextcloud/fixVanishingImages
Fix vanishing images
2019-10-10 13:56:29 +02:00
tobiasKaminsky
a2f2da9c20
move logic completely into function
prevent double subfolders

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-10 12:01:35 +02:00
tobiasKaminsky
73fc5e47ed
OCFiles can be retrieved also by photo search, which then do not have a parent, nor a fileId as the are only virtual files
upon refreshing folder
- they were found in database, but only updated with fileId=-1.
- they were not found in parent folder, so we have to search them manually via file path

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-10 10:51:54 +02:00
tobiasKaminsky
cf74da7bda
- remove CustomEditTextField
- do not use fancy material header for textInput, but regular TextView
- do not show QR button on legacy login
- fix layout in tablet mode

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-10 08:25:22 +02:00
Tobias Kaminsky
07d0abe87e
Merge pull request #4644 from nextcloud/detectAuth
Allow broader check on CheckAuth
2019-10-09 21:06:00 +02:00
Tobias Kaminsky
9be019ce4c
Merge pull request #4637 from nextcloud/fixSingleAccountMode
Enhance single account mode
2019-10-09 21:03:04 +02:00
tobiasKaminsky
140eb3b664
Allow broader check on CheckAuth
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-09 19:52:36 +02:00
tobiasKaminsky
3d6d396ba9
fix disappearing account list on resume
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-09 15:15:33 +02:00
tobiasKaminsky
baefe67ea9
enhance single account mode
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-09 14:06:14 +02:00
Tobias Kaminsky
bb81d2349b
Merge pull request #4632 from nextcloud/npeInDetail
hardening on possible NPE due to null account/activity
2019-10-09 13:58:14 +02:00
Tobias Kaminsky
ad9daacb25
Merge pull request #4629 from nextcloud/ezaquarii/remove-sticky-headers-code
Remove sticky headers from activities list view
2019-10-09 13:36:21 +02:00
tobiasKaminsky
832e525f09
hardening on possible NPE due to null account/activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-09 08:15:32 +02:00
Tobias Kaminsky
f321cedb24
Merge pull request #4623 from nextcloud/fixSyncedFolderNofications
Fix recurring synced folder notifications
2019-10-09 07:38:07 +02:00
Chris Narkiewicz
73658bcfe1
Remove sticky headers from activities list view
This will prevent application from crashing on
adapter update.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-08 23:04:51 +01:00
Andy Scherzinger
1b6b909a8c
Merge pull request #4621 from nextcloud/gridCrash
prevent crash when grid column is -1
2019-10-08 09:43:15 +02:00
tobiasKaminsky
2a88933075
- fix wrong sql to detect already existing synced folder
- remember every media folder where a notification was shown

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-08 09:19:16 +02:00
tobiasKaminsky
02eaa886ae
prevent crash when grid column is -1
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-08 08:00:36 +02:00
Daniel Bailey
f5aa60bae9
Fix activity foreground text colour for >=API21.
Share expiration date picker now has buttons that are the primary
colour.

Theme change is now done in BaseActivity and ThemedPreferenceActivity.
This should help any activities in the back stack show the correct
theme.

Fixed style issues on firstrun and authenticator activities.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-07 16:43:36 +02:00
Andy Scherzinger
8aaf29a7c3
add dark/light theming for activities headline
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:35 +02:00
Andy Scherzinger
a2963d9fc3
icons with light background need to be keep with dark color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:32 +02:00
Andy Scherzinger
196e33998a
use day/night color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:27 +02:00
Andy Scherzinger
916580cb19
remove unused radio button preference code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:25 +02:00
Andy Scherzinger
dc0ca5cc84
use correct color after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:20 +02:00
Daniel Bailey
c43633ebb9
Various improvements to dark theme
Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-07 16:43:19 +02:00
Andy Scherzinger
eff6a5bed9
don't tint avatars within the drawer menu
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:16 +02:00
Andy Scherzinger
f53f246f6e
rebase fixing plus proper theming of legacy login fields
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:15 +02:00
Andy Scherzinger
55d5f2f41a
remove unused theme getter from interface
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:11 +02:00
Daniel Bailey
66144bb8b6
Corrects "Choose" button colour in FolderPickerActivity. Removes un-used import from NotificationListAdapter.
MaterialButtons.
SearchView highlight text colour.
First run activity, outlined button colour.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:09 +02:00
Daniel Bailey
9f7fa6b6b6
DatePickerDialog theme and style.
Button styling.
Small improvements to layouts and correction of spelling errors.
Sets edittext highlight colour to theme colour.

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:07 +02:00
Andy Scherzinger
b0734f5768
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:06 +02:00
Andy Scherzinger
34cef89ce8
set background color for primary action buttons on upload and participate
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:04 +02:00
Andy Scherzinger
1930e5dc74
findbugs: accesses list or array with constant index
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:02 +02:00
Andy Scherzinger
cab2b12594
use right colors for drawer menu item text and icons
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:43:01 +02:00
Daniel
44099c0792
Dark theme v1
Fixing migration to androidx
Dark theme styling
File details fragment tab text colour
File list overflow menu background colour

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-07 16:42:49 +02:00
Chris Narkiewicz
88113c02df
Fix NPE in Favorites when file has no local storage path
Fixes #4578

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-02 22:04:04 +01:00
Chris Narkiewicz
808c9098ea
Migrate NContentObserverJob to WorkManager
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-02 21:38:44 +01:00
Tobias Kaminsky
4f15e87412
Merge pull request #4592 from nextcloud/parentCheck
if parent is null, then do a regular check, no early exit
2019-10-02 09:03:07 +02:00
Tobias Kaminsky
b204db0f1a
Merge pull request #4577 from nextcloud/ezaquarii/fix-npe-in-preview-media-fragment
Fix NPE in PreviewMediaFragment
2019-10-02 09:02:35 +02:00
Tobias Kaminsky
9876c49001
Merge pull request #4415 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.0.1
Bump detekt-gradle-plugin from 1.0.0-RC14 to 1.0.1
2019-10-02 08:26:25 +02:00
tobiasKaminsky
f6e24eb067
if parent is null, then do a regular check, no early exit
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-02 08:02:44 +02:00
tobiasKaminsky
37c6600d2e
Upload files into subfolder
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-01 11:37:16 +02:00
Tobias Kaminsky
a1c28f93d6
Merge pull request #4470 from stephanritscher/master
Normalize local target path in auto upload
2019-10-01 11:15:30 +02:00
tobiasKaminsky
9c1fedb14b
add test cases
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-01 10:46:22 +02:00
tobiasKaminsky
6184fcd5ae
add test cases
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-01 10:45:09 +02:00
dependabot-preview[bot]
6b4e90022f
Bump detekt-gradle-plugin from 1.0.0-RC14 to 1.0.1
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-01 10:18:43 +02:00
Chris Narkiewicz
488193a94e
Fix NPE in PreviewMediaFragment
Fragment can be detached before async task finishes.
Detached fragment has no context and getString() fails with NPE.

Fixes #4412

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-09-28 23:41:27 +01:00
Chris Narkiewicz
2dab887782 New media player service
Fixes #3061
Fixes #4412

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-09-27 20:13:51 +01:00
Tobias Kaminsky
5bcab439b4
Merge pull request #4538 from nextcloud/ezaquarii/fix-broken-account-registration
Fix registration of second account on first run
2019-09-27 09:47:55 +02:00
Tobias Kaminsky
8954aafb5f
Merge pull request #4545 from nextcloud/ezaquarii/speculative-fix-for-npe-in-log-d
Fix for NPE caused by Log.d in ThumbnailsCacheManager
2019-09-27 09:23:28 +02:00
Chris Narkiewicz
ed704c632e
Fix for NPE caused by Log.d in ThumbnailsCacheManager
Log.d does not like null.

Fixes #4542

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-09-26 16:19:36 +01:00
Chris Narkiewicz
551c4d3f1a
Fix NPE crash in OCFileListFragment when action mode is destroyed
Fixes #4438

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-09-26 16:17:49 +01:00
Chris Narkiewicz
953ee005e5
Fix registration of second account on first run
Fixes #4234
Fixes #4529
Fixes #4462

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-09-26 16:17:15 +01:00
Andy Scherzinger
7c1aae4c25
Merge pull request #4473 from nextcloud/dependabot/gradle/androidx.appcompat-appcompat-1.1.0
Bump appcompat from 1.0.2 to 1.1.0
2019-09-23 23:24:01 +02:00
tobiasKaminsky
1d0dd21169
use Nextcloud UA
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-09-19 21:50:23 +02:00
Andy Scherzinger
fc86b57065
lint: Overriding method should call super
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-09-16 20:15:05 +02:00
tobiasKaminsky
e2bc773c01
parameters not nullable anylonger
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-09-16 20:04:41 +02:00
Andy Scherzinger
be714d2b13
remove unused variable
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-09-09 22:10:10 +02:00
tobiasKaminsky
b32f63ab68
(temporary) fix for navigation issue
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-09-09 22:04:26 +02:00
tobiasKaminsky
5a53ca3c7c
check for nullable context
stop task on pause

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-09-09 13:25:14 +02:00
Stephan Ritscher
5c387fac7a Normalize local target path in auto upload
This closes #2131 and closes #4220.
2019-09-05 23:19:45 +02:00
tobiasKaminsky
9d3e28d019
do not use literals in conditional statements
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-09-05 19:56:09 +02:00
tobiasKaminsky
7fae76294a
rename participate -> community
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-09-04 09:24:25 +02:00
Tobias Kaminsky
e8d585eddd
Remote wipe (#4455)
Remote wipe
2019-09-04 08:07:15 +02:00
Tobias Kaminsky
4c0e1c0761
Update MimeTypes (#4434)
Update MimeTypes
2019-09-04 07:57:34 +02:00
tobiasKaminsky
0b26aa7755
Remote wipe
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-09-04 07:30:44 +02:00
rajput2122
014e45c690
Feedback link is removed from setting ang participate is changed to community
Signed-off-by: rajput2122 <kumar.atul.2122@gmail.com>
2019-09-03 17:34:20 +02:00
Andy Scherzinger
fba301b248
improve mime type detection
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-09-02 23:57:55 +02:00
Andy Scherzinger
2f30227cfa
Resolve #2081 adding a corresponding file-extension/mimetype mapping for .m files
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-09-02 23:05:23 +02:00
Andy Scherzinger
bff6395e42
Resolve #2073 adding a corresponding file-extension/mimetype mapping for .love files
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-09-02 23:05:22 +02:00
Andy Scherzinger
0cb8d46337
update to Nc17 defined mimetype list
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-09-02 23:05:13 +02:00
Andy Scherzinger
c6f6ce80dc
Merge pull request #4447 from nextcloud/npeImage
Prevent npe
2019-09-02 21:36:42 +02:00
Andy Scherzinger
639c770e51
Merge pull request #4449 from nextcloud/baseUrlNull
baseURL might be null
2019-09-02 20:08:13 +02:00
Andy Scherzinger
f671a1eafb
codacy: Useless parentheses.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-09-02 16:08:50 +02:00
tobiasKaminsky
23f40b710c
baseURL might be null
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-09-02 15:25:30 +02:00
tobiasKaminsky
83f7be14c5
prevent npe
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-09-02 14:30:41 +02:00
tobiasKaminsky
4e2f9af198
fix endless scroll on file detail activity stream
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-09-02 11:46:16 +02:00
Andy Scherzinger
8a58553019
Merge pull request #4421 from nextcloud/codacy
Codacy
2019-08-27 21:33:11 +02:00
tobiasKaminsky
5c06b83a70
activity: use lastGiven header
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-08-27 19:40:56 +02:00
Andy Scherzinger
cf02e861b8
codacy: Classes implementing Serializable should set a serialVersionUID
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-08-27 12:45:14 +02:00
Andy Scherzinger
56e74d2e8a
codacy: Avoid really long methods.
refactor updatePublicShareSection method

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-08-27 12:38:17 +02:00
Andy Scherzinger
dfc1a5e89f
codacy: Avoid instantiating new objects inside loops
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-08-27 12:20:34 +02:00
Andy Scherzinger
fc156a72bc
codacy: A class which only has private constructors should be final
codacy: Avoid throwing raw exception types.

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-08-27 10:57:33 +02:00
tobiasKaminsky
d423dd3b00
Add printing system to RichDocuments
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-08-27 08:26:53 +02:00
tobiasKaminsky
70ea959983
storage manager can be null
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-08-26 08:09:04 +02:00
tobiasKaminsky
35a625234b
parent file can be null
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-08-23 11:18:16 +02:00
Andy Scherzinger
783e28365d
codacy: Avoid using Literals in Conditional Statements
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-08-23 09:16:44 +02:00
Andy Scherzinger
c0b76e33ec
codacy: Avoid declaring a variable if it is unreferenced before a possible exit point.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-08-23 09:12:33 +02:00
Andy Scherzinger
c51db8b1cd
codacy: Avoid unused imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-08-23 08:45:52 +02:00
Andy Scherzinger
5a1b5ed5cf
codacy: Avoid really long methods.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-08-23 08:23:36 +02:00
Andy Scherzinger
d2c9e3273f
codacy: These nested if statements could be combined
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-08-23 08:23:35 +02:00
Andy Scherzinger
d445be1b5f
codacy: Avoid using implementation types like 'ArrayList'; use the interface instead
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-08-23 08:23:27 +02:00
Tobias Kaminsky
331edcb69c
fix possible NPE on stopping contact backup job (#4387)
fix possible NPE on stopping contact backup job
2019-08-23 07:45:56 +02:00
Tobias Kaminsky
88714c1c9f
moved multiple account dialog to recyclerview (#4381)
moved multiple account dialog to recyclerview
2019-08-23 07:45:38 +02:00
tobiasKaminsky
6ec0186bbf
moved multiple account dialog to recyclerview
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-08-23 07:34:00 +02:00
tobiasKaminsky
f5ca834e07
fix possible NPE on stopping contact backup job
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-08-23 07:27:41 +02:00
Andy Scherzinger
1660024105
Merge pull request #4360 from nextcloud/as350
Update due to Android Studio 3.5.0
2019-08-22 19:05:22 +02:00
Tobias Kaminsky
0fae1b7ba3
throttle avatar lookup (#4372)
throttle avatar lookup
2019-08-22 15:13:06 +02:00
tobiasKaminsky
fa0bd04139
throttle avatar lookup
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-08-22 14:42:07 +02:00
Tobias Kaminsky
6dfee6bd59
Npe in get sharees (#4370)
Npe in get sharees
2019-08-22 14:35:16 +02:00
Tobias Kaminsky
656628ce3c
fix shared view (#4373)
fix shared view
2019-08-22 14:35:03 +02:00
tobiasKaminsky
afae2a448f
Do not use NContentObserverJob in DI for now
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-08-22 11:03:55 +02:00
tobiasKaminsky
44698f6c90
Fix npe in sharees lookup
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-08-22 10:35:37 +02:00
tobiasKaminsky
179b14cb6b
fix shared view
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-08-22 09:33:36 +02:00
tobiasKaminsky
4411f22cd5
update due to Android Studio 3.5.0
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-08-22 08:10:56 +02:00
Tobias Kaminsky
7a29f488e3
Sharees will be in NC17 (#4284)
Sharees will be in NC17
2019-08-21 13:21:12 +02:00
tobiasKaminsky
39cb5d9179
sharees will be in NC17
later initialization of storageManager
add support for groups
catch potential wrong saved sharee date

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-08-21 13:05:52 +02:00
Tobias Kaminsky
66a889825e
Connectivity check: no need to use owncloudClient (#4344)
Connectivity check: no need to use owncloudClient
2019-08-21 07:57:00 +02:00