Commit graph

12711 commits

Author SHA1 Message Date
tobiasKaminsky
1646e46bde
remove test prefix name
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-08 11:55:46 +02:00
Tobias Kaminsky
f1ec1289fd
Merge pull request #3853 from nextcloud/fixDrone
fix drone.yml for drone 1.0
2019-04-08 07:24:07 +01:00
tobiasKaminsky
dc069ed79e
fix drone.yml for drone 1.0
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-08 08:01:10 +02:00
Tobias Kaminsky
958832d1c9 daily dev 20190408 2019-04-08 03:34:25 +02:00
Nextcloud bot
1f22645137
[tx-robot] updated from transifex 2019-04-08 00:52:12 +00:00
Andy Scherzinger
c4a4179467
Merge pull request #3849 from nextcloud/dependabot/gradle/org.mockito-mockito-core-2.26.0
Bump mockito-core from 2.25.1 to 2.26.0
2019-04-07 12:04:26 +02:00
Tobias Kaminsky
7d2aad6cfe daily dev 20190406 2019-04-06 03:34:12 +02:00
Andy Scherzinger
43c1d5e53c
Merge pull request #3850 from nextcloud/remove-unused-imports
removed unused imports.
2019-04-05 12:18:37 +02:00
tobiasKaminsky
f932ab3f5b
added nullable
add null checks

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
wip

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-05 09:51:25 +01:00
ardevd
c40788b11d
removed unused imports.
Leaving unused imports in reduces the code's readability, since their presence can be confusing.
2019-04-05 10:33:20 +02:00
ardevd
7d97b267af
updated assertion failure text. return empty string if arguments are null 2019-04-05 10:24:32 +02:00
dependabot[bot]
5ed4b269fa
Bump mockito-core from 2.25.1 to 2.26.0
Bumps [mockito-core](https://github.com/mockito/mockito) from 2.25.1 to 2.26.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v2.25.1...v2.26.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-05 01:12:17 +00:00
Nextcloud bot
4bcaf8414e
[tx-robot] updated from transifex 2019-04-05 00:51:44 +00:00
tobiasKaminsky
ed7cf414da
revert to old auth login method: do not use weblogin suffix
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-04 21:30:21 +01:00
Tobias Kaminsky
2b95ff3dc1 daily dev 20190404 2019-04-04 03:33:38 +02:00
Nextcloud bot
347f30674f
[tx-robot] updated from transifex 2019-04-04 00:51:24 +00:00
ardevd
44e1cd846c
utils: replaced string concatenation with String.format.
Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-04-03 09:56:05 +02:00
ardevd
fa047b751b
tests: added unit tests for the StringUtils class.
Provides full test coverage of said class.

Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-04-03 09:56:04 +02:00
ardevd
1c92e8c88b
utils: Removed dependency on android.text.TextUtils.
Depending upon android.text.TextUtils for simply checking if a string is empty seems unnecessary and makes unit testing harder.

Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-04-03 09:56:03 +02:00
Andy Scherzinger
479a0558aa
Merge pull request #3838 from nextcloud/daggerUpdate
bump dagger to 2.22.1
2019-04-03 09:00:17 +02:00
Andy Scherzinger
8cb9a76b93
bump dagger to 2.22.1
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-03 08:47:49 +02:00
Tobias Kaminsky
06e710d67c daily dev 20190403 2019-04-03 03:34:35 +02:00
Nextcloud bot
e88df10983
[tx-robot] updated from transifex 2019-04-03 00:53:20 +00:00
Andy Scherzinger
b9c9954ad0
Merge pull request #3829 from nextcloud/370-alpha1
bump master to 3.7.0-alpha1
2019-04-02 13:04:16 +02:00
Andy Scherzinger
15a944933b
bump master to 3.7.0-alpha1
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-02 12:45:15 +02:00
Andy Scherzinger
cbb4234771
Merge pull request #3791 from nextcloud/ezaquarii/inject-app-preferences-into-activities
Inject AppPreferences into activities and fragments
2019-04-02 12:33:08 +02:00
Nextcloud bot
ed84655a05
[tx-robot] updated from transifex 2019-04-02 09:11:34 +00:00
Andy Scherzinger
2dfbe3dfe1
Merge pull request #3826 from nextcloud/dependabot/gradle/com.mebigfatguy.fb-contrib-fb-contrib-7.4.3
Bump fb-contrib from 7.4.3.sb to 7.4.3
2019-04-02 08:23:10 +02:00
Tobias Kaminsky
677bd759df daily dev 20190402 2019-04-02 03:34:18 +02:00
dependabot[bot]
9e63184aca
Bump fb-contrib from 7.4.3.sb to 7.4.3
Bumps [fb-contrib](https://github.com/mebigfatguy/fb-contrib) from 7.4.3.sb to 7.4.3.
- [Release notes](https://github.com/mebigfatguy/fb-contrib/releases)
- [Commits](https://github.com/mebigfatguy/fb-contrib/compare/v7.4.3.sb...v7.4.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-02 01:11:33 +00:00
nextcloud-android-bot
d9c33be55a Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2019-04-01 15:03:59 +00:00
ezaquarii
518f5c8d52
Merge 8761e50b0f into 0ba9cc6f6b 2019-04-01 14:52:05 +00:00
Chris Narkiewicz
8761e50b0f
Inject AppPreferences into activities and fragments
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-04-01 15:51:47 +01:00
Andy Scherzinger
0ba9cc6f6b
Merge pull request #3824 from nextcloud/spotbugs
Use spotbugs for analytics
2019-04-01 13:55:41 +02:00
tobiasKaminsky
20802780c7
use spotbugs for analytics
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-01 10:30:49 +02:00
Andy Scherzinger
78323554e6
Merge pull request #3821 from nextcloud/npeCheckOnNote
NPE check on note
2019-04-01 09:47:22 +02:00
Tobias Kaminsky
7cba1afd12
Merge pull request #3813 from nextcloud/ezaquarii/integrate-spotbugs
Add SpotBugs tasks
2019-04-01 09:45:58 +02:00
Andy Scherzinger
b4e1e57859
Merge pull request #3820 from nextcloud/fixNotificationResultCheck
Check result also for 202 (accepted)
2019-04-01 09:43:59 +02:00
Tobias Kaminsky
caf89285eb
Merge pull request #3818 from nextcloud/filedatastoragemanager-string-comparison
datamodel: use equals for string comparison.
2019-04-01 09:14:22 +02:00
tobiasKaminsky
b0f9c5ea68
NPE check on note, it should never be null due to our fetch, which fails back to "" (empty string), but there are few crash reports on google…
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-01 08:31:26 +02:00
tobiasKaminsky
b2a2fa494c
check result also for 202 (accepted)
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-01 08:21:24 +02:00
Nextcloud bot
52ab9b95b3
[tx-robot] updated from transifex 2019-04-01 00:53:38 +00:00
ardevd
3968be4a58
fixed inverted comparison
Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-03-31 22:24:33 +02:00
nextcloud-android-bot
f26eecacec Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2019-03-31 20:01:06 +00:00
ardevd
81987b9b25
Merge e797e5ced8 into 7f523dfbcd 2019-03-31 19:56:19 +00:00
ardevd
e797e5ced8
datamodel: use equals for string comparison.
It is almost always a mistake to compare two instances of java.lang.String using reference equality == or !=, because it is not comparing actual value but locations in memory.

Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-03-31 21:55:47 +02:00
Nextcloud bot
7f523dfbcd
[tx-robot] updated from transifex 2019-03-31 01:52:59 +00:00
Chris Narkiewicz
d4788b0ad0
Add SpotBugs tasks
Closes #3759

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-03-30 22:55:57 +00:00
Nextcloud bot
83cdb1f28b
[tx-robot] updated from transifex 2019-03-30 01:52:07 +00:00
Tobias Kaminsky
7608587e87 daily dev 20190329 2019-03-29 03:34:19 +01:00