Commit graph

3818 commits

Author SHA1 Message Date
Andy Scherzinger
7005cdef2e
Introduce light/dark theme / black/white primary-color-aware primary-button theming
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:22 +02:00
Andy Scherzinger
643454c1d7
proper coloring of drawer items in black/white edge case scenarios
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:21 +02:00
Andy Scherzinger
20d2ef989d
proper button coloring for dark theme + black primary color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-26 15:15:14 +02:00
Andy Scherzinger
dfc94f4505
Merge pull request #6354 from nextcloud/noShare
Enhance FileDetailSharingFragment
2020-06-26 13:27:16 +02:00
tobiasKaminsky
348ae4435a
Enhance FileDetailSharingFragment:
- remove no users text
- disable search view if reshare is not allowed
- show note icon

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-26 11:03:03 +02:00
tobiasKaminsky
741cc24d11
fix #5468
if we have no activity, do nothing

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 23:36:05 +02:00
tobiasKaminsky
7ed4e2b24e
changes due to CR
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 22:57:48 +02:00
tobiasKaminsky
58ba15ac95
Removed legacy login
cleaned up a bit AuthenticatorActivity

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 22:57:22 +02:00
Andy Scherzinger
fe1cd33c26
Merge pull request #6344 from nextcloud/ocp
fix OCP_OVERLY_CONCRETE_PARAMETER
2020-06-25 20:30:34 +02:00
Andy Scherzinger
2f60b75fc5
add null check 2020-06-25 18:55:50 +02:00
tobiasKaminsky
1017e3ac3b
fix OCP_OVERLY_CONCRETE_PARAMETER
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 18:45:28 +02:00
Tobias Kaminsky
d70502f747
Merge pull request #6262 from nextcloud/hideOnScrolling
Hide on scrolling
2020-06-25 16:18:40 +02:00
tobiasKaminsky
38c28332e2
fix tests
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 15:57:46 +02:00
tobiasKaminsky
bd5c9dfa1e
make function puplic for testing
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 15:22:58 +02:00
tobiasKaminsky
22657040bd
Removed possible NPE
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:59:54 +02:00
tobiasKaminsky
a9dc3f5787
removed duplicated sort/switch grid buttons
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:59:54 +02:00
tobiasKaminsky
e5ec91b5a7
Changes due to CR
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:59:54 +02:00
tobiasKaminsky
1ecd64f128
Hide on scrolling, fix https://github.com/nextcloud/android/issues/6238
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:59:54 +02:00
tobiasKaminsky
6dfb4c7ef6
use view instead of linear layout as common parent
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-25 12:48:40 +02:00
Andy Scherzinger
83d4aaf1ab
Merge pull request #6345 from nextcloud/usbr
fix USBR_UNNECESSARY_STORE_BEFORE_RETURN
2020-06-24 23:18:08 +02:00
tobiasKaminsky
1f5352f2ec
Remove useless parents
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-24 22:05:37 +02:00
tobiasKaminsky
72fce1dd1e
fix USBR_UNNECESSARY_STORE_BEFORE_RETURN
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-24 21:54:56 +02:00
Andy Scherzinger
9e633b91b5
Merge pull request #6342 from nextcloud/view-binding
View binding
2020-06-24 20:28:20 +02:00
Andy Scherzinger
f0a608acde
remove unused constants
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2020-06-24 17:00:38 +02:00
tobiasKaminsky
4a791dda86
fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-24 16:45:15 +02:00
Andy Scherzinger
3e05624064
Merge pull request #6351 from nextcloud/castException
rich workspace not in folder picker activity
2020-06-24 12:52:36 +02:00
Tobias Kaminsky
ed8819ec86
Merge pull request #6327 from nextcloud/combineShare
Combined ShareActivity with FileDetailSharingFragment as much as possible
2020-06-24 10:43:24 +02:00
tobiasKaminsky
a424706368
rich workspace not in folder picker activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-24 07:56:58 +02:00
Stefan Niedermann
0aed8aaa86 #6247 View Binding - Fix new SpotBugs performance warning (unread field)
Signed-off-by: Stefan Niedermann <info@niedermann.it>
2020-06-23 18:21:22 +02:00
tobiasKaminsky
4e52f7f970
fix LSC_LITERAL_STRING_COMPARISON
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-23 14:59:02 +02:00
Stefan Niedermann
a43933082d #6247 View Binding - Remove unused imports
Signed-off-by: Stefan Niedermann <info@niedermann.it>
2020-06-23 14:10:18 +02:00
Stefan Niedermann
374bb21c33 #6247 View Binding - SendButtonAdapter.ViewHolder
Signed-off-by: Stefan Niedermann <info@niedermann.it>
2020-06-23 14:01:45 +02:00
Stefan Niedermann
558f1775de #6247 View Binding - AccountItemBinding & AccountActionBinding
Signed-off-by: Stefan Niedermann <info@niedermann.it>
2020-06-23 11:15:03 +02:00
Stefan Niedermann
934e1f406a #6247 View Binding - ConflictResolveDialogBinding
Signed-off-by: Stefan Niedermann <info@niedermann.it>
2020-06-23 10:51:40 +02:00
tobiasKaminsky
7732ff065b
Combined ShareActivity with FileDetailSharingFragment as much as possible
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-23 10:47:43 +02:00
tobiasKaminsky
e503106960
Fixed NPE when hiding ssl cert
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-23 09:23:59 +02:00
Stefan Niedermann
96aecac8ed
#6247 View Binding - Fix codacy issue
Signed-off-by: Stefan Niedermann <info@niedermann.it>
2020-06-23 09:23:59 +02:00
Stefan Niedermann
ab3dff9e1b
#6247 View Binding - FileDisplayActivity and partial Ssl views 2020-06-23 09:23:59 +02:00
Stephan Ritscher
9370cbab09 Fix improper deleting synced folder by OfflineSyncWork 2020-06-22 21:09:41 +02:00
tobiasKaminsky
e40893a136
Use always recommended spotbug version, defined by plugin
exclude data binding generated classes

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-19 11:03:24 +02:00
tobiasKaminsky
5f185326ab
Fixed Lint:
MissingClass: Missing registered class
Range: Outside Range
UseAppTint: app:tint attribute should be used on ImageView
UseCompatLoadingForDrawables
UseCompatTextViewDrawableXml

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2020-06-19 11:03:22 +02:00
Andy Scherzinger
c048fe2121
Merge pull request #6256 from nextcloud/clickConflictNotification
fix #5281: click on conflict notification opens conflict dialog directly
2020-06-18 09:26:58 +02:00
Tobias Kaminsky
ace90ef2ad
Merge pull request #6306 from nextcloud/fixBatteryDialog
check if activity is running before showing dialog
2020-06-18 07:06:47 +02:00
Tobias Kaminsky
1b1a58ed8c
Merge pull request #6289 from nextcloud/ezaquarii/migrate-contacts-preference-activity-startup-to-type-safe-api
Migrate ContactsPreferenceActivity startup to type-safe API
2020-06-18 07:03:58 +02:00
Tobias Kaminsky
cc06c8b613
Merge pull request #6283 from nextcloud/fixPhotoviewTitle
Show "photos" in title
2020-06-18 06:54:58 +02:00
Andy Scherzinger
28279bc3c1
Merge pull request #6284 from nextcloud/fixPhotoViewAppbar
Fix appbar photos view when enter in background
2020-06-17 16:55:18 +02:00
Andy Scherzinger
663537f304
Merge pull request #6209 from nextcloud/dependabot/gradle/com.pinterest-ktlint-0.37.0
Bump ktlint from 0.36.0 to 0.37.0
2020-06-17 16:54:38 +02:00
Andy Scherzinger
39bb258648
Merge pull request #6231 from nextcloud/theme-refresh
Theme refresh bugfix
2020-06-17 16:53:51 +02:00
Andy Scherzinger
73c22d4e8f
Merge pull request #6307 from thgoebel/addaccount-materialbutton
Use MaterialButton for addAccount action in accounts screen
2020-06-17 16:37:28 +02:00
Daniel Bailey
6f31f92a3f
Theme refresh bugfix
Removed call to setLocalNightMode from DrawerActivity to allow the theme
setting to be done by SettingsActivity and the following activity
recreation to be handled by BaseActivity.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2020-06-17 14:33:19 +02:00