Commit graph

11329 commits

Author SHA1 Message Date
Álvaro Brey
69033e25e9
Merge pull request #9823 from nextcloud/chore/mockitokotlin2
Chore: replace `com.nhaarman.mockitokotlin2` with `org.mockito.kotlin`
2022-02-14 11:09:47 +01:00
Tobias Kaminsky
b81027d057
Merge pull request #9791 from nextcloud/fix/shares-downloading-crash
FileActivity: fix crash on share operations when FileDetailFragment is second fragment
2022-02-14 09:06:22 +01:00
Tobias Kaminsky
c41f87d281
Merge pull request #9822 from nextcloud/chore/conflicts-dialog-logs
ConflictsResolveActivity: Add log messages when dialog can't be created
2022-02-14 09:00:28 +01:00
Tobias Kaminsky
1d4bc98de7
Merge pull request #9812 from nextcloud/avatarSize
Use 512px for avatar
2022-02-14 08:47:33 +01:00
Tobias Kaminsky
8b0674e29f
Merge pull request #9808 from nextcloud/resumeText
resuming TextEditor after splitting screens works now again
2022-02-14 08:40:09 +01:00
Tobias Kaminsky
541e55ff1c
Merge pull request #9821 from nextcloud/fix/db-upgrade-crash
FileContentProvider: fix crash on certain upgrades
2022-02-14 08:30:47 +01:00
Nextcloud bot
6b8ce02a2e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-14 03:55:09 +00:00
Nextcloud bot
bbf1032845
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-12 03:55:56 +00:00
Álvaro Brey Vilas
2a6398adda
Chore: replace com.nhaarman.mockitokotlin2 with org.mockito.kotlin
It has been integrated into the main mockito org, and the old ID no longer receives updates

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 18:32:15 +01:00
tobiasKaminsky
e20555f5d0 resuming TextEditor after splitting screens works now again
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-11 16:59:13 +00:00
Álvaro Brey Vilas
c506cda8a6 FileDisplayActivity: ditch secondFragment for FileDetailsFragment, use leftFragment instead
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 16:49:57 +00:00
Álvaro Brey Vilas
d82a989378 FileActivity: fix crash on share operations when FileDetailFragment is second fragment
When a file is downloaded, FileDetailFragment is opened as SECOND_FRAGMENT instead of LIST_OF_FILES, which breaks this logic.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 16:49:57 +00:00
Álvaro Brey Vilas
9cf0f1d6fa
ConflictsResolveActivity: Add log messages when dialog can't be created
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 17:33:58 +01:00
Álvaro Brey Vilas
b5d338fb8d
FileContentProvider: fix crash on certain upgrades
checkIfColumnExists should not use getColumnIndexOrThrow, as it's supposed to check if the index doesn't exist

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 13:57:03 +01:00
tobiasKaminsky
7ddbb65ca2 Use 512px for avatar
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-11 11:09:23 +00:00
tobiasKaminsky
1c9a3e0208 For display with >= 600dp use higher file icon resolution
use this resolution also default thumbnails

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-11 11:09:20 +00:00
Álvaro Brey
4d9c878d4f
Merge pull request #9801 from nextcloud/chore/test-sort-order
Update sorting tests
2022-02-07 09:21:24 +01:00
Nextcloud bot
73c01d1ef4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-07 03:54:38 +00:00
Nextcloud bot
559c41d880
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-05 03:54:13 +00:00
Álvaro Brey Vilas
08e7a761dc
NaturalSortTest: shuffle instead of duplicating parameters
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:55:07 +01:00
Álvaro Brey Vilas
64d386786c
Rename TestSorting to OCFileSortTest, conver to Kotlin, parameterize
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:55:07 +01:00
Álvaro Brey Vilas
bed01a2f0c
TestSorting: refactor and simplify since it's now only for OCFiles
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:12:52 +01:00
Álvaro Brey Vilas
e7e603f4d8
Move string sort tests from TestSorting to NaturalSortTest
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:02:42 +01:00
Álvaro Brey Vilas
d40fc88754
Move TestSorting to unit tests
No reason for it to be an instrumented test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 12:54:45 +01:00
Álvaro Brey Vilas
91297b7ce0
Test AlphanumComparator
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 10:49:08 +01:00
Nextcloud bot
927babb3bf
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-04 03:55:25 +00:00
Nextcloud bot
c437db409e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-03 03:55:06 +00:00
Nextcloud bot
dba8da00f0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-02 03:55:45 +00:00
Nextcloud bot
190332ceaa
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-01 03:55:35 +00:00
Álvaro Brey
1ecbf61cc7
Merge pull request #9776 from nextcloud/fix/activity-title
OCFileListFragment: set title when attached to activity
2022-01-31 15:42:16 +01:00
Álvaro Brey
0c5afce10e
Merge pull request #9770 from nextcloud/Valdnet-patch-1
i18n: Change to a capital letter
2022-01-31 13:43:46 +01:00
Álvaro Brey Vilas
d1d3a49a6b
OCFileListFragment: set title when attached to activity
This prevents wrong title while search isn't started yet (such as when returning to a search fragment from a preview fragment)

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-28 16:32:46 +01:00
Nextcloud bot
204cd5a2c5
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-28 03:54:54 +00:00
Valdnet
f28bc6f9f9
i18n: Change to a capital letter
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-01-27 17:12:02 +01:00
Álvaro Brey
88605985a0
Merge pull request #9743 from nextcloud/fix/media-dark-duplicated
Fix crashes and double loading in GalleryFragment when changing dark theme
2022-01-27 12:35:35 +01:00
Álvaro Brey
3e97e1e212
Merge pull request #9761 from nextcloud/fix/local-files-freeze
Improve freezes in local files screens when folder contains many files
2022-01-27 12:34:35 +01:00
Álvaro Brey Vilas
f3de5f9862
LocalFileListAdapter: fix case where directory==null
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:49:07 +01:00
Álvaro Brey Vilas
96c55a6d9f
FileSortOrder*: convert to Kotlin
Need more kotlin in the codebase and these were simple enough

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:49:07 +01:00
Álvaro Brey Vilas
7baa0f8da4
LocalFileListAdapter: Also change sort order asynchronously
Changing sort  order is also slow.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
2baf63d809
AlphaNumComparator: optimize usage and resolve signature problems
- Methods had ambiguous signatures (parameterized compare<T> overlapped the various typed compare()). This made the compiler very confused.
 - In several places throughout the app, AlphaNumComparator was getting repeatedly instantiated just to manually call a typed compare(). This was very wasteful

To solve both problems, the typed compare() methods have been been made static.

The performance gains of not instantiating the comparator repeatedly are very noticeable. In a test loading a local folder for upload with 1000 files in it,
time of load is reduced from 28 seconds to 17 seconds.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
462da35fdb
LocalFileList: load local files asynchronously
Loading a large list of files (especially the sorting part) is S L O W.
This ensures it doesn't block the UI while loading.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
c5ebc05964
PassCodeActivity: enable cancel button when re-created in confirmation step
Prevents a bug where the cancel button would stop working if the device was rotated

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:20:00 +01:00
Álvaro Brey
618a770349
Merge pull request #9751 from nextcloud/fix/clear-data
Fix some crashes and weird behaviours when clearing data
2022-01-27 09:18:21 +01:00
Álvaro Brey Vilas
c01fa0b170
Make more PendingIntents immutable
This should be all of them. Picked up by lint.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:56:05 +01:00
Álvaro Brey Vilas
27559efb79
Make PendingIntents immutable
Good practice for security

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:56:05 +01:00
Álvaro Brey Vilas
45fc831989
gplay/AndroidManifest: set exported value for service
picked up by lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
9d5395c8fd
ezvcard/ContactOperations: suppress locale lint in third_party class
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
a9ec1de015
manifest: Remove unneeded labels
Trips up lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
00586a5bde
BackgroundJobFactory: fix lint due to unchecked build version for ContentObserverJob
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
b6115a5fc1
lint: Fix getLayoutInflater calls
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00