Commit graph

10751 commits

Author SHA1 Message Date
Mario Đanić
648b02ee8a
Merge pull request #2649 from nextcloud/finishPreferences
Explicitly finish preferences
2018-06-05 07:53:40 +02:00
Mario Đanić
f123c269f0
Merge pull request #2651 from nextcloud/resultOnStoppedAsync
Do not process result of async task if activity is stopped
2018-06-05 07:53:09 +02:00
Mario Đanić
2d4cb825f9
Merge pull request #2661 from nextcloud/rewordEmptyActivity
Reword empty activity message
2018-06-05 07:52:31 +02:00
Mario Đanić
e49b1706ff
Merge pull request #2683 from nextcloud/override-annotations
util: Added @Override annotation where applicable.
2018-06-05 07:49:46 +02:00
Tobias Kaminsky
b86d1adfb4 daily dev 20180605 2018-06-05 00:32:02 +02:00
eho
62fe30134c util: Added @Override annotation where applicable.
Using the @Override annotation is useful for two reasons :

It elicits a warning from the compiler if the annotated method doesn't actually override anything, as in the case of a misspelling.
It improves the readability of the source code by making it obvious that methods are overridden.
2018-06-04 16:10:08 +02:00
eho
b1e032cd6c ui:fragment: Use isEmpty() to check if list of activities is empty.
Using Collection.size() to test for emptiness works, but using Collection.isEmpty() makes the code more readable and can be more performant
2018-06-04 16:07:29 +02:00
AndyScherzinger
4c6ffea5e4
massively shorten code and improve readability via a menu helper 2018-06-04 15:21:59 +02:00
Andy Scherzinger
9385f5d2f2
Merge pull request #2666 from nextcloud/ignoreLint-setJavaScriptEnabled
lint: ignore setJavaScriptEnabled
2018-06-04 14:25:19 +02:00
nextcloud-android-bot
6720bed292 Drone: update Lint results to reflect reduced error/warning count [skip ci] 2018-06-04 11:22:50 +00:00
Andy Scherzinger
6923d41db3
Merge eb7e5f735d into 682c177866 2018-06-04 11:20:57 +00:00
AndyScherzinger
eb7e5f735d
lint: ignore setJavaScriptEnabled 2018-06-04 13:20:33 +02:00
Mario Đanić
682c177866
Merge pull request #2665 from nextcloud/fixTransifexMapping
fix transifex mappings: he->iw and id->in
2018-06-04 12:11:43 +02:00
nextcloud-android-bot
a54cc9c683
Drone: update Lint results to reflect reduced error/warning count [skip ci] 2018-06-02 22:23:21 +02:00
AndyScherzinger
afc32f1cf1
fix he->iw and id->in 2018-06-02 22:23:21 +02:00
Nextcloud bot
18755ba08c
[tx-robot] updated from transifex 2018-06-02 00:45:28 +00:00
Tobias Kaminsky
ed9df6879f daily dev 20180602 2018-06-02 00:31:55 +02:00
Nextcloud bot
f7f988bc15
[tx-robot] updated from transifex 2018-05-31 00:47:30 +00:00
tobiasKaminsky
6cf37f3a0d
reword empty activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-30 13:45:50 +02:00
tobiasKaminsky
8d7b16b3ca
do not process result of async task if activity is stopped
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-30 11:07:34 +02:00
Andy Scherzinger
8c5f564253
Merge pull request #2650 from nextcloud/explicitAllowGCM
Explicitly allow gcm on gplay
2018-05-30 10:32:22 +02:00
Andy Scherzinger
c9beb477d1
Merge pull request #2647 from nextcloud/fixSearch
Fix search events
2018-05-30 10:31:50 +02:00
tobiasKaminsky
c1b1bc8fab
explicitly allow gcm on gplay
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-30 09:25:43 +02:00
tobiasKaminsky
7f28bad63e
explicitly finish preferences
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-30 08:23:49 +02:00
tobiasKaminsky
e718f49dea
store file/account when suspending fragments
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-30 07:29:52 +02:00
tobiasKaminsky
cf8478b80d
as we use singleTop, we shall not start a new activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-30 06:34:11 +02:00
Nextcloud bot
d598c3afcf
[tx-robot] updated from transifex 2018-05-30 00:47:59 +00:00
Nextcloud bot
455a92849f
[tx-robot] updated from transifex 2018-05-29 11:28:08 +00:00
Nextcloud bot
46fb12a68f
[tx-robot] updated from transifex 2018-05-29 10:02:22 +00:00
Andy Scherzinger
3e071b20ca
Merge pull request #2633 from nextcloud/masterFix
restore prematurely deleted strings
2018-05-29 11:52:40 +02:00
AndyScherzinger
058eff9627
restore prematurely deleted strings 2018-05-29 11:38:59 +02:00
Nextcloud bot
9a65471805
[tx-robot] updated from transifex 2018-05-29 09:05:28 +00:00
Andy Scherzinger
36584a1155
Merge pull request #2573 from nextcloud/fileDetails
Iteration 2 for file detail & new sharing
2018-05-29 11:02:24 +02:00
AndyScherzinger
ba0aff41a7
Fix comment again 2018-05-29 09:14:22 +02:00
AndyScherzinger
c3209d817d
fix further review comments 2018-05-29 09:13:09 +02:00
AndyScherzinger
84401e73a7
fix menu filter 2018-05-29 09:01:41 +02:00
AndyScherzinger
f731e4d59b
java imports, unused java been removed... 2018-05-29 08:38:58 +02:00
AndyScherzinger
cf1b8f8f85
Fix theming issue with date picker dialog 2018-05-29 08:31:50 +02:00
AndyScherzinger
892db9f689
raise font size on file name 2018-05-29 07:58:41 +02:00
AndyScherzinger
d72eb2a4b7
fix codacy 2018-05-29 07:58:41 +02:00
AndyScherzinger
a3daf0642e
fix lint again 2018-05-29 07:58:41 +02:00
nextcloud-android-bot
1f58926ad0
Drone: update Lint results to reflect reduced error/warning count [skip ci] 2018-05-29 07:58:40 +02:00
AndyScherzinger
f201a2dd66
first changes due to designers review 2018-05-29 07:58:40 +02:00
AndyScherzinger
d8c4be0604
fix lint for item divider, plus code formatting 2018-05-29 07:58:39 +02:00
AndyScherzinger
952db5a34b
added javaDoc for public methods 2018-05-29 07:58:39 +02:00
AndyScherzinger
5154280f00
fix refreshing OC file list after sharing info changes 2018-05-29 07:58:38 +02:00
AndyScherzinger
5c4a450b11
use file details sharing tab for files also via the share bottom sheet (only if FileDisplayActivity is the parent) 2018-05-29 07:58:38 +02:00
AndyScherzinger
abc2be7a23
further shortened the label 2018-05-29 07:58:37 +02:00
AndyScherzinger
f2edf5a7f5
shorten edit label 2018-05-29 07:58:37 +02:00
AndyScherzinger
90a129d232
use nicer UI element names 2018-05-29 07:58:36 +02:00