Álvaro Brey
f425045a31
FilesUploadWorker: fix infinite loop when uploads failed
...
With the previous approach (uploadsStorageManager.gtCurrentAndPendingUploadsForAccount),
an upload that is, for example, waiting for wifi, would always be returned in the call,
thus the list would never be empty.
To avoid this but still process the uploads in pages to avoid OOM, we'll request them page-wise
from the StorageManager, with the pages ordered by ascending ID. This way we will only process each upload once,
but newly added uploads after we start will not be missed.
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-01 16:52:43 +01:00
Álvaro Brey
a3e21d719b
UploadsStorageManager: extract getUploadsPage from getUploads
...
First step for making it accessible from outside
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-01 16:17:22 +01:00
Tobias Kaminsky
3f6832eaf1
Merge pull request #11118 from nextcloud/revert-sdk-32
...
Revert "Bump targetSdk to 32"
2022-12-01 12:27:15 +01:00
tobiasKaminsky
52497bb3e3
Template id must be long, as it is fileID, which can be very big
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-12-01 12:13:50 +01:00
Álvaro Brey
4a14602f0e
PreviewVideoFullscreenDialog: fix insets
...
This was breaking the window in Android 9 when going back twice from a fullscreen video.
Testing steps:
1. Open a video
2. Go to fullscreen
3. Close fullscreen
4. Press Back
This caused a white screen in Android 9 before this PR
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-01 11:04:24 +01:00
Nextcloud bot
7698b4b088
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-01 03:33:15 +00:00
Nextcloud bot
c3b1957ef8
[tx-robot] Update transifex configuration
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-01 03:32:57 +00:00
Tobias Kaminsky
980bb736a0
daily dev 20221201
...
Bump mockkVersion from 1.13.2 to 1.13.3
Update 3rd-party dependencies
2022-12-01 02:38:18 +01:00
Tobias Kaminsky
ab3bf3e7ca
Merge remote-tracking branch 'origin/master' into dev
2022-12-01 02:31:51 +01:00
Álvaro Brey
13f37c04f8
Revert "Bump targetSdk to 32"
...
This reverts commit 8c8723c7c5
.
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-30 12:21:37 +01:00
Álvaro Brey
5d4b7a6d04
Merge pull request #11113 from nextcloud/fix-crash-when-disabling-airplane-mode
...
Fix crash when disabling airplane mode
2022-11-30 09:33:56 +01:00
Nextcloud bot
cf148a0558
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-30 06:35:10 +00:00
Tobias Kaminsky
013f6dc7d2
Merge pull request #11075 from nextcloud/chore/sdk-32
...
Bump targetSdk to 32
2022-11-30 07:24:33 +01:00
Tobias Kaminsky
c2fc3424bc
daily dev 20221130
...
Bump kotlin_version from 1.7.21 to 1.7.22
Update Nextcloud Android library
Update 3rd-party dependencies
2022-11-30 03:45:47 +01:00
Tobias Kaminsky
5b89024800
Merge remote-tracking branch 'origin/master' into dev
2022-11-30 03:37:33 +01:00
Chris Narkiewicz
45567fb6d4
Fix crash when disabling airplane mode
...
Fixes #11096
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2022-11-29 20:17:38 +00:00
Álvaro Brey
f74f59220c
Merge pull request #11089 from nextcloud/fix/video-fullscreen-buffer
...
Video preview: use fullscreen dialog for video instead of new activity
2022-11-29 13:33:10 +01:00
Álvaro Brey
bbaf8d369d
Merge pull request #11073 from nextcloud/chore/strictmode-optional
...
Disable StrictMode by default
2022-11-29 13:23:52 +01:00
Nextcloud bot
d584c8416b
[tx-robot] Update transifex configuration
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-29 03:32:20 +00:00
Tobias Kaminsky
7ba1a9fa5b
daily dev 20221129
...
Bump mockito-kotlin from 4.0.0 to 4.1.0
Update 3rd-party dependencies
2022-11-29 02:38:13 +01:00
Tobias Kaminsky
eddd776d4b
Merge remote-tracking branch 'origin/master' into dev
2022-11-29 02:32:10 +01:00
Álvaro Brey
3f990c3f21
PreviewVideoFullscreenDialog: workaround for rotated videos on sdk < 29
...
See comments in added code for explanation
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
bdc0fc71e5
PreviewVideoFullscreenDialog: use listeners to control transfer, and pause the video while transfer is happening
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
efa7d9e317
Remove unused theme
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
b55d5768de
Fix lint and spotbugs
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
bbb85513e1
Video preview: use fullscreen dialog for video instead of new activity
...
This allows transfering the playback directly between Player views, thus avoiding creating
a new ExoPlayer, re-starting the stream, having to pass playing status/current position, etc.
Additionally:
- Always enable buffering animation so it's clear when a video is loading
- Add padding to fullscreen duration numbers so they don't get cut off on rounded screens
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Tobias Kaminsky
397ba74274
use getParentFragmentManager
...
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
2022-11-28 14:18:09 +00:00
tobiasKaminsky
831bffe571
show only one setup dialog, prevents strange situation on double tapping
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-28 14:18:09 +00:00
Álvaro Brey
e85737f41d
Disable StrictMode by default
...
StrictMode is not a good fit for the state of our app, since we are way too far from async operations or correct threading.
As a result, we find ourselves disabling the strict mode manually every time we actually want to work on something, as otherwise the
logspam drowns everything else.
With this PR I propose to disable StrictMode unless a prop is set in the Gradle build, which will also control LeakCanary.
Running `./gradlew installGplayDebug -P perfAnalysis` will install the app with both LeakCanary and StrictMode enabled.
This allows us to analyze performance problems on demand, without making our daily work harder.
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 15:09:04 +01:00
Andy Scherzinger
c66491a02f
update screenshot test results
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-11-28 13:03:10 +01:00
Valdnet
d184aa6690
i18n: Correct spelling
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:32 +01:00
Valdnet
1433dec21b
i18n: Change to lower case
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:32 +01:00
Valdnet
e57bf0eb2a
i18n: Correct spelling
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:31 +01:00
Valdnet
a65b896ce6
i18n: Change name of encryption
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:19 +01:00
Nextcloud bot
759b799e37
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-28 03:33:17 +00:00
Nextcloud bot
adcfaf381b
[tx-robot] Update transifex configuration
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-28 03:33:00 +00:00
Nextcloud bot
b9e1bb3f81
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-27 03:30:59 +00:00
Nextcloud bot
cf17a9fbfc
[tx-robot] Update transifex configuration
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-27 03:30:41 +00:00
Nextcloud bot
23d0b40d5b
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-26 03:30:47 +00:00
Nextcloud bot
5d9e0e6e0a
[tx-robot] Update transifex configuration
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-26 03:30:27 +00:00
Tobias Kaminsky
72c8248a43
daily dev 20221126
...
Bump com.diffplug.spotless from 6.11.0 to 6.12.0
Update Nextcloud Android library
Update 3rd-party dependencies
2022-11-26 03:43:42 +01:00
Tobias Kaminsky
eb2b9ec935
Merge remote-tracking branch 'origin/master' into dev
2022-11-26 03:36:27 +01:00
Álvaro Brey
16023016d7
Merge pull request #11091 from nextcloud/dependabot/gradle/com.diffplug.spotless-6.12.0
...
Bump com.diffplug.spotless from 6.11.0 to 6.12.0
2022-11-25 14:01:12 +01:00
Tobias Kaminsky
161bc98bde
Merge pull request #11031 from nextcloud/e2eUX
...
E2e ux
2022-11-25 11:30:43 +01:00
Nextcloud bot
02762bb2f0
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-25 08:27:05 +00:00
Nextcloud bot
f6c083ace7
[tx-robot] Update transifex configuration
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-25 08:26:49 +00:00
Nextcloud bot
b9cdb01b16
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-25 03:36:17 +00:00
Nextcloud bot
209404f058
[tx-robot] Update transifex configuration
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-25 03:35:56 +00:00
Tobias Kaminsky
a5883ef743
daily dev 20221125
...
Update Nextcloud Android library
2022-11-25 03:40:59 +01:00
dependabot[bot]
766ed4492c
Bump com.diffplug.spotless from 6.11.0 to 6.12.0
...
Bumps com.diffplug.spotless from 6.11.0 to 6.12.0.
---
updated-dependencies:
- dependency-name: com.diffplug.spotless
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-11-25 02:01:32 +00:00
tobiasKaminsky
393e34d28c
restart SettingsActivity after changing e2e settings
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-24 15:40:26 +01:00
tobiasKaminsky
3f82d37415
revert to master library
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-24 15:40:26 +01:00
tobiasKaminsky
f49252c87e
hide e2e options after removing local e2e setup
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-24 15:40:26 +01:00
Álvaro Brey
b110735dcc
NextcloudDatabase: enable automigration for new db version
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
30d38dee23
Restore database v65 schema from master
...
Mistakenly changed!
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
0d098255d9
Pass through SetupEncryptionDF result to SettingsActivity
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
6b4d6a6dfd
SettingsActivity: fix conditional to show e2e encrypt option
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
tobiasKaminsky
e3a7453846
properly handle stage 2: key exists, but e2e is not setup on this device
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-24 15:40:26 +01:00
Álvaro Brey
1b945b6131
SetupEncryptionDialogFragment: use builtin onCancel for setting cancel result
...
This captures back button as well
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
b1b05f740e
SetupEncryptionActivity: give transparent background to make it more seamless
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
09aac00330
SetupEncryptionActivity: finish activity when error happens
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
6568d1d272
Close SetupEncryptionActivity when dialog is dismissed
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Álvaro Brey
fc446b1deb
Update screenshots for SettingsActivity
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-24 15:40:26 +01:00
Tobias Kaminsky
9f1f21ee8c
Update app/src/main/res/values/strings.xml
...
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
2022-11-24 15:40:26 +01:00
tobiasKaminsky
5b4aba11f5
Better show different states of E2E
...
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-24 15:40:24 +01:00
Tobias Kaminsky
4a6f4707e4
daily dev 20221124
2022-11-24 02:38:15 +01:00
Tobias Kaminsky
1bfee60543
Merge remote-tracking branch 'origin/master' into dev
2022-11-24 02:31:58 +01:00
Álvaro Brey
1c4a1063f1
Merge pull request #10928 from nextcloud/test/calendar-skip-empty
...
Fix issues with calendar exporting
2022-11-23 22:11:31 +01:00
Álvaro Brey
c938a929c1
Merge pull request #11067 from nextcloud/fix/gallery-crash
...
GalleryFragment: fix crash when scrolling slowly until the end of the list
2022-11-23 22:10:20 +01:00
Álvaro Brey
f797260f76
Merge pull request #11068 from nextcloud/fix/favorites-back-navigation
...
FileDisplayActivity: fix drawer menu item when browsing back from favorite folder
2022-11-23 22:08:51 +01:00
Álvaro Brey
eaae4a0f9c
Merge pull request #11069 from nextcloud/fix/video-fullscreen-stuck
...
Misc fixes for video player
2022-11-23 22:07:43 +01:00
Álvaro Brey
09319ac7c3
Merge pull request #11074 from nextcloud/fix/calendar-backup-wrong-account
...
CalendarBackupWork: upload to configured account, not current account
2022-11-23 22:06:54 +01:00
Álvaro Brey
b0a3d6cc7e
Merge pull request #11059 from nextcloud/feature/3175/shortcuts_bottombar
...
Allow Pin to Home with file actions bottom sheet
2022-11-23 18:56:38 +01:00
Álvaro Brey
8c8723c7c5
Bump targetSdk to 32
...
32 is just a feature release of android 13 and no important changes are documented.
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 11:46:14 +01:00
Álvaro Brey
38e83cd03c
Keep screen on while video is playing
...
Fixes #9059
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 10:31:49 +00:00
Álvaro Brey
625ada4c17
Add default error and completion handler to Exoplayer in preview fragment/activity
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 10:31:49 +00:00
Álvaro Brey
250e8129dd
CalendarBackupWork: upload to configured account, not current account
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 11:13:03 +01:00
Álvaro Brey
7d8e37a8a0
FileDisplayActivity: also update sort group after browsing up
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 10:26:16 +01:00
Álvaro Brey
850e9e7ec3
CalendarBackupWork: log amount of calendars
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 08:12:10 +00:00
Álvaro Brey
b3eab117db
calendar export: port some changes from upstream
...
Ignore deleted events, and fix alarm triggers
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 08:12:10 +00:00
Álvaro Brey
008ee4e0cd
SaveCalendar: don't try to export empty calendars
...
Causes crashes
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-23 08:12:10 +00:00
Nextcloud bot
39f094af95
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-23 03:35:13 +00:00
Nextcloud bot
958a0e30eb
[tx-robot] Update transifex configuration
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-23 03:34:56 +00:00
Álvaro Brey
7bf90d364b
FileDisplayActivity: fix drawer menu item when browsing back from favorite folder
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 16:50:42 +01:00
Felix Nüsse
ea2a1a9163
extract string resource
...
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-22 16:31:15 +01:00
Álvaro Brey
c1ce254692
GalleryFragment: fix crash when scrolling slowly until the end of the list
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 13:52:54 +01:00
Álvaro Brey
8f1369cba2
ShortcutUtil: use system utilities to get pixel size for dimens instead of manually calculating them
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 11:00:12 +01:00
Álvaro Brey
52e1e8cef5
ShortcutUtil: use ShortcutManagerCompat to avoid min SDK requirement
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 10:53:09 +01:00
Álvaro Brey
2e3ef2eace
strings.xml: Remove unused string to appease Lint
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 10:16:07 +01:00
Álvaro Brey
280a92be51
Fix style and static analysis issues
...
- Rename ShortcutUtils.kt to ShortcutUtil.kt to match contained class
- Remove unused const
- Fix formatting with spotless
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 10:14:27 +01:00
Álvaro Brey
8a24ea03a0
Inject ShortcutUtil instead of manually creating it
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-22 10:11:02 +01:00
Nextcloud bot
bf328c9430
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-22 03:37:03 +00:00
Nextcloud bot
ca2d593d67
[tx-robot] Update transifex configuration
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-22 03:36:46 +00:00
Tobias Kaminsky
e4139af585
daily dev 20221122
...
Bump detekt-gradle-plugin from 1.21.0 to 1.22.0
Update Nextcloud Android library
Update 3rd-party dependencies
2022-11-22 03:41:11 +01:00
Tobias Kaminsky
b3b9b66917
Merge remote-tracking branch 'origin/master' into dev
2022-11-22 03:35:00 +01:00
Álvaro Brey
619563b34a
Merge pull request #11061 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.22.0
...
Bump detekt-gradle-plugin from 1.21.0 to 1.22.0
2022-11-21 17:26:27 +01:00
Felix Nüsse
d555847fea
extract and explain constant integer values for icon size
...
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
c19a256a97
Update shortcututils to use existing FolderIcon-function
...
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
758bfe1e17
Implement errorchecking and remove deprecations as suggested by @AlvaroBrey
...
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00
Felix Nüsse
f81340f63d
Add check for version in FileMenuFilter and ActionChoosen()
...
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
2022-11-21 16:47:30 +01:00