Commit graph

19746 commits

Author SHA1 Message Date
tobiasKaminsky
52497bb3e3
Template id must be long, as it is fileID, which can be very big
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-12-01 12:13:50 +01:00
Álvaro Brey
4a14602f0e
PreviewVideoFullscreenDialog: fix insets
This was breaking the window in Android 9 when going back twice from a fullscreen video.

Testing steps:
1. Open a video
2. Go to fullscreen
3. Close fullscreen
4. Press Back

This caused a white screen in Android 9 before this PR

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-01 11:04:24 +01:00
Nextcloud bot
7698b4b088
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-01 03:33:15 +00:00
Nextcloud bot
c3b1957ef8
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-01 03:32:57 +00:00
Álvaro Brey
13f37c04f8
Revert "Bump targetSdk to 32"
This reverts commit 8c8723c7c5.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-30 12:21:37 +01:00
Álvaro Brey
5d4b7a6d04
Merge pull request #11113 from nextcloud/fix-crash-when-disabling-airplane-mode
Fix crash when disabling airplane mode
2022-11-30 09:33:56 +01:00
Andy Scherzinger
d196a48931
Merge pull request #11114 from nextcloud/dependabot/gradle/mockkVersion-1.13.3
Bump mockkVersion from 1.13.2 to 1.13.3
2022-11-30 08:58:54 +01:00
Nextcloud bot
cf148a0558
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-30 06:35:10 +00:00
Tobias Kaminsky
013f6dc7d2
Merge pull request #11075 from nextcloud/chore/sdk-32
Bump targetSdk to 32
2022-11-30 07:24:33 +01:00
dependabot[bot]
320c893428
Bump mockkVersion from 1.13.2 to 1.13.3
Bumps `mockkVersion` from 1.13.2 to 1.13.3.

Updates `mockk` from 1.13.2 to 1.13.3
- [Release notes](https://github.com/mockk/mockk/releases)
- [Commits](https://github.com/mockk/mockk/compare/1.13.2...1.13.3)

Updates `mockk-android` from 1.13.2 to 1.13.3
- [Release notes](https://github.com/mockk/mockk/releases)
- [Commits](https://github.com/mockk/mockk/compare/1.13.2...1.13.3)

---
updated-dependencies:
- dependency-name: io.mockk:mockk
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.mockk:mockk-android
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-11-30 02:01:10 +00:00
Chris Narkiewicz
45567fb6d4
Fix crash when disabling airplane mode
Fixes #11096

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2022-11-29 20:17:38 +00:00
Álvaro Brey
4a0182ac38
Merge pull request #11109 from nextcloud/dependabot/gradle/kotlin_version-1.7.22
Bump kotlin_version from 1.7.21 to 1.7.22
2022-11-29 16:31:01 +01:00
Álvaro Brey
f74f59220c
Merge pull request #11089 from nextcloud/fix/video-fullscreen-buffer
Video preview: use fullscreen dialog for video instead of new activity
2022-11-29 13:33:10 +01:00
Álvaro Brey
bbaf8d369d
Merge pull request #11073 from nextcloud/chore/strictmode-optional
Disable StrictMode by default
2022-11-29 13:23:52 +01:00
Nextcloud bot
d584c8416b
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-29 03:32:20 +00:00
dependabot[bot]
7947bb1918
Bump kotlin_version from 1.7.21 to 1.7.22
Bumps `kotlin_version` from 1.7.21 to 1.7.22.

Updates `kotlin-gradle-plugin` from 1.7.21 to 1.7.22
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/compare/v1.7.21...v1.7.22)

Updates `kotlin-stdlib` from 1.7.21 to 1.7.22
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/compare/v1.7.21...v1.7.22)

---
updated-dependencies:
- dependency-name: org.jetbrains.kotlin:kotlin-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.jetbrains.kotlin:kotlin-stdlib
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-11-29 02:04:10 +00:00
Álvaro Brey
3f990c3f21 PreviewVideoFullscreenDialog: workaround for rotated videos on sdk < 29
See comments in added code for explanation

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
bdc0fc71e5 PreviewVideoFullscreenDialog: use listeners to control transfer, and pause the video while transfer is happening
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
efa7d9e317 Remove unused theme
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
b55d5768de Fix lint and spotbugs
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Álvaro Brey
bbb85513e1 Video preview: use fullscreen dialog for video instead of new activity
This allows transfering the playback directly between Player views, thus avoiding creating
a new ExoPlayer, re-starting the stream, having to pass playing status/current position, etc.

Additionally:
- Always enable buffering animation so it's clear when a video is loading
- Add padding to fullscreen duration numbers so they don't get cut off on rounded screens

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 19:22:49 +00:00
Tobias Kaminsky
397ba74274 use getParentFragmentManager
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
2022-11-28 14:18:09 +00:00
tobiasKaminsky
831bffe571 show only one setup dialog, prevents strange situation on double tapping
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-28 14:18:09 +00:00
Álvaro Brey
a2198d3b8f CONTRIBUTING.md: add performance section
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 15:09:04 +01:00
Álvaro Brey
e85737f41d Disable StrictMode by default
StrictMode is not a good fit for the state of our app, since we are way too far from async operations or correct threading.
As a result, we find ourselves disabling the strict mode manually every time we actually want to work on something, as otherwise the
logspam drowns everything else.

With this PR I propose to disable StrictMode unless a prop is set in the Gradle build, which will also control LeakCanary.
Running `./gradlew installGplayDebug -P perfAnalysis` will install the app with both LeakCanary and StrictMode enabled.
This allows us to analyze performance problems on demand, without making our daily work harder.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-11-28 15:09:04 +01:00
Álvaro Brey
f9e500ba40
Merge pull request #11105 from nextcloud/chore/noid/updateScreenshots
Update screenshot test results for E2E strings
2022-11-28 14:42:18 +01:00
Andy Scherzinger
c66491a02f
update screenshot test results
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-11-28 13:03:10 +01:00
Álvaro Brey
725348a8d4
Merge pull request #11097 from nextcloud/Valdnet-patch-1
i18n: Change name of encryption
2022-11-28 12:53:50 +01:00
Valdnet
d184aa6690
i18n: Correct spelling
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:32 +01:00
Valdnet
1433dec21b
i18n: Change to lower case
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:32 +01:00
Valdnet
e57bf0eb2a
i18n: Correct spelling
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:31 +01:00
Valdnet
a65b896ce6
i18n: Change name of encryption
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-28 09:55:19 +01:00
Álvaro Brey
a489619db3
Merge pull request #11103 from nextcloud/dependabot/gradle/org.mockito.kotlin-mockito-kotlin-4.1.0
Bump mockito-kotlin from 4.0.0 to 4.1.0
2022-11-28 09:34:01 +01:00
Nextcloud bot
759b799e37
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-28 03:33:17 +00:00
Nextcloud bot
adcfaf381b
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-28 03:33:00 +00:00
dependabot[bot]
693fe26e54
Bump mockito-kotlin from 4.0.0 to 4.1.0
Bumps [mockito-kotlin](https://github.com/mockito/mockito-kotlin) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/mockito/mockito-kotlin/releases)
- [Commits](https://github.com/mockito/mockito-kotlin/compare/4.0.0...4.1.0)

---
updated-dependencies:
- dependency-name: org.mockito.kotlin:mockito-kotlin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-11-28 02:02:33 +00:00
Nextcloud bot
b9e1bb3f81
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-27 03:30:59 +00:00
Nextcloud bot
cf17a9fbfc
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-27 03:30:41 +00:00
Nextcloud bot
23d0b40d5b
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-26 03:30:47 +00:00
Nextcloud bot
5d9e0e6e0a
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-26 03:30:27 +00:00
Álvaro Brey
16023016d7
Merge pull request #11091 from nextcloud/dependabot/gradle/com.diffplug.spotless-6.12.0
Bump com.diffplug.spotless from 6.11.0 to 6.12.0
2022-11-25 14:01:12 +01:00
Tobias Kaminsky
161bc98bde
Merge pull request #11031 from nextcloud/e2eUX
E2e ux
2022-11-25 11:30:43 +01:00
Nextcloud bot
02762bb2f0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-25 08:27:05 +00:00
Nextcloud bot
f6c083ace7
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-25 08:26:49 +00:00
Nextcloud bot
b9cdb01b16
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-25 03:36:17 +00:00
Nextcloud bot
209404f058
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-25 03:35:56 +00:00
dependabot[bot]
766ed4492c
Bump com.diffplug.spotless from 6.11.0 to 6.12.0
Bumps com.diffplug.spotless from 6.11.0 to 6.12.0.

---
updated-dependencies:
- dependency-name: com.diffplug.spotless
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-11-25 02:01:32 +00:00
tobiasKaminsky
393e34d28c
restart SettingsActivity after changing e2e settings
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-24 15:40:26 +01:00
tobiasKaminsky
3f82d37415
revert to master library
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-24 15:40:26 +01:00
tobiasKaminsky
f49252c87e
hide e2e options after removing local e2e setup
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-11-24 15:40:26 +01:00