Commit graph

9520 commits

Author SHA1 Message Date
tobiasKaminsky
e505421db9
Implicitly using the default locale is a common source of bugs
internal: Locale.ROOT
otherwise Locale.getDefault()
2018-01-09 10:51:22 +01:00
Tobias Kaminsky
2a79029205
Merge pull request #1909 from nextcloud/bugfix/1903
Fixes #1903: Fix image scaling in navigation drawer
2018-01-09 10:48:38 +01:00
nextcloud-android-bot
7905a555d7
Drone: update Lint results to reflect reduced error/warning count [skip ci] 2018-01-09 10:30:20 +01:00
Bartosz Przybylski
a3db144ecc
Crop center the image in account info
Because we need to correctly crop and center the image we can no longer support snapping of toolbar in appbar. Since AppBarLayout is a subclass of LinearLayout and doesn't look deeper into subview hierachy for snapping children, thus it is better not to support it.

Also instead of using ScrollView and pad it with some weird magic numbers, use NestedScrollView class which is made to cooperate with AppBarLayout.
2018-01-09 10:30:20 +01:00
Bartosz Przybylski
0e1dc14016
Fixes #1903: Fix image scaling in navigation drawer
* Insted of setting a background in ViewGroup add a ImageView inside it, stretch it, set cropping scaleType and then set a background image downloaded from server.
* CenterCrop will scale the image to fill the View, if needed image will be cropped in the center but the aspect ration will be kept
* Cleanup code to use more general types instead of direct layout type, previously enforcing LinearLayout wasn't using anything special about this class.
2018-01-09 10:30:20 +01:00
Tobias Kaminsky
11c9fa53a4
Merge pull request #1936 from nextcloud/preventAccountNPE
Prevent account NPE
2018-01-09 10:10:43 +01:00
tobiasKaminsky
213646cb41
prevent account NPE
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-01-09 09:52:29 +01:00
Tobias Kaminsky
ae2ac1c26d
Merge pull request #1571 from srkunze/issue-1508
Folder-Based Sort Order
2018-01-09 09:24:49 +01:00
tobiaskaminsky
fe14e66043
remove unneeded fully qualified name
Signed-off-by: tobiaskaminsky <tobias@kaminsky.me>
2018-01-09 09:05:53 +01:00
tobiaskaminsky
60fae3c502
code enhancements 2018-01-09 09:05:53 +01:00
tobiaskaminsky
e288507ce8
sorting in "receive external files" 2018-01-09 09:05:52 +01:00
Sven R. Kunze
1a86ba7eac
refactoring folder preferences
- based getFolderPreference and setFolderPreference on ArbitraryDataProvider
- converted Boolean-based "is grid preferred" to String-based folder layout preference

Signed-off-by: Sven R. Kunze <srkunze@mail.de>
2018-01-09 09:05:52 +01:00
Sven R. Kunze
0105b19e79
finished folder-based sort order
- base getSortOrder on getFolderPreference
- base setSortOrder on setFolderPreference
- added folder parameter to all call-sites of getSortOrder and getSortOrder
2018-01-09 09:05:52 +01:00
Sven R. Kunze
4b5e4b96a9
defined new way of addressing and storing sort orders
- defined string constants for all sort orders
- defined new SortOrder classes to handle sorting
- store/retrieve string constant in/from preferences
- cleaned up related code
2018-01-09 09:05:52 +01:00
Sven R. Kunze
830f909e8c
cleaned up OCFileListFragment preference management
- base isGridViewPreferred on getIsGridViewPreferred
- base setGridAsPreferred and setListAsPreferred on setIsGridViewPreferred
- moved GRID_IS_PREFERED_PREFERENCE to PreferenceManager
- moved KEY_FAB_EVER_CLICKED to PreferenceManager
2018-01-09 09:05:52 +01:00
Sven R. Kunze
0ef8995f5f
added folder-recognizing preference helpers
- added getFolderPreference
- added setFolderPreference
2018-01-09 09:05:52 +01:00
Tobias Kaminsky
f993c0cd0f
Merge pull request #1932 from nextcloud/contactBackupRemoval
Contact backup removal
2018-01-09 08:48:28 +01:00
tobiaskaminsky
2b0dd3209c
use cancelContactBackupJobForAccount to disable all backup jobs
switched if branches, according to findBugs

Signed-off-by: tobiaskaminsky <tobias@kaminsky.me>
2018-01-09 08:37:37 +01:00
tobiasKaminsky
2655d6f87b
code enhancement
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-01-09 08:37:37 +01:00
tobiasKaminsky
f1731f889d
on account removal also disable contacts backup job
remove unneeded function

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-01-09 08:37:36 +01:00
Tobias Kaminsky
97e2260cc5
Merge pull request #1931 from nextcloud/contactsBackupNPE
Contacts backup NPE
2018-01-09 08:34:57 +01:00
Tobias Kaminsky
4914b11bc1
Merge branch 'master' into contactsBackupNPE 2018-01-09 08:19:57 +01:00
Tobias Kaminsky
666ff25ce6
Merge pull request #1933 from nextcloud/userinfoButterknife
do not use id twice
2018-01-09 08:19:40 +01:00
Tobias Kaminsky
a1e0173e9c
Merge branch 'master' into userinfoButterknife 2018-01-09 08:12:42 +01:00
Nextcloud bot
ae6c33c9fa
[tx-robot] updated from transifex 2018-01-09 01:40:56 +00:00
Tobias Kaminsky
22a1a668d5 daily dev 20180109 2018-01-09 00:48:33 +01:00
tobiasKaminsky
62f74a8ff5
do not use id twice
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-01-08 15:47:44 +01:00
tobiaskaminsky
e6d597e172
code formatting
Signed-off-by: tobiaskaminsky <tobias@kaminsky.me>
2018-01-08 14:23:14 +01:00
tobiaskaminsky
9733b886af
fix potential NPEs
Signed-off-by: tobiaskaminsky <tobias@kaminsky.me>
2018-01-08 14:21:11 +01:00
Tobias Kaminsky
ab8b149067
Merge pull request #1887 from nextcloud/oreo
Oreo support
2018-01-08 09:37:58 +01:00
nextcloud-android-bot
f60e9d9cd0
Drone: update Lint results to reflect reduced error/warning count [skip ci] 2018-01-08 09:22:09 +01:00
tobiaskaminsky
138e35c512
add roundIcon to Manifest 2018-01-08 09:22:09 +01:00
AndyScherzinger
84d40f0421
fix compile error 2018-01-08 09:22:09 +01:00
AndyScherzinger
487407fb49
codacy: combine if blocks 2018-01-08 09:22:09 +01:00
AndyScherzinger
9111fa0555
use vector xml for launcher icon background 2018-01-08 09:22:09 +01:00
AndyScherzinger
9d029de12e
fix folder name -v26 2018-01-08 09:22:08 +01:00
AndyScherzinger
505306cbf5
try moving background to v26 directory for lint 2018-01-08 09:22:08 +01:00
AndyScherzinger
8f49c74a2c
cleanup dev verison parts 2018-01-08 09:22:08 +01:00
AndyScherzinger
0bdf9ffa51
remove replace call (originally introduced for round launcher icon) 2018-01-08 09:22:08 +01:00
AndyScherzinger
346c5ca9a3
move vector launcher foreground file to v26 directory 2018-01-08 09:22:08 +01:00
AndyScherzinger
4b87a0d109
properly enforce round launcher icon 2018-01-08 09:22:08 +01:00
tobiasKaminsky
5b6f0354f6
extract channel creation 2018-01-08 09:22:08 +01:00
AndyScherzinger
94823e576d
manifest 2018-01-08 09:22:08 +01:00
AndyScherzinger
c6016b9a0a
fix build for modified 2018-01-08 09:22:07 +01:00
AndyScherzinger
09fdc9b2e1
reworked raw logos 2018-01-08 09:22:07 +01:00
AndyScherzinger
95f2b488f9
fix positioning of Nc logo within icons 2018-01-08 09:22:07 +01:00
AndyScherzinger
1fadabac13
line break added 2018-01-08 09:22:07 +01:00
AndyScherzinger
36f3c936ec
raw files for adaptive launcher icon generator 2018-01-08 09:22:07 +01:00
AndyScherzinger
dbf753cce3
enforce round launcher icon on pre Oreo devices 2018-01-08 09:22:07 +01:00
AndyScherzinger
0137ec8ef6
reworked Nc13 style launcher icon work 2018-01-08 09:22:07 +01:00